[jira] [Created] (FLINK-30861) Table Store Hive Catalog throws java.lang.ClassNotFoundException: org.apache.hadoop.hive.common.ValidWriteIdList under certain environment

2023-01-31 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-30861: --- Summary: Table Store Hive Catalog throws java.lang.ClassNotFoundException: org.apache.hadoop.hive.common.ValidWriteIdList under certain environment Key: FLINK-30861 URL: https://is

[jira] [Created] (FLINK-30860) Add document for hybrid shuffle with adaptive batch scheduler

2023-01-31 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-30860: -- Summary: Add document for hybrid shuffle with adaptive batch scheduler Key: FLINK-30860 URL: https://issues.apache.org/jira/browse/FLINK-30860 Project: Flink Is

[jira] [Created] (FLINK-30859) Remove flink-connector-kafka rom master branch

2023-01-31 Thread Mason Chen (Jira)
Mason Chen created FLINK-30859: -- Summary: Remove flink-connector-kafka rom master branch Key: FLINK-30859 URL: https://issues.apache.org/jira/browse/FLINK-30859 Project: Flink Issue Type: Techni

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-31 Thread Hang Ruan
Hi all, > IIUC, there is only an OperatorCoordinatorMetricGroup interface without implementations (it never worked). There were no coordinator metrics implemented and registered. @Hang Ruan please correct me if I'm wrong. Yes, we shouldn't have to worry about backwards-compatibility as Chesnay sa

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.3.1, release candidate #1

2023-01-31 Thread Thomas Weise
Hi, Sorry for the late reply to this thread, but in the meantime we learned that the assumption based on which the above mentioned change to upgradeMode was approved does not hold true. The assumption was that the generation id in spec metadata and reconciled spec can be used to determine if chang

[jira] [Created] (FLINK-30858) Kubernetes operator does not update reconciled generation

2023-01-31 Thread Thomas Weise (Jira)
Thomas Weise created FLINK-30858: Summary: Kubernetes operator does not update reconciled generation Key: FLINK-30858 URL: https://issues.apache.org/jira/browse/FLINK-30858 Project: Flink Iss

[jira] [Created] (FLINK-30857) Create table does not create topic with multiple partitions

2023-01-31 Thread Vicky Papavasileiou (Jira)
Vicky Papavasileiou created FLINK-30857: --- Summary: Create table does not create topic with multiple partitions Key: FLINK-30857 URL: https://issues.apache.org/jira/browse/FLINK-30857 Project: Fl

[ANNOUNCE] Flink 1.17 feature freeze and summary of release sync 31st of January

2023-01-31 Thread Martijn Visser
Hi everyone, A summary of the release sync of today: - The feature freeze for 1.17 has started now. That means that no new features or improvements should now be merged into the master branch unless you ask the release managers first, which has already been done for PRs that’s pending on the CI t

Re: [RESULT][VOTE] Release 1.16.1, release candidate #1

2023-01-31 Thread Martijn Visser
Hi Jing, Probably today or tomorrow; it’s pending the availability of the new Docker images. Best regards, Martijn Op ma 30 jan. 2023 om 14:51 schreef Jing Ge > Hi Martijn, > > Thanks for driving this! Could you roughly estimate when 1.16.1 could be > officially released? > > Best regards, >

Re: [DISCUSS] Incorporate performance regression monitoring into routine process

2023-01-31 Thread Matthias Pohl
Thanks for the effort you put into this discussion, Yanfei. For me, the regression tests are similar to test instabilities. In this sense, I agree with what Piotr and Jing said about it: - It needs to be identified and fixed as soon as possible to avoid the change affecting other contributions (e.

Re: [DISCUSS] Incorporate performance regression monitoring into routine process

2023-01-31 Thread Jing Ge
Hi Yanfei, Thanks for your proposal and effort of driving it. I really like the document on how to deal with the performance regressions. This will coach more developers to be able to work with it. I would suggest that more developers will be aware of the performance regressions during the daily

[RESULT][VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Teoh, Hong
Hi all, I’m happy to announce we have unanimously approved this proposal, with 4 binding votes and 5 non-binding votes. +1 votes: * Danny (binding) * Jing (non-binding) * Ahmed (non-binding) * Yuxia (non-binding) * Martijn (binding) * Matthias (binding) * Samrat (non-binding) * Daren (non-bindin

[jira] [Created] (FLINK-30856) flink-kubernetes-operator - allow specifying job name

2023-01-31 Thread Vincent Chenal (Jira)
Vincent Chenal created FLINK-30856: -- Summary: flink-kubernetes-operator - allow specifying job name Key: FLINK-30856 URL: https://issues.apache.org/jira/browse/FLINK-30856 Project: Flink Iss

[jira] [Created] (FLINK-30855) Remove flink-connector-gcp-pubsub from master branch

2023-01-31 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30855: -- Summary: Remove flink-connector-gcp-pubsub from master branch Key: FLINK-30855 URL: https://issues.apache.org/jira/browse/FLINK-30855 Project: Flink Issu

[jira] [Created] (FLINK-30854) Expose periodic compaction to RocksdbCompactFilterCleanupStrategy

2023-01-31 Thread Hangxiang Yu (Jira)
Hangxiang Yu created FLINK-30854: Summary: Expose periodic compaction to RocksdbCompactFilterCleanupStrategy Key: FLINK-30854 URL: https://issues.apache.org/jira/browse/FLINK-30854 Project: Flink

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Teoh, Hong
Hi Dong Lin, I see where you are coming from. I agree it would be good to have a FLIP to design the public API for flink-avro, so we will limit this vote thread to the externalization. Regards, Hong From: Dong Lin Date: Tuesday, 31 January 2023 at 14:26 To: "dev@flink.apache.org" Cc: "Teo

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Teoh, Hong
Got it. Thanks for flagging it up. I have created a JIRA for the followup to make flink-avro Public API more clear. https://issues.apache.org/jira/browse/FLINK-30853 Will close this vote thread and announce in a separate thread. Regards, Hong

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Dong Lin
Hi all, It seems that we are on the same page that having flink-connector-aws use non-public API from apache/flink is not a blocking issue here. And I agree that it would be nice to make necessary APIs public so that 1) projects outside Flink can also develop similar connectors and 2) flink-connec

[jira] [Created] (FLINK-30853) Make clear the public API for flink-avro

2023-01-31 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-30853: --- Summary: Make clear the public API for flink-avro Key: FLINK-30853 URL: https://issues.apache.org/jira/browse/FLINK-30853 Project: Flink Issue Type: Te

[VOTE] Release flink-connector-kafka, release candidate #1

2023-01-31 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #1 for flink-connector-kafka version 3.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) Note: this is the same code as the Kafka connector for the Flink 1.16 release. The

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Chesnay Schepler
I don't intend to block this FLIP, but just wanted to raise awareness of the issue and it's implications. Ultimately in the worst case more connector-aws releases will have to be made if the API is changed in an incompatible-way. Whether this risk is acceptable is something you will have to d

[RESULT][VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: * Konstantin (binding) * Sergey (non-binding) * Danny (binding) * Martijn (binding) There are no disapproving votes. Thanks all! Best regards, Martijn

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
I'm closing this vote and will announce the results in a separate email. Op di 31 jan. 2023 om 13:16 schreef Martijn Visser : > +1 (binding) > > Op di 31 jan. 2023 om 12:38 schreef Danny Cranmer >: > >> Thanks for the update. >> >> +1 (binding) >> >> >> On Tue, 31 Jan 2023, 11:11 Martijn Visser,

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
+1 (binding) Op di 31 jan. 2023 om 12:38 schreef Danny Cranmer : > Thanks for the update. > > +1 (binding) > > > On Tue, 31 Jan 2023, 11:11 Martijn Visser, > wrote: > > > Hi Danny, > > > > > Why are we publishing the e2e tests jar? > > > > We shouldn't, but I think that's because the E2E tests c

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-31 Thread Chesnay Schepler
> IIUC, there is only an OperatorCoordinatorMetricGroup interface without implementations (it never worked). There were no coordinator metrics implemented and registered. @Hang Ruan  please correct me if I'm wrong. Indeed. There are interfaces, and theoretically

[jira] [Created] (FLINK-30852) TaskTest.testCleanupWhenSwitchToInitializationFails reports AssertionError but doesn't fail

2023-01-31 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30852: - Summary: TaskTest.testCleanupWhenSwitchToInitializationFails reports AssertionError but doesn't fail Key: FLINK-30852 URL: https://issues.apache.org/jira/browse/FLINK-30852

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Danny Cranmer
Thanks for the update. +1 (binding) On Tue, 31 Jan 2023, 11:11 Martijn Visser, wrote: > Hi Danny, > > > Why are we publishing the e2e tests jar? > > We shouldn't, but I think that's because the E2E tests config for GCP > hasn't been changed since 2018 and don't reflect the new setup. I've > cr

[jira] [Created] (FLINK-30851) flink-kubernetes-operator - operator image should provide s3 support for jarUri

2023-01-31 Thread Vincent Chenal (Jira)
Vincent Chenal created FLINK-30851: -- Summary: flink-kubernetes-operator - operator image should provide s3 support for jarUri Key: FLINK-30851 URL: https://issues.apache.org/jira/browse/FLINK-30851 P

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
Hi Danny, > Why are we publishing the e2e tests jar? We shouldn't, but I think that's because the E2E tests config for GCP hasn't been changed since 2018 and don't reflect the new setup. I've created [1] as a follow-up. > When do we update to 2023? We should do that with the next release :) It'

Re: [DISCUSS] Incorporate performance regression monitoring into routine process

2023-01-31 Thread Piotr Nowojski
Hi, @Dong, I think the drawback of your proposal is that it wouldn't detect if there is visible performance regression within benchmark noise. While this should be do-able with large enough number of samples @Yanfei, Gathering medians would have basically the same problems with how to deal with t

[jira] [Created] (FLINK-30850) Update GCP E2E tests to no longer publish their JARs

2023-01-31 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30850: -- Summary: Update GCP E2E tests to no longer publish their JARs Key: FLINK-30850 URL: https://issues.apache.org/jira/browse/FLINK-30850 Project: Flink Issu

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Teoh, Hong
Hi @Dong Lin @Chesnay Schepler, We have deviated from the original purpose of this thread. Let's keep this thread to the original proposal of externalising flink-avro-glue-schema-registry and flink-json-glue-schema-registry formats to the flink-connector-aws repository. The way I see it, @Che

[jira] [Created] (FLINK-30849) udaf validated failed with TableEnvironment#executeSql but work correctly with StreamTableEnrivorment#registerFunction

2023-01-31 Thread Jianhui Dong (Jira)
Jianhui Dong created FLINK-30849: Summary: udaf validated failed with TableEnvironment#executeSql but work correctly with StreamTableEnrivorment#registerFunction Key: FLINK-30849 URL: https://issues.apache.org/jir

Re: [DISCUSS] FLIP-274 : Introduce metric group for OperatorCoordinator

2023-01-31 Thread Jark Wu
Hi Chesnay, > The new option must default to the configured value of metrics.scope.jm.job because otherwise it isn't backwards-compatible with existing coordinator metrics. IIUC, there is only an OperatorCoordinatorMetricGroup interface without implementations (it never worked). There were no coor

Re: [VOTE] FLIP-279 Unified the max display column width for SqlClient and Table APi in both Streaming and Batch execMode

2023-01-31 Thread weijie guo
+1 (no-binding) Best regards, Weijie godfrey he 于2023年1月16日周一 18:11写道: > +1 (binding) > > Best, > Godfrey > > Shammon FY 于2023年1月12日周四 23:27写道: > > > > +1 (no-binding) > > > > > > Best, > > Shammon > > > > On Thu, Jan 12, 2023 at 8:11 PM Shengkai Fang wrote: > > > > > +1(binding) > > > > >

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Chesnay Schepler
> Existing APIs in Flink which are marked with @Internal also don't offer any compatibility guarantee. Yet we are OK to have classes in Flink use them. Well of course, it's the same codebase. If we change the API we can change all usages as well. Hence, there's no problem using internal APIs.

Re: [DISCUSS] Incorporate performance regression monitoring into routine process

2023-01-31 Thread Yanfei Lei
Thanks for all the feedback and suggestions. @Piotr: >> I was setting the priority to a blocker and I would propose to add this to >> the instructions and general convention. Thanks for sharing your experience, I will update this to the document. And your suggestion of leveraging Two-sample Kolm

[jira] [Created] (FLINK-30848) Enable CatalogTableITCase#testAlterTable

2023-01-31 Thread Jane Chan (Jira)
Jane Chan created FLINK-30848: - Summary: Enable CatalogTableITCase#testAlterTable Key: FLINK-30848 URL: https://issues.apache.org/jira/browse/FLINK-30848 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-30847) Some rel rules vioaltes Calcite guidance rule about instance creation

2023-01-31 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-30847: --- Summary: Some rel rules vioaltes Calcite guidance rule about instance creation Key: FLINK-30847 URL: https://issues.apache.org/jira/browse/FLINK-30847 Project:

Re: [VOTE] Externalize AWS formats to flink-connector-aws

2023-01-31 Thread Danny Cranmer
Hello all, @Dong Lin while I agree with your reasoning here, our ultimate aim is to have stable public APIs. If we need to use @Internal apis for the Apache connectors/formats/etc, then it is likely that users building custom integrations do too. Therefore I am aligned with @Chesnay that we should

Re: [ANNOUNCE] FRocksDB 6.20.3-ververica-2.0 released

2023-01-31 Thread Leonard Xu
Thanks Yanfei for driving the release ! ! Best, Leonard > On Jan 31, 2023, at 3:43 PM, Yun Tang wrote: > > Thanks Yuanfei for driving the frocksdb release! > > Best > Yun Tang > From: Yuan Mei > Sent: Tuesday, January 31, 2023 15:09 > To: Jing Ge > Cc: Yanfei Lei ; dev@flink.apache.org > ;