Thanks for the update. +1 (binding)
On Tue, 31 Jan 2023, 11:11 Martijn Visser, <martijnvis...@apache.org> wrote: > Hi Danny, > > > Why are we publishing the e2e tests jar? > > We shouldn't, but I think that's because the E2E tests config for GCP > hasn't been changed since 2018 and don't reflect the new setup. I've > created [1] as a follow-up. > > > When do we update to 2023? > > We should do that with the next release :) It's common to include the first > and last year of of a release, but it's not a mandatory thing. > > Best regards, > > Martijn > > [1] https://issues.apache.org/jira/browse/FLINK-30850 > > Op vr 27 jan. 2023 om 14:55 schreef Danny Cranmer <dannycran...@apache.org > >: > > > Hey Martijn, thanks for driving yet another connector release. > > > > Before I cast my vote I have a couple of queries: > > * Contents of dist. Why are we publishing the e2e tests jar [1]? We do > not > > typically do this, but I see the old GCP e2e tests are published [2], > > however not to maven central. > > * NOTICE and LICENSE look good, but I have a query on the copyright > > "Copyright 2014-2022 The Apache Software Foundation". When do we update > to > > 2023? > > > > Rest is ok: > > * Release notes look good > > * Verified signature and hashes or source archive and jar from dist > > * Verified there are no binaries in the source archive > > * Builds from src > > * Reviewed web PR > > * Tag present in Github > > > > Thanks, > > Danny > > > > [1] > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1581/org/apache/flink/flink-connector-gcp-pubsub-e2e-tests/ > > [2] > > > > > https://mvnrepository.com/artifact/org.apache.flink/flink-connector-gcp-pubsub-emulator-tests > > > > On Thu, Jan 26, 2023 at 7:06 PM Sergey Nuyanzin <snuyan...@gmail.com> > > wrote: > > > > > +1 (non-binding) > > > > > > * verified hashes and signatures > > > * verified versions in pom files > > > * verified LICENSE and NOTICE files > > > * compared sources against git tag > > > * built from sources > > > > > > > > > On Thu, Jan 26, 2023 at 3:08 PM Konstantin Knauf <kna...@apache.org> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > * checked Maven and source artifact signatures and checksums - OK > > > > * no binaries or packaged dependencies - OK > > > > * checked website changes - Approved. > > > > > > > > Am Fr., 20. Jan. 2023 um 15:39 Uhr schrieb Martijn Visser < > > > > martijnvis...@apache.org>: > > > > > > > > > Hi everyone, > > > > > Please review and vote on the release candidate #1 for the version > > > 3.0.0, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release to be deployed to > > dist.apache.org > > > > > [2], > > > > > which are signed with the key with fingerprint > > > > > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag v3.0.0-rc1 [5], > > > > > * website pull request listing the new release [6]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Release Manager > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352589 > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-gcp-pubsub-3.0.0-rc1 > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1581/ > > > > > [5] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink-connector-gcp-pubsub/releases/tag/v3.0.0-rc1 > > > > > [6] https://github.com/apache/flink-web/pull/604 > > > > > > > > > > > > > > > > > -- > > > > https://twitter.com/snntrable > > > > https://github.com/knaufk > > > > > > > > > > > > > -- > > > Best regards, > > > Sergey > > > > > >
