Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-02 Thread Jark Wu
Hi Timo, I will respond some of the questions: 1) SQL client specific options Whether it starts with "table" or "sql-client" depends on where the configuration takes effect. If it is a table configuration, we should make clear what's the behavior when users change the configuration in the lifecy

[jira] [Created] (FLINK-21247) flink iceberg table map cannot convert to datastream

2021-02-02 Thread donglei (Jira)
donglei created FLINK-21247: --- Summary: flink iceberg table map cannot convert to datastream Key: FLINK-21247 URL: https://issues.apache.org/jira/browse/FLINK-21247 Project: Flink Issue Type: New F

Re: [VOTE] FLIP-158: Generalized incremental checkpoints

2021-02-02 Thread Arvid Heise
FLIP looks good to me. +1 On Wed, Feb 3, 2021 at 8:00 AM Piotr Nowojski wrote: > I'm carrying over my +1 from the discussion thread. > > Piotrek > > śr., 3 lut 2021 o 05:55 Yuan Mei napisał(a): > > > As aforementioned in the discussion thread, +1 on this Flip vote. > > > > On Wed, Feb 3, 2021 a

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-02 Thread Shengkai Fang
Hi, Timo. Thanks for your detailed feedback. I have some thoughts about your feedback. *Regarding #1*: I think the main problem is whether the table environment has the ability to update itself. Let's take a simple program as an example. ``` TableEnvironment tEnv = TableEnvironment.create(...);

[jira] [Created] (FLINK-21246) Decline Checkpoint if some tasks finished before get triggered

2021-02-02 Thread Yun Gao (Jira)
Yun Gao created FLINK-21246: --- Summary: Decline Checkpoint if some tasks finished before get triggered Key: FLINK-21246 URL: https://issues.apache.org/jira/browse/FLINK-21246 Project: Flink Issue T

Re: [VOTE] FLIP-158: Generalized incremental checkpoints

2021-02-02 Thread Piotr Nowojski
I'm carrying over my +1 from the discussion thread. Piotrek śr., 3 lut 2021 o 05:55 Yuan Mei napisał(a): > As aforementioned in the discussion thread, +1 on this Flip vote. > > On Wed, Feb 3, 2021 at 6:36 AM Khachatryan Roman < > khachatryan.ro...@gmail.com> wrote: > > > Hi everyone, > > > > I'

[jira] [Created] (FLINK-21245) Support StreamExecCalc json serialization/deserialization

2021-02-02 Thread godfrey he (Jira)
godfrey he created FLINK-21245: -- Summary: Support StreamExecCalc json serialization/deserialization Key: FLINK-21245 URL: https://issues.apache.org/jira/browse/FLINK-21245 Project: Flink Issue T

Re: [DISCUSS] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Xintong Song
Thanks for your feedback, Kezhu. I think Flink *runtime* already has an ideal granularity for resource > management 'task'. If there is > a slot shared by multiple tasks, that slot's resource requirement is simple > sum of all its logical > slots. So basically, this is no resource requirement for

Re: [DISCUSS] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Yangze Guo
Hi, Kezhu. Thanks for your feedback. > Flink *runtime* already has an ideal granularity for resource management > 'task'. As mentioned in FLIP, there are some ancient codes in Flink code base, but these codes are never really used and exposed to user. So, there is actually no operator or SSG lev

[jira] [Created] (FLINK-21244) shouldPerformUnalignedCheckpointOnLocalAndRemoteChannel Fail

2021-02-02 Thread Guowei Ma (Jira)
Guowei Ma created FLINK-21244: - Summary: shouldPerformUnalignedCheckpointOnLocalAndRemoteChannel Fail Key: FLINK-21244 URL: https://issues.apache.org/jira/browse/FLINK-21244 Project: Flink Issue

Re: [DISCUSS] FLINK-21045: Support 'load module' and 'unload module' SQL syntax

2021-02-02 Thread Jark Wu
Hi Jane, Yes. I think we should fail fast. Best, Jark On Wed, 3 Feb 2021 at 12:06, Jane Chan wrote: > Hi everyone, > > Thanks for the discussion to make this improvement plan clearer. > > Hi, @Jark, @Rui, and @Timo, I'm collecting the final discussion summaries > now and want to confirm one th

Re: [DISCUSS] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Kezhu Wang
Hi all, sorry for join discussion even after voting started. I want to share my thoughts on this after reading above discussions. I think Flink *runtime* already has an ideal granularity for resource management 'task'. If there is a slot shared by multiple tasks, that slot's resource requirement

Re: [VOTE] FLIP-158: Generalized incremental checkpoints

2021-02-02 Thread Yuan Mei
As aforementioned in the discussion thread, +1 on this Flip vote. On Wed, Feb 3, 2021 at 6:36 AM Khachatryan Roman < khachatryan.ro...@gmail.com> wrote: > Hi everyone, > > I'd like to start a vote on FLIP-158 [1] which was discussed in [2]. > > The vote will be open for at least 72 hours. Unless

Re: [DISCUSS] FLINK-21045: Support 'load module' and 'unload module' SQL syntax

2021-02-02 Thread Jane Chan
Hi everyone, Thanks for the discussion to make this improvement plan clearer. Hi, @Jark, @Rui, and @Timo, I'm collecting the final discussion summaries now and want to confirm one thing that for the statement `USE MODULES x [, y, z, ...]`, if the module name list contains an unexsited module, sha

Re: [VOTE] FLIP-160: Declarative scheduler

2021-02-02 Thread Yu Li
+1 (binding) Best Regards, Yu On Mon, 1 Feb 2021 at 17:21, Matthias Pohl wrote: > +1 (non-binding) > > Thanks, > Matthias > > On Mon, Feb 1, 2021 at 4:22 AM Zhu Zhu wrote: > > > +1 (binding) > > > > Thanks, > > Zhu > > > > Yang Wang 于2021年2月1日周一 上午11:04写道: > > > > > +1 (non-binding) > > > >

Re: [VOTE] FLIP-159: Reactive Mode

2021-02-02 Thread Yu Li
+1 (binding) Thanks for the efforts Robert! Best Regards, Yu On Mon, 1 Feb 2021 at 17:19, Matthias Pohl wrote: > Thanks Robert and congratulations on your first FLIP. > +1 (non-binding) > > Matthias > > On Mon, Feb 1, 2021 at 4:22 AM Zhu Zhu wrote: > > > +1 (binding) > > > > Thanks, > > Zhu

Re: [DISCUSS] FLIP-152: Hive Query Syntax Compatibility

2021-02-02 Thread Jark Wu
Thanks Rui for the great proposal, I believe this can be very attractive for many Hive users. The FLIP looks good to me in general, I only have some minor comments: 1) BlinkParserFactory IIUC, BlinkParserFactory is located in the flink-table-api-java module with the Parser interface there. I sugg

Re: [DISCUSS] FLIP-152: Hive Query Syntax Compatibility

2021-02-02 Thread godfrey he
Thanks for bringing up the discussion, Rui! Regarding the DDL part in the "Introduce HiveParser" section, I would like to choose the second option. Because if we could use one hive parser to parse all hive SQLs, we need not to copy Calcite parser code, and the framework and the code will be very s

Re: [DISCUSS] FLIP-152: Hive Query Syntax Compatibility

2021-02-02 Thread Rui Li
Hi Jingsong, Thanks for your comments and they're very good questions. Regarding # Version, we need to do some tradeoff here. Choosing the latest 3.x will cover all the features we want to support. But as you said, 3.x and 2.x can have some differences and requires more efforts to support lower v

Re: [DISCUSS] FLINK-21110: Optimize Scheduler Performance for Large-Scale Jobs

2021-02-02 Thread Guowei Ma
Thanks to ZhiLong for improving the scheduler's performance. I think many users would benefit from your work! Best, Guowei On Wed, Feb 3, 2021 at 2:04 AM Till Rohrmann wrote: > Thanks for making the community aware of these performance improvements, > Zhilong. I like them and I am looking forwa

[VOTE] FLIP-158: Generalized incremental checkpoints

2021-02-02 Thread Khachatryan Roman
Hi everyone, I'd like to start a vote on FLIP-158 [1] which was discussed in [2]. The vote will be open for at least 72 hours. Unless there are any objections, I'll close it by February 5, 2021 if we have received sufficient votes. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-158%3

Re: [DISCUSS] FLINK-21110: Optimize Scheduler Performance for Large-Scale Jobs

2021-02-02 Thread Till Rohrmann
Thanks for making the community aware of these performance improvements, Zhilong. I like them and I am looking forward to a faster Flink :-) Cheers, Till On Tue, Feb 2, 2021 at 11:00 AM Zhilong Hong wrote: > Hello, everyone: > > I would like to start the discussion about FLINK-21110: Optimize S

[jira] [Created] (FLINK-21243) Add Java SDK maven module

2021-02-02 Thread Igal Shilman (Jira)
Igal Shilman created FLINK-21243: Summary: Add Java SDK maven module Key: FLINK-21243 URL: https://issues.apache.org/jira/browse/FLINK-21243 Project: Flink Issue Type: Task Componen

Re: [DISCUSS] FLIP-162: Consistent Flink SQL time function behavior

2021-02-02 Thread Jark Wu
Hi Fabian, I think we have an agreement that the functions should be evaluated at query start in batch mode. Because all the other batch systems and traditional databases are this behavior, which is standard SQL compliant. *1. The different point of view is what's the behavior in streaming mode?

[jira] [Created] (FLINK-21242) Support state access API for map operation

2021-02-02 Thread Wei Zhong (Jira)
Wei Zhong created FLINK-21242: - Summary: Support state access API for map operation Key: FLINK-21242 URL: https://issues.apache.org/jira/browse/FLINK-21242 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-21241) E2E test exception check might fail if older checkpoint not completed when triggering the stop-with-savepoint

2021-02-02 Thread Yun Tang (Jira)
Yun Tang created FLINK-21241: Summary: E2E test exception check might fail if older checkpoint not completed when triggering the stop-with-savepoint Key: FLINK-21241 URL: https://issues.apache.org/jira/browse/FLINK-21

[jira] [Created] (FLINK-21240) incompati datetime

2021-02-02 Thread macdoor615 (Jira)
macdoor615 created FLINK-21240: -- Summary: incompati datetime Key: FLINK-21240 URL: https://issues.apache.org/jira/browse/FLINK-21240 Project: Flink Issue Type: Bug Reporter: macdoor

Re: [VOTE] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Yang Wang
+1 (non-binding) Best, Yang Chesnay Schepler 于2021年2月2日周二 下午5:50写道: > +1 > > On 2/2/2021 10:11 AM, Till Rohrmann wrote: > > +1 (binding) > > > > Cheers, > > Till > > > > On Mon, Feb 1, 2021 at 5:38 AM Xintong Song > wrote: > > > >> +1 (binding) > >> > >> Thank you~ > >> > >> Xintong Song > >>

Re: Proposal to add Google Cloud Storage FileSystem with RecoverableWriter

2021-02-02 Thread Xintong Song
Hi Galen, Thanks for offering the contribution. As Till has already suggested, please comment on FLINK-11838 your solution proposal. Once we reach consensus on the proposal, I'll assign you to the ticket. Thank you~ Xintong Song On Tue, Feb 2, 2021 at 5:19 PM Till Rohrmann wrote: > Hi Gale

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-02 Thread Timo Walther
Thanks for this great proposal Shengkai. This will give the SQL Client a very good update and make it production ready. Here is some feedback from my side: 1) SQL client specific options I don't think that `sql-client.planner` and `sql-client.execution.mode` are SQL Client specific. Similar t

Re: [DISCUSS] FLIP-162: Consistent Flink SQL time function behavior

2021-02-02 Thread Fabian Hueske
Hi everyone, Sorry for joining this discussion late. Let me give some thought to two of the arguments raised in this thread. Time functions are inherently non-determintistic: -- This is of course true, but IMO it doesn't mean that the semantics of time functions do not matter. It makes a differen

[jira] [Created] (FLINK-21239) Upgrade Calcite version to 1.28

2021-02-02 Thread Timo Walther (Jira)
Timo Walther created FLINK-21239: Summary: Upgrade Calcite version to 1.28 Key: FLINK-21239 URL: https://issues.apache.org/jira/browse/FLINK-21239 Project: Flink Issue Type: Improvement

[DISCUSS] FLINK-21110: Optimize Scheduler Performance for Large-Scale Jobs

2021-02-02 Thread Zhilong Hong
Hello, everyone: I would like to start the discussion about FLINK-21110: Optimize Scheduler Performance for Large-Scale Jobs [1]. According to the result of scheduler benchmarks we implemented in FLINK-20612 [2], the bottleneck of deploying and running a large-scale job in Flink is mainly focu

Re: [VOTE] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Chesnay Schepler
+1 On 2/2/2021 10:11 AM, Till Rohrmann wrote: +1 (binding) Cheers, Till On Mon, Feb 1, 2021 at 5:38 AM Xintong Song wrote: +1 (binding) Thank you~ Xintong Song On Mon, Feb 1, 2021 at 11:56 AM Yangze Guo wrote: Hi everyone, I'd like to start the vote of FLIP-156 [1]. This FLIP is di

Re: Proposal to add Google Cloud Storage FileSystem with RecoverableWriter

2021-02-02 Thread Till Rohrmann
Hi Galen, I think that adding support for GCS using the StreamingFileSink sounds like a very good idea to me. Looking at FLINK-11838 I believe that this effort has been abandoned. I think that you could take this ticket over if you want. Maybe you could update this ticket with your solution propos

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-02 Thread Shengkai Fang
Sorry for the typo. I mean `RESET` is much better rather than `UNSET`. Shengkai Fang 于2021年2月2日周二 下午4:44写道: > Hi, Jingsong. > > Thanks for your reply. I think `UNSET` is much better. > > 1. We don't need to introduce another command `UNSET`. `RESET` is > supported in the current sql client now.

Re: [VOTE] FLIP-156: Runtime Interfaces for Fine-Grained Resource Requirements

2021-02-02 Thread Till Rohrmann
+1 (binding) Cheers, Till On Mon, Feb 1, 2021 at 5:38 AM Xintong Song wrote: > +1 (binding) > > Thank you~ > > Xintong Song > > > > On Mon, Feb 1, 2021 at 11:56 AM Yangze Guo wrote: > > > Hi everyone, > > > > I'd like to start the vote of FLIP-156 [1]. This FLIP is discussed in > > the thread[

Re: [DISCUSS] FLIP-152: Hive Query Syntax Compatibility

2021-02-02 Thread Jingsong Li
Thanks Rui for the proposal, I think this FLIP is required by many users, and it is very good to traditional Hive users. I have some confusion: # Version Which Hive version do you want to choose? Maybe, Hive 3.X and Hive 2.X have some differences? # Hive Codes Can you evaluate how much code we

Re: [DISCUSS] FLIP-162: Consistent Flink SQL time function behavior

2021-02-02 Thread Kurt Young
BTW I also don't like to introduce an option for this case at the first step. If we can find a default behavior which can make 90% users happy, we should do it. If the remaining 10% percent users start to complain about the fixed behavior (it's also possible that they don't complain ever), we cou

Re: [DISCUSS] FLIP-162: Consistent Flink SQL time function behavior

2021-02-02 Thread Kurt Young
Hi Timo, I don't think batch-stream unification can deal with all the cases, especially if the query involves some non deterministic functions. No matter we choose any options, these queries will have different results. For example, if we run the same query in batch mode multiple times, it's also

Re: [DISCUSS]FLIP-163: SQL Client Improvements

2021-02-02 Thread Shengkai Fang
Hi, Jingsong. Thanks for your reply. I think `UNSET` is much better. 1. We don't need to introduce another command `UNSET`. `RESET` is supported in the current sql client now. Our proposal just extends its grammar and allow users to reset the specified keys. 2. Hive beeline also uses `RESET` to s

Re: [DISCUSS] FLIP-162: Consistent Flink SQL time function behavior

2021-02-02 Thread Timo Walther
Hi everyone, I'm not sure if we should introduce the `auto` mode. Taking all the previous discussions around batch-stream unification into account, batch mode and streaming mode should only influence the runtime efficiency and incremental computation. The final query result should be the same