Re: Hope to contribute code

2020-05-09 Thread Leonard Xu
Hi, Very happy to hear you're willing to contribute community. Contribution to Flink includes many ways like `Report a Bug`,`Contribute Code`, `Code Reviews` and so on, Flink community has a detailed guidance[1] to make it easy. For the `Contribute Code` section, Flink uses JIRA[1] to track all

Re: [DISCUSS] FLIP-126: Unify (and separate) Watermark Assigners

2020-05-09 Thread Jark Wu
Hi, Regarding to the `open()/close()`, I think it's necessary for Table&SQL to compile the generated code. In Table&SQL, the watermark strategy and event-timestamp is defined using SQL expressions, we will translate and generate Java code for the expressions. If we have `open()/close()`, we don't

Re: Hope to contribute code

2020-05-09 Thread Manish G
There is a file 'WordCount.java' in the codebase. You can start executing and debugging it to understand how the whole flow works. And then you can start exploring further which would help you to identify the issues you can work upon. Manish On Sun, May 10, 2020 at 7:51 AM Pankaj Chand wrote: >

Re: Hope to contribute code

2020-05-09 Thread Pankaj Chand
+2 On Sat, May 9, 2020, 10:16 PM Venkata Sanath Muppalla wrote: > +1 > > On Sat, May 9, 2020, 7:11 PM i'mpossible <605769...@qq.com> wrote: > > > Hi, > >     I hope to contribute some simple code to flink, But it is > > difficult for me to find a problem that is suitable  > > for myself among th

Re: Hope to contribute code

2020-05-09 Thread Venkata Sanath Muppalla
+1 On Sat, May 9, 2020, 7:11 PM i'mpossible <605769...@qq.com> wrote: > Hi, >     I hope to contribute some simple code to flink, But it is > difficult for me to find a problem that is suitable  > for myself among the many problems of JIRA.  > > >     I think many people will have the same proble

Hope to contribute code

2020-05-09 Thread i'mpossible
Hi,     I hope to contribute some simple code to flink, But it is difficult for me to find a problem that is suitable  for myself among the many problems of JIRA.      I think many people will have the same problem, that is how to get a simple question and then contribute  their first code. Thi

Re: [DISCUSS] FLIP-126: Unify (and separate) Watermark Assigners

2020-05-09 Thread Stephan Ewen
Thanks, Aljoscha, for picking this up. I agree with the approach of doing the here proposed set of changes for now. It already makes things simpler and adds idleness support everywhere. Rich functions and state always add complexity, let's do this in a next step, if we have a really compelling ca

Re: [DISCUSS] Align the behavior of internal return result of MapState#entries, keys, values and iterator.

2020-05-09 Thread Jark Wu
+1 to return emty iterator and align the implementations. Best, Jark On Sat, 9 May 2020 at 19:18, SteNicholas wrote: > Hi Tang Yun, > I agree with the point you mentioned that align these internal > behavior > to return empty iterator instead of null. In my opinion, > StateMapViewWithKeysN

[jira] [Created] (FLINK-17598) Implement FileSystemHAServices for native K8s setups

2020-05-09 Thread Canbin Zheng (Jira)
Canbin Zheng created FLINK-17598: Summary: Implement FileSystemHAServices for native K8s setups Key: FLINK-17598 URL: https://issues.apache.org/jira/browse/FLINK-17598 Project: Flink Issue Ty

[jira] [Created] (FLINK-17597) JavaSqlTests#test_java_sql_ddl is instable

2020-05-09 Thread Dian Fu (Jira)
Dian Fu created FLINK-17597: --- Summary: JavaSqlTests#test_java_sql_ddl is instable Key: FLINK-17597 URL: https://issues.apache.org/jira/browse/FLINK-17597 Project: Flink Issue Type: Bug Co

Re: [DISCUSS] Align the behavior of internal return result of MapState#entries, keys, values and iterator.

2020-05-09 Thread SteNicholas
Hi Tang Yun, I agree with the point you mentioned that align these internal behavior to return empty iterator instead of null. In my opinion, StateMapViewWithKeysNullable handle nullable map keys, and result of internal map state should be empty map in the null behavior case. Therefore, as you

[DISCUSS] Align the behavior of internal return result of MapState#entries, keys, values and iterator.

2020-05-09 Thread Yun Tang
Hi devs This thread is inspired by FLINK-17015 [1] which meet NEP when SQL guys develop operator based on internal map state. Unfortunately, we have different behavior of result of internal map state. For HeapMapState, #entries(), #keys(), #values(), and #iterator() would all return null. Howe

[jira] [Created] (FLINK-17596) Unstable PyFlinkBlinkStreamUserDefinedFunctionTests testMethod#test_udf_in_join_condition_2

2020-05-09 Thread Yun Tang (Jira)
Yun Tang created FLINK-17596: Summary: Unstable PyFlinkBlinkStreamUserDefinedFunctionTests testMethod#test_udf_in_join_condition_2 Key: FLINK-17596 URL: https://issues.apache.org/jira/browse/FLINK-17596 P

[jira] [Created] (FLINK-17595) JobExceptionsInfo. ExecutionExceptionInfo miss getter method

2020-05-09 Thread Wei Zhang (Jira)
Wei Zhang created FLINK-17595: - Summary: JobExceptionsInfo. ExecutionExceptionInfo miss getter method Key: FLINK-17595 URL: https://issues.apache.org/jira/browse/FLINK-17595 Project: Flink Issue

[jira] [Created] (FLINK-17594) Support path-based PartFileWriter

2020-05-09 Thread Yun Gao (Jira)
Yun Gao created FLINK-17594: --- Summary: Support path-based PartFileWriter Key: FLINK-17594 URL: https://issues.apache.org/jira/browse/FLINK-17594 Project: Flink Issue Type: Sub-task Compon

[jira] [Created] (FLINK-17593) Support arbitrary recovery mechanism for PartFileWriter

2020-05-09 Thread Yun Gao (Jira)
Yun Gao created FLINK-17593: --- Summary: Support arbitrary recovery mechanism for PartFileWriter Key: FLINK-17593 URL: https://issues.apache.org/jira/browse/FLINK-17593 Project: Flink Issue Type: New