Re: [FlexJS] more on undefined / non initialised values

Hi, > If a variable is of type Boolean in AS (not JS), is there a > difference between these three patterns. No as a boolean can only have the values of true and false and defaults to false in AS. If you take the same code and run it in the browser it can now have three values, true, false and

Re: [FlexJS] more on undefined / non initialised values

HI, > The general principle is optimization. Optimization looks for specific > patterns. What you wrote below is not one of the patterns. Not one of what patterns? BTW Initialising the Boolean to false also optimises the seed by a factor of two. i.e. twice as fast. > Would be fun to see how

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, Perhaps a silly question but does there need to be a release of the typedef project as well? Even if only for Maven? Thanks, Justin

Re: [DISCUSS] Discuss Release Apache Flex FalconJX 0.8.0 RC1

Hi, I notice falcon-flexTasks.jar is missing from the compiler/lib directory and asdocs.jar and falcon-flexTasks.jar msiinsg form /js/lib. Should they be included? Thanks, Justin

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, +1 (binding) as long as the missing jars are not an issue (see discussion) I checked on OSX: - Signatures and hashes correct - LICENSE and NOTICE correct - All source files have ASF headers - No unexpected binary files - Can compile from source (using mvn) - Tests pass - Can use to compile a

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 950 - Still Failing

Hi, This seem to be failing due to typedef failing? [INFO] --- exec-maven-plugin:1.5.0:exec (patch-js) @ flexjs-typedefs-js --- error: patch failed: js/target/downloads/svg.js:401 error: js/target/downloads/svg.js: patch does not apply [ERROR] Command execution failed. and Compiling locally and

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 950 - Still Failing

Hi, > I got it also. When I compiled typedefs it's gone. Those error are from compiling typedefs, I’m using the latest develop branch. Thanks, Justin

Re: [FlexJS] more on undefined / non initialised values

Hi, So to summarise this thread. - discussing if Boolean be initialised to false and Numbers to NaN - Code can act differently on AS and JS when these initialisers are not present - Josh and I think this a serious bug - Harbs also sees the issue - Piotrz also wants Booleans and Numbers to be init

Re: [FlexJS] more on undefined / non initialised values

Hi, If you were wondering about the size here’s the results. The release version was 1441523 bytes before the change and 1441458 bytes after the change i.e. it become smaller by about 1/1 of a % after the Numbers an Booleans were initialised. I guess google optimisation works in mysterious

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > I did not see anything that would preclude a release, but the readme does not > have anything that mentions Maven. The prerequisites only mention ANT and > environment variables. Falcon has this [1] should be easy enough to do similar. Thanks, Justin 1. https://github.com/apache/flex-fa

Re: [FlexJS] more on undefined / non initialised values

Hi, > The changes you made look fine. Do you want them as the default and an option to turn them off? I’m assuming you will you at some later point add other switches to turn other optimisations (whatever they may be) on? > Seems like eventually we'll have to initialize other types as well. I

Re: [FlexJS] more on undefined / non initialised values

Hi, > But I don’t see this as critical for now. This is probably not required as the google compiler take care of this for us. Code like this: function test() { var a = false; a = b; if (a) { Console.log("got here"); } } Becomes: function test(){b&&Console.log("got here”)} In this

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, Currently the RC1 fails to compile with maven with this error: [ERROR] org.apache.flex.flexjs.typedefs:flexjs-typedefs-js:swc:0.8.0-SNAPSHOT [ERROR] [ERROR] from the specified remote repositories: [ERROR] apache-release (https://repository.apache.org/content/repositories/releases, releases=t

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > I didn't get it and I was building by Maven straight from the sources > downloaded by ApproveFlexJS script. Are these the same sources that are in the release? Perhaps there’s an issue there BTW I’m also see the issue on develop branch and so is the apache build server. Thanks, Justi

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Flex-typedefs code should be packaged in the -falconjx packages. I can see in that in the falcon source release when when I try to compile it I get the following error: error: patch failed: js/target/downloads/svg.js:401 error: js/target/downloads/svg.js: patch does not apply Thanks, Jus

Re: [VOTE] Release Apache FlexJS 0.8.0 RC1

Hi, Sorry -1 (binding) as unable to compile from source. Will change to +1 once I can and test build. It looks like this may be an issue with the typedef code bundled in the falcon RC1 release so it may be that that RC needs to change rather than this RC? I checked: - signatures and hashes cor

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, Locally I have been using Maven for 4 months or so to build Falcon / FlexJS and haven’t run into any major issues expect when the dual branch was first merged and in the last couple of days so obviously something has changed recently that stops this from working. Thanks, Justin

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > mvn clean install -Drat.skip=true -s ~/.m2/settings-test.xml > > (My settings-test.xml simply excludes the Apache snapshot repo) So by just removing this right? apache.snapshots.https jmclean X If so I’m still getting this: error: patch failed: js/target/downloads/svg.js:

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Are there some files that are being caught by RAT? If so, what are they? I mentioned them in my vote email. [1] 3 patch files don’t have ASF headers. > IMO, the main thing folks want from Maven are the JARs which aren't an > official ASF release anyway. Seems like we should vote on a sou

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > Justin - you did state that you consider this acceptable for this release and > that we can clean it up for the next. Yes I stated that in my vote and that would be acceptable. Thanks, Justin

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, Changing to -1 (binding). I can confirm the tyoedef issue is not due to differences in git version. My guess (but not confirmed) is that some people may to have the js file file cached and that it has changed recently so the patch no longer applies. I can confirm that the current js.patch

Re: [DISCUSS] Discuss Release Apache Flex FalconJX 0.8.0 RC1

Hi, > I saw your -1. Are you talking about Maven build not Ant? Just wanted to > know for clarification. In this case I’m seeing the failure on Maven, but I would assume ant would fail as well if the patch can’t be applied. Also in develop my CI is also seeing it and so is the Apache Jenkins b

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, > I assume this is from the patch. Yep that’s in the patch. /** * @param {string} type - * @param {!EventListener|(function(Event): (boolean|undefined))| null} listener + * @param {!EventListener|(function(!Event): (boolean|undefined))| null} listener * @param {boolean=} opt_useCapture */ S

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, > Justin experienced this issue, maybe he will try fix with cache. I can confirm that is the issue is as Greg explained. Like Greg once the issue is fixed it actually hard to reproduce. I have some time today and will look further into it and see if I can reliably reproduce and fix it. Th

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC1

Hi, > I did the changes, but need to do more test whether I didn't forget about > something. I will push everything tomorrow - if there will not be any veto. Just a friendly reminder that a -1 on a release vote is not a veto. You need 3 +1’s and more +1’s than -1’s for a release vote to pass. H

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, > If you could once again reproduce this issue and try later whether switch > off cache help that would be good. > > Go to: flex-typedefs\js\pom.xml and add to configuration tag in > download-maven-plugin > > true And I can confirm that this fixes the issue. Thanks, Justin

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC1

Hi, > I wonder if you can get in this hole by running Maven without the clean > target. No it occurs even with clean specified. > so it might be better to just bundle and modify. +1 to that. It’s very likely that old releases of FlexJS may not be able to be compiled in the future as 3rd party

Re: [DISCUSS] Discuss Release Apache Flex FalconJX 0.8.0 RC2

Hi, > During examination I noticed that in folder "apache-flex-falconjx-0.8.0-bin" > rat complains about this files That’s fine rat tends to complain a bit when run over binary releases. > D:/flex_sdk/empty_folder/apache-flex-falconjx-0.8.0-bin/flex-typedefs/GCL/target/rat.txt I’ve not looked

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

Hi, >> I noticed the MIT license says: 2013-2016. Shouldn't it be 2013-2017? >> >> The MIT License (MIT) >> Copyright (c) 2013-2016 Designmodo It matters a small amount but is not an issue. The question to ask is has any changes been made to the code we bundle by Designmodo in 2017. If not the

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

Hi, > Since we didn't staged typedefs (in the next release we should) you have to > first build Falcon and typedefs. This is likely going to cause a number of issues as nor everyone will compile typedefs from source and would expect it to deployed. It still still be possible to stage it from th

Re: [DISCUSS] Discuss Release Apache Flex FalconJX 0.8.0 RC2

Hi, It looks like the encoding of the help files [1] for the command line tools has changed between RC1 and RC2. I’m not sure if it was incorrect before or incorrect now or if it even matters. Could someone who's first language isn't English please double check it’s not broken. Thanks, Justi

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

Hi, I’m also seeing encoding difference between RC1 and RC2 in .as files [1][2][3] I think it may only be in comments - look to be “smart" quotes. Thanks, Justin 1. frameworks/projects/Language/src/main/flex/QName.as 2. frameworks/projects/XML/src/main/flex/XML.as 3. frameworks/projects/XML/src

Re: [3/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !== where needed

Hi, Can you provide a bit more information on how it is broken? Can you point to any failing tests for instance or provide sample code? I’m using these changes in a project and have't noticed any issues and tests are still passing. IMO it would be better to try and pinpoint the issue rather th

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > It broke when element was undefined. So why not only change / revert that? > There’s no reason to use strict equality so rampantly. (The performance gains > are insignificant.) As has previously been discussed on develop the performance gains are significant. Thanks, Justin

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC2

Hi, +1 (binding) I checked on OSX: - Signatures and hashes correct - LICENSE and NOTICE correct - All source files have ASF headers - No unexpected binary files - Can compile from source (using mvn) - Tests pass like RC1 I did note that the rat check fails on 3 files: flex-typedefs/google_maps/

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

Hi, I just tested the new RC2 and I’m see a couple of issues with our application. 1) initialisation order seem to have changed for mxml components and we’re getting some things undefined where previously they were defined. 2) a couple layouts are now broken I’m going to assume this are easily f

Re: [VOTE] Release Apache FlexJS 0.8.0 RC2

Hi, +1 (binding) I checked: - signatures and hashes correct - LICENSE and NOTICE are fine - all source files have ASF headers - no unexpected binary files in release - Can compile from source I compiled a largish FlexJS application and did notice a few issues (see discussion thread) but they do

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > You willy-nilly changed equality to strict equality. That cost me time and > money. I vetoed your change. Period. I have no issue with you fixing a bug or even asking me to fix it but please put my changes back. > Changing all equality to strict equality is (IMO) pedantic. In most cases

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > The main argument for using strict equality is because it does type > conversions which can cause bugs. Incorrect strict equality doesn’t do type conversion, but I assume you meant to say "it doesn’t do type conversion”. > Since we are using a strongly typed language, type safety is gene

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, >> I got performance gains of 30-40%. > > Of what? Percentages when dealing with such cheap operators are generally > meaningless. Of total CPU time spent on application for a few minutes. Measured using the Chrome profiler. Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

HI, Point 1 may explain the issue clearer [1] there are situation we’re use of == and != is going to cause bugs. Thanks, Justin 1. https://herringtondarkholme.github.io/2016/11/05/how-to-write-copy-paste-friendly-code/

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > Again; this means nothing to me. What is your app doing and how much CPU time > was spent? Startup up and showing a few windows, changing a few tabs within a reasonably complex layout some web service call going on in the background. Initial cpu time was of the order of 480ms from memory

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

HI, Alternately you can compile the source release using maven and install locally i.e. mvn clean install Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > Your link is actually arguing for use for non-strict equality… I suggest you read the content at the link again [1] perhaps you missed the humour there. So given you don’t want to use strict equality and inequality how do you want to handle this? Does everyone agree with that not using t

Re: [FlexJS] more on undefined / non initialised values

Hi, So I’ve just checked in a compiler option to turn the initialisers for Number and Boolean off just is case you want to optimise this in other way. If there are no objections or further suggested changes I’ll merge into develop next week sometime. YMMV but once merged if you do turn them of

Re: [1/2] git commit: [flex-falcon] [refs/heads/initializers] - make default initialisers configurable

Hi, > Is this mean that if this property is true in config and I set my boolean > property to false it will be ignored ? No. If you do this it will be false. var prop:Boolean = false; If you do this it will be true. var prop:Boolean = true; If you do this: var prop:Boolean; it will be false a

Re: [1/2] git commit: [flex-falcon] [refs/heads/initializers] - make default initialisers configurable

Hi, > It is default swtich on as I understand ? No you use it to turn initialisers off. if you don’t use the compiler option then uninitialised Booleans will default to false and Numbers will default to NaN. This is different to how the current compiler does it. if you do use it then initiali

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > Thanks for raising jira, I will revert develop soon. There’s no rush we can see if anyone has an option on it. I’ve not tested in the change in the SDK yet. Just want to show that it improved performance first. > I hope we will find solution which will not break any changes in apps. On

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

HI, > Assuming the numbers are really indicative, you’ve just shown it to be no > significant increase in performance. It’s also quite possible that the > browser is optimizing some of the checks away. It show significant permanence increase in Chrome on mac and windows and in Safari. > You m

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > I have never seen real world ActionScript code which uses strict equality for > null. Remember we are also cross compiling to Javascript as well. As as I see we have a choice between using strict equality or initialising Objects and Strings but you want neither? If there’s a performance

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > undefined can be a functional change to ActionScript code when adding to > numbers and strings: > > var obj:Foo; > trace(1 + undefined); NaN > trace("hello " + undefined); //hello undefined > trace(1 + obj); //1 > trace("hello " + obj); //hello null > trace(1 + null); //1 > trace("hello "

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > You didn't get warnings when mixing undefined with Number or String? No warnings are given. The same code compiled using the FlexSDK also doesn’t give any warnings. Thanks, Justin

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

Hi, I’m curious and certainly not a veto / asking you to revert this. Is there any reason why this isn’t a BailoutDisableBead via PAYG concepts? Thanks, Justin > On 25 Jun 2017, at 7:36 pm, ha...@apache.org wrote: > > Repository: flex-asjs > Updated Branches: > refs/heads/tlf 26b15e5a0 -> 9986

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

Hi, > It would be an interesting exercise to see much much adding null > initialization would add to file size. I would guess that it would be > significant. It’s not from the test’s I’ve done. I’ve also mentioned this several times you keep forgetting that the closure compiles optimises the c

Re: Build failed in Jenkins: flex-falcon #1627

Hi, > Does this failure is related to failing MD5Checker ? I don't think so. It looks like one of the unit tests has failed. BUILD FAILED >:892: The fo

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > That's not a merge error. That code is now in AllCSSValuesImpl and is not > needed in SimpleCSSValuesImpl. Please follow the commits. Consensus was to leave it in SimpleCSSValuesImpl why did you change it without discussion? We have a live application that is using this. AllCSSValuesImp

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > AllCSSValuesImpl - is not enough performant cause of lack of strict > comparison ? Just the large number of styles.When Harbs added it he said "It has a LOT of styles, so it’s probably best to not use in as-is in deployed apps…” Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, But you did agreed that the code in question should stay in CSSValuesImpl. From you last email in that thread: "I agree with Justin on this. I don’t see why numeric font weights is different than backgroundImage for example. Not every app uses backgroundImage, but it should work if used. T

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > Considering we have AllCSSValuesImpl, I think that should be the default for > apps which are expecting HTML CSS. It’s not about HTTML CSS. This code: Will compile with no warnings but fail to work without the fix. Thanks, Justin

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > A font weight of 600 will fail in Flash. It compiles with no warnings and displays the text correctly. There is no run time error but if you mean by “fail” it doesn't set the text to font weight to 600 then that’s correct. That is expected as 600 is not a supported value for font weight

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

Hi, > The JS version of the test is here: > http://home.apache.org/~aharui/FlexJS/FLEX35330/bin/js-release/ > > The SWF version of the test is here: > http://home.apache.org/~aharui/FlexJS/FLEX35330/bin-debug/ > > For me, the SWF

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > That’s why you should use You can’t in this case as it doesn’t compile with the following error: This tag could not be resolved to an ActionScript class. It will be ignored. So somehow you need to include one on one platform and one on the other in MXML I’m not sure if our co

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, The class is there I’m on the latest version of develop of all 3 repos and I’m still getting that compile error. Did you actually try using that class / compiling it? Thanks, Justin

Re: [FLEXJS][FALCONJX] Variable Initialization, equality, etc.

HI, > There are tests for both, and you DON’T get type conversions unless it’s > required. Browsers are smarter than that. See [1] and follow the path if x in undefined and y is a boolean and true. Compare this with [2] Thanks, Justin 1. https://es5.github.io/#x11.9.3

Re: [FlexJS] PAYG definitions and guidance, Please participate

Hi, Thanks for that Greg and good to see it started some conversation around this. Thanks, Justin

Re: [FlexJS] PAYG definitions and guidance, Please participate

Hi, > You could be right that folks are just too used to the old Flex way of > thinking. If you've never hit the performance and size issues I've seen > then maybe you can't understand the motivation behind it, but that might > mean the active committers are self-selected. I’ve worked on many la

Re: [Legal] Code from Stack Overflow

Hi, > My understanding is that CC-BY-SA is “strong copyleft” and not really > compatible with Apache licensing. Is that right? Not quite. Unmodified images and the like can be included [1]. Source code can not be included [2]. There was a discussion about this on legal discuss a little while a

Re: Installer Problems

Hi, IMO downloading the binaries from an offical Apache page should be the preferred link to hand out [1][2] even if a little more effort is needed to make a working SDK. Thanks, Justin [1] http://flex.apache.org/download-binaries.html [2] http://flex.apache.org/download-flexjs.html

Re: [FlexJS] 0.8.0 not working in IntelliJ IDEA

Hi, > I was trying some time ago to do as you are doing and failed. - Not sure > whether it was same problem. After some time I gave up. > > The conclusion is that I end up with pom for Maven build and setup where the > intelisence is working. That mirrors my experience as well. I know Chris l

[FlexJS] technical debt

Hi, If you take a look at this [1] you see that technical debt increased a bit between the 0.8 and 0.9 releases. It would be good if we could reduce this. While Sonar cube isn’t perfect, probably needs some tuning, and there are a number of false positives in there it is trying to tell us somet

Re: [FlexJS] technical debt

Hi, > In the differential all 30 of the bugs are of the form: > > Make this class “Event" override "Event.clone()” function Which some are false positives as there’s a cloneEvent method. Note you can mark them as such in the interface. I had already fixed a couple of these a few weeks back. >

Re: [FlexJS] technical debt

Hi, > You cut my previous reply which means I need to repeat. Why is that? All modern email clients support threaded messages. so people should be able to see my email and your original in context. When replying repeating the whole email is generally frowned upon. Sorry if I cut too much out

Re: [FlexJS] technical debt

Hi, Dave I assume the case statement issue you referring to is is the last one in this list [1]. It not a bug but style wise it’s a little odd and probably should still be fixed. Thanks, Justin 1. https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3A

Re: [FlexJS] technical debt

Hi, > A large percentage of the complaints are inaccurate. The reason the technical > debt increased is largely because of the new TLF code. > > Who made these rules and how do we change them? We can make it look much > better by just changing some of the rules… The rules come from various pla

Re: [FlexJS] technical debt

Hi, > - Do we care about code being commented out? I think not. If we know why it was commented out sure. There’s always the concern is this code possibly needed or not? > - Does a semicolon matter? It marked as a minor issue but it can cause issues when JS code is optimised and/or minified.

Re: FlexJS Tests (was Re: [FlexJS] technical debt)

Hi, BTW Sonar can give you useful test coverage statistics [1] and will even show line by line where a test is covered by tests [2] look at the red and green bars in the gutter. Thanks, Justin 1. https://builds.apache.org/analysis/component_measures/domain/Coverage?id=org.apache.flex.flexjs.c

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > I just tried swapping SimpleCSSValuesImpl for AllCSSValuesImpl in the > develop branch in examples/flexjs/DataBindingExample and it worked for me. > > Does it still not work for you? It still does not work for me. Justin

Re: [FlexJS] technical debt

Hi, >> IMO, even more important than technical debt is a test system and tests to >> make sure any changes don't break anything. > > That would include any changes to fix “technical debt”. Or if fact any changes right? Thanks, Justin

Re: [FlexJS] technical debt

Hi, > That is the concern, but it may be that the developer was making a > speculative change. If I were cleaning then I would do one of two actions. > > (a) Review the history of that change and see if the associated comments > provide a reason. > (b) Ask the developer who made the change. Bo

Re: [FlexJS] technical debt

Hi, > If you make a change to fix technical debt then you should also assure that > both existing tests pass and if no tests exist then tests are added and > proper. I’m all for more tests. However should this apply to any changes anyone makes for any reason OR only changes I make? I asking b

Re: [FlexJS] technical debt

Hi, > Think of it like this if someone makes a commit you would not revert without > giving them an opportunity to do it first. > > So the suggestion from me is get approval for anything complex. It is the > social thing to do. !00% agree. > I see you asked directly about a standard else thre

Re: [FlexJS] technical debt

Hi, >> and how do we change them? In the sonar cube web interface (same url as before) under rules/quality profile. It's best to set up a new quality profile rather than edit the existing one as that may effect other projects. I’ll put together a wiki page on making the rules more in the style

Re: [FlexJS] technical debt

Hi, > I don’t see any options like that (logged in using my Apache account). Does > someone need to add permissions? If you can’t see them then yes you would need to ask infra. Justin

Re: [FlexJS] technical debt

Hi, I’ve created a draft page here [1] and will do some more work on it over the weekend. Thanks, Justin 1. https://cwiki.apache.org/confluence/display/FLEX/Sonar+Cube+Flex+Rules

Re: [FlexJS] technical debt

Hi, > My discussion was around procedures related to technical debt. And you would agree the Sonar Cube configuration relates to that? > Keep in mind that this is all my opinion as part of the PMC. If others don't > agree then there is not yet consensus. Which is why as suggested I’m trying to

Re: [FlexJS] technical debt

Hi, > Before you accuse anyone (even if you expressed doubt) do you have a way to > determine who made the change to the Sonar Cube configuration? I can’t see anything in the interface no, but the changes are logged and infra will be able to tell. If it wasn’t him I’ll appoligise. Thanks, Just

Re: git commit: [flex-asjs] [refs/heads/develop] - Fix merge error removing support for numeric font size.

Hi, > Well, then maybe you can help us figure out why. Upthread there are > suggestions to check the manifest, etc. What do you see in yours? I sorted out the issue in the end. The alternate AllXXX class did suit our needs in terms of size / performance / quality so we went with an alternative

Re: [FlexJS] technical debt

Hi, > I made two changes on Friday. Can I ask why you didn’t email the list saying you had done this and what the purpose of disabling those rules were? Or disabling rules when I suggested that you should make a custom profile instead? > It’s important to note that these changes were only to t

Re: [FlexJS] technical debt

Hi, > O really! - There are other projects which using AS3 in Apache? Could you > send a links? Off top of my head MyFaces, Thrift and a couple of others. Maxim works on one of them but I think they may of moved to a JS front end. None that I know use AS as the main language but given the 300+

Re: [FlexJS] technical debt

Hi, > Of the remaining 16 projects, it’s very easy to see that none of them are > using the Flex language. The first link relies on projects meta data and may not be accurate. None of the links you provide show what profile(s) the projects use. You missed that MyFaces uses Sonar Type and it

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi, I’ve not tested this and it’s likely to have issues (I’m not 100% sure the binding will work) and you need to modify it so it's not an application. I think this may help you get towards a working version - their may be other ways of doing this as well. http://ns.adobe.com/mxml/2009";

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi, Sending again as this didn’t seem to make it to the list. There a number of other changes you may need to make to get this to work in FlexJS: - You need to set value impl to enable layout try js:SimpleCSSValuesImpl - Change Button to TextButton which has a text attribute but there’s no enabl

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

HI, There a number of other changes you may need to make to get this to work in FlexJS: - you need to set value impl to enable layout try js:SimpleCSSValuesImpl - Change Button to TextButton which has a text attribute but there’s no enable attribute - toolTips are supported via the tool tip bead

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi, I’d guess you have an js:Application tag elsewhere in your application and this is just a component right? To use as a component try this instead (again untested): http://ns.adobe.com/mxml/2009"; xmlns:js="library://ns.apache.org/flexjs/basic">

Re: [FlexJS] question about porting an Adobe Flex 3 project to HTML+JS

Hi, > Once I got through the tag issue I will add these. In the code (assuming it works) I’ve actually done most of these. The emails arrived out of order. The only thing you need to work out is how to convert the enter event. Thanks, Justin

Re: [FlexJS] technical debt

Hi, I reset the default rules back to the way they were and created a "FlexJS Framework” quality profile we can make the changes there. Thanks, Justin

Re: [FlexJS] technical debt

Hi, > Can you take a look whether you can edit it ? It seems that I don't have > some permission to change that profile. Harbs has the same permissions as me so yes he can edit it. If you want permission to edit it you need to ask Infra. If you do get access please take care as it is possible t

Re: [FlexJS] technical debt

Hi, > I have permissions to edit profiles, but I don’t seem to have permissions to > assign profiles. You do have permissions you’re just doing it in the wrong place. Also I won’t recommend hard coding a set of rules as you have done. It’s better to define the rule set as a delta of the defaul

Re: [FlexJS] technical debt

Hi, > I was trying to set up an alternate set because it’s easier to have two sets > to compare rather than having long drawn-out discussion. As opposed to using the filtering that exists in the web interface? That seems an easier way to do to comparisons but I guess sit depends on your exact a

Re: Flex installation aborted

Hi, > Downloading Adobe AIR Runtime Kit for Windows from: > http://airdownload.adobe.com/air/win/download/25.0//AdobeAIRSDK.zip > Validating download: K:\flex\4.16-25/in/AdobeAIRSDK.zip > Error #1000 Error 1000 is an out of memory issue. Currently there is an issue with the install where it may

  1   2   3   4   5   6   7   8   9   10   >