Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Justin Mclean
Hi, > You didn't get warnings when mixing undefined with Number or String? No warnings are given. The same code compiled using the FlexSDK also doesn’t give any warnings. Thanks, Justin

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread Justin Mclean
Hi, I’m curious and certainly not a veto / asking you to revert this. Is there any reason why this isn’t a BailoutDisableBead via PAYG concepts? Thanks, Justin > On 25 Jun 2017, at 7:36 pm, ha...@apache.org wrote: > > Repository: flex-asjs > Updated Branches: > refs/heads/tlf 26b15e5a0 -> 9986

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread Harbs
Sure. The bug was that specifying the initial disabled value in MXML caused a runtime error: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo >> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/99864a8c >> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/99864a8c >>

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread piotrz
Harbs, Your TLF branch will not be soon merged, can you more important fixes from time to time make also to develop ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-flex-asjs-git-commit-Di

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread Harbs
I’m actually thinking of merging TLF back sometime over the next few weeks. I’m at the point where TLF is working pretty well… If there’s specific commits that someone wants before then, I’ll be happy to help with cherry picking. > On Jun 25, 2017, at 3:14 PM, piotrz wrote: > > Harbs, > > Yo

Re: flex-asjs git commit: DisableBead should not access the strand until it’s added

2017-06-25 Thread piotrz
WOW! Great news :) Looking forward to that. ! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-flex-asjs-git-commit-DisableBead-should-not-access-the-strand-until-it-s-added-tp62602p62606.html Sent fr

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Josh Tynjala
I have seen it in real world code. In fact, I personally use strict equality in ActionScript most of the time. - Josh On Jun 24, 2017 12:35 PM, "Harbs" wrote: I have never seen real world ActionScript code which uses strict equality for null. The argument to use strict equality “because of mo

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Josh Tynjala
I have yet to hear a good reason not to default to null either. Why are you fighting this so hard? All of your arguments that I can recall seem to be that Justin's performance claims aren't as big as he says. Is there more that I missed? Because if it's little more than that, then, at the very leas

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Josh Tynjala
I should make clear that even though I said "at the very least", which might sounds like it's minor, I actually think this parity is more important than any performance improvements. - Josh On Jun 25, 2017 9:36 AM, "Josh Tynjala" wrote: > I have yet to hear a good reason not to default to null

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
> I actually think this parity is more important than any performance > improvements. I agree with that. Although, I have two minds on this. I wrote my counter-argument to my own arguments after this email (which was making the same point you are making). However, after thinking about this some

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
For kicks I just checked my minified code of my app for equality and inequality checks and there were 5466 instances. Just adding strict equality would add 3KB to my file size. (out of 1.8 MB, but still...) It would be an interesting exercise to see much much adding null initialization would ad

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Josh Tynjala
I'd also be curious to see size comparisons using gzip too, which is pretty standard in the JS world. - Josh On Jun 25, 2017 10:57 AM, "Harbs" wrote: For kicks I just checked my minified code of my app for equality and inequality checks and there were 5466 instances. Just adding strict equality

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
Yup. If we add the option to the compiler, we can do some tests with and without initialization. Strict equality would be a little harder but that should be doable as well. (A temporary find and replace should work even though it might break code. It’ll at least give an idea on the impact to co

Re: [DISCUSS] Discuss Release Apache FlexJS 0.8.0 RC2

2017-06-25 Thread piotrz
Hi Alex, What's the plan with release ? I think we have enough votes do we wait still on others ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/DISCUSS-Discuss-Release-Apache-FlexJS-0-8-0-RC2

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
Interesting factoid: My original Flash Flex app was 1.5 MB plus a 395 KB module. The ported Javascript version is 1.8 MB before gzipping plus maybe 100KB of images. The main app after gzipping is 494KB. That’s including all the framework code and TLF. So even after figuring in linked images, t

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Justin Mclean
Hi, > It would be an interesting exercise to see much much adding null > initialization would add to file size. I would guess that it would be > significant. It’s not from the test’s I’ve done. I’ve also mentioned this several times you keep forgetting that the closure compiles optimises the c

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
No I don’t. > On Jun 26, 2017, at 1:04 AM, Justin Mclean wrote: > > you keep forgetting that the closure compiles optimises the code

Re: git commit: [flex-asjs] [refs/heads/tlf] - Reverted strict equality

2017-06-25 Thread Harbs
I’m not sure how you will do that unless you use every part of the SDK. My point was that I would like to try it on my own app which does have quite extensive SDK use (as well as many, many other classes). I will do that if and when we have these compiler options in Falcon. > On Jun 26, 2017, a

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC2

2017-06-25 Thread Alex Harui
Vote passed with 4 +1 votes. On 6/20/17, 10:55 PM, "piotrz" wrote: >Voting again, cause I did mistake and examined last nightly builds not >RC2: > >+1 (Binding) >Package >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apac >he.org%2Frepos%2Fdist%2Fdev%2Fflex%2Ffalcon%2F0.8

[RESULT] [VOTE] Release Apache FlexJS 0.8.0 RC2

2017-06-25 Thread Alex Harui
Vote passed with 5 +1 votes. On 6/21/17, 6:36 PM, "Justin Mclean" wrote: >Hi, > >+1 (binding) > >I checked: >- signatures and hashes correct >- LICENSE and NOTICE are fine >- all source files have ASF headers >- no unexpected binary files in release >- Can compile from source > >I compiled a lar

Re: [VOTE] Release Apache Flex FalconJX 0.8.0 RC2

2017-06-25 Thread OmPrakash Muppirala
Gah, I give up. The Adobe AIR SDK download kept failing several times :-( Thanks, Om On Mon, Jun 26, 2017 at 11:27 AM, Alex Harui wrote: > Vote passed with 4 +1 votes. > > On 6/20/17, 10:55 PM, "piotrz" wrote: > > >Voting again, cause I did mistake and examined last nightly builds not > >RC2:

[RESULT][VOTE] Release Apache Flex FalconJX 0.8.0 RC2

2017-06-25 Thread Alex Harui
Add "result" to subject line so it is easier to find in the archives. -Alex On 6/25/17, 10:57 PM, "Alex Harui" wrote: >Vote passed with 4 +1 votes. > >On 6/20/17, 10:55 PM, "piotrz" wrote: > >>Voting again, cause I did mistake and examined last nightly builds not >>RC2: >> >>+1 (Binding) >>Pac