Re: [FlexJS] enabled property

2016-10-18 Thread Carlos Rovira
Hi, thanks Harbs, I cherry piclked the Yishay commit in my branch, and will play with it. btw, I think the visible property, although maybe could be only one implementation, seems to be the same philosophy right? Not all buttons should be hidden, so following the criteria, seems a code to aggregat

Re: [FlexJS] enabled property

2016-10-18 Thread Carlos Rovira
Hi, I tested DisableBead, but had to make some changes, since depends os changes in sprite branch. So removed the cherry pick in my branch. I'll left that behind for now. The Sprite refactor branch seems a huge one, what's the purpose behind? and when is estimate to finish and merge? Thanks 2

Re: [FlexJS] enabled property

2016-10-18 Thread Harbs
The purpose is to remove all Flash APIs from Flex objects. The refactor composes Flash objects rather than inherits them. I would like to merge it into develop now, but Alex has questioned whether we want to keep the refactor. It’s basically waiting for someone to do some profiling to see wheth

Re: [FlexJS] enabled property

2016-10-18 Thread Alex Harui
On 10/18/16, 12:32 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, >thanks Harbs, I cherry piclked the Yishay commit in my branch, and will >play with it. > >btw, I think the visible property, although maybe could be only one >implementation, seems to be the same philosophy

Re: [FlexJS] enabled property

2016-10-18 Thread Alex Harui
On 10/18/16, 5:06 AM, "Harbs" wrote: >The purpose is to remove all Flash APIs from Flex objects. The refactor >composes Flash objects rather than inherits them. > >I would like to merge it into develop now, but Alex has questioned >whether we want to keep the refactor. It’s basically waiting for

Re: [FlexJS] enabled property

2016-10-18 Thread Alex Harui
On 10/18/16, 4:28 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, > >I tested DisableBead, but had to make some changes, since depends os >changes in sprite branch. So removed the cherry pick in my branch. I'll >left that behind for now. FWIW, if MDL has a defined implemen

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Harbs
I’m not sure where this response went… On Sep 29, 2016, at 9:15 AM, Harbs wrote: > Let’s actually do some profiling so we can see if there’s really an issue. > > Is there really a difference whether you have one object whose size is x+y or > two objects where one size is x and another is y? >

Re: [FlexJS] enabled property

2016-10-18 Thread Harbs
I responded about 3 weeks ago, but I don’t know where the response went. I just resent it… On Oct 18, 2016, at 6:11 PM, Alex Harui wrote: > On 10/18/16, 5:06 AM, "Harbs" wrote: > >> The purpose is to remove all Flash APIs from Flex objects. The refactor >> composes Flash objects rather than i

Re: [FlexJS] enabled property

2016-10-18 Thread Carlos Rovira
Hi Alex, in MDL the disabled is done simply adding "disabled" to the tag, either in declaration or by code. the DisabledBead don't use that approach. I could make my own DisabledBead, I only need to know how I can write "disabled" in the code at runtime. Do you know the way to do this in FlexJS? t

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Alex Harui
On 10/18/16, 8:18 AM, "Harbs" wrote: >I’m not sure where this response went… > >On Sep 29, 2016, at 9:15 AM, Harbs wrote: > >> Let’s actually do some profiling so we can see if there’s really an >>issue. >> >> Is there really a difference whether you have one object whose size is >>x+y or two

Re: [FlexJS] enabled property

2016-10-18 Thread Josh Tynjala
You should be able to set the disabled property on your HTMLButtonElement or HTMLInputElement (or any other type of element that can be disabled) to true. This should have the same effect as setting the disabled attribute on the HTML tag. - Josh 2016-10-18 8:37 GMT-07:00 Carlos Rovira : > Hi Ale

Re: [FlexJS] enabled property

2016-10-18 Thread Alex Harui
On 10/18/16, 8:42 AM, "Josh Tynjala" wrote: >You should be able to set the disabled property on your HTMLButtonElement >or HTMLInputElement (or any other type of element that can be disabled) to >true. This should have the same effect as setting the disabled attribute >on >the HTML tag. Yep, a

Re: [FlexJS] enabled property

2016-10-18 Thread OK
Carlos Rovira wrote > I could make my own DisabledBead, I only need to know how I can write > "disabled" in > the code at runtime. Do you know the way to do this in FlexJS? If I understand you right this [1] is a similar discussion, maybe it helps a bit. Olaf [1] http://apache-flex-users.246

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Harbs
> Why are you objecting to using a tooling workflow to find the potential > conflicts of your code against the various platform implementations? Because I don’t think it’s just a tooling problem. Basically, you are suggesting that there should be tooling to warn the user that certain properties

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Alex Harui
On 10/18/16, 9:08 AM, "Harbs" wrote: >> Why are you objecting to using a tooling workflow to find the potential >> conflicts of your code against the various platform implementations? > >Because I don’t think it’s just a tooling problem. > >Basically, you are suggesting that there should be too

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Harbs
On Oct 18, 2016, at 7:30 PM, Alex Harui wrote: > > > On 10/18/16, 9:08 AM, "Harbs" wrote: > >>> Why are you objecting to using a tooling workflow to find the potential >>> conflicts of your code against the various platform implementations? >> >> Because I don’t think it’s just a tooling pr

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-18 Thread Alex Harui
On 10/18/16, 10:26 AM, "Harbs" wrote: > >On Oct 18, 2016, at 7:30 PM, Alex Harui wrote: > >> >> >>OK, I think you are describing a different problem. AIUI, you are saying >> that certain APIs cannot currently be overridden or overloaded to take a >> subclass or alternate type. That you can

[FlexJS] Overlapping default styles

2016-10-18 Thread Carlos Rovira
Hi, I'm getting some css styles included in my example that I don't know how to avoid. In concrete are referred to Button: Button { border : 1px solid #808080 ; padding : 4px ; background-color : #f8f8f8 ; margin : 0px ; border-radius : 2px ; } Button:hov

Re: [FlexJS] Overlapping default styles

2016-10-18 Thread Alex Harui
They are coming from the default.css in the HTML swc. I guess because you have extended the HTML Button or there is one elsewhere in the app, maybe as a subcomponent. Or maybe it is a bug and it shouldn't be there. You can specify a custom defaults.css file if you need to. -Alex On 10/18/16, 3

Re: [FlexJS] Overlapping default styles

2016-10-18 Thread Carlos Rovira
I extended TextButton (ergo Button in the end), but I think carry all its CSS is not what I expect...maybe I should not extend and replicate functionality extending UIBase I tried an empty defaults.css in my example project but nothing changes 2016-10-19 1:03 GMT+02:00 Alex Harui : > They are co

Re: [FlexJS] Overlapping default styles

2016-10-18 Thread Alex Harui
On 10/18/16, 4:47 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >I extended TextButton (ergo Button in the end), but I think carry all its >CSS is not what I expect...maybe I should not extend and replicate >functionality extending UIBase Well, maybe. I thought it would be e