AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Christofer Dutz
Ok ... so today I'm feeling like I'm wasting my time again :-( I merged the changes from develop up to my feature/maven-migration-test ... unfortunately I had do manually merge quite some stuff, but that's ok. Now my build no longer worked. The Externs no longer compiled. So I switched to my Ant

AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Christofer Dutz
I'm currently having a problem with the JS extern. EXTERNC seems to be generating commented out methods and I have no idea why: Here the generated code for Generator.as where I get a compile error cause next is commented out :-( package { /** * @see https://developer.mozilla.org/en-US/docs/W

AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Christofer Dutz
Would it be possible to eliminate some of the warnings while generating the externs? I am getting tons of: WARNUNG: [es6]:1083: WARNING - Keywords and reserved words are not allowed as unquoted property names in older versions of JavaScript. If you are targeting newer versions of JavaScript, set

RE: AW: FlexJS identity crisis. was: [Discuss]Accept donation of drawing APIs

2016-04-21 Thread Kessler CTR Mark J
Sounds like that ASP 5... wait I mean ASP Core v1.0. -Mark -Original Message- From: Alex Harui [mailto:aha...@adobe.com] Sent: Wednesday, April 20, 2016 12:47 PM To: dev@flex.apache.org Subject: [Non-DoD Source] Re: AW: FlexJS identity crisis. was: [Discuss]Accept donation of drawing AP

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
Taking this thread to develop ... :-) Thanks for that ... I would have missed that one ;-) Can you or someone else here explain why EXTERNC is commenting out tons of methods in the maven version? It's generating identical code, but it's commenting out a lot of methods (not all) and therefore I

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
I wish I knew. It’s probably going to have to be Alex or Josh that answers this. Good luck! On Apr 21, 2016, at 2:44 PM, Christofer Dutz wrote: > Taking this thread to develop ... :-) > > Thanks for that ... I would have missed that one ;-) > > Can you or someone else here explain why EXTERNC

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
I was hoping not to have to ... already wasted 3/4 of a day for this :-( But I just ran the Ant build with your replacement ... the output is identical ... the "var $ = jQuery;" line seems to pass unchanged. Perhaps extending the description on the Wiki with the intention of the replacement coul

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
It didn’t add in @type? I edited the wiki with the intention. On Apr 21, 2016, at 2:57 PM, Christofer Dutz wrote: > I was hoping not to have to ... already wasted 3/4 of a day for this :-( > > But I just ran the Ant build with your replacement ... the output is > identical ... the "var $ = jQ

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
You are right. It did not seem to work. I was not able to get flacon to build at all until I did wipe-all. Not sure why. It was failing on the node swc. Maybe that’s a clue for you. The replacement was not run on the jquery file, but a manual GREP replacement using the same parameters worked fi

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
I really hate if I try to figure out things and I do a wipe-all and things work. It's an implication that somethings fundamentally wrong in the scripts. But hopefully that will go away soon :-) The bad thing is that I work with an LTE connection and bandwidth is limited. This way I have to dow

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
Ah. I didn’t know which flavor of regex ant uses… Are you committing that change, or should I? On Apr 21, 2016, at 3:59 PM, Christofer Dutz wrote: > I had to change the "/1" and "/2" in the replace string with "$1" and "$2".

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
No I did that in the pom.xml of the branch, not touching the Ant stuff ;-) Just wanted to know if my replacement does the correct stuff. Chris Von: Harbs Gesendet: Donnerstag, 21. April 2016 15:04 An: dev@flex.apache.org Betreff: Re: FlexJS, JQuery and F

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
The replacement worked, but it does not fix the problem. It produces: package { public const $ : Object = 0; } while it should be: package { public const $ : jQuery = null; } On Apr 21, 2016, at 4:13 PM, Christofer Dutz wrote: > No I did that in the pom.xml of the branch, not to

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Josh Tynjala
The downloads.xml Ant script only checks for compiler.jar, I think. It doesn't check for the other files. When I added the new Node externs to the downloads, they were getting skipped because that file was already downloaded. - Josh On Apr 21, 2016 5:47 AM, "Harbs" wrote: You are right. It did n

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
I tried a number of different options here and they all either don’t help, or the compile fails. I think someone who understands the compiler a little better is going to have to look at this. On Apr 21, 2016, at 4:49 PM, Harbs wrote: > The replacement worked, but it does not fix the problem.

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
We should probably use language_in with whatever the ES5 value is, instead of the default ES3. We're targeting ES5 in our compiler output, so it would make sense. - Josh On Apr 21, 2016 3:23 AM, "Christofer Dutz" wrote: > Would it be possible to eliminate some of the warnings while generating >

Re: FlexJS identity crisis. was: [Discuss]Accept donation of drawing APIs

2016-04-21 Thread Harbs
I think we’re all in agreement that FalconJX without the rest is an important part even on its own. That’s what I meant by #1. I do think that naming is important. It helps “brand” a product. Something like MXMLC2.0 is way too techie to be a “product”. I’ve been thinking of different ways to “b

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
Things are commented out by externc when they are explicitly excluded. Those look like some things I re-included in the config XML for js.swc (which I assume you'd still use with Maven...) after fixing some bugs. - Josh On Apr 21, 2016 2:46 AM, "Christofer Dutz" wrote: > I'm currently having a p

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
On 4/21/16, 1:38 AM, "Christofer Dutz" wrote: >Ok ... so today I'm feeling like I'm wasting my time again :-( > >I merged the changes from develop up to my feature/maven-migration-test >... unfortunately I had do manually merge quite some stuff, but that's >ok. Now my build no longer worked. Th

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
Whee! The compiler tests are now working. I'm trying to figure out my next task. I'm afraid to sync up and push my changes since Chris is saying things are broken. And I'm not clear how desperate Harbs is for a fix for the Jquery thing. IMO, getting the Maven branches merged into develop is th

Re: [FlexJS] Status on Maven migration

2016-04-21 Thread Harbs
I’m not desparate for the JQuery fix. For now, I’m just using “jQuery” instead of”$”. That works fine. We want to fix this before people start really using jquery.swc in production, but immediate issues definitely come first. Do you want me to log a bug in JIRA for this issue? On Apr 21, 2016,

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
For the Ant build, you need to clear out the third-party downloads to ensure that some new files are downloaded (new externs for Node.js). If the Ant build sees that the Closure compiler is already there, it will skip the rest of the downloads. Chris said that wipe-all does the trick. Locally, I wa

Re: [FlexJS] Status on Maven migration

2016-04-21 Thread Harbs
Just do wipe-all and it should build. On Apr 21, 2016, at 6:28 PM, Alex Harui wrote: > I'm afraid to sync up and push my changes since Chris is saying things are > broken.

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
I think maybe I'm confused, but I think he's not stuck on the node externs, but in the externc output doing some commenting. So that's what I'm going to avoid until I get to the externs section myself. -Alex On 4/21/16, 8:39 AM, "Josh Tynjala" wrote: >For the Ant build, you need to clear out t

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
I might have misunderstood what you meant by synching up. I thought you meant that you didn't want to pull the latest changes because you worried about the Ant stuff not working. - Josh On Apr 21, 2016 9:06 AM, "Alex Harui" wrote: > I think maybe I'm confused, but I think he's not stuck on the n

AW: FlexJS identity crisis. was: [Discuss]Accept donation of drawing APIs

2016-04-21 Thread Christofer Dutz
When creating maven artifacts from SDKs we had a different naming, which I find a little more intuitive. Applied to FlexJS instead of Flex, this would be: FlexJS Compiler: Falcon, FalconJX FlexJS Framework: ASJS FlexJS Externs: Externs How about this .. but I agree in the part where you call cal

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
OK, got through compiler.jx and its tests. I started looking at flex-oem-compiler and noticed it is pulling in the Apache Flex SDK swfutils.jar instead of building a smaller subset that frees FlexJS from dependencies on the Flex SDK. Since the files we need are rarely changed, I am tempted to jus

[FalconJX] More Node.js stuff

2016-04-21 Thread Josh Tynjala
Hey folks, I've been working on improving Node.js support for the next release of FlexJS. Sorry for forcing you to wipe your builds of flex-falcon after I added new externs downloads! In FlexJS 0.6, you could use require() to load Node modules, but you'd have untyped objects: var http:Object = r

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
Skipped over flex-compiler-oem and got the externs to compile. Then I synced up and got the same error that Chris reported. Looks like a bug where a class with no super class but has @override metadata on a method gets the method commented out. I'm out of time for tonight and will look at it tom