I think maybe I'm confused, but I think he's not stuck on the node externs, but in the externc output doing some commenting. So that's what I'm going to avoid until I get to the externs section myself.
-Alex On 4/21/16, 8:39 AM, "Josh Tynjala" <joshtynj...@gmail.com> wrote: >For the Ant build, you need to clear out the third-party downloads to >ensure that some new files are downloaded (new externs for Node.js). If >the >Ant build sees that the Closure compiler is already there, it will skip >the >rest of the downloads. Chris said that wipe-all does the trick. Locally, I >was running thirdparty-clean in the compiler.jx directory, so that works >too. > >I was also able to get a successful build on Jenkins, so it should just be >a matter of ensuring that the new files get downloaded. > >- Josh > >On Thu, Apr 21, 2016 at 8:28 AM, Alex Harui <aha...@adobe.com> wrote: > >> Whee! The compiler tests are now working. >> >> I'm trying to figure out my next task. I'm afraid to sync up and push >>my >> changes since Chris is saying things are broken. And I'm not clear how >> desperate Harbs is for a fix for the Jquery thing. IMO, getting the >>Maven >> branches merged into develop is the top priority. >> >> My current thinking is for me to plow ahead on the rest of the Ant build >> without syncing up, then when I get through that I'll sync up and see if >> the Ant build has the same problems Chris is seeing. Chris can you work >> with an older revision of flex-falcon for now to make progress on >> flex-asjs? >> >> -Alex >> >> On 4/21/16, 7:50 AM, "Alex Harui" <aha...@adobe.com> wrote: >> >> > >> > >> >On 4/21/16, 1:38 AM, "Christofer Dutz" <christofer.d...@c-ware.de> >>wrote: >> > >> >>Ok ... so today I'm feeling like I'm wasting my time again :-( >> >> >> >>I merged the changes from develop up to my >>feature/maven-migration-test >> >>... unfortunately I had do manually merge quite some stuff, but that's >> >>ok. Now my build no longer worked. The Externs no longer compiled. So >>I >> >>switched to my Ant version, updated and did a "clean-all" and "all" >>build >> >>... this too didn't work, even if I got different errors. So as a >>measure >> >>of last resort, I did that "wipe-all" and then an "all" build. Now at >> >>least the Ant build worked again. Unfortunately I couldn't see what >>has >> >>changed :-( >> > >> >What was the error you got? >> > >> >> >> >>Could you guys please post to this list if you change any downloads or >> >>change things in the build? It's one thing to port something, but >>it's a >> >>completely different thing to find problems that now occur in a >> >>previously ported part :-( >> >> >> >>I think it would eventually be a good idea to do the maven switch >>pretty >> >>soon cause I'm loosing more and more of my time in keeping things in >>sync >> >>... time I would prefer to be investing on pushing the migration of >>ASJS >> >>forward. >> > >> >I'm still work on the Ant build in maven-migration-test. I got through >> >compiler-build-tools and compiler-jburg-types and most of compiler, >>but am >> >currently on compiler/src/test. Then on to compiler.jx, and the >>externs >> >and other things. Hope to be done with it maybe Monday. >> > >> >-Alex >> > >> >>