Re: failing tests / flash player locale issue with negative numbers

2017-02-01 Thread Alex Harui
OK, I get it now. Thanks, -Alex On 2/1/17, 4:59 PM, "Justin Mclean" wrote: >Hi, > >> I'm still puzzled by the DropDownList fix. To me it looks like the only >> effective change is: >> >> if (displayItem != null) >> >> >> Was replaced by: >> >> if (displayItem != null && displayItem != un

Re: failing tests / flash player locale issue with negative numbers

2017-02-01 Thread Justin Mclean
Hi, > I'm still puzzled by the DropDownList fix. To me it looks like the only > effective change is: > > if (displayItem != null) > > > Was replaced by: > > if (displayItem != null && displayItem != undefined) > > > Or is there some subtle other difference I'm missing? In the code before

Re: failing tests / flash player locale issue with negative numbers

2017-02-01 Thread Alex Harui
All of the tests you listed passed on my Mac. So I think we are good to go. -Alex On 2/1/17, 4:15 PM, "Alex Harui" wrote: >I will try to look now. I had missed the bottom of your other reply with >the list of failures. My brain was waiting for an attachment. I forgot >that the list doesn't

Re: failing tests / flash player locale issue with negative numbers

2017-02-01 Thread Alex Harui
I will try to look now. I had missed the bottom of your other reply with the list of failures. My brain was waiting for an attachment. I forgot that the list doesn't like attachments. I'm still puzzled by the DropDownList fix. To me it looks like the only effective change is: if (displayIte

Re: failing tests / flash player locale issue with negative numbers

2017-02-01 Thread Justin Mclean
Hi, Anyone have some free cycles to look at this? If not I'd say lets just go ahead with the release candidate. I've had several people (on and off list) ask when the next release is out. Thanks, Justin

Re: failing tests / flash player locale issue with negative numbers

2017-01-29 Thread Justin Mclean
Hi, > I still don't understand how that change was important. What was the input > that was giving bad output? LabelUtil.itemToLabel has hidden side effects. If it’s not called the text in the drop drop would not be updated, this would cause tests to fail as the initial prompt didn’t show for

Re: failing tests / flash player locale issue with negative numbers

2017-01-28 Thread Alex Harui
On 1/28/17, 4:22 PM, "Justin Mclean" wrote: >Hi, > >> Might be ok to change the tests so they don't expect the number format >>to change. > >I've gone through all of the other failures and I don't think there’s any >major concerns. The drop down (now fixed) seems to be the only regression >issu

Re: failing tests / flash player locale issue with negative numbers

2017-01-28 Thread Justin Mclean
Hi, > Might be ok to change the tests so they don't expect the number format to > change. I've gone through all of the other failures and I don't think there’s any major concerns. The drop down (now fixed) seems to be the only regression issue. - The negative number / locale tests (40 odd tests

Re: failing tests / flash player locale issue with negative numbers

2017-01-23 Thread Alex Harui
On 1/22/17, 4:40 PM, "Justin Mclean" wrote: >Hi, > >We’ve got a number of mustella tests failing due to locale issues, for >example NV_negativeNumberFormat_tester test >NV_negativeNumberFormat_bindingWithLocaleChange_test15. > >The issues seem to be that the negativeNumberFormat value is expect

Re: failing tests / flash player locale issue with negative numbers

2017-01-22 Thread Justin Mclean
Hi, Confirmed it’s running 11.1 (right clicking on the tests while running shows 11.1). I also re-ran on latest version (24.0) and the same tests fail. Thanks, Justin

Re: failing tests / flash player locale issue with negative numbers

2017-01-22 Thread Justin Mclean
Hi, > Which player version did you use? I think we started out on 11.1 or 11.2. It's configured to point to the 11.1 debug player via an environment variable so I assume it running that one: FLASHPLAYER_DEBUGGER=/Users/justinmclean/Documents/player/11.1/mac/Flash Player Debugger.app/Contents/M

Re: failing tests / flash player locale issue with negative numbers

2017-01-22 Thread Alex Harui
On 1/22/17, 4:40 PM, "Justin Mclean" wrote: > >Note that this seem to be a Flash Player issue not a flex SDK issue. Which player version did you use? I think we started out on 11.1 or 11.2. -Alex

failing tests / flash player locale issue with negative numbers

2017-01-22 Thread Justin Mclean
Hi, We’ve got a number of mustella tests failing due to locale issues, for example NV_negativeNumberFormat_tester test NV_negativeNumberFormat_bindingWithLocaleChange_test15. The issues seem to be that the negativeNumberFormat value is expected to change when switching locale between in this c