Hi,

> I still don't understand how that change was important.  What was the input 
> that was giving bad output?

LabelUtil.itemToLabel has hidden side effects. If it’s not called the text in 
the drop drop would not be updated, this would cause tests to fail as the 
initial prompt didn’t show for instance.

See this checkin that fixed the issue for more details [1] it basically 
reverted the code back to the way it way before being optimised.

Failures are as follows:

For mirroring:
components/DateField/Styles/DateField_Styles_Mirroring 
DateField_Styles_Mirroring_rtl_parentContainer
components/NumericStepper/styles/NumericStepper_Styles_Mirroring 
NumericStepper_Styles_Mirroring_parentContainer1
components/NumericStepper/styles/NumericStepper_Styles_Mirroring 
NumericStepper_Styles_Mirroring_parentContainer1_2
components/NumericStepper/styles/NumericStepper_Styles_Mirroring 
NumericStepper_Styles_Mirroring_parentContainer2
components/NumericStepper/styles/NumericStepper_Styles_Mirroring 
NumericStepper_Styles_Mirroring_parentContainer2_1
components/NumericStepper/styles/NumericStepper_Styles_Mirroring 
NumericStepper_Styles_Mirroring_parentContainer3
gumbo/components/TitleWindow/Properties/TitleWindow_wireframe_test 
TitleWindow_wireframe_closeButtonDisabled
gumbo/components/TitleWindow/Methods/TitleWindow_methods_tester 
method_addElement_test1
gumbo/components/TitleWindow/Integration/TitleWindow_Integration_tester1 
TitleWindow_mixed_components1
gumbo/components/TitleWindow/Mirroring/TitleWindow_mirroring_tester 
TitleWindow_layoutDirection_rtl2
gumbo/components/TitleWindow/Mirroring/TitleWindow_mirroring_tester 
TitleWindow_layoutDirection_rtl3
gumbo/components/TitleWindow/Mirroring/TitleWindow_mirroring_tester3 
TitleWindow_layoutDirection_style1

Other failing tests:
gumbo/components/Application/styles/Application_Styles 
Application_Styles_baseColor_test1
gumbo/components/TitleWindow/Properties/TitleWindow_wireframe_test 
TitleWindow_wireframe_closeButtonDisabled
gumbo/components/TitleWindow/Methods/TitleWindow_methods_tester 
method_addElement_test1
gumbo/components/TitleWindow/Integration/TitleWindow_Integration_tester1 
TitleWindow_mixed_components1
gumbo/core/Group/events/Group_Events_main Group_event_add_halo
gumbo/core/Group/viewport/HGroup_viewport_horizontal 
HGroup_viewport_HL_dataBinding
gumbo/core/Group/viewport/VGroup_viewport_vertical 
VGroup_viewport_VL_dataBinding
spark/effects/Resize/Containers/Resize_Containers 
Resize_Containers_Accordion_FromTo

I assume you don't want the Chart tests or the negative number format locale 
tests?

Thanks,
Justin

1. 
https://github.com/apache/flex-sdk/commit/4523974603953af1e042917f0098049dd290ffb2

Reply via email to