Re: [FlexJS MDL] release build broken

On 2/17/17, 5:54 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >2017-02-17 12:36 GMT+01:00 Harbs : > >> Simply specifying strings instead of the constants would be the most >> efficient currently. >> > >But that's what we try to avoid in order to support type safe code > >I pu

Re: [FlexJS MDL] release build broken

2017-02-17 12:36 GMT+01:00 Harbs : > Simply specifying strings instead of the constants would be the most > efficient currently. > But that's what we try to avoid in order to support type safe code I put on my plate to break the class in 16 classes, but as I'm working on other things I invite pe

Re: [FlexJS MDL] release build broken

I’d really like to eventually see the compiler to optimize constants better, but yes, breaking the constant classes into smaller categories will help if only some of them are used. Simply specifying strings instead of the constants would be the most efficient currently. > On Feb 17, 2017, at 1

Re: [FlexJS MDL] release build broken

Hi Harbs, if we don't use constants what you suggest? One of the things we provide is "type safe". I think this is the minimal version we can provide. Think that before we was creating a class per icon, given the 900+ icons would be a problem to both in terms of coding and space used. The only th

Re: [FlexJS MDL] release build broken

On 2/16/17, 12:34 PM, "Harbs" wrote: >When I’ve had these kinds of issues in my app, it’s because of minified >renaming. Yep, and there is code in one of the Binding classes that does some trickery to look up a constant when minified. That code might need to be used in this scenario. -Alex

Re: [FlexJS MDL] release build broken

When I’ve had these kinds of issues in my app, it’s because of minified renaming. Tangentially: FWIW, I’m not sure how wise it is to use constants to specify the icon text. The minified version of just the definitions for the MaterialIconTypes is a full 77KB! Until we have a way to stripped ou

Re: [FlexJS MDL] release build broken

pache-flex-development.247.n4.nabble.com/FlexJS-MDL-release-build-broken-tp59537p59564.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS MDL] release build broken

Hi Harbs, Thanks for seeing that. @Pitor, I looked at the code and seems something related to binding, The binding is not working and no text is retrieved. The output is: So no text in the i element tag seems the binding no

[FlexJS MDL] release build broken

1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/bin/js-release/index.html 2. Cl

Re: asdoc - Release build broken (was: Release build broken)

and delete the 3.0.33 link if you have it too. -Fred -Message d'origine- From: Frédéric THOMAS Sent: Thursday, March 28, 2013 6:31 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) It has been fixed in the build.xml, how did you

Re: asdoc - Release build broken (was: Release build broken)

build broken (was: Release build broken) Hi Also doesn't look like the TLF issue is fixed in that branch: git branch * FLEX-33451 develop master ompile: [compc] Loading configuration file /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/projects/textLayout/compile-config.xml

Re: asdoc - Release build broken (was: Release build broken)

Hi Also doesn't look like the TLF issue is fixed in that branch: git branch * FLEX-33451 develop master ompile: [compc] Loading configuration file /Users/justinmclean/Documents/ApacheFlexDevelopGit/frameworks/projects/textLayout/compile-config.xml [compc] Apache Flex compc (Compone

Re: asdoc - Release build broken (was: Release build broken)

From: Frédéric THOMAS Sent: Thursday, March 28, 2013 5:42 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) You right, I had to do that but didn't do it, feel free to open other tickets. There're no needs to open a new branch, the mother one

Re: asdoc - Release build broken (was: Release build broken)

t the new issue ids. -Fred -Message d'origine- From: Justin Mclean Sent: Thursday, March 28, 2013 5:37 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) Hi, You right, I just filled the jira accordingly. Thanks that's a lot clea

Re: asdoc - Release build broken (was: Release build broken)

Hi, > You right, I just filled the jira accordingly. Thanks that's a lot clearer. There still a minor workflow issue here in that unless we make each of those sub tasks real JIRA subtasks how do I know who's working on each one (or if anyone is). I can't assign the entire bug to myself as I wou

Re: asdoc - Release build broken (was: Release build broken)

7;origine- From: Justin Mclean Sent: Thursday, March 28, 2013 5:20 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) Hi, It's not a silly question, the answer is because, I opened a jira ticket [1] in which there are few sub-issues/tasks

Re: asdoc - Release build broken (was: Release build broken)

Hi, > It's not a silly question, the answer is because, I opened a jira ticket [1] > in which there are few sub-issues/tasks. I guess that one way of doing it - but IMO would be better if they were either merged into develop as each sub task was fixed. As that JIRA issue is unassigned I'd assum

Re: asdoc - Release build broken (was: Release build broken)

ssage d'origine- From: Justin Mclean Sent: Thursday, March 28, 2013 4:48 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) Hi, You can see the fix in the branch I did Perhaps a silly question but if you have a fix in a branch why hasn&#x

Re: asdoc - Release build broken (was: Release build broken)

Hi, > You can see the fix in the branch I did Perhaps a silly question but if you have a fix in a branch why hasn't it been merged into develop? Especially if it fixes an issue. Other people may have this issue but they wouldn't know that your branch fixes it. Thanks, Justin

Re: asdoc - Release build broken (was: Release build broken)

You can see the fix in the branch I did -Fred -Message d'origine- From: Justin Mclean Sent: Thursday, March 28, 2013 2:33 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) Hi, Ok files the compiler issue but still getting an error

Re: asdoc - Release build broken (was: Release build broken)

Hi, Ok files the compiler issue but still getting an error to do with TLF. Assume this is to do with the recent TLF changes. Can you remind me how the SDK build files now knows where TLF is? There nothing in the README that I can see. compile: [compc] Loading configuration file /Users/j

Re: asdoc - Release build broken (was: Release build broken)

On 3/27/13 12:43 AM, "Justin Mclean" wrote: > Hi, > >> For me, it is using the one in lib, not in ant/lib. > > Mine was using the one in ant/lib and issue was fixed my moving the lib one to > this location. However I'd still like to know why it was using the one in > ant/lib and not lib - an

Re: asdoc - Release build broken (was: Release build broken)

humm... weird, I'ld like to see the others result then. Thanks Erik, -Fred -Message d'origine- From: Erik de Bruin Sent: Wednesday, March 27, 2013 10:51 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) I ran 'ant

Re: asdoc - Release build broken (was: Release build broken)

> > Thanks, > -Fred > > -Message d'origine- From: Erik de Bruin > Sent: Wednesday, March 27, 2013 10:29 AM > > To: dev@flex.apache.org > Subject: Re: asdoc - Release build broken (was: Release build broken) > > Running 'ant asdoc' gives me: >

Re: asdoc - Release build broken (was: Release build broken)

Well, sorry, I meant 'ant doc' from the experimental lib. Thanks, -Fred -Message d'origine- From: Erik de Bruin Sent: Wednesday, March 27, 2013 10:29 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) Running '

Re: asdoc - Release build broken (was: Release build broken)

ed > > -Message d'origine- From: Erik de Bruin > Sent: Wednesday, March 27, 2013 10:06 AM > > To: dev@flex.apache.org > Subject: Re: asdoc - Release build broken (was: Release build broken) > > I just did this (OS X) and the build was successful both times (on >

Re: asdoc - Release build broken (was: Release build broken)

27;origine- From: Erik de Bruin Sent: Wednesday, March 27, 2013 10:06 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was: Release build broken) I just did this (OS X) and the build was successful both times (on develop with 'main', on FLEX-33451 with 'relea

Re: asdoc - Release build broken (was: Release build broken)

branch, > checkout the 'FLEX-33451' and build release on it ? > > -Fred > > -Message d'origine- From: Justin Mclean > Sent: Wednesday, March 27, 2013 8:11 AM > To: dev@flex.apache.org > Subject: Re: asdoc - Release build broken (was: Release build broke

Re: asdoc - Release build broken (was: Release build broken)

Ok, so I'm curious to know where the issue you have comes from as we don't have it, keep us in touch. Thanks, -Fred -Message d'origine- From: Justin Mclean Sent: Wednesday, March 27, 2013 8:44 AM To: dev@flex.apache.org Subject: Re: asdoc - Release build broken (was

Re: asdoc - Release build broken (was: Release build broken)

Hi, > Couldn't you simply clone again the sdk, build on the develop branch, > checkout the 'FLEX-33451' and build release on it ? Tried that it failed as well. Justin

Re: asdoc - Release build broken (was: Release build broken)

Hi, > For me, it is using the one in lib, not in ant/lib. Mine was using the one in ant/lib and issue was fixed my moving the lib one to this location. However I'd still like to know why it was using the one in ant/lib and not lib - anyone know where this is specified? As far as I know I only

Re: asdoc - Release build broken (was: Release build broken)

sdoc - Release build broken (was: Release build broken) Hi, For me, it is using the one in lib, not in ant/lib. Is it possible you have a Falcon flexTasks.jar in ant/lib? Is there an easy way to tell which one it's using? I have flexTasks.jar in both places. Thanks, Justin

Re: asdoc - Release build broken (was: Release build broken)

Hi, > For me, it is using the one in lib, not in ant/lib. Is it possible you have > a Falcon flexTasks.jar in ant/lib? Is there an easy way to tell which one it's using? I have flexTasks.jar in both places. Thanks, Justin

Re: asdoc - Release build broken (was: Release build broken)

I don't think so. I don't have a compiler.jar in my sdk tree and themes build. The build is failing on flexTasks.tasks loading classes from one of the two flexTasks.jar you see in the build.xml. For me, it is using the one in lib, not in ant/lib. Is it possible you have a Falcon flexTasks.jar i

Re: asdoc - Release build broken (was: Release build broken)

Hi, > If Justin doesn't help you with asdoc, I will try to find time tomorrow. My build is still broken (unable to build the themes) so unable to help. Are you sure a falcon dependancy hasn't accidentally got into the SDK release build - that's the only reference to compiler.jar I could find.

Re: asdoc - Release build broken (was: Release build broken)

I had to pull before I could see your branch. Once I checked it out, the build script ran fine on my Mac. If Justin doesn't help you with asdoc, I will try to find time tomorrow. On 3/26/13 10:50 AM, "Frédéric THOMAS" wrote: > Ok, I double checked, all good for the release except the build nu

Re: asdoc - Release build broken (was: Release build broken)

Ok, I double checked, all good for the release except the build number and the asdoc, so, TLF, empty.properties and .gitignore are ok. If someone wants to give a hand for the asdoc, run the asdoc target of the experimental build after you built the sdk. Once fixed, uncomment in framework.build.

Re: Release build broken

dev@flex.apache.org Subject: Re: Release build broken I'm sure you'll be ok too ;-) Thanks, -Fred -Message d'origine- From: Alex Harui Sent: Tuesday, March 26, 2013 5:58 PM To: dev@flex.apache.org Subject: Re: Release build broken I'm sure I'll be ok, I

Re: Release build broken

I'm sure you'll be ok too ;-) Thanks, -Fred -Message d'origine- From: Alex Harui Sent: Tuesday, March 26, 2013 5:58 PM To: dev@flex.apache.org Subject: Re: Release build broken I'm sure I'll be ok, I don't have any changes in flex-sdk so it will be much

Re: Release build broken

mmands to well start working on > it. > > Thanks, > -Fred > > -Message d'origine- > From: Alex Harui > Sent: Tuesday, March 26, 2013 5:51 PM > To: dev@flex.apache.org > Subject: Re: Release build broken > > OK, I will try to run it in a few hours. > &g

Re: Release build broken

files which you can check with git status) git checkout git stash apply "my current work" Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 26, 2013 1:44 PM To: dev@flex.apache.org Subject: Re: Release build broken Just created https://issues

Re: Release build broken

ush > > To go back on the branch you was before and the same working tree / index: > git stash -u "release" (if you've got uncommitted files/untracked files > which you can check with git status) > git checkout > git stash apply "my current work" > > T

Re: Release build broken

I created an issue for the release ones, so, I work on a branch until everything will be ok, I'll merge after. Yes, I need help fot asdoc. -Fred -Message d'origine- From: Alex Harui Sent: Tuesday, March 26, 2013 5:42 PM To: dev@flex.apache.org Subject: Re: Release bu

Re: Release build broken

--Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 26, 2013 1:44 PM To: dev@flex.apache.org Subject: Re: Release build broken Just created https://issues.apache.org/jira/browse/FLEX-33451 for the issues relative to the broken release to link with at commit time. Please for

Re: Release build broken

On 3/26/13 9:23 AM, "Frédéric THOMAS" wrote: > I'm building the release again too right now, do you want me to share my > branch ? It sounded like you had enough working to push it. Or are you waiting for help on the asdoc? I'd rather not have to test the release target right now, although i

Re: Release build broken

lease build broken I'm building the release again too right now, do you want me to share my branch ? -Fred -Message d'origine- From: Alex Harui Sent: Tuesday, March 26, 2013 5:14 PM To: dev@flex.apache.org Subject: Re: Release build broken OK. Did you push? I didn't see a

Re: Release build broken

I'm building the release again too right now, do you want me to share my branch ? -Fred -Message d'origine- From: Alex Harui Sent: Tuesday, March 26, 2013 5:14 PM To: dev@flex.apache.org Subject: Re: Release build broken OK. Did you push? I didn't see a commit emai

Re: Release build broken

nt I check it in, tell me." > > Thanks, > -Fred > > -Message d'origine- > From: Frédéric THOMAS > Sent: Tuesday, March 26, 2013 1:16 PM > To: dev@flex.apache.org > Subject: Re: Release build broken > > Hi, > > Just to keep you in touch: >

Re: Release build broken

times, not sure you want I check it in, tell me." Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 26, 2013 1:16 PM To: dev@flex.apache.org Subject: Re: Release build broken Hi, Just to keep you in touch: BUILD SUCCESSFUL Total time: 60 minutes

Re: Release build broken

2013 8:10 AM To: dev@flex.apache.org Subject: Re: Release build broken The same as me and Alex, I'm on it. Thanks, -Fred -Message d'origine- From: Om Sent: Tuesday, March 26, 2013 8:07 AM To: dev@flex.apache.org Subject: Re: Release build broken My ant release fails as well, but

asdoc - Release build broken (was: Release build broken)

Hi, Ok, it seems I solved the TLF release build issues, now I've got asdoc issues [1] with the experimental lib, did it exist before ? I don't know anything in as doc generation but from far, I would say, that's a NS problem between http://flex.apache.org/experimental/ns and the Spark one, s

Re: Release build broken

The same as me and Alex, I'm on it. Thanks, -Fred -Message d'origine- From: Om Sent: Tuesday, March 26, 2013 8:07 AM To: dev@flex.apache.org Subject: Re: Release build broken My ant release fails as well, but because of a different reason: doc: [asdo

Re: Release build broken

My ant release fails as well, but because of a different reason: doc: [asdoc] Loading configuration file C:\p\flex_os\workspace\flexroot\git\flex- sdk\frameworks\flex-config.xml [zip] Updating zip: C:\p\flex_os\workspace\flexroot\git\flex-sdk\framework s\locale\en_US\mx_

Re: Release build broken

Just another point, I'm trying to build a release and the textLayout asdoc target source-path point on ${source.dir}/src, it turns into an error, shouldn't it be ${tlf.branch}/src ? Ah yes, I never did finish the release target. I just got main and checkintests to run. If you can fix it, great

Re: Release build broken

Hi, > Do you have spaces in your paths? No. > Did you run "ant release" or something else? Post more of the console output > otherwise. "ant release" but "ant themes" fails very quickly: ant sample-themes Buildfile: /Users/justinmclean/Documents/ApacheFlexDevelopGit/build.xml sample-themes:

Re: Release build broken

I ran "ant release" and all the way to asdoc like Fred said. Do you have spaces in your paths? Did you run "ant release" or something else? Post more of the console output otherwise. On 3/25/13 8:56 PM, "Justin Mclean" wrote: > Hi, > >> Is it possible that a falcon build polluted your setup

Re: Release build broken

I can try in a couple of hours.. Thanks, Om On Mar 25, 2013 8:56 PM, "Justin Mclean" wrote: > Hi, > > > Is it possible that a falcon build polluted your setup? > Unlikely. Unless something been done that git related with that? Not tried > to build falcon since the move to git. > > Have we missed

Re: Release build broken

Hi, > Is it possible that a falcon build polluted your setup? Unlikely. Unless something been done that git related with that? Not tried to build falcon since the move to git. Have we missed something in the move to git that's broken the release build? Can someone do a "ant release" on the gi

Re: Release build broken

I'm not in a good place to stop and investigate right now. Is it possible that a falcon build polluted your setup? On 3/25/13 8:33 PM, "Justin Mclean" wrote: > Hi, > >> Ah yes, I never did finish the release target. I just got main and >> checkintests to run. If you can fix it, great, if no

Release build broken

Hi, > Ah yes, I never did finish the release target. I just got main and > checkintests to run. If you can fix it, great, if not, I will try to get to > it later in the week. Issue I'm having is to do with compiling themes no idea what is causing the error. ant themes compile: [echo] Co