I’d really like to eventually see the compiler to optimize constants better, but yes, breaking the constant classes into smaller categories will help if only some of them are used.
Simply specifying strings instead of the constants would be the most efficient currently. > On Feb 17, 2017, at 1:16 PM, Carlos Rovira <carlos.rov...@codeoscopic.com> > wrote: > > Hi Harbs, > > if we don't use constants what you suggest? > One of the things we provide is "type safe". I think this is the minimal > version we can provide. Think that before we was creating a class per icon, > given the 900+ icons would be a problem to both in terms of coding and > space used. > > The only thing I see is to separate in pieces. For example there is various > sections in > > https://material.io/icons/ > > * Action > * Alert > * AV > * Communication > * Content > * Device > * Editor > * File > * Hardware > * Image > * Maps > * Navigation > * Notification > * Places > * Social > * Toggle > > That makes 16 categories. So splitting in 16 files could be better right? > > > > 2017-02-16 21:34 GMT+01:00 Harbs <harbs.li...@gmail.com>: > >> When I’ve had these kinds of issues in my app, it’s because of minified >> renaming. >> >> Tangentially: >> FWIW, I’m not sure how wise it is to use constants to specify the icon >> text. The minified version of just the definitions for the >> MaterialIconTypes is a full 77KB! >> >> Until we have a way to stripped out unused constants during compilation, I >> think extra const definitions should be avoided. >> >> Harbs >> >>> On Feb 16, 2017, at 8:34 PM, Carlos Rovira < >> carlos.rov...@codeoscopic.com> wrote: >>> >>> Hi Harbs, >>> >>> Thanks for seeing that. >>> >>> @Pitor, I looked at the code and seems something related to binding, >>> >>> <mdl:beads> >>> <js:ContainerDataBinding/> >>> </mdl:beads> >>> >>> <mdl:IconToggle dataMdlFor="mdlItalicIcon" change="counter3++"> >>> <mdl:materialIcon> >>> <mdl:MaterialIcon text="{MaterialIconType. >> FORMAT_ITALIC}"/> >>> </mdl:materialIcon> >>> </mdl:IconToggle> >>> >>> The binding is not working and no text is retrieved. The output is: >>> >>> <i class="material-icons mdl-icon-toggle__label"></I> >>> >>> So no text in the i element tag seems the binding not doing its work. >> Maybe >>> some latest changes in binding caused this? >>> >>> Thanks >>> >>> >>> 2017-02-16 11:03 GMT+01:00 Harbs <harbs.li...@gmail.com>: >>> >>>> 1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/ >>>> lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/ >>>> bin/js-release/index.html <http://apacheflexbuild. >> cloudapp.net:8080/job/ >>>> MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/ >>>> bin/js-release/index.html> >>>> >>>> 2. Click on Toggles >>>> >>>> You will see that the two IconToggles have no content. It seems like the >>>> Material Design font is not beiing used for some reason in the release >>>> build. The same thing works in the debug build. >>>> >>>> Harbs >>> >>> >>> >>> >>> -- >>> >>> Carlos Rovira >>> Director General >>> M: +34 607 22 60 05 >>> http://www.codeoscopic.com >>> http://www.avant2.es >>> >>> Este mensaje se dirige exclusivamente a su destinatario y puede contener >>> información privilegiada o confidencial. Si ha recibido este mensaje por >>> error, le rogamos que nos lo comunique inmediatamente por esta misma vía >> y >>> proceda a su destrucción. >>> >>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le >> comunicamos >>> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC >>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del >>> servicio o información solicitados, teniendo usted derecho de acceso, >>> rectificación, cancelación y oposición de sus datos dirigiéndose a >> nuestras >>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación >>> necesaria. >> >> > > > -- > > Carlos Rovira > Director General > M: +34 607 22 60 05 > http://www.codeoscopic.com > http://www.avant2.es > > Este mensaje se dirige exclusivamente a su destinatario y puede contener > información privilegiada o confidencial. Si ha recibido este mensaje por > error, le rogamos que nos lo comunique inmediatamente por esta misma vía y > proceda a su destrucción. > > De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos > que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC > S.A. La finalidad de dicho tratamiento es facilitar la prestación del > servicio o información solicitados, teniendo usted derecho de acceso, > rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación > necesaria.
