Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
We don't do any rewriting right now, but we might be able to rewrite them in the future. One warning I see is from this code: /** * @export * @type {org.apache.flex.core.WrappedHTMLElement} */ positioner: { get: org.apache.flex.core.UIBase.prototype.get__positioner, set: org.apache.flex.core.

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
Alex, What do you mean by rewriting those getter/setters ? Could you point to an some example ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Closure-warnings-tp63939p63944.html Sent f

Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
Some are from Closure Library. I haven't really looked into why. I don't think we are on the absolute latest, so we might need to move there. Others are from our code because we are now annotating the Object.defineProperties getter/setters with @type information, but we don't force the inclusion

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
I did it for Maven as I remember [1], but it seems that we are missing it here [2]. - It doesn't have influence on warnings. - Could I miss some places ? As for the ant I think closure library has been downloaded from master without pointing any specific version, but I'm not sure - It has to be c

Re: FlexJS Closure warnings

2017-08-22 Thread Josh Tynjala
I remember seeing that Alex updated to a newer version of Closure compiler recently. I don't recall if he updated Closure library at the same time. As I understand it, it's a good idea to keep them both in sync. - Josh On Aug 22, 2017 3:43 AM, "Harbs" wrote: > I’ve been getting hundreds of warn

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
Hi Harbs, I can confirm that I have also a lot of warnings in Maven build. Even with simple project. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Closure-warnings-tp63939p63940.html