Some are from Closure Library. I haven't really looked into why. I don't think we are on the absolute latest, so we might need to move there.
Others are from our code because we are now annotating the Object.defineProperties getter/setters with @type information, but we don't force the inclusion of the types used by getter/setters in the output. So, a simple getter of some interface type where the interface isn't ever really used can cause such a warning. So does references to WrappedHTMLElement which is just a fake type we use at compile time. We need to decide whether to suppress those warnings, or fatten the output by including types only referenced by getter/setters that aren't referenced in elsewhere, including their method bodies, or probably, indicate in the code which ones can be suppressed or rewritten to not cause a warning. Haven't thought about it too much as this was part of seeing if minification could act as obfuscation. Not sure if we've reached a conclusion on that either. Thoughts? -Alex On 8/22/17, 6:31 AM, "piotrz" <piotrzarzyck...@gmail.com> wrote: >I did it for Maven as I remember [1], but it seems that we are missing it >here [2]. - It doesn't have influence on warnings. - Could I miss some >places ? > >As for the ant I think closure library has been downloaded from master >without pointing any specific version, but I'm not sure - It has to be >confirmed. > >[1] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co >m%2Fapache%2Fflex-falcon%2Fblob%2Fdevelop%2Fcompiler-jx%2Fpom.xml&data=02% >7C01%7C%7C421273163ecb41539c1208d4e962681c%7Cfa7b1b5a7b34438794aed2c178dec >ee1%7C0%7C0%7C636390056254236146&sdata=4scr0UhFN8MWjf%2BV2KhIptQsxxhJmrKw7 >RSX3U9btW8%3D&reserved=0 >[2] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co >m%2Fapache%2Fflex-falcon%2Fblob%2Fdevelop%2Fdebugger%2Fpom.xml&data=02%7C0 >1%7C%7C421273163ecb41539c1208d4e962681c%7Cfa7b1b5a7b34438794aed2c178decee1 >%7C0%7C0%7C636390056254236146&sdata=TszqCn2%2BgjnJ7IzkxHajNJq%2Bw3BTubaqSI >DYdQwzoCA%3D&reserved=0 > >Thanks, >Piotr > > > > >----- >Apache Flex PMC >piotrzarzyck...@gmail.com >-- >View this message in context: >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle >x-development.2333347.n4.nabble.com%2FFlexJS-Closure-warnings-tp63939p6394 >2.html&data=02%7C01%7C%7C421273163ecb41539c1208d4e962681c%7Cfa7b1b5a7b3443 >8794aed2c178decee1%7C0%7C0%7C636390056254236146&sdata=YnM%2B3O9diZg931PjGm >%2BO3Dn60xEPPIBEc3mwTZ1RjX8%3D&reserved=0 >Sent from the Apache Flex Development mailing list archive at Nabble.com.
