Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
Skipped over flex-compiler-oem and got the externs to compile. Then I synced up and got the same error that Chris reported. Looks like a bug where a class with no super class but has @override metadata on a method gets the method commented out. I'm out of time for tonight and will look at it tom

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
OK, got through compiler.jx and its tests. I started looking at flex-oem-compiler and noticed it is pulling in the Apache Flex SDK swfutils.jar instead of building a smaller subset that frees FlexJS from dependencies on the Flex SDK. Since the files we need are rarely changed, I am tempted to jus

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
I might have misunderstood what you meant by synching up. I thought you meant that you didn't want to pull the latest changes because you worried about the Ant stuff not working. - Josh On Apr 21, 2016 9:06 AM, "Alex Harui" wrote: > I think maybe I'm confused, but I think he's not stuck on the n

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
I think maybe I'm confused, but I think he's not stuck on the node externs, but in the externc output doing some commenting. So that's what I'm going to avoid until I get to the externs section myself. -Alex On 4/21/16, 8:39 AM, "Josh Tynjala" wrote: >For the Ant build, you need to clear out t

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
For the Ant build, you need to clear out the third-party downloads to ensure that some new files are downloaded (new externs for Node.js). If the Ant build sees that the Closure compiler is already there, it will skip the rest of the downloads. Chris said that wipe-all does the trick. Locally, I wa

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
Whee! The compiler tests are now working. I'm trying to figure out my next task. I'm afraid to sync up and push my changes since Chris is saying things are broken. And I'm not clear how desperate Harbs is for a fix for the Jquery thing. IMO, getting the Maven branches merged into develop is th

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Alex Harui
On 4/21/16, 1:38 AM, "Christofer Dutz" wrote: >Ok ... so today I'm feeling like I'm wasting my time again :-( > >I merged the changes from develop up to my feature/maven-migration-test >... unfortunately I had do manually merge quite some stuff, but that's >ok. Now my build no longer worked. Th

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
Things are commented out by externc when they are explicitly excluded. Those look like some things I re-included in the config XML for js.swc (which I assume you'd still use with Maven...) after fixing some bugs. - Josh On Apr 21, 2016 2:46 AM, "Christofer Dutz" wrote: > I'm currently having a p

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-21 Thread Josh Tynjala
We should probably use language_in with whatever the ES5 value is, instead of the default ES3. We're targeting ES5 in our compiler output, so it would make sense. - Josh On Apr 21, 2016 3:23 AM, "Christofer Dutz" wrote: > Would it be possible to eliminate some of the warnings while generating >

Re: AW: AW: [FlexJS] Status on Maven migration

2016-04-14 Thread Alex Harui
On 4/14/16, 10:44 PM, "Christofer Dutz" wrote: >In the cleanup script I simply removed all non Maven related stuff. What >I could do, was to have my IntelliJ to generate an ant build from the >Maven build. Eventually that would get rid of some of the problems if the >old ant build. That might