Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-06-12 Thread Erik de Bruin
Yes, double bump. Can someone please take a look at this? EdB On Wed, Jun 10, 2015 at 10:41 AM, Dretch wrote: > Github user Dretch commented on the pull request: > > https://github.com/apache/flex-sdk/pull/18#issuecomment-110656554 > > Bump. Could this pull request be considered? > >

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-06-07 Thread Mihai Chira
Hi Fréd, thanks for your suggestion. (I responded inline.) > I have to admit I'm not very keen to see an already overly complex class to > become even more complex adding complex field managment. Me neither, I agree. I was thinking to add the field watcher as an optional constructor parameter / s

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-29 Thread Erik de Bruin
> Me? I generally tried to avoid being on the naming committees. Naming committees? I lol'ed at the idea, and then at the multiple... And the best they could come up with was "frameworks/projects/framework"? No wonder FB cost so much! :-P EdB -- Ix Multimedia Software Jan Luykenstraat 27 3

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-29 Thread Alex Harui
On 5/29/15, 12:34 AM, "Erik de Bruin" wrote: >Gareth, > >> 1. The logical project for my test (i.e. the project containing >> mx.collections.ArrayList) seems to be the "framework" project. I am >>confused >> by the name of this project being "framework"... it lives in a folder >>called >> "fram

RE: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-29 Thread Frédéric THOMAS
k already complex. Thought ? Frédéric THOMAS > From: mihai.ch...@gmail.com > Date: Fri, 29 May 2015 11:55:24 +0200 > Subject: Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making > ArrayList extend P... > CC: dev@flex.apache.org > > >> 2. I have added my test

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-29 Thread Mihai Chira
>> 2. I have added my test to the "framework" project according to the wiki, >> and it works! Except that there was already a >> "frameworks/projects/framework/tests/ folder", and it already contained a >> test (ListCollectionView_FLEX_34837_Tests.as). I suppose that this test was >> not being run

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-29 Thread Erik de Bruin
Gareth, > 1. The logical project for my test (i.e. the project containing > mx.collections.ArrayList) seems to be the "framework" project. I am confused > by the name of this project being "framework"... it lives in a folder called > "frameworks/projects/framework/" - what is the meaning of this?

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-28 Thread Gareth Smith
Hi Erik, Thanks for your help. I have setup the tests according to the wiki page, but I have a few questions: 1. The logical project for my test (i.e. the project containing mx.collections.ArrayList) seems to be the "framework" project. I am confused by the name of this project being "frame

Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making ArrayList extend P...

2015-05-17 Thread Erik de Bruin
Hi, While we wait for the performance discussion to die down (I'd say "commit THEN review", but who am I ;-)), I'll give you this: https://cwiki.apache.org/confluence/display/FLEX/Add+FlexUnit+tests+to+SDK+projects If that doesn't do it for you, I'll be glad to help to get you run as part of the