Hi, While we wait for the performance discussion to die down (I'd say "commit THEN review", but who am I ;-)), I'll give you this:
https://cwiki.apache.org/confluence/display/FLEX/Add+FlexUnit+tests+to+SDK+projects If that doesn't do it for you, I'll be glad to help to get you run as part of the regular build. EdB On Sun, May 17, 2015 at 1:51 PM, Dretch <g...@git.apache.org> wrote: > GitHub user Dretch opened a pull request: > > https://github.com/apache/flex-sdk/pull/18 > > Fix FLEX-15159 by making ArrayList extend Proxy. > > This fixes https://issues.apache.org/jira/browse/FLEX-15159. > > Notes: > > - This is more-or-less a copy-paste job with code taken from > `ListCollectionView` > - I have patched both `mx.collections.ArrayList` and also > `org.apache.flex.collections.ArrayList` > - I have written a unit test for the changes and put it in what seems to > be a logical place. The test passes, but can't figure out how to get the > build to call it. I was having segfault problems with my flashplayer that > made it difficult to look into this further. It is possible (and I hope it is > the case) that something in the build will call this test. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/Dretch/flex-sdk flex-15159 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/flex-sdk/pull/18.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #18 > > ---- > commit 9b483a586bd29867aece66eebd16c3acefe49732 > Author: Dretch <garetdanielsm...@gmail.com> > Date: 2015-05-17T11:44:20Z > > Fix FLEX-15159 by making ArrayList extend Proxy. > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
