Re: [FlexJS] refactor_sprite branch

2016-08-15 Thread Peter Ent
PM To: Peter Ent mailto:p...@adobe.com>>, "dev@flex.apache.org<mailto:dev@flex.apache.org>" mailto:dev@flex.apache.org>> Subject: Re: [FlexJS] refactor_sprite branch Good find. I will take a look. Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message

Re: [FlexJS] refactor_sprite branch

2016-08-12 Thread Alex Harui
Good find. I will take a look. Sent from my LG G3, an AT&T 4G LTE smartphone -- Original message-- From: Peter Ent Date: Fri, Aug 12, 2016 12:36 PM To: dev@flex.apache.org; Subject:Re: [FlexJS] refactor_sprite branch I finally tracked this down. The reason, it looks like to me, is somet

Re: [FlexJS] refactor_sprite branch

2016-08-12 Thread Peter Ent
I finally tracked this down. The reason, it looks like to me, is something the cross-compiler is doing. In Core/…/UIBase.as are lines like this: COMPILE::JS { this.positioner.style.height = value + 'px'; } which are being cross-compiled to: this.positioner.style.height = value + Number('px'

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Alex Harui
Looks like nobody found time to merge the Language.string from develop into the refactor-sprite branch. I just did that but didn't test it, but please try the JS versions again. -Alex On 8/11/16, 11:28 AM, "Peter Ent" wrote: >Here's a breakdown of all of the examples except a couple which requ

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Peter Ent
Here's a breakdown of all of the examples except a couple which require AIR and/or Cordova. Bottom line is that none of the JS versions work, all with the same error. The SWF versions have mixed results, but most have errors. ChartExample - SWF: OK JS: TypeError: org.apache.flex.utils.Language.str

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Peter Ent
Thanks. I now have mobile trader working. That example requires FALCON_HOME to be set to the compiler directory but I didn't need it for DataBindingExample. I'll see what others need it. Seems best to avoid env vars if possible. ‹peter On 8/11/16, 11:14 AM, "Alex Harui" wrote: > > >On 8/11/16, 7

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Peter Ent
I wish when these changes were made a more explicit email would be sent. Not too long ago I found some other old folder and changed it. ‹peter On 8/11/16, 11:14 AM, "Alex Harui" wrote: > > >On 8/11/16, 7:24 AM, "Peter Ent" wrote: > >>I have this: >> >>[echo] >>FALCON_HOME=/Users/pent/dev/flex-

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Alex Harui
On 8/11/16, 7:24 AM, "Peter Ent" wrote: >I have this: > >[echo] FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk > [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx > > >The build fails if I set FALCON_HOME to the flex-falcon directory. That looks like a lefto

Re: [FlexJS] refactor_sprite branch

2016-08-11 Thread Peter Ent
I have this: [echo] FALCON_HOME=/Users/pent/dev/flex-falcon/compiler/generated/dist/sdk [echo] FALCONJX_HOME=/Users/pent/dev/flex-falcon/compiler-jx The build fails if I set FALCON_HOME to the flex-falcon directory. —peter On 8/10/16, 5:14 PM, "Alex Harui" wrote: >Worked for me. Alter t

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
OK, just pushed a fix for Namespace and Qname. Scanning our generated JS code shows that many implicit coercions are still being generated, but as far as I can tell they are all "correct". We could do more "guessing" like assuming that someArray[someIndex].substring() is really going to return a s

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
Worked for me. Alter the ant script for MobileTrader to spit out the FALCON_HOME value. -Alex On 8/10/16, 1:58 PM, "Peter Ent" wrote: >I sync'd up with the latest falcon and rebuilt (ant all), rebuild >flex-asjs (refactor-sprite branch), rebuild MobileTrader. Running the SWF >version I get: >V

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Peter Ent
I sync'd up with the latest falcon and rebuilt (ant all), rebuild flex-asjs (refactor-sprite branch), rebuild MobileTrader. Running the SWF version I get: VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be found. Followed by: ReferenceError: Error #1065: Variable _MobileTrad

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
On 8/10/16, 1:44 PM, "Peter Ent" wrote: >I have the Aug 1 compile. Is the .toString() thing fixed? I'll check it >out anyway and give it a try. It looks better, but I think it isn't doing the right thing in Namespace and Qname yet. It looks like the ConstantBinding issue is fixed. -Alex

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Peter Ent
I have the Aug 1 compile. Is the .toString() thing fixed? I'll check it out anyway and give it a try. ‹peter On 8/10/16, 4:03 PM, "Alex Harui" wrote: >I will try to make a unit test out of the test case you cited. In theory >if the expression resolves to a String no implicit conversion will be

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
I will try to make a unit test out of the test case you cited. In theory if the expression resolves to a String no implicit conversion will be added. Maybe your expression was XML-ish which doesn't always resolve so I might need to special case that. -Alex On 8/10/16, 12:54 PM, "Harbs" wrote:

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Harbs
OK. I’ll take it for a spin when I have some time. Does this address the double toString() methods too? Is it smart enough to only call the Language.string() method when it’s not otherwise being cast? On Aug 10, 2016, at 10:45 PM, Alex Harui wrote: > > > On 8/10/16, 12:24 PM, "Harbs" wrote:

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
On 8/10/16, 12:24 PM, "Harbs" wrote: >Alex, > >What’s the state of the implicit coercions in Falcon? > >Should I give it another try? I pushed an update last night. In theory it only adds coercions on assignments. It will call Language.string() to do the conversion, so if you are working in

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Harbs
Alex, What’s the state of the implicit coercions in Falcon? Should I give it another try? On Aug 10, 2016, at 10:21 PM, Alex Harui wrote: > > >> On Aug 10, 2016, at 9:18 PM, Peter Ent wrote: >> >>> When I run MobileTrader, the JS version looks OK, but the SWF version >>> gives an immediate

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Alex Harui
>On Aug 10, 2016, at 9:18 PM, Peter Ent wrote: > >> When I run MobileTrader, the JS version looks OK, but the SWF version >> gives an immediate error: >> VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be >> found. > This indicates you are running and out-of-date Falcon co

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Harbs
I was getting the same error on my project. I think it’s from js.swc. On Aug 10, 2016, at 9:18 PM, Peter Ent wrote: > When I run MobileTrader, the JS version looks OK, but the SWF version > gives an immediate error: > VerifyError: Error #1014: Class mx.core::IFlexModuleFactory could not be > fo

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Peter Ent
I did a sync again and I'm seeing more errors. Running the CreateJSExample (which I accidentally skipped yesterday) yields this on SWF: TypeError: Error #1007: Instantiation attempted on a non-constructor. at org.apache.flex.core::UIHTMLElementWrapper/get model()[/Users/pent/dev/flex-asjs/

Re: [FlexJS] refactor_sprite branch

2016-08-10 Thread Peter Ent
I'm going to change the examples that have given issues from "source" to "url" and post my results. ‹peter On 8/9/16, 5:31 PM, "Harbs" wrote: >I¹ll be happy to change it back to source if others disagreeŠ > >On Aug 10, 2016, at 12:30 AM, Harbs wrote: > >> I tried to change that in the examples

Re: [FlexJS] refactor_sprite branch

2016-08-09 Thread Harbs
I’ll be happy to change it back to source if others disagree… On Aug 10, 2016, at 12:30 AM, Harbs wrote: > I tried to change that in the examples. I obviously missed some. > > I changed “source” to “url”. I think that makes more sense. > > On Aug 10, 2016, at 12:16 AM, Peter Ent wrote: > >>

Re: [FlexJS] refactor_sprite branch

2016-08-09 Thread Harbs
I tried to change that in the examples. I obviously missed some. I changed “source” to “url”. I think that makes more sense. On Aug 10, 2016, at 12:16 AM, Peter Ent wrote: > Hi, > > I've gotten a copy of the refactor_sprite branch. While everything builds > (need to skip the tests, though), m