I will try to make a unit test out of the test case you cited. In theory if the expression resolves to a String no implicit conversion will be added. Maybe your expression was XML-ish which doesn't always resolve so I might need to special case that.
-Alex On 8/10/16, 12:54 PM, "Harbs" <harbs.li...@gmail.com> wrote: >OK. I’ll take it for a spin when I have some time. > >Does this address the double toString() methods too? Is it smart enough >to only call the Language.string() method when it’s not otherwise being >cast? > >On Aug 10, 2016, at 10:45 PM, Alex Harui <aha...@adobe.com> wrote: > >> >> >> On 8/10/16, 12:24 PM, "Harbs" <harbs.li...@gmail.com> wrote: >> >>> Alex, >>> >>> What’s the state of the implicit coercions in Falcon? >>> >>> Should I give it another try? >> >> I pushed an update last night. In theory it only adds coercions on >> assignments. It will call Language.string() to do the conversion, so if >> you are working in the sprite branch you will need to sync that change >> from flex-asjs's develop branch. And it should support >> @flexjsnoimplicitstringconversion to suppress the Language.string calls. >> I didn't change the Number() logic. >> >> I considered checking for XML expressions and just calling toString(), >>but >> didn't implement that. >> >> -Alex >> >
