RE: [Externs] jasmine-2.0.js

2015-07-07 Thread Frédéric THOMAS
I guess I'm good, you can checkout add-CollectImportPass if you like to review it. Thanks, Frédéric THOMAS > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: [Externs] jasmine-2.0.js > Date: Tue, 7 Jul 2015 02:44:5

RE: [Externs] jasmine-2.0.js

2015-07-06 Thread Frédéric THOMAS
e constructors in more :P So, better I finish to write the tests, manage the UnionType, etc.. and come back to you. Happy painting ! ;-) Frédéric THOMAS > Date: Mon, 6 Jul 2015 18:48:03 -0400 > Subject: Re: [Externs] jasmine-2.0.js > Fro

Re: [Externs] jasmine-2.0.js

2015-07-06 Thread Michael Schmalle
gt;> >> import superClasses.Import; >> >> /** >> * @see [collect_import] >> */ >> public class CollectImports extends superClasses.Import { >> >> /** >> * @param bar [(foo.Bar|null)] >> * @param value [number] >> * @see [colle

Re: [Externs] jasmine-2.0.js

2015-07-06 Thread Michael Schmalle
extends superClasses.Import { > > /** > * @param bar [(foo.Bar|null)] > * @param value [number] > * @see [collect_import] > */ > public function CollectImports(bar:foo.Bar, value:Number) { > super(); > } > > Thanks, > Frédéric THOMAS >

RE: [Externs] jasmine-2.0.js

2015-07-06 Thread Frédéric THOMAS
- > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: [Externs] jasmine-2.0.js > Date: Mon, 6 Jul 2015 00:18:10 +0100 > >> I am going to be busy most of the week remodeling my mother in laws >> bathroom starting tomorrow. So if you want to

RE: [Externs] jasmine-2.0.js

2015-07-05 Thread Frédéric THOMAS
text is already the ClassReference, so call classRef.addImport(). :) You can review the add-CollectImportPass branch before I merge it when you have a chance. Thanks, Frédéric THOMAS -------------------- > Date: Sun, 28 Jun 2015 14:23:57 -0400 > Subject: Re: [Externs] jas

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
Jun 2015 15:51:45 -0400 > > Subject: Re: [Externs] jasmine-2.0.js > > From: teotigraphix...@gmail.com > > To: dev@flex.apache.org > > > > On Sun, Jun 28, 2015 at 3:49 PM, Frédéric THOMAS < > webdoubl...@hotmail.com> > > wrote: > > > >>>

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
I just found that http://stackoverflow.com/questions/881515/how-do-i-declare-a-namespace-in-javascript There are I guess all the ways to create them. Frédéric THOMAS > Date: Sun, 28 Jun 2015 15:51:45 -0400 > Subject: Re: [Externs] jasmine-2.0.js

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
ion structures. > > Like what ? > > Well if I had complete tests I could tell you. ;-) Mike > Frédéric THOMAS > > > > > Date: Sun, 28 Jun 2015 15:33:42 -0400 > > Subject: Re: [Externs] jasmine-2.0.js > > From: teotigr

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
-- > Date: Sun, 28 Jun 2015 15:33:42 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > And... haha packages are really sketchy. We need more package type test > from the externs that use them. > > My intuition

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
Alright ! Frédéric THOMAS > Date: Sun, 28 Jun 2015 15:28:54 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > Fred, what I plan on doing since you are going to be working

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
which the parser ignores > right now, so that is another thing that can be tested and implemented. > > Mike > > > > On Sun, Jun 28, 2015 at 3:21 PM, Frédéric THOMAS > wrote: > >> Thanks ! >> >> Frédéric THOMAS >> >> >> ----------

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
ric THOMAS wrote: > Thanks ! > > Frédéric THOMAS > > > > > Date: Sun, 28 Jun 2015 15:11:20 -0400 > > Subject: Re: [Externs] jasmine-2.0.js > > From: teotigraphix...@gmail.com > > To: dev@flex.apache.org > > >

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
Thanks ! Frédéric THOMAS > Date: Sun, 28 Jun 2015 15:11:20 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > Yeah I know, sent to your hotmail. > > Mike > > O

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
hanks, > Frédéric THOMAS > > > > > From: webdoubl...@hotmail.com > > To: dev@flex.apache.org > > Subject: RE: [Externs] jasmine-2.0.js > > Date: Sun, 28 Jun 2015 20:06:19 +0100 > > > >> BTW, what should we do about code formatti

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
t you can do is to send me your eclipse formatter property file. > I will use it in IJ. > > Frédéric THOMAS > > > ------------------------ >> Date: Sun, 28 Jun 2015 14:57:50 -0400 >> Subject: Re: [Externs] jasmine-2.0.js >> From: teotigraphix...@gm

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
J. Frédéric THOMAS > Date: Sun, 28 Jun 2015 14:57:50 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > BTW, what should we do about code formatting, it seems my formatting is > different then yours. I am using

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
f >> >>> TYPE that is attached to a member, identifier such as a param type, >> >> return >> >>> type, filed type, superclass and interface(already taken care of using >> >>> addImport()). >> >>> >> >>> See where

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
- > > Date: Sun, 28 Jun 2015 14:23:57 -0400 > > Subject: Re: [Externs] jasmine-2.0.js > > From: teotigraphix...@gmail.com > > To: dev@flex.apache.org > > > > Kewl. > > > > I am going to be busy most of the week remode

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
Date: Sun, 28 Jun 2015 14:23:57 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > Kewl. > > I am going to be busy most of the week remodeling my mother in laws > bathroom starting tomorrow. So if you w

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
> If it's top level why would we need an import, I am confused? lol, sorry, not enough coffee !! Frédéric THOMAS > Date: Sun, 28 Jun 2015 14:41:52 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To:

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
nce, so call classRef.addImport(). :) > > Ok yes, will give it a try. > Just another thing maybe you can help with, is there a function somewhere > that does something like isBuiltin(type) as I didn't know how to deal with > imports of top level custom classes or even if we

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
should try to manage that. Frédéric THOMAS ---------------- > Date: Sun, 28 Jun 2015 14:23:57 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > Kewl. > > I am going to be bus

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
t could be very >> interesting. >> > So having you understand my design intention is really important to me. >> :) >> >> Don't worry, I don't think you are bossy or condescending Mike, I'm >> reading you >> and try to put in parallel the new i

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
uld be very interesting. > > So having you understand my design intention is really important to me. > :) > > Don't worry, I don't think you are bossy or condescending Mike, I'm > reading you > and try to put in parallel the new informations you give and what I&#x

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
;m reading you and try to put in parallel the new informations you give and what I've seen in the code for a better understanding, that's it. Cheers, Frédéric THOMAS -------- > Date: Sun, 28 Jun 2015 13:48:02 -0400 > Subject: Re: [Externs] jasmine

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
iler and despite the recursive visitor >> pattern, I guess I can do it. >> >> > How much are you working on right now Fred? I just ask because I don't >> want >> > to create any conflicts. >> >> Go ahead Mike, I'm done with that at the moment

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
done with that at the moment, I did my last cleanup > already. > Anyway, better I work on a branch and commit the branch instead for review > next time. > > Frédéric THOMAS > > > > > Date: Sun, 28 Jun 2015 13:23:15 -0400 > > Subject: Re:

RE: [Externs] jasmine-2.0.js

2015-06-28 Thread Frédéric THOMAS
better I work on a branch and commit the branch instead for review next time. Frédéric THOMAS ------------ > Date: Sun, 28 Jun 2015 13:23:15 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > &g

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
as called in ResolvePackagesPass hoping >>> to find a missing case but after debug spin I wasn't able to do what I >>> expected, I'm not sure I understood all the logic in this class but it >>> looked like the Node of my return type was never visited and therefore >>> wasn't

Re: [Externs] jasmine-2.0.js

2015-06-28 Thread Michael Schmalle
erence addMethod(Node node, String functionName, >> JSDocInfo comment, boolean isStatic) >> >> To me it would be enough to add the import to the list of imports to be >> emitted when the MethodReference is to be added, I just had to determinate >> i

Re : Re: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
I'm out right now but will read ASAP --- Message initial --- De : "Michael Schmalle" Envoyé : 27 juin 2015 22:59 A : dev@flex.apache.org Objet : Re: [Externs] jasmine-2.0.js Hey Fred, I was out all day. I will have some time in the morning to look at what you did and comment. :

Re: [Externs] jasmine-2.0.js

2015-06-27 Thread Michael Schmalle
ither ! > > My test was passing was I was able to compile with this new code the old > externs. > > The only thing I had to do to finish to compile the jasmine extern was to > emit the imports for the global functions too as they shown to be faulty > for the same reasons. > &g

RE: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
to compile the jasmine extern was to emit the imports for the global functions too as they shown to be faulty for the same reasons. Mike will probably tell me now where my logic was wrong now :-) Frédéric THOMAS > From: webdoubl...@hotmail.com >

RE: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
Ok, done ! I forgot to uncomment the externc build of jasmine and print the global function imports ! Frédéric THOMAS > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: [Externs] jasmine-2.0.js > Date: Sat, 27 Jun 2

RE: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
model. > > Thanks, > Frédéric THOMAS > > > >> Date: Sat, 27 Jun 2015 05:31:50 -0400 >> Subject: Re: [Externs] jasmine-2.0.js >> From: teotigraphix...@gmail.com >> To: dev@flex.apache.org >> >> I just noti

RE: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
Jun 2015 05:31:50 -0400 > Subject: Re: [Externs] jasmine-2.0.js > From: teotigraphix...@gmail.com > To: dev@flex.apache.org > > I just noticed you said today or tomorrow, whatever man. doesn't matter. > > Mike > > On Sat, Jun 27, 2015 at 5:17 AM, Michael Schmalle >

Re: [Externs] jasmine-2.0.js

2015-06-27 Thread Michael Schmalle
efore >> and it would be nice if you can review it. >> >> Thanks, >> Frédéric THOMAS >> >> >> ---------------- >> > From: webdoubl...@hotmail.com >> > To: dev@flex.apache.org >> > Subject: RE: [Externs] jasmine-2.0.js >> > Date: Fri, 26

Re: [Externs] jasmine-2.0.js

2015-06-27 Thread Michael Schmalle
as I need to clean a bit before > and it would be nice if you can review it. > > Thanks, > Frédéric THOMAS > > > > > From: webdoubl...@hotmail.com > > To: dev@flex.apache.org > > Subject: RE: [Externs] jasmine-2.0.js >

RE: [Externs] jasmine-2.0.js

2015-06-27 Thread Frédéric THOMAS
ric THOMAS > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: [Externs] jasmine-2.0.js > Date: Fri, 26 Jun 2015 22:43:30 +0100 > > Hey Mike, it looks like "import jasmine.Clock;" is missing in the generated > ja

RE: [Externs] jasmine-2.0.js

2015-06-26 Thread Frédéric THOMAS
Hey Mike, it looks like "import jasmine.Clock;" is missing in the generated jasmine.as, that's it ! Frédéric THOMAS > From: webdoubl...@hotmail.com > To: dev@flex.apache.org > Subject: RE: [Externs] jasmine-2.0.js > Date: Fri,

RE: [Externs] jasmine-2.0.js

2015-06-26 Thread Frédéric THOMAS
the offer but I think I am > going to need to get this one. There are a couple places it could be though > if you are curious. > > First you really need to understand the problem, I am typing this stuff in > between installing a bathroom vanity and sink, so I haven't looked

Re: [Externs] jasmine-2.0.js

2015-06-26 Thread Michael Schmalle
vanity and sink, so I haven't looked at the code yet. :) So I can't really give you an answer since I don't quite know the problem yet. Mike > > Thanks, > Frédéric THOMAS > > > > > Date: Fri, 26 Jun 2015 16:32:16 -0400

RE: [Externs] jasmine-2.0.js

2015-06-26 Thread Frédéric THOMAS
ked" to do > more work then my initial implementation. > > Make sense? Well, kind of :-) What classes would you check for this ? Thanks, Frédéric THOMAS ------------ > Date: Fri, 26 Jun 2015 16:32:16 -0400 > Subject: Re: [Externs] jasmine-2.0.js &

Re: [Externs] jasmine-2.0.js

2015-06-26 Thread Michael Schmalle
Yeah, this "jasmine.Clock" The error means that the Falcon compiler is trying to resolve a member expression and it can't resolve it. So this means there is a bug in the AST resolver. You are using the extern in the GCC project correct? If so, I need to take a look at it. Everyone, I did one pa