Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-21 Thread Justin Mclean
Hi, > Should we encourage SlavaRa to spend his energy on Falcon, or take his > pull requests and hope they are good? "Scratch your own itch” as they say. I don’t think we should be discouraging any contribution, the old compiler is still in use so we should at least consider them. > Does anyb

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-21 Thread Alex Harui
On 10/20/15, 11:43 PM, "Harbs" wrote: >He just closed the pull request. I’m not sure why. Hmm. He just created new pull requests. Well, what do others think? Should we encourage SlavaRa to spend his energy on Falcon, or take his pull requests and hope they are good? Does anybody else have t

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-20 Thread Harbs
He just closed the pull request. I’m not sure why. On Oct 19, 2015, at 10:48 PM, OmPrakash Muppirala wrote: > You could just comment on the PR at GitHub. The messages and responses get > forwarded to the dev list. > > Thanks, > Om > > On Mon, Oct 19, 2015 at 10:45 AM, Alex Harui wrote: > >>

[GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-20 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-19 Thread OmPrakash Muppirala
You could just comment on the PR at GitHub. The messages and responses get forwarded to the dev list. Thanks, Om On Mon, Oct 19, 2015 at 10:45 AM, Alex Harui wrote: > > > On 10/19/15, 9:03 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" > wrote: > > >Alex, et al., > > > >Can you plea

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-19 Thread Alex Harui
On 10/19/15, 9:03 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Alex, et al., > >Can you please take a look at this PR and respond accordingly? Well, I looked at a few screenfuls of the diffs when it first came in. It appears to be an actual code clean up a portion of the

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-19 Thread OmPrakash Muppirala
Alex, et al., Can you please take a look at this PR and respond accordingly? Thanks, Om On Oct 17, 2015 12:12 AM, "SlavaRa" wrote: > GitHub user SlavaRa opened a pull request: > > https://github.com/apache/flex-sdk/pull/22 > > [Module asc] Cleanup code - 1st step > > This PR is the

[GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-17 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/22 [Module asc] Cleanup code - 1st step This PR is the first step on the path to good condition code of compiler. I hope that you will take it and then I can make the new PR. You can merge this pu

[GitHub] flex-sdk pull request: [Module asc] Cleanup code 1st step

2015-10-17 Thread SlavaRa
Github user SlavaRa closed the pull request at: https://github.com/apache/flex-sdk/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flex-sdk pull request: [Module asc] Cleanup code 1st step

2015-10-17 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/21 [Module asc] Cleanup code 1st step This PR is the first step on the path to good condition code of compiler. I hope that you will take it and then I can make the new PR. You can merge this pull