On 10/19/15, 9:03 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala"
<omup...@gmail.com on behalf of bigosma...@gmail.com> wrote:
>Alex, et al.,
>
>Can you please take a look at this PR and respond accordingly?
Well, I looked at a few screenfuls of the diffs when it first came in. It
appears to be an actual code clean up a portion of the MXMLC compiler. I
saw things like “import java.util.*” being replaced by the actual classes
that are needed, and “someString.indexOf('foo') > -1” being replaced by
“someString.contains('foo’)"
I have to admit that I am not motivated to scrub this patch looking for
potential errors. I would be much more interested if the clean up was in
the Falcon code base. While I want to encourage all kinds of
contributions and recruit more committers, I don’t see how this patch
“moves the needle”. Adding to that, I don’t see the email address of the
PR author on our dev@ subscriber list, and it seems we should engage the
author in a dialog about “why” this PR was generated and/or try to
redirect his/her efforts to the Falcon code base.
If some other committer has the motivation to review the PR, please do so.
IMO, you don’t have to know anything about the compiler and only some
basics about Java. And we could also gamble by just having someone commit
the PR and see what breaks if anything, but there is always the risk of
subtle errors being introduced. I wouldn’t worry about that at all for
Falcon’s code base since the whole thing is in flux, but it would not be
good to de-stabilize MXMLC.
Meanwhile, it seems like we should contact the author and encourage them
to discuss the PR on our dev@ list.
Thoughts?
-Alex
