Re: [FlexJS MDL] release build broken

2017-02-17 Thread Alex Harui
On 2/17/17, 5:54 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >2017-02-17 12:36 GMT+01:00 Harbs : > >> Simply specifying strings instead of the constants would be the most >> efficient currently. >> > >But that's what we try to avoid in order to support type safe code > >I pu

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Carlos Rovira
2017-02-17 12:36 GMT+01:00 Harbs : > Simply specifying strings instead of the constants would be the most > efficient currently. > But that's what we try to avoid in order to support type safe code I put on my plate to break the class in 16 classes, but as I'm working on other things I invite pe

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Harbs
I’d really like to eventually see the compiler to optimize constants better, but yes, breaking the constant classes into smaller categories will help if only some of them are used. Simply specifying strings instead of the constants would be the most efficient currently. > On Feb 17, 2017, at 1

Re: [FlexJS MDL] release build broken

2017-02-17 Thread Carlos Rovira
Hi Harbs, if we don't use constants what you suggest? One of the things we provide is "type safe". I think this is the minimal version we can provide. Think that before we was creating a class per icon, given the 900+ icons would be a problem to both in terms of coding and space used. The only th

Re: [FlexJS MDL] release build broken

2017-02-16 Thread Alex Harui
On 2/16/17, 12:34 PM, "Harbs" wrote: >When I’ve had these kinds of issues in my app, it’s because of minified >renaming. Yep, and there is code in one of the Binding classes that does some trickery to look up a constant when minified. That code might need to be used in this scenario. -Alex

Re: [FlexJS MDL] release build broken

2017-02-16 Thread Harbs
When I’ve had these kinds of issues in my app, it’s because of minified renaming. Tangentially: FWIW, I’m not sure how wise it is to use constants to specify the icon text. The minified version of just the definitions for the MaterialIconTypes is a full 77KB! Until we have a way to stripped ou

Re: [FlexJS MDL] release build broken

2017-02-16 Thread piotrz
pache-flex-development.247.n4.nabble.com/FlexJS-MDL-release-build-broken-tp59537p59564.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS MDL] release build broken

2017-02-16 Thread Carlos Rovira
Hi Harbs, Thanks for seeing that. @Pitor, I looked at the code and seems something related to binding, The binding is not working and no text is retrieved. The output is: So no text in the i element tag seems the binding no

[FlexJS MDL] release build broken

2017-02-16 Thread Harbs
1. Go here: http://apacheflexbuild.cloudapp.net:8080/job/MDLExample/lastSuccessfulBuild/artifact/examples/flexjs/MDLExample/bin/js-release/index.html 2. Cl