Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Alex Harui
On 10/20/16, 9:49 AM, "Harbs" wrote: >I feel like we’re not communicating. No. I want to merge as-is. I don't understand how that would create a second component set. Seems like that would just stomp on the current basic set. > >I think that wrapping should be the default for all components.

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Harbs
I feel like we’re not communicating. No. I want to merge as-is. I think that wrapping should be the default for all components. I feel that having Flash properties leaking though is worse than a bit of redirection for 99% of use cases. I can’t stress how much of an issue that the Flash propertie

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Alex Harui
On 10/20/16, 8:30 AM, "Harbs" wrote: >Can we just merge the sprite-refactor now and deal with the alternates >later (if it’s necessary)? The longer we take to merge it in, the more >work it will be to do so. I assume you mean merging after moving the wrapping code into a new component set? Ot

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Alex Harui
On 10/20/16, 8:23 AM, "Harbs" wrote: >I don’t think so. (unless I’m misunderstanding you) > >I’m not sure it makes sense to have automatic overloading. Requiring >specifying “override” when overriding a function is a good feature. It >makes sure you don’t do it by mistake. If the Flash implemen

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Harbs
Can we just merge the sprite-refactor now and deal with the alternates later (if it’s necessary)? The longer we take to merge it in, the more work it will be to do so. On Oct 20, 2016, at 5:15 PM, Alex Harui wrote: > But if there are advantages to wrapping the SWF side because it is the best

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Harbs
I don’t think so. (unless I’m misunderstanding you) I’m not sure it makes sense to have automatic overloading. Requiring specifying “override” when overriding a function is a good feature. It makes sure you don’t do it by mistake. If the Flash implementation have properties and methods that the

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Alex Harui
On 10/20/16, 1:48 AM, "Harbs" wrote: >AFAIK, properties cannot be overridden as getters and setters, so even >simple properties can have issues. Yes. Rect Point and Matrix were all >classes which caused problems. This is true for now, but this is what I want to look into a bit more. The discus

Re: [FlexJS] HTMLElementWrapper extending Sprite

2016-10-20 Thread Harbs
AFAIK, properties cannot be overridden as getters and setters, so even simple properties can have issues. Yes. Rect Point and Matrix were all classes which caused problems. Transform is actually quite a bit more complicated than just CSS. For HTML, yes, you probably need CSS3. But for SVG, it’s

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-10-20 Thread Mihai Chira
No problem, and thanks for that, I appreciate it! Will email you a reminder. On 20 October 2016 at 10:37, Harbs wrote: > Hi Mihai, > > I forgot about this. I’m not going to have time to look into this for at > least a week or two. > > Please email me a reminder to take a look in a couple of week

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-10-20 Thread Harbs
Hi Mihai, I forgot about this. I’m not going to have time to look into this for at least a week or two. Please email me a reminder to take a look in a couple of weeks… Harbs On Oct 20, 2016, at 11:29 AM, Mihai Chira wrote: > If anyone with TLF knowledge wants to take a look at this, it would

Re: [jira] [Comment Edited] (FLEX-35078) Fatal when SelectionManager tries to reapply selection onto changed textFlow

2016-10-20 Thread Mihai Chira
If anyone with TLF knowledge wants to take a look at this, it would be quite helpful. Some of the investigation work is already done, and someone who understands what _should_ happen can probably spot the problem quickly. Thank you! On 29 August 2016 at 15:26, Mihai Chira wrote: > Hi Harbs, just