I feel like we’re not communicating. No. I want to merge as-is. I think that wrapping should be the default for all components. I feel that having Flash properties leaking though is worse than a bit of redirection for 99% of use cases. I can’t stress how much of an issue that the Flash properties and methods leaking through was for us. Spark-like components was not the issue. Platform-specific implementation details leaking through is the issue and it’s more of an issue than possible performance problems IMO.
We have not demonstrated that the performance impact will even be an issue. If that’s demonstrated, we can make leaky high-preformance alternates for those cases. On Oct 20, 2016, at 7:17 PM, Alex Harui <aha...@adobe.com> wrote: > > > On 10/20/16, 8:30 AM, "Harbs" <harbs.li...@gmail.com> wrote: > >> Can we just merge the sprite-refactor now and deal with the alternates >> later (if it’s necessary)? The longer we take to merge it in, the more >> work it will be to do so. > > I assume you mean merging after moving the wrapping code into a new > component set? Otherwise the wrapping would overwrite the basic set. > > To move the wrapping, I guess you would create another SWC or two and copy > parts of Core and HTML? Then revert the changes in Core and HTML that > executed the wrapping? There would probably be some other things to be > fixed up after that. I could try to help out with that. Are there only a > few components that "must" be wrapped like Image, or is it all components? > > -Alex >
