Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
Well, I think I was able to reproduce your problem. Falcon is looking for env.properties in a different place and doesn’t use the arg value passéd in. I pushed a change to Falcon to fix that. So pull changes to flex-falcon before trying again and run “ant all”. You may need to add the wrote:

Re: [FalconJX] Intermittently adds incorrect goog.require() for class in external library

2015-10-21 Thread Alex Harui
On 10/21/15, 5:35 PM, "Alex Harui" wrote: > > >On 10/21/15, 4:20 PM, "Josh Tynjala" wrote: > >>Is the compiler using more than one thread? Could different threads be >>calling isExternalLinkage(), and am I seeing a race condition? > >The compiler uses one thread for each .as file so yes, you a

Re: [FalconJX] Intermittently adds incorrect goog.require() for class in external library

2015-10-21 Thread Alex Harui
On 10/21/15, 4:20 PM, "Josh Tynjala" wrote: >Is the compiler using more than one thread? Could different threads be >calling isExternalLinkage(), and am I seeing a race condition? The compiler uses one thread for each .as file so yes, you are probably seeing a multi-thread issue, although I ha

[FalconJX] Intermittently adds incorrect goog.require() for class in external library

2015-10-21 Thread Josh Tynjala
Recently, I've noticed that the output of asjsc is not always identical. Sometimes, it will incorrectly add a goog.require() for a class that is in the external library path. Not always, though. Here's some simplified example output (comment added for emphasis): goog.provide('feathers.core.Feathe

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Mihai Chira
Sorry about that, Alex. Thank you for the fix. I'll be more careful next commits. On 21 Oct 2015 23:16, "Alex Harui" wrote: > Nevermind, I pushed a fix. > > On 10/21/15, 11:35 AM, "Alex Harui" wrote: > > >Mihai, can you fix the build? It looks like an import statement got > >deleted. > > > >-Al

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Alex Harui
Nevermind, I pushed a fix. On 10/21/15, 11:35 AM, "Alex Harui" wrote: >Mihai, can you fix the build? It looks like an import statement got >deleted. > >-Alex > >On 10/21/15, 8:49 AM, "flex.ci.bui...@gmail.com" > wrote: > >>See

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-21 Thread Justin Mclean
Hi, > Should we encourage SlavaRa to spend his energy on Falcon, or take his > pull requests and hope they are good? "Scratch your own itch” as they say. I don’t think we should be discouraging any contribution, the old compiler is still in use so we should at least consider them. > Does anyb

Re: Building FlexJS from source

2015-10-21 Thread Harbs
OK. I’m calling it a night. Hopefully, I’ll have more success with this tomorrow. Harbs On Oct 21, 2015, at 11:41 PM, Alex Harui wrote: > > > On 10/21/15, 1:37 PM, "Harbs" wrote: > >> No joy. >> >> I made this change in that file: >> > output="${FLEXJS_HOME}/frameworks/

Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
On 10/21/15, 1:37 PM, "Harbs" wrote: >No joy. > >I made this change in that file: > output="${FLEXJS_HOME}/frameworks/libs/Core.swc"> > > >/> > > > > > >I’m really confused about where that is defined. The

Re: Building FlexJS from source

2015-10-21 Thread Harbs
Yeah. I realized that after running ant all again… ;-) On Oct 21, 2015, at 11:37 PM, Alex Harui wrote: > FWIW, since you are failing in the flex-asjs build, you can probably just > run “ant” instead of “ant all”. > > -Alex > > On 10/21/15, 1:24 PM, "Harbs" wrote: > >> Trying now… >> >> On O

Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
FWIW, since you are failing in the flex-asjs build, you can probably just run “ant” instead of “ant all”. -Alex On 10/21/15, 1:24 PM, "Harbs" wrote: >Trying now… > >On Oct 21, 2015, at 11:19 PM, Alex Harui wrote: > >> It looks like there are bugs in the scripts if you use env.properties >>and

Re: Building FlexJS from source

2015-10-21 Thread Harbs
No joy. I made this change in that file: I get the same error. These two lines seem to not be resolved correctly in flex-asjs/frameworks/flex-config.xml: —> {playerglobalHome}/{targetPlayerMajorV

Re: Using MX functions in a FlexJS project

2015-10-21 Thread Alex Harui
On 10/21/15, 12:54 PM, "LukeWilimitis" wrote: >As part of a rather complex project I'm working on, I'm required to >convert >functionality from the Flex3 SDK (specifically, the MX classes) and >compile >it into a working FlexJS app. Do you mean the mx UI widgets like mx:TextInput? Can you pro

Re: Building FlexJS from source

2015-10-21 Thread Harbs
Trying now… On Oct 21, 2015, at 11:19 PM, Alex Harui wrote: > It looks like there are bugs in the scripts if you use env.properties and > not actually set environment variables. If you look in a file like > frameworks/projects/Core/build.xml, it appears that the tag in the > “compile” target c

Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
It looks like there are bugs in the scripts if you use env.properties and not actually set environment variables. If you look in a file like frameworks/projects/Core/build.xml, it appears that the tag in the “compile” target could also use (like the other targets have): Do you hav

Re: Building FlexJS from source

2015-10-21 Thread Harbs
I tried commenting that var out and it failed immediately. Whatever my problem is, it appears to be related to the playerglobal path. At first it seems to be correct: check-playerglobal-home: [echo] PLAYERGLOBAL_HOME is /Users/harbs/Documents/ApacheFlex/frameworks/libs/player [echo] p

Using MX functions in a FlexJS project

2015-10-21 Thread LukeWilimitis
As part of a rather complex project I'm working on, I'm required to convert functionality from the Flex3 SDK (specifically, the MX classes) and compile it into a working FlexJS app. Am I way over my head here? Or should it theoretically be possible to include large pieces of the original Flex SDK

Re: Building FlexJS from source

2015-10-21 Thread Josh Tynjala
I'm guessing that there will be conflicts if you use the AIR SDK that comes with a compiler. - Josh On Wed, Oct 21, 2015 at 12:27 PM, Harbs wrote: > env.AIR_HOME=/Users/harbs/Documents/ApacheFlex/frameworks/AIRSDK_Compiler > >

Re: Building FlexJS from source

2015-10-21 Thread Harbs
I did ant all and it failed in the same place (but after much longer): compile: [echo] Compiling libs/Core.swc [echo] FLEX_HOME: /Users/harbs/Documents/ApacheFlex/flex-asjs [echo] FALCON_HOME: /Users/harbs/Documents/ApacheFlex/flex-asjs/../flex-falcon/compiler/generated/dist/sdk

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Alex Harui
On 10/21/15, 11:27 AM, "Josh Tynjala" wrote: > >By the way, the SIMPLE_OPTIMIZATIONS argument for the closure compiler >might be an acceptable middle ground for minification. When I tried it, I >was able to load up my CreateJS demo and it actually rendered everything. >However, I noticed that it

Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
On 10/21/15, 11:08 AM, "Harbs" wrote: >But I already have clones of all the repos (and some custom files like >env.properties files). > >Why do I need to delete them? Well, I set up the script for new folks. It looks like the right checks are in the script so that it won’t overwrite your stuf

Re: Build failed in Jenkins: flex-sdk #884

2015-10-21 Thread Alex Harui
Mihai, can you fix the build? It looks like an import statement got deleted. -Alex On 10/21/15, 8:49 AM, "flex.ci.bui...@gmail.com" wrote: >See > >Changes: > >[Mihai Chira] FLEX-34945 > >[Mihai Chira] FLEX-34944 > >---

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Josh Tynjala
That makes it easier than generating the externs files myself. By the way, the SIMPLE_OPTIMIZATIONS argument for the closure compiler might be an acceptable middle ground for minification. When I tried it, I was able to load up my CreateJS demo and it actually rendered everything. However, I notic

Re: Building FlexJS from source

2015-10-21 Thread Harbs
But I already have clones of all the repos (and some custom files like env.properties files). Why do I need to delete them? On Oct 21, 2015, at 4:20 PM, Alex Harui wrote: > If you have PLAYERGLOBAL_HOME set correctly in the environment, delete all > other folders in /Users/harbs/Documents/Apac

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Alex Harui
On 10/21/15, 10:16 AM, "Josh Tynjala" wrote: >The cross-compiler that generates ActionScript from TypeScript >definitions? >Yeah, I could probably do that. Generating both ActionScript and externs >files adds some complexity that I'd prefer to hide from ActionScript >developers, though. Ideally

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Josh Tynjala
The cross-compiler that generates ActionScript from TypeScript definitions? Yeah, I could probably do that. Generating both ActionScript and externs files adds some complexity that I'd prefer to hide from ActionScript developers, though. Ideally, most developers wouldn't need to know about the exte

Re: [FlexJS] How to get Falcon to ignore AS beads

2015-10-21 Thread Alex Harui
On 10/21/15, 8:15 AM, "Stewart Robertson" wrote: >Hi, how do I unsubscribe from the list pls? Thanks To unsubscribe, send an email to dev-unsubscr...@flex.apache.org -Alex

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Alex Harui
On 10/21/15, 8:29 AM, "Josh Tynjala" wrote: >The problem with expecting externs files to be packaged into the SWC is >that they might not exist. For instance, if I've converted a TypeScript >definition to ActionScript, I won't have an externs file to add to the >SWC. Hmm. Maybe the cross-comp

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Josh Tynjala
The problem with expecting externs files to be packaged into the SWC is that they might not exist. For instance, if I've converted a TypeScript definition to ActionScript, I won't have an externs file to add to the SWC. - Josh On Oct 20, 2015 11:46 PM, "Alex Harui" wrote: > > > On 10/20/15, 5:08

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread SlavaRa
Github user SlavaRa commented on the pull request: https://github.com/apache/flex-sdk/pull/33#issuecomment-149929667 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [FlexJS] How to get Falcon to ignore AS beads

2015-10-21 Thread Stewart Robertson
Hi, how do I unsubscribe from the list pls? Thanks On 21/10/2015 16:06, Alex Harui wrote: On 10/21/15, 6:33 AM, "yishayw" wrote: I'm trying to write the JS counterparts of a new video component. Some of the beads in the AS part are unnecessary in the JS version and do not need to be implemen

Re: [FlexJS] How to get Falcon to ignore AS beads

2015-10-21 Thread Alex Harui
On 10/21/15, 6:33 AM, "yishayw" wrote: >I'm trying to write the JS counterparts of a new video component. Some of >the >beads in the AS part are unnecessary in the JS version and do not need to >be >implemented as they're built in to the HTML element. This is how I tried >to >achieve this: > >1

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread aharui
Github user aharui commented on the pull request: https://github.com/apache/flex-sdk/pull/33#issuecomment-149923072 Hi, are you subscribed to our developer mailing list (dev@flex.apache.org). If not, please subscribe by sending an email to dev-subscr...@flex.apache.org so we can disc

[GitHub] flex-sdk pull request: Manual array to collection copy replace wit...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/34 Manual array to collection copy replace with Collections.addAll You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/manua

[GitHub] flex-sdk pull request: Manual array copy replace with System.array...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/33 Manual array copy replace with System.arraycopy You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/manual_array_copy Alt

[GitHub] flex-sdk pull request: Simplify boolean constructor call

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/32 Simplify boolean constructor call You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/boolean_constructor_call Alternati

Re: [GitHub] flex-sdk pull request: [Module asc] Cleanup code - 1st step

2015-10-21 Thread Alex Harui
On 10/20/15, 11:43 PM, "Harbs" wrote: >He just closed the pull request. I’m not sure why. Hmm. He just created new pull requests. Well, what do others think? Should we encourage SlavaRa to spend his energy on Falcon, or take his pull requests and hope they are good? Does anybody else have t

Re: Building FlexJS from source

2015-10-21 Thread Alex Harui
If you have PLAYERGLOBAL_HOME set correctly in the environment, delete all other folders in /Users/harbs/Documents/ApacheFlex/ except flex-asjs, then go to flex-asjs and run “ant all”. It should pull all the dependent repos and run things in the right order. -Alex On 10/21/15, 4:40 AM, "Harbs"

Re: Debugging (was [DISCUSS] Release Apache FlexJS 0.5.0)

2015-10-21 Thread Alex Harui
For sure, FlexJS is not so far along that you won’t have to use browser debugging. More thoughts inline. On 10/21/15, 12:19 AM, "Harbs" wrote: >Changing the subject… > >Here’s a real-life scenario which I’m not sure how it’s going to work: > >I expect to spend the next many months building a JS

[GitHub] flex-sdk pull request: Remove redundant castings

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/31 Remove redundant castings You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_redundant_casting Alternatively you

[GitHub] flex-sdk pull request: Remove unnecessary interface modifier

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/30 Remove unnecessary interface modifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_interface_mo

[GitHub] flex-sdk pull request: Remove unnecessary enum modifier

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/29 Remove unnecessary enum modifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_enum_modifier Al

[GitHub] flex-sdk pull request: Replace 'String.indexOf(value) > -1' by 'St...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/28 Replace 'String.indexOf(value) > -1' by 'String.contains(value)' You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/repl

[GitHub] flex-sdk pull request: Remove unnecessary unboxing

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/26 Remove unnecessary unboxing You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_unboxing Alternativel

[GitHub] flex-sdk pull request: Remove unnecessary semicolon

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/27 Remove unnecessary semicolon You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_semicolon Alternativ

[GitHub] flex-sdk pull request: Remove unnecessary boxing

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/25 Remove unnecessary boxing You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_boxing Alternatively yo

[GitHub] flex-sdk pull request: Remove unnecessary intern() on String const...

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/23 Remove unnecessary intern() on String constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_unnecessary_int

[GitHub] flex-sdk pull request: Replace with chained append() calls

2015-10-21 Thread SlavaRa
GitHub user SlavaRa opened a pull request: https://github.com/apache/flex-sdk/pull/24 Replace with chained append() calls You can merge this pull request into a Git repository by running: $ git pull https://github.com/SlavaRa/flex-sdk feature/remove_string_concatenation_as_ar

Re: [DISCUSS] Release Apache FlexJS 0.5.0

2015-10-21 Thread Alex Harui
It looks like GCC provides more than one way to deal with renaming. Right now the compiler does prevent renaming of public things, but we have not measured how expensive that is. In the future, it might be possible to determine which public things are being access with [] syntax and only prevent

Building FlexJS from source

2015-10-21 Thread Harbs
Back here again… I’m trying to build FlexJS from the source repo in an attempt to see if I can get a setp for working on FlexJS itself. I’m getting stuck here: [mxmlc] /Users/harbs/Documents/ApacheFlex/flex-asjs/frameworks/flex-config.xml:65 [mxmlc] Error: unable to open '/Users/harbs/Doc

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34876 Added/fixed tests

2015-10-21 Thread Harbs
It’s a problem with the way the test case is set up. You will never have a case where HTML markup is pasted so the test case is kind of contrived. When markup is converted to a TextFlow, it has a line return at the end. Unless you do something to get rid of that, the line return will get pasted

Re: Fixing Flexmojos import in IntelliJ

2015-10-21 Thread Alexander Doroshko
Thank you for your contribution! Please see comments in the pull request: https://github.com/JetBrains/intellij-plugins/pull/281 On 17.10.2015 16:52, Christofer Dutz wrote: Ok ... the reason for the Error was code I commented out in order to debug the generator. After commenting that back in,

Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34876 Added/fixed tests

2015-10-21 Thread Mihai Chira
Harbs, in relation to FLEX-34807, I don't understand the change you made to FLEX_34807_Test.as: why is it expected that a new line will be added when pasting text? Or is it something to do with the exporting to plain text that requires it? Otherwise I'd see it as a bug, not as expected behaviour.

Debugging (was [DISCUSS] Release Apache FlexJS 0.5.0)

2015-10-21 Thread Harbs
Changing the subject… Here’s a real-life scenario which I’m not sure how it’s going to work: I expect to spend the next many months building a JS version of my PrintUI WYSIWYG web app. Many parts of the the code maps pretty well to JS, especially when using EaselJS. However, I think it’s unreas