Re: TextFlowLine recycling

2014-11-06 Thread Harbs
It’s pretty big. It consistently gets out of whack at the end of the second paragraph. I’m getting closer to where it’s going off… On Nov 7, 2014, at 1:01 AM, Alex Harui wrote: > > > On 11/6/14, 2:02 PM, "Harbs" wrote: > >> I think it’s _curElementOffset which gets updated. >> >> It does

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Erik de Bruin
How about: "ask the third parties?" They must have an opinion on the "blocking" status of this issue ... EdB On Fri, Nov 7, 2014 at 7:01 AM, Alex Harui wrote: > > > On 11/6/14, 4:06 PM, "Justin Mclean" wrote: > > >Hi, > > > >> Seems like if we drop 3rd-party support, we should remove 3rdpar

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
On 11/6/14, 4:06 PM, "Justin Mclean" wrote: >Hi, > >> Seems like if we drop 3rd-party support, we should remove 3rdparty.xml >> from the source package and update the RELEASE_NOTES. > >-1 to that we would have to revert about a dozen fixes (via cherry >picking) to remove 3rd party example suppo

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread OmPrakash Muppirala
> > Currently we have PMC members who are effectively blocking the release or > a vote on it but are unwilling to help out in fixing with they see as > issues. Please read the "Implications of Voting" section in [1] I am quoting what I think is the significant portion in that paragraph. "a vote

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, > Seems like if we drop 3rd-party support, we should remove 3rdparty.xml > from the source package and update the RELEASE_NOTES. -1 to that we would have to revert about a dozen fixes (via cherry picking) to remove 3rd party example support for Tour De Flex. > To say in the RELEASE_NOTES t

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
On 11/6/14, 2:02 PM, "Harbs" wrote: >I think it’s _curElementOffset which gets updated. > >It does look like something is getting out of sync. I’m just not sure yet >what. This is one of those areas that’s way too fragile IMHO… Every time >I’ve run into these kinds of issues it’s taken me days

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
On 11/6/14, 1:46 PM, "Justin Mclean" wrote: >Hi, > >So far we had a couple of PMC members who consider the 3rd Party issue to >be blocking (but no indication they will provide a patch) and a couple >who don't think it is blocking. Normally may be enough for a vote to pass >but with the "no RC"

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread OmPrakash Muppirala
On Thu, Nov 6, 2014 at 2:19 PM, Justin Mclean wrote: > Hi, > > > Or a third option: how about we just have a short description and a link > to > > the third party component? We can add the embedded part in the next > > release. > > Thats basically what we have now - the difference being it's hos

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, > Or a third option: how about we just have a short description and a link to > the third party component? We can add the embedded part in the next > release. Thats basically what we have now - the difference being it's hosted at the 3rd party site. One of the 3rd parties did provide their

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
I think it’s _curElementOffset which gets updated. It does look like something is getting out of sync. I’m just not sure yet what. This is one of those areas that’s way too fragile IMHO… Every time I’ve run into these kinds of issues it’s taken me days to figure out exactly what’s off. On Nov 6

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
On 11/6/14, 1:50 PM, "Harbs" wrote: >Well, it does this: > >if (_curElementStart == _curParaStart+_curParaElement.textLength) > break; > >to normally break out of the loop. > >I’m a bit fuzzy though on how it handles SpanElements that span multiple >lines and how to break out of that. Doesn’t

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread OmPrakash Muppirala
Sorry, I will not be able to provide a patch. I have limited bandwidth this week. I want to finish up the iOS7 skins first before working on anything else. +1 for dropping third party support in this release because of this issue. Or a third option: how about we just have a short description an

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
Well, it does this: if (_curElementStart == _curParaStart+_curParaElement.textLength) break; to normally break out of the loop. I’m a bit fuzzy though on how it handles SpanElements that span multiple lines and how to break out of that. (I should really try to comment the code a bit so next

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, So far we had a couple of PMC members who consider the 3rd Party issue to be blocking (but no indication they will provide a patch) and a couple who don't think it is blocking. Normally may be enough for a vote to pass but with the "no RC" process that's unclear. Looks like we have a choi

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
On 11/6/14, 1:03 PM, "Harbs" wrote: > >For some reason, the flowComposer has TextFlowLines beyond the end of the >paragraph which it’s trying to compose. >BaseCompose.composeParagraphElementIntoLines() should really break out of >the loop before this happens (if I’m understanding things correct

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
The error happens here: // trace("Recreating line from", absoluteStart, "to", absoluteStart + textLength); textLine = TextLineRecycler.getLineForReuse(); if (textLine) {

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
On 11/6/14, 12:27 PM, "Harbs" wrote: >It’s all checked in to the tables branch. > >I can give you a swf to step through. I’m willing to spend a little time looking into it. Probably not until this evening (8 hours or so from now). -Alex

Re: To FlexJS or not to FlexJS

2014-11-06 Thread Harbs
Thanks for your insights. FWIW, there’s three approaches out there for JS text engines. Google uses DOM (each character is a separate div absolutely positioned). Apple Pages uses the SVG approach you mention. Others use Canvas. All three of these methods require low-level handling of selections

Re: TextFlowLine recycling

2014-11-06 Thread Joel Marks
I think the root of the problem is that BaseCompose.createTextLine() is returning null. The only reason why that would happen is if the line couldn't fit in the space provided. I am not sure why ComposeState.composeNextLine() is trying to do _curLine.getTextLine(true) when the textLine is null. I w

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
It’s all checked in to the tables branch. I can give you a swf to step through. On Nov 6, 2014, at 10:18 PM, Alex Harui wrote: > > > On 11/6/14, 12:09 PM, "Harbs" wrote: > >> Yes. It’s very reproducible. >> >> Not small at all… :-( >> >> It would be considerable work to try to put togethe

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
On 11/6/14, 12:09 PM, "Harbs" wrote: >Yes. It’s very reproducible. > >Not small at all… :-( > >It would be considerable work to try to put together a test case for this. Can the current SWF you are debugging be made public so I can run it in a debugger, or do I need accounts, password, etc? I

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
Yes. It’s very reproducible. Not small at all… :-( It would be considerable work to try to put together a test case for this. On Nov 6, 2014, at 9:41 PM, Alex Harui wrote: > Do you have a 100% reproducible test case? How small is it? > > On 11/6/14, 11:31 AM, "Harbs" wrote: > >> If someone

Re: To FlexJS or not to FlexJS

2014-11-06 Thread Joel Marks
@Harbs we are in a very similar position. Unfortunately we have kind of given up on Flex but the grass hasn't been very green on the other side. Our production application which uses our custom version of TLF 1 is still all in Flex. But, we have a viewer that is in JS which i

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
Do you have a 100% reproducible test case? How small is it? On 11/6/14, 11:31 AM, "Harbs" wrote: >If someone has the time to walk through this with me off-list, that would >be very helpful. I’d really like an extra set of eyeballs to make sure >I’m not missing something with this and I don’t bl

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
If someone has the time to walk through this with me off-list, that would be very helpful. I’d really like an extra set of eyeballs to make sure I’m not missing something with this and I don’t blow things up. I don’t have a good enough grasp on exactly how the management of TextFlowLines is supp

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
I think my explanation might be more helpful, but here: TypeError: Error #1009: Cannot access a property or method of a null object reference. at flashx.textLayout.compose::TextFlowLine/http://ns.adobe.com/textLayout/internal/2008::recreateTextLine()[/Users/harbs/Documents/ApacheFlex/fle

Re: TextFlowLine recycling

2014-11-06 Thread Joel Marks
What was the stack trace? On Thu, Nov 6, 2014 at 11:29 AM, Harbs wrote: > > On Nov 6, 2014, at 7:15 PM, Alex Harui wrote: > > > My memory is a bit fuzzy. I thought TextLine recycling wasn’t > > per-paragraph, or is there a TextBlock per paragraph? > > There’s generally one TextBlock per paragr

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
On 11/6/14, 12:51 AM, "Justin Mclean" wrote: >Hi, > >> If trustContent=false, the SWFLoader doesn’t know it loaded another Flex >> SWF. There is code in SWFLoader that tries to size loaded Flex SWFs >> differently than other SWFs. > >From what I can see (but not 100% sure) it's loadForCompatib

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
On 11/6/14, 1:04 AM, "Harbs" wrote: >Did you try this? >http://blog.techhit.com/551102-how-to-prevent-outlook-2010-and-2013-from-a >dding-line-breaks-to-sent-plain-text-messages Seems to be for Windows. I’m on Mac and already have that option set. I spent 20 minutes searching the internet.

Re: TextFlowLine recycling

2014-11-06 Thread Harbs
On Nov 6, 2014, at 7:15 PM, Alex Harui wrote: > My memory is a bit fuzzy. I thought TextLine recycling wasn’t > per-paragraph, or is there a TextBlock per paragraph? There’s generally one TextBlock per paragraph. My table work was actually quite difficult because there was an assumption in ma

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
Hi, thanks for pointing that out. Maybe we need to update the README to mention the upstream dependency on Squiggly? Does anybody know why we can build Squiggly apps with missing classes? Usually the compiler/linker complains first. -Alex On 11/6/14, 1:04 AM, "Gowtham S" wrote: >Dear All, >I'

Re: TextFlowLine recycling

2014-11-06 Thread Alex Harui
My memory is a bit fuzzy. I thought TextLine recycling wasn’t per-paragraph, or is there a TextBlock per paragraph? The doc says that TextBlock.createTextLine/recreateTextLine returns null if the TextBlock is empty or if the width specified is less than the width of the next element, and to check

Re: [mustella] all recent SDK tests failed

2014-11-06 Thread Alex Harui
Yup, time to try moving the window again. I’m not near my RDP computer today. Can you do it? -Alex On 11/6/14, 2:25 AM, "Tom Chiverton" wrote: >The last two runs had 386 bitmap failures >http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/lastFailedBuild/co >nsole >which can not be correct

Re: [mustella] all recent SDK tests failed

2014-11-06 Thread Tom Chiverton
The last two runs had 386 bitmap failures http://flex-mustella.cloudapp.net/job/flex-sdk_mustella/lastFailedBuild/console which can not be correct. Tom On 04/11/14 17:14, Tom Chiverton wrote: Ahh, cool. I minimised the Jenkins status window too, just in case. Still an hour to run and I'm just

TextFlowLine recycling

2014-11-06 Thread Harbs
I ran into an issue where I have a runtime error in TextFlowLine.getTextLine(). I’m having trouble stepping through things, but as best as I can figure, the issue is caused by the umber of lines in a paragraph becoming reduced. The RTE happens inside TextFlowline.recreateTextLine() after request

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Harbs
Did you try this? http://blog.techhit.com/551102-how-to-prevent-outlook-2010-and-2013-from-adding-line-breaks-to-sent-plain-text-messages On Nov 6, 2014, at 10:30 AM, Alex Harui wrote: >> PS Any chance you can format your email so that the URL don't break over >> lines and thus result in 404s? >

RE: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Gowtham S
Dear All, I'm seeing one more Error in Spell check example of tour the flex while clicking on check spelling on both mx and spark versions. In Internet explorer 11 with Flash Player 14. ERROR: -- VerifyError: Error #1014: Class com.adobe.linguistics.spelling::UserDictionary could not be

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, > If trustContent=false, the SWFLoader doesn’t know it loaded another Flex > SWF. There is code in SWFLoader that tries to size loaded Flex SWFs > differently than other SWFs. From what I can see (but not 100% sure) it's loadForCompatibility not trustContent. Setting loadForCompatibility to

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, > Any URL I type is not a link at the point I hit send, it is just plain text. > And most email clients treat anything starting with "http://"; as a link, which breaks as some of your links are broken over two lines. Simple fix is to not break the text over multiple lines. > I may have

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
On 11/6/14, 12:08 AM, "Justin Mclean" wrote: >Hi, > >> The Marshall Plan [3] was the nickname for multi-version support in Flex >> [4][5] that also solved communicating between sandboxed applications. > >Tour De Flex has no need for communication between it and any 3rd party >app it loads so th

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Alex Harui
Going to try to consolidate this thread a bit. On 11/5/14, 11:53 PM, "Justin Mclean" wrote: >Hi, > >> The Ardisia example sizing problem feels like a SecurityDomain issue. >> After you force a resize with the divided box, the app scales down to >>fit >> instead of resizing. Third-party content

Re: [DISCUSSION] TourDeFlex 1.2 RC 0

2014-11-06 Thread Justin Mclean
Hi, > The Marshall Plan [3] was the nickname for multi-version support in Flex > [4][5] that also solved communicating between sandboxed applications. Tour De Flex has no need for communication between it and any 3rd party app it loads so that's not a requirement here. From looking at the SWFLo