RE: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Maurice Amsellem
I don't understand. Doesn't the current RC1 correspond to the contents of branch remote/release 4.11.0 ? Maurice -Message d'origine- De : Erik de Bruin [mailto:e...@ixsoftware.nl] Envoyé : lundi 14 octobre 2013 08:49 À : dev@flex.apache.org Objet : Re: [DISCUSSION] Apache Flex 4.11.0 R

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Erik de Bruin
Alex, The RC hasn't changed. All fixes made since the RC failed the tests (and the changes to the tests) are NOT part of the release that we are currently voting on. What makes you change your vote? EdB On Mon, Oct 14, 2013 at 7:03 AM, Alex Harui wrote: > For some reason, the 3rd test passed

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Erik de Bruin
That fix isn't in the RC currently being VOTE-d on... EdB On Mon, Oct 14, 2013 at 8:47 AM, Maurice Amsellem wrote: > Release Notes: > Missing : > FLEX-33813 Datagrid goes blank when assigning new dataProvider.source > and calling refresh > > Maurice > > -Message d'origine- > De :

RE: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Maurice Amsellem
Release Notes: Missing : FLEX-33813 Datagrid goes blank when assigning new dataProvider.source and calling refresh Maurice -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : lundi 14 octobre 2013 07:24 À : dev@flex.apache.org Objet : Re: [DISCUSSION]

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Erik de Bruin
Hi, I've done all the pre-voting tests on RC1 (sig check, compile, checkintests, build for IDE, loaded in FB, compiled several small and large projects) and it all seems to check out... However (yes, here we go again), since there have been several commits made to both develop AND release branch s

Re: [VOTE] Apache Flex 4.11.0 release candidate 1

2013-10-13 Thread Erik de Bruin
Changing my vote to: -0 (binding) EdB On Mon, Oct 14, 2013 at 7:10 AM, Alex Harui wrote: > +1 (binding) > > Repaired some mustella tests and re-ran some others and no failures on the > main runs. (did not run mobile or air tests since they are passing on CI). > > Source kits built and passed

Feedback on Apache Flex 4.11.0 RC1

2013-10-13 Thread Justin Mclean
Hi, I'd like to see a little more feedback (even of the informal type) on RC1. Has anyone tried it out, have any feedback good or bad? There might be an issue with the 480 and 640 dpi skins - have anyone had a play with them? Thanks, Justin PS Reviewing and voting (even if it's not binding) o

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, Thanks for voting +1 Alex, but there has to be something wrong with it, it would be unusual for first RC to pass :-) I need to look at the mobile skins in a little more detail and may actually vote -1 depending on what that turns up. The mobile DPI test pass which is a start. As we're not

Re: [VOTE] Apache Flex 4.11.0 release candidate 1

2013-10-13 Thread Alex Harui
+1 (binding) Repaired some mustella tests and re-ran some others and no failures on the main runs. (did not run mobile or air tests since they are passing on CI). Source kits built and passed checkintests and mustella -all on Mac and Win. Signatures match. Rat report clean. README and RELEASE_NOT

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
For some reason, the 3rd test passed tonight, and the two mx/states/Transition failures on Windows which did not pass this morning passed tonight. So now, I can submit my vote. On 10/13/13 9:58 PM, "Justin Mclean" wrote: >Hi, > >> Anyway, I fixed the tests and they passed for me on both Mac and

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, > Anyway, I fixed the tests and they passed for me on both Mac and Win. All good - so in theory we have no failing tests now right? Does the 3rd test you had failing (and doesn't for me) also have the same embed font issue? Thanks, Justin

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
I'm guessing they were developed on Windows so they passed there if the player handled the device fonts the same way, which happens often, but not all the time. But why we started seeing these now, I don't know. It is a small test so maybe it gets skipped on occasion. Anyway, I fixed the tests a

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, > Turns out it's a new test SWF and doesn't have fonts embedded. So yes, > these two were faulty tests. So how could they pass on windows or before? Seems odd they would suddenly start failing for no reason. Thanks, Justin

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
Turns out it's a new test SWF and doesn't have fonts embedded. So yes, these two were faulty tests. -Alex On 10/13/13 8:44 PM, "Alex Harui" wrote: >Just starting to dig. I'll keep the FTETextField idea in mind. I thought >you said it passed for you? How did you get it to fail this time? Di

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, > Just starting to dig. I'll keep the FTETextField idea in mind. I thought > you said it passed for you? How did you get it to fail this time? Did > you change player versions or something? It was passing for me over he weekend, but I've changed player versions since then. Justin

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
Just starting to dig. I'll keep the FTETextField idea in mind. I thought you said it passed for you? How did you get it to fail this time? Did you change player versions or something? -Alex On 10/13/13 7:08 PM, "Justin Mclean" wrote: >Hi, > >> [java]

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, > [java] = > [java]Failed: > [java] = > [java] > components/AdvancedDataGrid/Styles/advanceddatagrid_styles_FLEX_32848 > style_textSelectedColor_singleRow Failed Compa

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, Can only reproduce 2 here when running 11.9. [java] = [java] Failed: [java] = [java] components/AdvancedDataGrid/Styles/advanceddatagrid_styles_FLEX_32848 style_t

Re: Need help on https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank)

2013-10-13 Thread Alex Harui
Makes sense to me. -Alex On 10/13/13 5:24 PM, "Maurice Amsellem" wrote: >Hi Alex, > >I implemented the fix with flag and invalidateList. > >Two remarks on the fix: > >>Maybe I'm not understanding. My recommendation is to change >>dataprovder_collectionChangeHandler to set a flag and have >>upda

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
Actually, 3 failures on Mac [java] components/AdvancedDataGrid/Styles/advanceddatagrid_styles_FLEX_32848 style_textSelectedColor_singleRow Failed CompareBitmap(body:step 3) compare returned-4 [java] components/AdvancedDataGrid/Styles/advanceddatagrid_styles_FLEX_32848 style_textSelect

RE: FLEX-33806 and spark Alert implementation

2013-10-13 Thread Maurice Amsellem
>That might be a flaw in the design. I think other Spark components have a >content property that can take a textFlow. >Then it is left to the skin designer to grab the right property from the model >and display it in the view/skin. Shouldn't that be done in the hostComponent (eg. in partAdde

RE: Need help on https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank)

2013-10-13 Thread Maurice Amsellem
Hi Alex, I implemented the fix with flag and invalidateList. Two remarks on the fix: >Maybe I'm not understanding. My recommendation is to change >dataprovder_collectionChangeHandler to set a flag and have updateDisplayList >check that flag > and call updateCaretForDataProviderChange. DONE f

RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

2013-10-13 Thread Maurice Amsellem
Fixed and pushed to develop -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : lundi 14 octobre 2013 01:49 À : dev@flex.apache.org Objet : RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (Da

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, Looks there there's a couple of issues that need to be sorted - try this out: http://ns.adobe.com/mxml/2009"; xmlns:s="library://ns.adobe.com/flex/spark" applicationDPI="640">

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, > I don't think Combobox is supposed to work with mobile. Ah well that could be my issue then - was a just quick test I put to together to see if there's any obvious issues. You might want to double check button sizes (they are possible too large at 640 dpi) and the popup window close but

RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

2013-10-13 Thread Maurice Amsellem
Ok -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : lundi 14 octobre 2013 01:46 À : dev@flex.apache.org Objet : Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolle

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread OmPrakash Muppirala
On Oct 13, 2013 4:33 PM, "Justin Mclean" wrote: > > Hi, > > Tested on OSX. > -MD5 and sigs check out (the new check_sigs.sh in build can help out here) > - Can compile source code (OSX/Java 1.7) > - README, RELEASE_NOTES and NOTICE all in good shape. > - Rat report says no bad licences. > - Turned

Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

2013-10-13 Thread Justin Mclean
Hi, > So should I discard the temp fix until it's done ? Only if you can't fix it in time for the next RC. Justin

RE: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

2013-10-13 Thread Maurice Amsellem
Hi, This is a temp fix I let by mistake and was working on it now. The fix is OK, but not optimal,because it's using validateNow(). According to Alex, it should be fixed using flags and invalidateDisplayList(). (cf. email on 10/11@18:46 CET Re: Need help on https://issues.apache.org/jira/brow

Re: [1/4] git commit: [flex-sdk] [refs/heads/develop] - FIX https://issues.apache.org/jira/browse/FLEX-33813 (DataGrid goes blank when scrolled and dataProvider is changed )

2013-10-13 Thread Justin Mclean
Hi, Is the validateNow() required? Justin

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
Hi, Tested on OSX. -MD5 and sigs check out (the new check_sigs.sh in build can help out here) - Can compile source code (OSX/Java 1.7) - README, RELEASE_NOTES and NOTICE all in good shape. - Rat report says no bad licences. - Turned into usable SDK via build scripts (not installer). Added AIR 3.9.

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Justin Mclean
HI, > OK, my mustella runs have finished. I have two mx/states/Transition > failures on Windows and two ADG failures on Mac. Mind posting what the failure are? The ADG tests run clean here. Given that there very little difference with windows and OS in terms of SDK code it more likely to be a

RE: Mustella tests failing and release candidates

2013-10-13 Thread Frédéric THOMAS
Erik, Did you setup an external address for Jenkins or I need to log on your VM in order to see how you configured the builds ? I want to setup my VM to run some of them or at least the RCs based on what you did. Thanks, -Fred -Message d'origine- De : Erik de Bruin [mailto:e...@ixsoftwa

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Alex Harui
OK, my mustella runs have finished. I have two mx/states/Transition failures on Windows and two ADG failures on Mac. I'll try to investigate them this evening if nobody beats me to it. -Alex On 10/11/13 5:16 PM, "Justin Mclean" wrote: >Hi, > >Please place all discussion around the release can

Re: Getting image for failed Mustella test

2013-10-13 Thread Alex Harui
Use an image editor to see where that pixel is. It should be in a solid fill not some antialias edge. If on an edge try to change to a solid fill. Sent via the PANTECH Discover, an AT&T 4G LTE smartphone. Tom Chiverton wrote: On Sunday 13 October 2013 09:10:14 Maurice Amsellem wrote: > Not

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Nicholas Kwiatkowski
Sorry, read into the source a bit more -- looks like it is the font support, not Batik. On Sun, Oct 13, 2013 at 9:57 AM, Nicholas Kwiatkowski wrote: > During a build from source with the ANT script, we are still prompting for > acceptance for a non-compatible license for what seems to be Batik.

Re: Flex is doing good!

2013-10-13 Thread Avi Kessner
I'm a bit perplexed by the notion that inkscape can help someone correct CSS percentages, or x,y values for flex components when the border gets drawn on the outside of the boundaries or on the center of it, or when a half pixel gets rounded up vs rounded down. brought to you by the letters A, V,

Re: [DISCUSSION] Apache Flex 4.11.0 RC 1

2013-10-13 Thread Nicholas Kwiatkowski
During a build from source with the ANT script, we are still prompting for acceptance for a non-compatible license for what seems to be Batik. We then proceed to download Batik from an Apache web server. Is Batik still covered by the Adobe license? (I think the prompt is for Batik -- the prompt d

Re: Mustella tests failing and release candidates

2013-10-13 Thread Nicholas Kwiatkowski
I personally have a lot less time on the weekends as well. It would help me out by extending it so the vote does not primarily occur during a weekend. -Nick On Sun, Oct 13, 2013 at 12:41 AM, Justin Mclean wrote: > Hi, > > > IIRC, there is precedence for extending the vote past 72 hours when it

Re: Mustella tests failing and release candidates

2013-10-13 Thread Erik de Bruin
If we don't change anything, everything will remain the same. EdB On Sunday, October 13, 2013, Justin Mclean wrote: > Hi, > > > MORE releases means LESS work? > Yes 4.9 has a huge effort because we left it so long, it we had had a few > releases along the way the total effort would of been les

Re: Mustella tests failing and release candidates

2013-10-13 Thread Justin Mclean
Hi, > MORE releases means LESS work? Yes 4.9 has a huge effort because we left it so long, it we had had a few releases along the way the total effort would of been less IMO. The longer we leave it between releases the more work it takes (it's not linear) and the less likely someone will take o

Re: Mustella tests failing and release candidates

2013-10-13 Thread Erik de Bruin
>> You tell us the current release workflow is too much work and to fragile. > What I would like to do is make release less effort and try and reduce the > number of release candidates and release more frequently. IMO that's the best > way to reduce the workload on the release manager. That and s

RE: Getting image for failed Mustella test

2013-10-13 Thread Frédéric THOMAS
If you did a "./mini_run.sh -createImages", revert it and use the ImageDiffAIR app in sdk\mustella\utilities , you'll need to build it first. -Fred -Message d'origine- De : Tom Chiverton [mailto:t...@apache.org] Envoyé : dimanche 13 octobre 2013 10:25 À : dev@flex.apache.org Objet : Gett

RE: Mustella tests failing and release candidates

2013-10-13 Thread Frédéric THOMAS
> 2) once all contributions have landed, cut the release branch; switch > all Jenkins jobs and Mustella runs to 'release'; leave the release > branch alone for 2 days so Mustella can be run in all configs. Wouldn't it be better if we didn't have to manually switch all of the Jenkins jobs? And the

Re: Getting image for failed Mustella test

2013-10-13 Thread Tom Chiverton
On Sunday 13 October 2013 09:10:14 Maurice Amsellem wrote: > Not all tests are generating full bitmap compares. Okay... but I don't want to put the different value in as OK (well, OK if you are on Linux, how ever you do that) unless I can tell what is meant to be there are that point. -- Tom

RE: Mustella tests failing and release candidates

2013-10-13 Thread Maurice Amsellem
> Wouldn't it be better if we didn't have to manually switch all of the > Jenkins jobs? Isn't it possible to have duplicate Jenkins job, on the release and develop, run at the same time? I know this is possible with SVN, as you can check-out the branch that you are interested in, but maybe it's

Re: building flex sdk

2013-10-13 Thread Lee Burrows
Thanks Justin On 13/10/2013 10:01, Justin Mclean wrote: Hi, Can the 4.11 SDK (or earlier) be built with Java JDK 1.7 yet? Or is it still 1.5/1.6 only? JDK 1.7 is fine. Justin -- Lee Burrows ActionScripter

RE: Getting image for failed Mustella test

2013-10-13 Thread Maurice Amsellem
Not all tests are generating full bitmap compares. The error message says: dg1 pixel at (15,35) ED1B24 != 0xEC1C24 So it seems to be doing a one-pixel check Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : dimanche 13 octobre 2013 10:37 À

Re: Mustella tests failing and release candidates

2013-10-13 Thread Tom Chiverton
On Sunday 13 October 2013 19:58:27 Justin Mclean wrote: > Wouldn't it be better if we didn't have to manually switch all of the > Jenkins jobs? For sure. The 'heads up, release coming email' could serve as a reminder to stop landing patches on develop until the release was done ? -- Tom

Re: building flex sdk

2013-10-13 Thread Justin Mclean
Hi, > Can the 4.11 SDK (or earlier) be built with Java JDK 1.7 yet? Or is it still > 1.5/1.6 only? JDK 1.7 is fine. Justin

Re: Mustella tests failing and release candidates

2013-10-13 Thread Justin Mclean
Hi, > You tell us the current release workflow is too much work and to fragile. What I would like to do is make release less effort and try and reduce the number of release candidates and release more frequently. IMO that's the best way to reduce the workload on the release manager. That and sha

building flex sdk

2013-10-13 Thread Lee Burrows
Hi All, Can the 4.11 SDK (or earlier) be built with Java JDK 1.7 yet? Or is it still 1.5/1.6 only? Thanks, -- Lee Burrows ActionScripter

Re: Getting image for failed Mustella test

2013-10-13 Thread Tom Chiverton
On Sunday 13 October 2013 08:37:07 Maurice Amsellem wrote: > Look for a file same name but ending with .bad.png in one of the Baselines > sub-dir in components/DataGrid/DataGrid_HaloSkin/Integration/ falken@wopr:~/workspace/flex-sdk-source$ find /home/falken/workspace/flex-sdk- source-develop/ -in

Re: Mustella tests failing and release candidates

2013-10-13 Thread Tom Chiverton
On Sunday 13 October 2013 10:27:56 Erik de Bruin wrote: > It will take more > time, sure, but I don't think that is a bad thing in this case. Works for me. I'm not aware of a particular set of bugs/features or an active timebox or anything that pushes us to do a release every N weeks or whatever

RE: Getting image for failed Mustella test

2013-10-13 Thread Maurice Amsellem
Look for a file same name but ending with .bad.png in one of the Baselines sub-dir in components/DataGrid/DataGrid_HaloSkin/Integration/ -Message d'origine- De : Tom Chiverton [mailto:t...@apache.org] Envoyé : dimanche 13 octobre 2013 10:25 À : dev@flex.apache.org Objet : Getting image

RE: Failing mustella tests

2013-10-13 Thread Maurice Amsellem
>I haven't found an (easy) way to catch missing tests. Every once in a while >it skips an entire SWF. It appears like it launches it, but it takes too long >to launch and then >kills it, but it doesn't currently know what tests were in >that SWF so they don't go in the report. To see the diff

Re: Mustella tests failing and release candidates

2013-10-13 Thread Erik de Bruin
Justin, I'm lost. You tell us the current release workflow is too much work and to fragile. We suggest way to reduce the workload and make the process more robust... And you come back telling us the current workflow is the best way. What are we missing? What are you asking of us? I sure hope you

Getting image for failed Mustella test

2013-10-13 Thread Tom Chiverton
I am having a local test failure: [java] components/DataGrid/DataGrid_HaloSkin/Integration/datagrid_integration_halo dataGrid_integration_imageRendererReload_halo Failed AssertPixelValue(body:step 4) dg1 pixel at (15,35) ED1B24 != 0xEC1C24 How do I find the difference with the expected imag

Re: Mustella tests failing and release candidates

2013-10-13 Thread Justin Mclean
Hi, > How would this help with running Mustella tests on the release branch, > which is want Erik's point was? You don't you keep running them off develop - less effort for all involved I think that way. Merge often and there's less issues all round. For instance what happens if after several r

Re: Mustella tests failing and release candidates

2013-10-13 Thread Tom Chiverton
On Saturday 12 October 2013 21:30:51 Alex Harui wrote: > Another way to cut down on RCs may be to ask on the dev list before you > cut the RC. Again, you kind of know who might help you out and review the I'd find a heads up a few days before the the formal vote, as well as a longer voting perio

Re: Mustella tests failing and release candidates

2013-10-13 Thread Justin Mclean
Hi, > But all that merging back and forth is extra work for the release > manager. It not a huge amount of work if everyone does it and means there less likely to be merge issues. The 4.9 release had huge merge issue because we didn't merge often enough. Thanks, Justin

RE: Failing mustella tests

2013-10-13 Thread Maurice Amsellem
>What are the differences between bitmaps? If there is some pixel shifting, >that can cause the dragdrop to fail. 1) components/DataGrid/DataGrid_HaloSkin/Properties/datagrid_properties_lockedRowCount_halo_lockedRowCount_config3_unlockedToPopulatedLocked_multiple_halo Failed: Can't find the .b

Re: Mustella tests failing and release candidates

2013-10-13 Thread OmPrakash Muppirala
On Oct 12, 2013 11:48 PM, "Justin Mclean" wrote: > > Hi. > > > Also, I think it might be a good idea that if we include a 'prepare > > for RC' phase, I can switch the Mustella VM from the 'develop' branch > > to the 'RC' branch. > Wouldn't it be easier to just ask people to work in branches and no

Re: Mustella tests failing and release candidates

2013-10-13 Thread Erik de Bruin
>> Also, I think it might be a good idea that if we include a 'prepare >> for RC' phase, I can switch the Mustella VM from the 'develop' branch >> to the 'RC' branch. > Wouldn't it be easier to just ask people to work in branches and not commit > directly directly to develop unless they want it in

Re: Failing mustella tests

2013-10-13 Thread Alex Harui
Shouldn't be, but you never know. BTW, I ran into a household plumbing issue this evening and now I'm out of time. I'll review the README and RELEASE_NOTES tomorrow. Yes, you've been pre-empted by poop. On 10/12/13 11:28 PM, "Justin Mclean" wrote: >Hi, > >> Now it's worked 4 times in a row.