On Thu, Jan 19, 2023 at 7:07 PM Edwin Brossette
wrote:
>
> Hello,
>
Hi Edwin,
Thanks for reaching out, here's my attempt at answering your questions
> I am trying to operate a Broadcom BCM57414 2x10G nic using dpdk bnxt pmd. I
> use DPDK 22.11.
> However, doing so I stumbled over a number of dif
inimum size of RX buffer: 1
>> Maximum configurable length of RX packet: 9600
>> Maximum configurable size of LRO aggregated packet: 0
>> Maximum number of VMDq pools: 64
>> Current number of RX queues: 2
>> Max possible RX queues: 117
>> Max possible number of R
rte_unused)
>
> rte_eth_copy_pci_info(eth_dev, pci_dev);
> eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
> + eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
>
> bp = eth_dev->data->dev_private;
>
> --
> 2.35.0.4.g44a5d4affccf
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
Fix to clear the Rx FIFO while reading the timestamp.
If the Rx FIFO has pending bit set, keep reading to clear it
and return the last valid timestamp instead of unconditionally
returning an error.
Fixes: b11cceb83a34 ("net/bnxt: support timesync")
Cc: sta...@dpdk.org
Signed-off-b
t;net/bnxt: add Rx queue create/destroy")
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_rxq.c | 30 --
1 file changed, 30 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index 2b0d3d4ac7..
ecause David pointed me that these flags are still used by
> other projects. Adding an explicit RTE_DEPRECATED() would prevent this,
> and... it doesn't bother to add one more year :)
>
> Thank you for the review.
Acked-by Somnath Kotur
ame. The old flags remain usable, but a deprecation warning is issued
> > > at compilation.
> > >
> > > Signed-off-by: Olivier Matz
> >
> > Acked-by: Andrew Rybchenko
>
> Acked-by: Ajit Khaparde
> >
Acked-by: Somnath Kotur
> Suggested-by: Ferruh Yigit
> > Signed-off-by: Dmitry Kozlyuk
> Acked-by: Ajit Khaparde
>
Acked-by: Somnath Kotur
>
; Syntax fixed on lines that this patch touches.
> >
> > Signed-off-by: Ferruh Yigit
> > Acked-by: Tyler Retzlaff
> > Acked-by: Andrew Rybchenko
> > Acked-by: Ajit Khaparde
> > Acked-by: Jerin Jacob
> > Acked-by: Wisam Jaddo
> > Acked-by: Rosen Xu
> > Acked-by: Chenbo Xia
> > Acked-by: Hemant Agrawal
>
Acked-by: Somnath Kotur
somnath.ko...@broadcom.com
>
>
In bnxt_init_one_rx_ring(), reset this variable internal to the driver
ring to 0, so that there is no mismatch with actual value in HW on
traffic resumption.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-
/tf_ulp/ulp_utils.c
> > index df3afaa6fd..c60d81d14a 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_utils.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_utils.c
> > @@ -200,7 +200,6 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t len,
> > uint8_t *val)
> > {
> > int i;
> > int cnt = (len + 7) / 8;
> > - int tlen = len;
> >
> > /* Handle any remainder bits */
> > int tmp = len % 8;
> > @@ -211,12 +210,10 @@ ulp_bs_push_msb(uint8_t *bs, uint16_t pos, uint8_t
> > len, uint8_t *val)
> > ulp_bs_put_msb(bs, pos, tmp, val[0]);
> >
> > pos += tmp;
> > - tlen -= tmp;
> >
> > for (i = 1; i < cnt; i++) {
> > ulp_bs_put_msb(bs, pos, 8, val[i]);
> > pos += 8;
> > - tlen -= 8;
> > }
> >
> > return len;
>
> Review please.
Acked-by: Somnath Kotur
>
>
> --
> David Marchand
>
testpmd
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Signed-off-by: Ajit Khaparde
Reviewed-by: Ajit Khaparde
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 inser
alid settings being retrieved and configured in subsequent
application loads resulting in launch failures.
Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link")
Reported-by: Charlie Brtee
Reviewed-by: Ajit Khaparde
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_hwrm.c |
ummy ones set by bnxt_stop_rxtx() leading to crashes
in the data path (e.g. dereferencing freed structures)
Fix the segfault by updating the fast-path pointer as well
Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
Signed-off-by: Somnath Kotur
Rev
uot;)
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
---
drivers/net/bnxt/bnxt_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c1bdf9a921..f79f33ab4e 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++
- a/lib/ip_frag/rte_ipv6_fragmentation.c
> +++ b/lib/ip_frag/rte_ipv6_fragmentation.c
> @@ -90,7 +90,7 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in,
>
> /*
> * Ensure the IP payload length of all fragments (except the
> -* the last fragment) are a multiple of 8 bytes per RFC2460.
> +* last fragment) are a multiple of 8 bytes per RFC2460.
> */
>
> frag_size = mtu_size - sizeof(struct rte_ipv6_hdr) -
> diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h
> index b1bed13ee2..3b7be57d3e 100644
> --- a/lib/rawdev/rte_rawdev_pmd.h
> +++ b/lib/rawdev/rte_rawdev_pmd.h
> @@ -126,7 +126,7 @@ rte_rawdev_pmd_is_valid_dev(uint8_t dev_id)
> }
>
> /**
> - * Definitions of all functions exported by a driver through the
> + * Definitions of all functions exported by a driver through
> * the generic structure of type *rawdev_ops* supplied in the
> * *rte_rawdev* structure associated with a device.
> */
> --
> 2.25.1
>
Acked-by: Somnath Kotur
On Thu, Nov 25, 2021 at 5:23 PM Ferruh Yigit wrote:
>
> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote:
> > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was
> > introduced by [1]. This action provides an unified way
> > to perform various arithmetic and transfer operations over
> > pack
bnxt_alloc_hwrm_rings() was duplicating a snippet of code that was
already present in bnxt_alloc_hwrm_rx_ring() with just one line/function
invocation missing. Add that line and replace the snippet of code
with a call to bnxt_hwrm_alloc_rx_ring
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt
On Tue, Feb 28, 2023 at 2:30 PM Vita Batrla wrote:
>
> Hi all,
>
> I don't know where to report this nit. It's not a real bug and I don't want
> to even send a patch for it. I'm looking if someone could just fix it in
> the source code. Here's the problem:
>
> drivers/net/bnxt/bnxt_hwrm.c
>
>
}
> - rte_memcpy(((uint8_t *)&tenant_id_be + 1),
> - nvgre_spec->tni, 3);
> + memcpy(((uint8_t *)&tenant_id_be + 1),
> + nvgre_spec->tni, 3);
> filter->vni =
> rte_be_to_cpu_32(tenant_id_be);
> filter->tunnel_type =
> --
> 2.43.0
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
RTE_LOG_DP(ERR, PMD,
> - "Unhandled CMP type %02x\n",
> - CMP_TYPE(txcmp));
> + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n",
> CMP_TYPE(txcmp));
> raw_cons = NEXT_RAW_CMP(raw_cons);
> } while (nb_tx_pkts < ring_mask);
>
> --
> 2.42.0
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
e_ether_addr eth_addr;
> @@ -399,8 +399,8 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)
> eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
> ptp_hdr = (struct ptp_header *)(rte_pktmbuf_mtod(m, char *)
> + sizeof(struct rte_et
resource subtype and session id are passed in.
> * An identifier (previously allocated) corresponding to all these is
> - * freed, only after various sanity checks are completed.
> + * freed, only after various checks are completed.
> */
> /* hwrm_tfc_ident_free_input (size:192b/2
}
>
> - if (new_mtu > RTE_ETHER_MTU) {
> + if (new_mtu > RTE_ETHER_MTU)
> bp->flags |= BNXT_FLAG_JUMBO;
> - bp->eth_dev->data->dev_conf.rxmode.offloads |=
> - DEV_RX_OFFLOAD_JUMBO_FRAME;
> - } else {
> -
net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3025,7 +3025,7 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev,
> uint16_t new_mtu)
> uint32_t overhead = BNXT_MAX_PKT_LEN - BNXT_MAX_MTU;
> struct bnxt *bp = eth_dev->data->dev_private;
>
On Mon, Oct 4, 2021 at 10:42 AM Somnath Kotur
wrote:
>
> On Fri, Oct 1, 2021 at 8:07 PM Ferruh Yigit wrote:
> >
> > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.
> >
> > Instead of drivers announce this capability, application can deduct
7;s ability to deliver received metadata to the user
> > by virtue of mbuf fields should be covered by mbuf library.
> > It is also out of scope of the new API in question.
> >
> > Signed-off-by: Ivan Malov
> > Reviewed-by: Andrew Rybchenko
> > Reviewed-by: Andy Moreton
> > Acked-by: Ray Kinsella
> > Acked-by: Jerin Jacob
>
> Acked-by: Ajit Khaparde
Acked-by: Somnath Kotur
Rx/Tx size limitation,
> > Rx buffer is where to store Rx packets, many PMDs use mbuf data buffer
> > size as Rx buffer size.
> > PMDs compare MTU against Rx buffer size to decide enabling scattered Rx
> > or not. If scattered Rx is not supported by device, MTU bigger than Rx
> > buffer size should fail.
> >
> > Signed-off-by: Ferruh Yigit
> > ---
> > Cc: Min Hu (Connor)
> >
> > v2:
> > * Converted to explicit checks for zero/non-zero
> > * fixed hns3 checks
> > * fixed some sample app rxmode.mtu value
> > * fixed some sample app max-pkt-len argument and updated doc for it
> >
> > v3:
> > * rebased
> >
> > v4:
> > * fix typos in commit logs
>
> That's a lot of detail in the log. Thanks
>
> Acked-by: Ajit Khaparde
Acked-by: Somnath Kotur
mandatory, because flow API does not supply users with
> > capabilities, so
> > this is the only way for a user to learn that configuration is invalid. For
> > example, if queue count changes and the action of a flow rule specifies
> > queues
> > that are going away
tnic_flow.c
> b/drivers/net/softnic/rte_eth_softnic_flow.c
> index 27eaf380cd..39038d26d8 100644
> --- a/drivers/net/softnic/rte_eth_softnic_flow.c
> +++ b/drivers/net/softnic/rte_eth_softnic_flow.c
> @@ -1448,13 +1448,6 @@ flow_rule_action_get(struct pmd_internals *softnic,
> action,
> "COUNT: Null configuration");
>
> - if (conf->shared)
> - return rte_flow_error_set(error,
> - ENOTSUP,
> - RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> - conf,
> - "COUNT: Shared counters not
> supported");
> -
> if (n_count)
> return rte_flow_error_set(error,
> ENOTSUP,
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 7b1ed7f110..5306e8ca4b 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -75,7 +75,7 @@ extern "C" {
> * At least one direction must be specified.
> *
> * Specifying both directions at once for a given rule is not recommended
> - * but may be valid in a few cases (e.g. shared counter).
> + * but may be valid in a few cases.
> */
> struct rte_flow_attr {
> uint32_t group; /**< Priority group. */
> @@ -2498,24 +2498,11 @@ struct rte_flow_query_age {
> * Counters can be retrieved and reset through ``rte_flow_query()``, see
> * ``struct rte_flow_query_count``.
> *
> - * @deprecated Shared attribute is deprecated, use generic
> - * RTE_FLOW_ACTION_TYPE_INDIRECT action.
> - *
> - * The shared flag indicates whether the counter is unique to the flow rule
> the
> - * action is specified with, or whether it is a shared counter.
> - *
> - * For a count action with the shared flag set, then then a global device
> - * namespace is assumed for the counter id, so that any matched flow rules
> using
> - * a count action with the same counter id on the same port will contribute
> to
> - * that counter.
> - *
> * For ports within the same switch domain then the counter id namespace
> extends
> * to all ports within that switch domain.
> */
> struct rte_flow_action_count {
> - /** @deprecated Share counter ID with other flow rules. */
> - uint32_t shared:1;
> - uint32_t reserved:31; /**< Reserved, must be zero. */
> + uint32_t reserved; /**< Reserved, must be zero. */
> uint32_t id; /**< Counter ID. */
> };
>
> --
> 2.30.2
>
Acked-by: Somnath Kotur
.
> *
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index efd729c0f2..c516837723 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -245,6 +245,9 @@ EXPERIMENTAL {
> rte_mtr_meter_policy_delete;
> rte_mtr_meter_policy_update;
> rte_mtr_meter_policy_validate;
> +
> + # added in 21.11
> + rte_eth_dev_conf_get;
> };
>
> INTERNAL {
> --
Acked-by: Somnath kotur
> 2.25.1
>
variable would still point to a stale value.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt
Thank you Ferruh, have sent V2 with updated commit log, please see if it
sounds good now?
-Som
On Fri, Aug 20, 2021 at 6:17 PM Ferruh Yigit wrote:
> On 8/10/2021 7:07 AM, Somnath Kotur wrote:
> > In bnxt_init_one_rx_ring(), reset this variable internal to the driver
> > rin
point to a stale value.
Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v3: Updated commit log and summary as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c
.@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v4: Updated commit log as requested by Ferruh
v3: Updated commit log and summary as requested by Ferruh
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c | 3 +++
1 file changed, 3
.@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
v4: Updated commit log as requested by Ferruh
v3: Updated commit log and summary as requested by Ferruh
v2: Updated commit log as requested by Ferruh
drivers/net/bnxt/bnxt_rxr.c | 3 +++
1 file changed, 3
timesync adjust and write_time APIs needed to account for the Rx and Tx
timestamp counters as well. Fix it since it was not done earlier.
Fixes: b11cceb83a3 ("net/bnxt: support timesync")
Cc: sta...@dpdk.org
Reviewed-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Signed-off-b
Please apply the following fixes
Somnath Kotur (2):
net/bnxt: fix to return count in xstats get op in all cases
net/bnxt: fix Rx and Tx timestamp assignment
drivers/net/bnxt/bnxt_ethdev.c | 4
drivers/net/bnxt/bnxt_stats.c | 23 +--
2 files changed, 13 insertions
he actual stats populated by the driver.
Fixes: 063e59ddd28 ("net/bnxt: fix crash in xstats get")
Cc: sta...@dpdk.org
Reviewed-by: Kalesh Anakkur Purayil
Reviewed-by: Lance Richardson
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_stats.c | 23 +--
1 file cha
Reviewed-by: Kalesh Anakkur Purayil
Reviewed-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index
On Tue, Aug 2, 2022 at 8:33 AM Mao YingMing wrote:
>
Thanks for the patch
> From: maoyingming
>
> VFs's "bp->leds" is allways null, check bp->leds is
> not null before use bp->leds->num_leds.
Typo in 'always'
You can just say ' For VFs , bp->leds is uninitialized'
>
> segfault backtrace in trex p
On Tue, Aug 2, 2022 at 9:17 AM Mao YingMing wrote:
>
> For VFs, bp->leds is uninitialized, check bp->leds is
> not null before use bp->leds->num_leds.
Sorry for missing this the first time around, Rephrase it to say
'before checking for bp->leds->num_leds'
> segfault backtrace in trex program when
led_on)
> uint16_t duration = 0;
> int rc, i;
>
> - if (!bp->leds->num_leds || BNXT_VF(bp))
> + if (BNXT_VF(bp) || !bp->leds || !bp->leds->num_leds)
> return -EOPNOTSUPP;
>
> HWRM_PREP(&req, HWRM_PORT_LED_CFG, BNXT_USE_CHIMP_MB);
> --
> 1.8.3.1
>
Acked-by: Somnath Kotur
smime.p7s
Description: S/MIME Cryptographic Signature
the next one.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 19 +++
drivers/net/bnxt/bnxt_hwrm.h | 1 +
drivers/net/bnxt/bnxt_rxq.h | 1 +
drivers/net/bnxt/bnxt_rxr.c | 101 ++-
drivers/net/bnxt/bnxt_rxr.h
post
accounting for the spurious zero stat value.
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 45 +++
drivers/net/bnxt/bnxt_ethdev.c | 14
drivers/net/bnxt/bnxt_hwrm.c | 106 +
drivers/net/bnxt/bnxt_h
Hi Owen,
Thank you for the heads up. I still could not figure out how
to reproduce this though, i did not run into any issue on my end and i
tried launching testpmd with similar cmdline parameters as specified here
in the log(TestNicSingleCorePerf) , but no luck
In any case, looks lik
post
accounting for the spurious zero stat value.
Signed-off-by: Somnath Kotur
Reviewed-by: Lance Richardson
Reviewed-by: Kalesh AP
---
v2:
- Sum counters across ALL rings for function stats instead of the ones
reported for
- Allocate/free the previous ring stats(Rx/Tx) in dev_start
Hi
Any idea on the ETA for this patch? I'm presuming it's all good to be
pulled into the mainline otherwise?
Thanks
Som
On Thu, Jun 6, 2013 at 3:03 AM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Wed, 05 Jun 2013 20:05:15 +0200
> Damien Millescamps wrote:
>
> > On 06/05/201
Hi,
What's the best approach to go about this ? Try and roll out user space
equivalents of the above calls (to issue mailbox commands to configure the
H/W- another 10G NIC )
OR
Use kernel memory allocated in the UIO Driver and mmap it in the
PMD/usermode driver ?
Pls advise or offer any sugges
Hi,
Pls pardon me if this has been asked/addressed in another thread. Just
wanted to know what i need to do if i wanted to plumb my non-Intel 10G NIC
into the DPDK , For instance just into the test-pmd framework would also be
fine ?
Any pointers /tips welcome?
Thanks
Som
-- next part
Pass 'eth_da' pointer instead of pass by value to
bnxt_rep_port_probe()
Coverity issue: 360841
Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnx
Check and log an error message if switch domain free API fails
Coverity issue: 362757
Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
Cc: sta...@dpdk.org
Signed-off-by: Somnath Kotur
Reviewed-by: Kalesh Anakkur Purayil
---
drivers/net/bnxt/bnxt_eth
Hello,
I'm trying to launch a thread - lcore_mainloop( from
examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd
to ensure the timers i've registered in my driver are checked for expiry (
i even tried putting this thread in my driver as well, no difference in
results
On Fri, Nov 2, 2018 at 9:30 AM Somnath Kotur
wrote:
> Hello,
>I'm trying to launch a thread - lcore_mainloop( from
> examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd
> to ensure the timers i've registered in my driver are checked for ex
Thank you Anatoly and keith for your replies. What i still don't get is why
the two cannot seem to co-exist?
That is , whenever this while loop was running in the EAL thread that i
showed in the code, my driver would stop receiving interrupts/async events
...Do we understand that?
But you are righ
t was before
with rte_timer_manage() as well.
What is going wrong here ? Something we are missing ?
Thanks
Som
On Sat, Nov 3, 2018 at 8:06 AM Somnath Kotur
wrote:
> Thank you Anatoly and keith for your replies. What i still don't get is
> why the two cannot seem to co-exist?
> That
/interrupts arriving
on my driver
Thanks
Som
On Sat, Nov 3, 2018 at 9:58 AM Somnath Kotur
wrote:
> Hi Anatoly/keith,
> I just tried using rte_eal_alarm_set() in the driver
> like so:
>
> rte_eal_alarm_set(US_PER_S * 2, timer0_cb, (void *)data);
>
> Th
Hi Dekel,
Could you please show with an example i.e how the corresponding
'flow create' cmd will look like in testpmd?
Also I'm guessing you would need to change the cmdline_parser logic in
testpmd application as well to recognize this new rte_flow_item?
Thanks
Som
On Wed, Aug 29, 2018 at
Hi Ferruh,
On Fri, Mar 23, 2018 at 12:16 AM, Ferruh Yigit
wrote:
> On 2/22/2018 2:58 AM, Somnath Kotur wrote:
>
> Please start with lowercase after "net/bnxt: fix"
>
> > When user reissues same flow director cmd with a different queue
> > update the existing
On Fri, Mar 23, 2018 at 4:11 PM, Ferruh Yigit
wrote:
> On 3/23/2018 3:34 AM, Somnath Kotur wrote:
> > Hi Ferruh,
> >
> >
> > On Fri, Mar 23, 2018 at 12:16 AM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote:
> >
> > On 2/22/2018 2:5
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 46 --
1 file changed, 31 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 21c46f8..0b21653 100644
--- a/drivers/net/bnxt/bnx
Signed-off-by: Somnath Kotur
---
v2:
* Trimmed the subject line.
* Removed some redundant comments in the code
drivers/net/bnxt/bnxt_ethdev.c | 46 --
1 file changed, 31 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/driver
Implemented the 'time_sync' related APIs for supporting PTP.
Defined new FW structs, opcodes and cmds for the same.
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 49 +++
drivers/net/bnxt/bnxt_ethdev.c | 245 -
d
Implemented the 'time_sync' related APIs for supporting the PTP protocol.
Signed-off-by: Somnath Kotur
---
v2 Changes
- Updated bnxt.ini to announce 'timesync' feature
- Added code to correctly detect PTP in the pkt and set corresponding ol_flags
for PTP in Rx path
doc/
Thank you for your comments Ferruh!
Hope i got it right this time
Thanks
Som
On Tue, Dec 5, 2017 at 5:35 AM, Ferruh Yigit wrote:
> On 12/4/2017 4:03 PM, Ferruh Yigit wrote:
>> On 11/30/2017 12:13 AM, Somnath Kotur wrote:
>>> Implemented the 'time_sync' rel
Implemented the 'time_sync' related APIs for supporting the PTP protocol.
Signed-off-by: Somnath Kotur
---
v3 Changes
- Initialize the time counters correctly during timesync_enable
- Use correct flag to check for PTP in Rx completion
v2 Changes
- Updated bnxt.ini to announce 'ti
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 82c93d6..430990d 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -459,7
Sure , will do a response
Thanks
Som
On Feb 1, 2018 8:54 PM, "Ferruh Yigit" wrote:
> On 2/1/2018 5:09 AM, Somnath Kotur wrote:
>
> Hi Somnath,
>
> Can you please keep patch title brief (around 50 characters) and put more
> content in commit log?
>
&
The timestamp flag needed to be set in the offload flags
for the recieved pkt in case of PTP offload
Signed-off-by: Somnath Kotur
---
v1->v2: Trimmed subject line and added content in commit log
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
The timestamp flag needed to be set in the offload flags
for the received pkt in case of PTP offload
Signed-off-by: Somnath Kotur
---
v1->v2: Trimmed subject line and added content in commit log
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
The timestamp flag needs to be set in the offload flags
for the received pkt in case of PTP offload.
Fixes: b11cceb83a34 ("net/bnxt: support timesync")
Cc: somnath.ko...@broadcom.com
Signed-off-by: Somnath Kotur
---
v2->v3: Added the 'fixes commit line'
v1->v2: Trim
the filter in the scenario where there is a pattern match
and only the destination queue varies.
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/d
Ferruh,
Sorry, please ignore this patch, think i re-sent an old
one by mistake, sent out the new one now
Thanks
Som
On Wed, Feb 21, 2018 at 4:09 PM, Somnath Kotur
wrote:
> When user re-issues same 5 tuple filter pattern cmd with different
> destination queue, it would flag
When user reissues same flow director cmd with a different queue
update the existing filter to redirect flow to the new desired
queue as destination just like the other filters like 5 tuple and
generic flow.
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 45
PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
> + pools, nb_q_per_grp);
> start_grp_id = 0;
> end_grp_id = nb_q_per_grp;
>
> --
> 2.17.1
>
Acked-by: Somnath Kotur (somnath.ko...@broadcom.com
in mbuf->vlan_tci_outer.
Only When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2
vlans
have been stripped by the hardware and their tci are saved in mbuf->vlan_tci
(inner)
and mbuf->vlan_tci_outer (outer).
Signed-off-by: Somnath Kotur
Signed-off-by: JP Lee
On Mon, Dec 16, 2019 at 12:01 PM Andrew Rybchenko
wrote:
>
> On 12/16/19 6:16 AM, Somnath Kotur wrote:
> > Certain hardware may be able to strip and/or save only the outermost
> > VLAN instead of both the VLANs in the mbuf in a QinQ scenario.
> > To handle such case
is better to fallback to using the first valid
profile.
Fixes: 698aa7e95 ("net/bnxt: add code to determine the Tx COS queue")
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 44
driver
Please apply.
Santoshkumar Karanappa Rastapur (2):
net/bnxt: fix link failure during port toggle by increasing link wait
time
net/bnxt: fix non matching flow hitting filter rule
Somnath Kotur (4):
net/bnxt: fix to use first valid profile if lossy profile not found
net/bnxt: fix flow
: Somnath Kotur
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt.h| 10 ++
drivers/net/bnxt/bnxt_cpr.c| 2 +-
drivers/net/bnxt/bnxt_ethdev.c | 18 +-
3 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net
will be set while
creating the ntuple filter in hardware.
Signed-off-by: Santoshkumar Karanappa Rastapur
Reviewed-by: Somnath Kotur
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_flow.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt
filter that would have been created as part of an
n-tuple filter.
Also, decrement the l2_ref_cnt for a filter in the case of a filter
update as it would've bumped up previously in validate_and_parse_flow()
Fixes: a0800839 ("net/bnxt: handle flow flush handling")
Signed-off-by: Somnath
y
references")
Signed-off-by: Somnath Kotur
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_filter.h | 4
drivers/net/bnxt/bnxt_flow.c | 20 +---
drivers/net/bnxt/bnxt_hwrm.c | 14 +-
3 files changed, 26 insertions(+), 12 deletions(-)
diff --git
Now that L2 filters can be re-used for an n-tuple filter(s), delete
L2 filter as well so the reference count of an L2 filter (if reused)
can be decremented appropriately.
Fixes: 0ba82dee ("net/bnxt: fix to check for L2 filters that doesn't have any
references")
Signed-off-by
Given that we haven't heard any objection from anyone in a while on
this ...can we get this in please?
Thanks
On Mon, Dec 16, 2019 at 2:43 PM Andrew Rybchenko
wrote:
>
> On 12/16/19 11:47 AM, Somnath Kotur wrote:
> > On Mon, Dec 16, 2019 at 12:01 PM Andrew Rybchenko
> >
On Fri, Dec 27, 2019 at 8:20 PM Olivier Matz wrote:
>
> Hi,
>
> On Tue, Dec 24, 2019 at 12:53:21PM +0300, Andrew Rybchenko wrote:
> > On 12/24/19 6:16 AM, Somnath Kotur wrote:
> > > Given that we haven't heard any objection from anyone in a while on
> &g
Andrew,
On Tue, Dec 24, 2019 at 3:23 PM Andrew Rybchenko
wrote:
>
> On 12/24/19 6:16 AM, Somnath Kotur wrote:
> > Given that we haven't heard any objection from anyone in a while on
> > this ...can we get this in please?
>
> I'm sorry, but ha
->vlan_tci_outer.
Only When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2
VLANs have been stripped by the hardware and their TCI are saved in
mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).
Signed-off-by: Somnath Kotur
---
lib/librte_mbuf/rte_mbuf_co
On Thu, Jan 2, 2020 at 6:35 PM Andrew Rybchenko
wrote:
>
> Somnath,
>
> On 12/31/19 5:15 AM, Somnath Kotur wrote:
> > Andrew,
> >
> > On Tue, Dec 24, 2019 at 3:23 PM Andrew Rybchenko
> > wrote:
> >> On 12/24/19 6:16 AM, Somnath Kotur wrote:
> &g
Ferruh,
Will recheck and revert on
Thanks
Som
On Tue, 14 Jan 2020, 18:26 Ferruh Yigit, wrote:
> On 1/14/2020 5:14 AM, Ajit Khaparde wrote:
> > From: Somnath Kotur
> >
> > Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources
> > for the port can be
Ferruh,
On Thu, 16 Jan 2020, 16:50 Ferruh Yigit, wrote:
> On 1/14/2020 2:49 PM, Somnath Kotur wrote:
> > Ferruh,
> > Will recheck and revert on
>
> Hi Ajit,
>
> this is blocking the next-net-brcm tree to be pulled. Would you want to
> drop
> this patch from
action items
net/bnxt: use VF vnic when port action is for a VF rep port
Somnath Kotur (2):
net/bnxt: enable flow ctrl ops for the VF-rep device
net/bnxt: use byte/pkt count shift/masks from the device template
drivers/net/bnxt/bnxt.h|5 +
drivers/net/bnxt
From: Kishore Padmanabha
The vxlan encap and decap flows need to allocate the source
record property and populate the action fields during the
flow parsing.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Ajit Kumar Khaparde
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
From: Kishore Padmanabha
Add support for index opcode constant so that
parif configuration could be constant value.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_ulp/ulp_def_rules.c
From: Kishore Padmanabha
Add support for the vlan headers in the matching of the flow
patterns.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 20 +++---
drivers
From: Jay Ding
Change global cfg from tunneled to non-tunneled
HWRM cmds.
Signed-off-by: Jay Ding
Reviewed-by: Michael Wildt
Reviewed-by: Peter Spreadborough
Reviewed-by: Randy Schacher
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_core/tf_msg.c | 43
From: Kishore Padmanabha
Added validations to the ulp parser to validate the dpdk port id
and phy port index during the flow creation.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Michael Baucom
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_ulp
From: Kishore Padmanabha
Added support for negative conditional opcodes in the
mapper processing.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Michael Baucom
Signed-off-by: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_ulp
Reviewed-by: Ajit Kumar Khaparde
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/tf_core/tf_em_host.c | 2 +-
drivers/net/bnxt/tf_core/tf_msg.c | 75 +--
drivers/net/bnxt/tf_core/tf_session.c | 8
drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 2 +-
drivers/net
: Somnath Kotur
Signed-off-by: Venkat Duvvuru
---
drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
index b4bf431..2e310e0 100644
--- a/drivers
1 - 100 of 540 matches
Mail list logo
