[dpdk-dev] [PATCH] mempool/octeontx: fix error handling in initialization

2019-12-19 Thread kkanas
From: Krzysztof Kanas When octeontx_get_fpavf fails fpa pointer is used to get pool_stack_base, which is then freed. Coverity issue: 351263 Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation") Cc: pbhagavat...@marvell.com Signed-off-by: Krzysztof Kanas --- drivers/memp

[dpdk-dev] [PATCH] doc: thunderx: explain which PCI is secondary VF

2020-01-28 Thread kkanas
From: Krzysztof Kanas Thunderx-nic uses secondary VF's to provide more queues to DPDK. Current instructions explain the concept but don't show easy way to find which PCI id is primary and which is secondary VF's. Signed-off-by: Krzysztof Kanas --- doc/guides/nics/thunderx.rst | 48

Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest

2019-11-08 Thread kkanas
Hi David, Thanks for review, hopefully this patch will addresses most of the sutff. Rest I will address here. > > > + const char *procdir = "/proc/self/fd/"; > > self is a Linux thing. > This won't work on FreeBSD. IMHO original code didn't worked on FreeBSD as well. I have created funct

[dpdk-dev] [PATCH v3 1/3] test: fix timeout in flags autotest

2019-11-08 Thread kkanas
From: Krzysztof Kanas Test eal_flags_autotest times out on 64 ARM due to excessive calls to 'access' system call. While at it fix process_dup logic so it tests correct file path for opened fd's. Fixes: af75078fece3 ("first public release") Cc: intel.com Signed-off-by: Krzysztof Kanas --- app/

[dpdk-dev] [PATCH v3 2/3] test: move close files to separate function

2019-11-08 Thread kkanas
From: Krzysztof Kanas As iterating over opened files is different on Linux and FreeBSD move to separate function. Signed-off-by: Krzysztof Kanas --- app/test/process.h | 89 ++ 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/app/test/

[dpdk-dev] [PATCH v3 3/3] test: fix FreeBSD file closing function

2019-11-08 Thread kkanas
From: Krzysztof Kanas The FreeBSD was iterating over non existing procfs entries, where sysctl could give same information. Signed-off-by: Krzysztof Kanas --- app/test/process.h | 51 +- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/a

[dpdk-dev] [PATCH v4] net/bonding: fix selection logic

2019-11-13 Thread kkanas
From: Krzysztof Kanas Arrays agg_count and agg_bandwidth should be indexed by slave_id not by aggregator port_id. The new_agg_id should be chosen as slave_id from slaves table in different selection modes. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@in

[dpdk-dev] [PATCH] common/octeontx2: cleanup void returns

2019-07-08 Thread kkanas
From: Krzysztof Kanas mbox_unregister_vf_irq and mbox_unregister_pf_irq returns void value. mbox_unregister_irq also returns void. Clang with flags '-Wall -Wextra -pedantic' complains about: void function should not return void expression Signed-off-by: Krzysztof Kanas --- drivers/common/octe

[dpdk-dev] [PATCH v2] net/af_packet: add string error for system errors

2019-07-10 Thread kkanas
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 53 ++- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a

[dpdk-dev] [PATCH v3] net/af_packet: add string error for system errors

2019-07-12 Thread kkanas
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 53 ++- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a

[dpdk-dev] [PATCH] mk: disable flag for no packet member warning

2019-07-22 Thread kkanas
From: Krzysztof Kanas gcc prior 9 don't will add additional warning for unrecognized command line option, but only when there is some other warning in the code, e.g unused variable. Fixes: a385972c3675 ("mk: disable warning for packed member pointer") Cc: reshma.pat...@intel.com Signed-off-by:

[dpdk-dev] [PATCH] net/octeontx2: fix driver reconfiguration

2019-07-22 Thread kkanas
From: Krzysztof Kanas When configure returns error, e.g. in case not supported offloads (outer ip and sctp) driver released Rx,Tx queues. Then in case of correct configuration the driver could not start due to queues already released but the driver thought it was configured correctly. Secondly i

[dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration

2019-07-22 Thread kkanas
From: Krzysztof Kanas When configure returns error, e.g. in case not supported offloads (outer ip and sctp) driver released Rx,Tx queues. Then in case of correct configuration the driver could not start due to queues already released but the driver thought it was configured correctly. Secondly i

[dpdk-dev] [PATCH] net/bonding: fix stack overflow in selection logic

2019-07-30 Thread kkanas
From: Krzysztof Kanas Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id but those arrays are 8 entries long. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzysztof Kanas --- drivers/net/bonding/rte_eth_b

[dpdk-dev] [PATCH 2/2] net/bonding: fix selection logic

2019-08-05 Thread kkanas
From: Krzysztof Kanas Fix max_index to return uint16_t as it is valid slave_id type. Arrays agg_count and agg_bandwidth should be indexed by slave_id not by aggregator port_id. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzys

[dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in selection logic

2019-08-05 Thread kkanas
From: Krzysztof Kanas Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id but those arrays are 8 entries long. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzysztof Kanas --- drivers/net/bonding/rte_eth_b

[dpdk-dev] [PATCH] net/af_packet: set default blocksize to pagesize

2019-06-24 Thread kkanas
From: Krzysztof Kanas Kernel validates block size to be aligned to page size. Code works on platforms with page size 4k, but on others e.g. Arm64 fails with default parameters. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-- 1 file changed, 2 insertions(+

[dpdk-dev] [PATCH] net/af_packet: append system error to error msgs

2019-07-04 Thread kkanas
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 47 --- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a

[dpdk-dev] [PATCH v2] net/bonding: fix selection logic

2019-10-10 Thread kkanas
From: Krzysztof Kanas Arrays agg_count and agg_bandwidth should be indexed by slave_id not by aggregator port_id. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzysztof Kanas --- drivers/net/bonding/rte_eth_bond_8023ad.c | 15

[dpdk-dev] [PATCH v3] net/bonding: fix selection logic

2019-10-10 Thread kkanas
From: Krzysztof Kanas Arrays agg_count and agg_bandwidth should be indexed by slave_id not by aggregator port_id. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzysztof Kanas --- v3: * fix incorrect reabse v2: * rebase patch

[dpdk-dev] [PATCH] net/bonding: fix test bonding MAC assignment

2019-04-26 Thread kkanas
From: Krzysztof Kanas Fix test_set_bonded_port_initialization_mac_assignment so that it works after 're run' test_link_bonding. Fixes: f2ef6f21ee2e ("bond: fix mac assignment to slaves") Cc: declan.dohe...@intel.com Signed-off-by: Krzysztof Kanas --- app/test/test_link_bonding.c | 53

[dpdk-dev] [PATCH] mk: fix printing target name when build completes

2019-06-04 Thread kkanas
From: Krzysztof Kanas The configuration for native-linux-* targets is done using symbolic links, e.g config/defconfig_x86_64-native-linux-gcc which points to config/defconfig_x86_64-native-linuxapp-gcc. When configuring mk will output correct target based on RTE_CONFIG_TEMPLATE. When building m

[dpdk-dev] [PATCH] eal: fix spelling

2019-06-04 Thread kkanas
From: Krzysztof Kanas Fixes: a753e53d517b ("eal: add device event monitor framework") Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Krzysztof Kanas --- lib/librte_eal/common/include/rte_dev.h| 2 +- lib/librte_eal/common/include/rte_interrupts.h | 2 +-

[dpdk-dev] [PATCH 2/2] test/bonding: fix LSC timeout unit

2019-08-23 Thread kkanas
From: Krzysztof Kanas Fixes: 76d29903f5f5 ("bond: support link status interrupt") Cc: declan.dohe...@intel.com Signed-off-by: Krzysztof Kanas --- app/test/test_link_bonding.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/tes

[dpdk-dev] [PATCH 1/2] test/bonding: fix LSC related test cases

2019-08-23 Thread kkanas
From: Krzysztof Kanas On rare situation test_link_bonding test case fail due to timespec tv_nsec overflow, which causes pthread_cond_timedwait to return EINVAL and test to fail. Fixes: 76d29903f5f5 ("bond: support link status interrupt") Cc: declan.dohe...@intel.com Signed-off-by: Krzysztof Kan

[dpdk-dev] [PATCH] test: fix process dup fd close

2019-09-02 Thread kkanas
From: Krzysztof Kanas process_dup was intending to close it's own fd's but failed to do so Fixes: af75078fece3 ("first public release") Signed-off-by: Krzysztof Kanas Reviewed-on: https://sj1git1.cavium.com/14906 Reviewed-by: Amit Gupta Reviewed-by: Jerin Jacob Kollanukkaran Tested-by: Jerin

[dpdk-dev] [PATCH v2] test: fix process dup fd close

2019-09-02 Thread kkanas
From: Krzysztof Kanas process_dup was intending to close it's own fd's but failed to do so Fixes: af75078fece3 ("first public release") Signed-off-by: Krzysztof Kanas --- v2: * remove unnecessary commit msg information app/test/process.h | 40 +++- 1 file