RE: [PATCH v2 0/5] add TLS record processing security offload

2023-10-04 Thread Akhil Goyal
Hi Harry, Do you have any further comments on this series? Regards, Akhil > -Original Message- > From: Anoob Joseph > Sent: Tuesday, October 3, 2023 4:19 PM > To: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob Kollanukkaran ; Harry > van Haaren > Cc: Konstantin Ana

RE: [PATCH v4 0/7] cryptodev: support digest message in SM2

2023-10-09 Thread Akhil Goyal
> Subject: [PATCH v4 0/7] cryptodev: support digest message in SM2 > > This patch series fixes SM2 algorithm implementation to > support digest message as input along with plain message > as today. > > v4: > - code rebase on next-crypto > Added release notes for API changes introduced in 4/7 p

RE: [PATCH v2 0/5] add TLS record processing security offload

2023-10-09 Thread Akhil Goyal
d notification of the > same in rte_crypto_op (Harry) > - Use 8 bits reserved space in rte_crypto_op to pass content type from > application to PMD (in case of record write) and from PMD to > application (in case of of record read). TLS 1.3 has content type as > part of trail

RE: [PATCH v3 1/2] security: add fallback security processing and Rx inject

2023-10-09 Thread Akhil Goyal
ecurity processing. The API > would behave like a loopback but with the additional security > processing. > > Signed-off-by: Anoob Joseph > Signed-off-by: Vidya Sagar Velumuri > --- > v3: > * Resolved compilation error with 32 bit build Series Acked-by: Akhil Goyal Please add release notes for the new feature.

RE: [EXT] Re: [PATCH 1/2] ethdev: add IPsec event subtype range for PMD specific code

2023-10-10 Thread Akhil Goyal
ent type */ > > RTE_ETH_EVENT_IPSEC_UNKNOWN = 0, > > /** Sequence number overflow */ > > > > I don't see any problem to extend event subtype with custom error range, > @Akhil, @Anoob what do you think? I believe it is ok to add the custom error range. It is just that the user will need to check the negative values too, which I believe is ok. Acked-by: Akhil Goyal

RE: [PATCH v4 1/2] security: add fallback security processing and Rx inject

2023-10-10 Thread Akhil Goyal
> -Original Message- > From: Anoob Joseph > Sent: Tuesday, October 10, 2023 4:02 PM > To: Akhil Goyal ; Jerin Jacob Kollanukkaran > ; Konstantin Ananyev > Cc: Hemant Agrawal ; dev@dpdk.org; Vidya Sagar > Velumuri ; david.co...@intel.com; kai...@intel.com; > k

RE: [EXT] [PATCH v3 21/29] security: remove experimental flag from macsec

2023-10-19 Thread Akhil Goyal
> The rte_security API's for macsec were added in 22.11. > Therefore remove the experimental tag. > > There is also one helper function for setting packet > metadata that should have been marked internal. > > Signed-off-by: Stephen Hemminger Acked-by: Akhil Goy

RE: [EXT] Re: [PATCH] test/crypto: move some tests to driver-tests suite

2023-10-23 Thread Akhil Goyal
> Subject: [EXT] Re: [PATCH] test/crypto: move some tests to driver-tests suite > > External Email > > -- > On Wed, Oct 18, 2023 at 02:55:42PM +0200, David Marchand wrote: > > Some cryptodev driver specific tests were in the "dri

RE: [PATCH] test/pdcp: add data walkthrough test

2023-10-23 Thread Akhil Goyal
> Subject: RE: [PATCH] test/pdcp: add data walkthrough test > > > > > Enable data walkthrough test in combined mode. > > The test covers data size ranging from 0B to 9000B both inclusive. > > > > Signed-off-by: Aakash Sasidharan > > Acked-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

RE: [PATCH] app/test: add modexp group tests

2023-10-23 Thread Akhil Goyal
Hi Gowri, > Subject: [PATCH] app/test: add modexp group tests > > Add modexp tests for groups 5, 14, 15, 16, 17 and 18. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Can you rebase this patch so that CI can run?

RE: [PATCH] crypto/openssl: fix memory leaks in SM2 ops

2023-10-23 Thread Akhil Goyal
> Subject: [PATCH] crypto/openssl: fix memory leaks in SM2 ops > > Fix memory leaks in SM2 ops, as reported by valgrind. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 45 ++-- > 1 file changed, 26 insertions(+), 19 deletions

RE: [EXT] [PATCH v1] cryptodev: clarify usage of the block ciphers

2023-10-23 Thread Akhil Goyal
> Subject: [EXT] [PATCH v1] cryptodev: clarify usage of the block ciphers > > External Email > > -- > From: Arkadiusz Kusztal > > Some of the API comments incorrectly limited the usage of symmetric > crypto fields to block ciph

RE: [EXT] [PATCH v2] doc: update QAT kernel module entry

2023-10-23 Thread Akhil Goyal
> The Kernel Module entry for 2.0 devices was incorrect in the doc table. > Updated table with Kernel Module qat_4xxx. > > Fixes: f4eac3a09c51 ("common/qat: enable GEN4 b devices") > Cc: arkadiuszx.kusz...@intel.com > > Signed-off-by: Brian Dooley Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v3 14/19] cryptodev: use rte optional stdatomic API

2023-10-26 Thread Akhil Goyal
> Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API > > Signed-off-by: Tyler Retzlaff Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 06/19] ipsec: use rte optional stdatomic API

2023-10-26 Thread Akhil Goyal
> Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Akhil Goyal

RE: [PATCH v2 0/4] crypto/ccp cleanup

2022-10-13 Thread Akhil Goyal
Hi Sunil > For this series > > Below shared patches seems fine, verified on AMD platform works fine. > > crypto/ccp: fix IOVA handling > crypto/ccp: remove some dead code for UIO > crypto/ccp: remove some printf > > Now working on the "crypto/ccp: fix PCI probing" patch and will update on > th

RE: [v1] examples/fips_validation: remove unused include file

2022-10-13 Thread Akhil Goyal
> Subject: [v1] examples/fips_validation: remove unused include file > > Remove invoking include for sys/random.h which is not actually used > by app. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Squashed with original commit. Thanks.

RE: [EXT] [PATCH 1/3] net/iavf: fix security session destroy

2022-10-13 Thread Akhil Goyal
> Replace mempool_put with memset 0, the internal session memory block > is no longer allocated from a mempool > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > Cc: gak...@marvell.com > > Signed-off-by: Radu Nicolau > --- Acked-by: Akhil Goyal

RE: [EXT] [PATCH 3/3] net/txgbe: fix security session destroy

2022-10-13 Thread Akhil Goyal
> Replace mempool_put with memset 0, the internal session memory block > is no longer allocated from a mempool > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > Cc: gak...@marvell.com > > Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal

RE: [EXT] [PATCH 2/3] net/ixgbe: fix security session destroy

2022-10-13 Thread Akhil Goyal
> Replace mempool_put with memset 0, the internal session memory block > is no longer allocated from a mempool > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > Cc: gak...@marvell.com > > Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal

RE: [EXT] [PATCH v3 18/30] baseband/acc100: enable input validation by default

2022-10-13 Thread Akhil Goyal
> Enable validation functions by default and provide a new flag > RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without > validating input to save cycles. > > Signed-off-by: Hernan Vargas > > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/rte_acc100_pmd.c | 36 +-

RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11

2022-10-13 Thread Akhil Goyal
> Hernan Vargas (30): > baseband/acc100: fix ring availability calculation > baseband/acc100: add function to check AQ availability > baseband/acc100: memory leak fix > baseband/acc100: add LDPC encoder padding function > baseband/acc100: check turbo dec/enc input > baseband/acc100: che

RE: [EXT] [PATCH v3 24/30] baseband/acc100: rename ldpc encode function arg

2022-10-13 Thread Akhil Goyal
> Rename total_enqueued_cbs to total_enqueued_descs in the > enqueue_ldpc_enc_n_op_cb function. No functional impact. > Can you specify the reason for rename in description? > Signed-off-by: Hernan Vargas > > Reviewed-by: Maxime Coquelin

RE: [EXT] [PATCH v3 29/30] baseband/acc100: add workaround for deRM corner cases

2022-10-13 Thread Akhil Goyal
> Add function to support de-ratematch pre-processing for SW corner cases. > Please add more meaningful description. Title says adding workaround. You should explain the issue and then what is done in this patch. > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/acc_common.h |

RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11

2022-10-13 Thread Akhil Goyal
> > > Hernan Vargas (30): > > > baseband/acc100: fix ring availability calculation > > > baseband/acc100: add function to check AQ availability > > > baseband/acc100: memory leak fix > > > baseband/acc100: add LDPC encoder padding function > > > baseband/acc100: check turbo dec/enc input

RE: [EXT] [PATCH v2] common/qat: read hw slice configuration

2022-10-14 Thread Akhil Goyal
> Read slice configuration of QAT capabilities. > This will allow to recognize if specific hw function > is available on particular device. > > Signed-off-by: Arek Kusztal Spit the patch into 2. - common/qat for adding the function pointer and implementation - crypto/qat for calling that function

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-14 Thread Akhil Goyal
Hi Zhangfei, > Hi, Akhil > > On 2022/10/11 下午5:22, Akhil Goyal wrote: > >>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make > >>>> make all-recursive > >>>> make[1]: Entering directory '/home/gakhil/up/uadk' > >>&g

RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-14 Thread Akhil Goyal
> Hi Zhangfei, > > Hi, Akhil > > > > On 2022/10/11 下午5:22, Akhil Goyal wrote: > > >>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make > > >>>> make all-recursive > > >>>> make[1]: Entering directory '/home/gakh

crypto/uadk: introduce uadk crypto driver

2022-10-17 Thread Akhil Goyal
Hi everyone, We have a new crypto PMD submitted on ML (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei@linaro.org/) This PMD is dependent on an external library which needs to be cross compiled for ARM on x86. It mandatorily need "numactl" also cross-compiled and i

RE: [EXT] Re: crypto/uadk: introduce uadk crypto driver

2022-10-19 Thread Akhil Goyal
Hi Zhangfei, > Hi, Akhil > > On Mon, 17 Oct 2022 at 15:02, Akhil Goyal wrote: > > > > Hi everyone, > > > > > > > > We have a new crypto PMD submitted on ML > (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei@linaro.org

RE: [EXT] [PATCH v4 04/30] baseband/acc100: add LDPC encoder padding function

2022-10-20 Thread Akhil Goyal
> LDPC Encoder input may need to be padded to avoid small beat for ACC100. > Padding 5GDL input buffer length (BLEN) to avoid case (BLEN % 64) <= 8. > Adding protection for corner case to avoid for 5GDL occurrence of last > beat within the ACC100 fabric with <= 8B which might trigger a fabric > cor

RE: [EXT] [PATCH v4 30/30] baseband/acc100: update guide docs

2022-10-20 Thread Akhil Goyal
> Add new flags ACC100_EXT_MEM and RTE_LIBRTE_BBDEV_SKIP_VALIDATE to > the > documentation. > > Signed-off-by: Hernan Vargas Squash the patch where these flags were introduced. > --- > doc/guides/bbdevs/acc100.rst | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/guides/bb

RE: [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-20 Thread Akhil Goyal
apabilities and documentation > 6. test app changes. > > Update in v2: > Change uadk_supported_platform to uadk_crypto_version, which matches > better > than platform. > enum uadk_crypto_version { > UADK_CRYPTO_V2, > UADK_CRYPTO_V3, > }; > > Update in v1, co

RE: [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-20 Thread Akhil Goyal
> Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > UADK is a framework for user applications to access hardware accelerators. > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > the same page table between IOMMU and MMU. > Thereby user applicatio

RE: [PATCH 5/6] test/crypto: add unit tests for DES and MD5

2022-10-20 Thread Akhil Goyal
> diff --git a/app/test/test_cryptodev_security_ipsec.h > b/app/test/test_cryptodev_security_ipsec.h > index 9147d1c0d6..b98f4741b2 100644 > --- a/app/test/test_cryptodev_security_ipsec.h > +++ b/app/test/test_cryptodev_security_ipsec.h > @@ -196,7 +196,7 @@ static const struct crypto_param auth_li

RE: [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-20 Thread Akhil Goyal
> On Thu, 20 Oct 2022 at 22:46, Akhil Goyal wrote: > > > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > > > UADK is a framework for user applications to access hardware accelerators. > > > UADK relies on IOMMU SVA

RE: [EXT] [PATCH v5 00/29] baseband/acc100: changes for 22.11

2022-10-21 Thread Akhil Goyal
> v5: Fix compilation error and squash documentation changes. Series Applied with some more compilation fixes in docs. Please fix your build environment for future patches. Also updated commit messages and description of some of the patches. You should run the script ./devtools/check-git-log.sh o

RE: [PATCH v2 1/3] crypto/qat: fix uncleared cookies in asym

2022-10-21 Thread Akhil Goyal
> > Subject: [PATCH v2 1/3] crypto/qat: fix uncleared cookies in asym > > > > Fixed incorrectly placed clean function in asym response. > > > > Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") > > > > Signed-off-by: Arek Kusztal > > --- > > v2: > > - fixed compilation issues > > - s

RE: [PATCH v3 1/2] common/qat: read hw slice configuration

2022-10-21 Thread Akhil Goyal
> Acked-by: Kai Ji > > Subject: [PATCH v3 1/2] common/qat: read hw slice configuration > > > > Read slice configuration of QAT capabilities. > > This will allow to recognize if specific hw function is available on > > particular > > device. > > > > Signed-off-by: Arek Kusztal Series applied to d

RE: [PATCH 00/13] fixes and improvements to cnxk crypto PMD

2022-10-21 Thread Akhil Goyal
> Subject: [PATCH 00/13] fixes and improvements to cnxk crypto PMD > > This series adds improvements and support for 103XX CPT, > PDCP AAD, DES and MD5 algorithms in cnxk crypto PMD. > > Anoob Joseph (3): > crypto/cnxk: switch to SG when metabuf is allocated > crypto/cnxk: verify IV length du

RE: [PATCH v2 0/6] update autotest with new algorithms

2022-10-21 Thread Akhil Goyal
> Subject: [PATCH v2 0/6] update autotest with new algorithms > > This series updates autotest with DES, 3DES, MD5 > and custom UDP ports support. > > v2: > * Squashed a change in 5th patch with 2nd one. > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH] test/cryptodev: fix PDCP vectors

2022-10-21 Thread Akhil Goyal
; > Signed-off-by: Anoob Joseph > Tested-by: Gagandeep Singh > > Verified the patch on DPAA2 platform. Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH 0/2] test: add elliptic curve tests

2022-10-21 Thread Akhil Goyal
> This patchset adds new test cases that can be used to verify > elliptic curve algorithms like ECDSA, ECDH, etc. > > Depends-on: series-24333 ("crypto/qat: extend asymmetric crypto pmd") > > Arek Kusztal (2): > test/crypto: add ecdsa qat test cases > test/crypto: add ecdh tests > > app/tes

RE: [PATCH 0/1] Add security perf application

2022-10-21 Thread Akhil Goyal
ot; in a similar manner. But DPDK community decided to allow > "test-flow-perf" and so the same logic can be applied here as well. > > Thanks, > Anoob > > > -Original Message- > > From: Akhil Goyal > > Sent: Wednesday, September 28, 2022 12:47 AM

RE: [EXT] [PATCH v13 1/1] test-bbdev: unit test extension including for FFT

2022-10-21 Thread Akhil Goyal
> From: Nic Chautru > > Added support for bbdev level unit test > for the FFT operations and for Soft-Output options. > Also added 2 small test vectors for the FFT operation. > > Signed-off-by: Nic Chautru > Reviewed-by: Maxime Coquelin Applied to dpdk-next-crypto Thanks.

RE: [v1 2/2] examples/fips_validation: add ECDSA validation

2022-10-21 Thread Akhil Goyal
> > Subject: [v1 2/2] examples/fips_validation: add ECDSA validation > > > > This patch adds support in fips_validation app to validate ECDSA. > > > > Signed-off-by: Gowrishankar Muthukrishnan > > Acked-by: Brian Dooley Applied to dpdk-next-crypto Thanks.

RE: [PATCH] examples/ipsec-secgw: support for per SA HW reassembly

2022-10-21 Thread Akhil Goyal
int64_t ip_reassembly_dynflag; A nit, move this extern next to ip_reassembly_dynfield_offset Apart from that Acked-by: Akhil Goyal Also change the patch title as examples/ipsec-secgw: support per SA HW reassembly

RE: [PATCH 11/13] crypto/cnxk: switch to SG when metabuf is allocated

2022-10-25 Thread Akhil Goyal
> Subject: [PATCH 11/13] crypto/cnxk: switch to SG when metabuf is allocated > > From: Anoob Joseph > > Metabuf would be allocated only when SG is required. Check the pointer > instead of flags. > > Coverity issue: 381018 > Fixes: d3bff77cc371 ("crypto/cnxk: separate out PDCP chain datapath")

RE: [EXT] [PATCH resend v5 1/6] crypto/uadk: introduce uadk crypto driver

2022-10-25 Thread Akhil Goyal
> diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst > new file mode 100644 > index 00..1dfaab73c8 > --- /dev/null > +++ b/doc/guides/cryptodevs/uadk.rst > @@ -0,0 +1,73 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright 2022-2023 Huawei Technologies

RE: [EXT] [PATCH resend v5 2/6] crypto/uadk: support basic operations

2022-10-25 Thread Akhil Goyal
> +/* Maximum length for digest (SHA-512 needs 64 bytes) */ > +#define DIGEST_LENGTH_MAX 64 > + > +struct uadk_qp { > + /* Ring for placing process packets */ > + struct rte_ring *processed_pkts; > + /* Queue pair statistics */ > + struct rte_cryptodev_stats qp_stats; > + /* Que

RE: [EXT] [PATCH resend v5 4/6] crypto/uadk: support cipher algorithms

2022-10-25 Thread Akhil Goyal
> @@ -326,7 +641,9 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev) > dev->driver_id = uadk_cryptodev_driver_id; > dev->dequeue_burst = uadk_crypto_dequeue_burst; > dev->enqueue_burst = uadk_crypto_enqueue_burst; > - dev->feature_flags = RTE_CRYPTODEV_FF_HW_ACCELERATED; >

RE: [EXT] [PATCH resend v5 5/6] crypto/uadk: support auth algorithms

2022-10-25 Thread Akhil Goyal
> Hash algorithms: > > * ``RTE_CRYPTO_AUTH_MD5`` > * ``RTE_CRYPTO_AUTH_MD5_HMAC`` > * ``RTE_CRYPTO_AUTH_SHA1`` > * ``RTE_CRYPTO_AUTH_SHA1_HMAC`` > * ``RTE_CRYPTO_AUTH_SHA224`` > * ``RTE_CRYPTO_AUTH_SHA224_HMAC`` > * ``RTE_CRYPTO_AUTH_SHA256`` > * ``RTE_CRYPTO_AUTH_SHA256_HMAC`` > * ``RTE_CRYPTO_AU

RE: [EXT] [PATCH resend v5 6/6] test/crypto: add cryptodev_uadk_autotest

2022-10-25 Thread Akhil Goyal
> Subject: [EXT] [PATCH resend v5 6/6] test/crypto: add cryptodev_uadk_autotest Rewrite patch title as test/crypto: support uadk PMD > Add a line Updated test application to run autotest for uadk crypto PMD. > Example: > sudo dpdk-test --vdev=crypto_uadk --log-level=6 > RTE>>cryptodev_uadk_autote

RE: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-25 Thread Akhil Goyal
uadk_crypto_version, which matches > better > than platform. > enum uadk_crypto_version { > UADK_CRYPTO_V2, > UADK_CRYPTO_V3, > }; > > Update in v1, compared with rfc > > Suggested from Akhil Goyal > Only consider crypto PMD first > Split patch int

RE: [EXT] [PATCH 1/2] app/test-crypto-perf: fix number of scheduler sessions

2022-10-25 Thread Akhil Goyal
sion framework") > Cc: gak...@marvell.com > > Signed-off-by: Ciara Power Acked-by: Akhil Goyal

RE: [PATCH] common/cnxk: fix build failure with rhel

2022-10-25 Thread Akhil Goyal
> Subject: [PATCH] common/cnxk: fix build failure with rhel > > Fix compiler warning of uninitialized address. > > Fixes: a7033a2fb2bf ("common/cnxk: support custom UDP port values") > > Signed-off-by: Anoob Joseph Squashed with original commit. Thanks.

RE: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-26 Thread Akhil Goyal
> > Hi, Akhil > > Thanks for your guidance. > > On Tue, 25 Oct 2022 at 23:02, Akhil Goyal wrote: > > > > > > > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. > > > > > > UADK is a framework for user applicati

RE: [EXT] [PATCH v6 5/6] crypto/uadk: support auth algorithms

2022-10-26 Thread Akhil Goyal
> + { /* SHA384 HMAC */ > + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC, > + {.sym = { > + .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH, > + {.auth = { > + .algo = RTE_CRYPTO_AUTH_SHA384_HMAC, > +

RE: [EXT] [PATCH v2 0/4] crypto/qat: extend asymmetric crypto pmd

2022-10-27 Thread Akhil Goyal
> This patchset extends Intel QuickAssist Technology asymmetric crypto PMD. > Following features were added: > - ECDH algorithm handling > - EC point verification > > Depends-on: series-25284 ("crypto/qat: fix uncleared cookies in asym") > Series applied to dpdk-next-crypto Thanks.

RE: [dpdk-dev v1] crypto/qat: fix of qat build request session in mp

2022-10-27 Thread Akhil Goyal
> > Subject: [dpdk-dev v1] crypto/qat: fix of qat build request session in mp > > > > This patch fix the session pointer passed in set_session() when ctx has NULL > > build request pointer in multi-processes scenario. > > > > Fixes: fb3b9f492205 ("crypto/qat: rework burst data path") > > Cc: sta...

RE: [EXT] [dpdk-dev v5] crypto/ipsec_mb: multi-process IPC request handler

2022-10-27 Thread Akhil Goyal
> As the queue pair used in secondary process needs to be set up by > the primary process, this patch adds an IPC register function to help > secondary process to send out queue-pair setup request to primary > process via IPC request messages. A new "qp_in_used_pid" param stores > the PID to provid

RE: [EXT] [PATCH 1/2] app/test-crypto-perf: fix number of scheduler sessions

2022-10-27 Thread Akhil Goyal
le l2fwd-crypto, but was missed in test-crypto-perf. > > > > Fixes: bdce2564dbf7 ("cryptodev: rework session framework") > > Cc: gak...@marvell.com > > > > Signed-off-by: Ciara Power > Acked-by: Akhil Goyal Series Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2] app/test: add support to run multi-seg inline IPsec test

2022-10-27 Thread Akhil Goyal
> Subject: [PATCH v2] app/test: add support to run multi-seg inline IPsec test > > Add support to run multi-seg inline ipsec test using > new test command `inline_ipsec_sg_autotest` > > Signed-off-by: Nithin Dabilpuram > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v1] examples/fips_validation: parse block error fix

2022-10-27 Thread Akhil Goyal
> Acked-by: Gowrishankar Muthukrishnan > > > When parsing request files check for file type. This fix will remove > > dependence on command line parameter for using libjansson > > > > Fixes: 0f42f3d6034c ("examples/fips_validation: share callback with multiple > > keys") > > Cc: gmuthukri...@marv

RE: [EXT] [PATCH v7 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-27 Thread Akhil Goyal
nd setup/remove APIs > 3. Add data path > 4. implement cipher op. Add capabilities and documentation of what is >supported in each of the patches. Add feature flags etc. > 5. implement auth, add capabilities and documentation > 6. test app changes. > > Update in v2: > Change uadk_s

RE: [PATCH v1] crypto/qat: fix null hash algorithm digest size

2022-10-27 Thread Akhil Goyal
> > Add check for null hash algorithm digest size. Digest size should be 4B or > > request will be rejected. > > > > Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") > > Cc: declan.dohe...@intel.com > > Cc: sta...@dpdk.org > > Signed-off-by: Brian Dooley > > --- > > Acked-by: Ciara

RE: [PATCH v2] examples/ipsec-secgw: support per SA HW reassembly

2022-10-27 Thread Akhil Goyal
pv4-tunnel src > dst type inline-protocol-offload port_id reassembly_en > > Stats counter frag_dropped will represent the number of fragment > drop in case of reassembly failures. > > Signed-off-by: Rahul Bhansali > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v2 1/1] doc: update to include bbdev snippet using literalinclude

2022-10-27 Thread Akhil Goyal
> Adding code snippet using literalinclude so that to keep > automatically these structures in doc in sync with the > bbdev source code. > > Signed-off-by: Nicolas Chautru Applied to dpdk-next-crypto Thanks.

[pull-request] next-crypto 22.11 rc2

2022-10-27 Thread Akhil Goyal
The following changes since commit 9082336048e8c5779c1b4f8930041a42e9197348: net/nfp: support new solution for tunnel decap action (2022-10-25 10:53:33 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to ee18061c78af29975

RE: [EXT] Re: [PATCH] cryptodev: add missing algorithm strings

2022-11-02 Thread Akhil Goyal
> On 15/09/2022 09:26, Volodymyr Fialko wrote: > > SHA3 family algorithms were missing in the array of algorithm strings. > > > > Fixes: 1df800f89518 ("crypto/ccp: support SHA3 family") > > > > Signed-off-by: Volodymyr Fialko > > --- > > lib/cryptodev/rte_cryptodev.c | 9 + > > 1 file c

RE: [EXT] Re: [PATCH] cryptodev: add missing algorithm strings

2022-11-02 Thread Akhil Goyal
> Subject: Re: [EXT] Re: [PATCH] cryptodev: add missing algorithm strings > > On Wed, Nov 2, 2022 at 11:58 AM Akhil Goyal wrote: > > > This is being flagged as an ABI break for 21.11.3 [1]. I don't see it > > > mentioned in the commit message or discussed, is i

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-12 Thread Akhil Goyal
> 12/01/2023 17:16, De Lara Guarch, Pablo: > > From: Thomas Monjalon > > > 12/01/2023 14:22, De Lara Guarch, Pablo: > > > > Hi Thomas, > > > > > > > > From: Thomas Monjalon > > > > > 12/01/2023 11:32, Ji, Kai: > > > > > > Ok, a long story short, this issue should only occurred when > > > > > RTE_

RE: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-17 Thread Akhil Goyal
> On Tue, Jan 10, 2023 at 12:27 PM Bruce Richardson > wrote: > > > > On Mon, Jan 09, 2023 at 11:34:36AM +0100, David Marchand wrote: > > > Similar to commit 04361fe2aca8 ("crypto/qat: fix build with GCC 12"). > > > The issue appears when building with the "generic" target we have in > > > devtools

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-17 Thread Akhil Goyal
> 12/01/2023 20:30, Pablo de Lara: > > Instead of undefining AES_BLOCK_SIZE, define NO_COMPAT_IMB_API_053, > > which prevents legacy macros like AES_BLOCK_SIZE from being defined > > from IPSec MB library. > > Given we are discarding my first workaround, > your first sentence doesn't really make s

RE: [PATCH 2/5] lib: add pdcp protocol

2023-01-18 Thread Akhil Goyal
Hi Anoob, Please see inline comments. > Subject: [PATCH 2/5] lib: add pdcp protocol > > Add Packet Data Convergence Protocol (PDCP) processing library. > > The library is similar to lib_ipsec which provides IPsec processing > capabilities in DPDK. > > PDCP would involve roughly the following op

RE: [PATCH v2] crypto/qat: fix build

2023-01-19 Thread Akhil Goyal
> Acked-by: Kai Ji > > > Subject: [PATCH v2] crypto/qat: fix build > > > > When building QAT PMD, the following issue comes up: > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > In file included from drivers/crypto/q

RE: [EXT] Re: [PATCH] crypto/qat: fix build for generic x86 with GCC 12

2023-01-19 Thread Akhil Goyal
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, January 17, 2023 2:33 PM > To: Akhil Goyal > Cc: David Marchand ; Kai Ji ; > dev@dpdk.org; sta...@dpdk.org; Ciara Power ; Fan > Zhang > Subject: Re: [EXT] Re: [PATCH] crypto/qat: fix build for ge

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Akhil Goyal
> +/** > + * Block checksum flag. > + * If this flag is set, each data block will be followed by a 4-bytes > checksum, > + * calculated by using the xxHash-32 algorithm on the raw (compressed) data > + * block. The intention is to detect data corruption (storage or transmission > + * errors) immed

RE: [EXT] [PATCH v2 1/4] crypto/ccp: remove some printf

2023-01-30 Thread Akhil Goyal
> A DPDK application must _not_ use printf. > Use log framework. > > Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand First 3 patches of the series applied to dpdk-next-crypto Please submit the last patch again with the required cha

RE: [PATCH 3/4] cryptodev: introduce query API for error interrupt event

2023-01-30 Thread Akhil Goyal
igned-off-by: Srujana Challa Acked-by: Akhil Goyal

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler > > Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. > The query handler finds the next queue pair ID with pending error > interrupt event if any, starting from the given queue pair index, > for the device.

RE: [PATCH v2 1/3] cryptodev: add SHAKE algorithm

2023-01-30 Thread Akhil Goyal
> -Original Message- > From: Volodymyr Fialko > Sent: Thursday, January 12, 2023 4:18 PM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; Volodymyr Fialko > Subject: [PATCH v2 1/3] cryptodev: add SHAKE algorith

RE: [PATCH v2 2/3] app/test: add SHAKE test cases

2023-01-30 Thread Akhil Goyal
> Subject: [PATCH v2 2/3] app/test: add SHAKE test cases > > Add test cases for SHAKE hash algorithm for Digest and Digest-Verify. > > Signed-off-by: Volodymyr Fialko > --- Acked-by: Akhil Goyal

RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-01-30 Thread Akhil Goyal
ts) have the MAC-I set. > > Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") > Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity > cases") > Cc: sta...@dpdk.org > > Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-30 Thread Akhil Goyal
> The "rte_compressdev_info_get()" function retrieves the contextual > information of a device. > The output structure "dev_info" contains a list of devices supported > capabilities for each supported algorithm. > > In this function description, it says the element after the last valid > element h

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Akhil Goyal
> -Original Message- > From: Michael Baum > Sent: Tuesday, January 31, 2023 2:07 AM > To: Akhil Goyal ; dev@dpdk.org; Mahipal Challa > ; Fan Zhang ; Ashish Gupta > > Cc: Matan Azrad ; Fiona Trahe ; > NBU-Contact-Thomas Monjalon (EXTERNAL) > Subject: RE: [E

RE: [PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2023-01-31 Thread Akhil Goyal
> > > > > Signed-off-by: Srujana Challa > > The patch description do not match with the API added. > > Can you please update it? > > > Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. > The query handler returns pending error interrupt event sta

RE: [EXT] [PATCH v2] crypto/openssl: fix warning on copy length

2023-01-31 Thread Akhil Goyal
> When building with gcc 11.2.0, the compiler warns as follows: > In function 'memcpy', > inlined from 'openssl_set_session_auth_parameters' at > ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3, > inlined from 'openssl_set_session_parameters' at > ../drivers/crypto/openssl/rte_openssl_pmd

RE: [EXT] [PATCH v2 0/3] Add support for SHAKE

2023-01-31 Thread Akhil Goyal
| 15 + > lib/cryptodev/rte_crypto_sym.h| 7 +- > lib/cryptodev/rte_cryptodev.c | 5 +- > 11 files changed, 142 insertions(+), 5 deletions(-) > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Added release notes. Please make sure to add it in future.

RE: [EXT] [PATCH] ipsec: remove unneccessary null check

2023-01-31 Thread Akhil Goyal
> Subject: [EXT] [PATCH] ipsec: remove unneccessary null check Changed subject to crypto/ipsec_mb: remove unnecessary null check Fixed couple of spellings in description and title. Applied to dpdk-next-crypto Thanks. > > The function rte_ring_free() accepts NULL as vaild input > like free() and

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-31 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro > conflict > > > The "rte_compressdev_info_get()" function retrieves the contextual > > information of a device. > > The output structure "dev_info" contains a list of devices supported > > capabilities for each supported alg

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Akhil Goyal
Hi, > > > > > > After this change, I'm not sure about the purpose of > > > "RTE_COMP_ALGO_LIST_END". > > > There is no any other use of it in DPDK code, and it isn't represent the > > > number of algorithms supported by the API since the > > > "RTE_COMP_ALGO_UNSPECIFIED" is part of the enum. > > >

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Akhil Goyal
> > Hi, > > > > > > > > > > After this change, I'm not sure about the purpose of > > > > > "RTE_COMP_ALGO_LIST_END". > > > > > There is no any other use of it in DPDK code, and it isn't > > > > > represent the number of algorithms supported by the API since the > > > > > "RTE_COMP_ALGO_UNSPECIFIED"

RE: [PATCH] test/crypto: fix typo in AES test

2023-02-01 Thread Akhil Goyal
> Acked-by: Kai Ji > > > > > Fix the spelling of scater to scatter in cryptodev AES test vector > > header file > > > > Fixes: 2692b02e03b2 ("test/crypto: add multi-segment out-of-place AES- > > XTS") > > Cc: shi...@nvidia.com > > > > Signed-off-by: Vikash Poddar > > --- Cc: sta...@dpdk.org App

RE: [PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-02-01 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: add missing MAC-I to PDCP vectors > > Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL > integrity do not contain the MAC-I (32-bit of all zeros according to the > specification). > Vectors for other SN length (5, 18 bits) have the MAC-I set

RE: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device

2023-02-01 Thread Akhil Goyal
> Acked-by: Kai Ji > > > Subject: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device > > > > This commit enables asymmetric crypto in generation three devices. > > > > Signed-off-by: Ciara Power Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

2023-02-01 Thread Akhil Goyal
Hi Radu, > Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 > > Set AES-CTR IV length as 16 instead of taking from > SA config option since the application populates > 16B IV in the datapath. AES-CTR requires 16B IV > constructed from nonce and counter. > > Signed-off-by: Te

RE: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: scatter gather mode feature support

2023-02-01 Thread Akhil Goyal
> Subject: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: scatter gather > mode feature support Rename title to compress/octeontx: support scatter gather mode Fix checkpatch warning. Add documentation update in .ini file. > Scatter gather mode feature support is added to compress or decompr

RE: [EXT] [PATCH] crypto/qat: remove openssl 3.0 deprecated functions

2023-02-01 Thread Akhil Goyal
> This commit removes OpenSSL 3.0 deprecated functions > from Intel QuickAssist Technology PMD. It does not remove > all deprecated functions, this will be added in later versions. > > Signed-off-by: Arek Kusztal Reviews please.

RE: [EXT] [PATCH] crypto/qat: add curve25519 and curve448 functions

2023-02-01 Thread Akhil Goyal
> This commit adds qat functions for curve25519 and > curve448. > > Signed-off-by: Arek Kusztal > --- Please review

  1   2   3   4   5   6   7   8   9   10   >