[dpdk-dev] [PATCH v3 0/2] e1000: enable igb TSO support

2015-10-20 Thread Wang Xiao W
ions in hardware for TCP segmentaion offload". * Added "unlikely" in check_tso_para function. v1: * Initial version for igb TSO feature. Wang Xiao W (2): e1000: enable igb TSO support doc: update release note for igb TSO support doc/guides/rel_notes/release_2_2.rst |

[dpdk-dev] [PATCH v3 1/2] e1000: enable igb TSO support

2015-10-20 Thread Wang Xiao W
This patch enables igb TSO feature, the feature works on both PF and VF. The TCP segmentation offload needs to write the offload related information into the advanced context descriptors, which is similar to checksum offload. Signed-off-by: Wang Xiao W --- drivers/net/e1000/igb_ethdev.c | 6

[dpdk-dev] [PATCH v3 2/2] doc: update release note for igb TSO support

2015-10-20 Thread Wang Xiao W
Signed-off-by: Wang Xiao W --- doc/guides/rel_notes/release_2_2.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..74ebd49 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides

[dpdk-dev] [PATCH v3 1/2] e1000: enable igb TSO support

2015-10-21 Thread Wang, Xiao W
-Original Message- From: Lu, Wenzhuo Sent: Wednesday, October 21, 2015 2:41 PM To: Wang, Xiao W; dev at dpdk.org Cc: Richardson, Bruce; Zhang, Helin Subject: RE: [PATCH v3 1/2] e1000: enable igb TSO support Hi Xiao, > -Original Message- > From: Wang, Xiao W > Sent

[dpdk-dev] [PATCH v4 0/2] e1000: enable igb TSO support

2015-10-21 Thread Wang Xiao W
more used. * Corrected typo in line "There're some limitaions in hardware for TCP segmentaion offload". * Added "unlikely" in check_tso_para function. v1: * Initial version for igb TSO feature. Wang Xiao W (2): e1000: enable igb TSO support doc: update release note for igb

[dpdk-dev] [PATCH v4 1/2] e1000: enable igb TSO support

2015-10-21 Thread Wang Xiao W
This patch enables igb TSO feature, the feature works on both PF and VF. The TCP segmentation offload needs to write the offload related information into the advanced context descriptors, which is similar to checksum offload. Signed-off-by: Wang Xiao W --- drivers/net/e1000/igb_ethdev.c | 6

[dpdk-dev] [PATCH v4 2/2] doc: update release note for igb TSO support

2015-10-21 Thread Wang Xiao W
Signed-off-by: Wang Xiao W --- doc/guides/rel_notes/release_2_2.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst index 5687676..74ebd49 100644 --- a/doc/guides/rel_notes/release_2_2.rst +++ b/doc/guides

[dpdk-dev] [PATCH v4 1/2] e1000: enable igb TSO support

2015-10-23 Thread Wang, Xiao W
-Original Message- From: Zhang, Helin Sent: Friday, October 23, 2015 10:04 AM To: Wang, Xiao W; dev at dpdk.org Cc: Lu, Wenzhuo; Richardson, Bruce Subject: RE: [PATCH v4 1/2] e1000: enable igb TSO support > -Original Message- > From: Wang, Xiao W > Sent: Wednesday, O

[dpdk-dev] [PATCH v4 1/2] e1000: enable igb TSO support

2015-10-23 Thread Wang, Xiao W
Hi, Helin Thanks a lot for your comments, please find my reply inline. > -Original Message- > From: Zhang, Helin > Sent: Friday, October 23, 2015 10:04 AM > To: Wang, Xiao W; dev at dpdk.org > Cc: Lu, Wenzhuo; Richardson, Bruce > Subject: RE: [PATCH v4 1/2] e10

[dpdk-dev] [PATCH 00/28] fm10k: update shared code from ND team

2015-09-10 Thread Wang Xiao W
This set of shared code update patches has been tested. Wang Xiao W (28): fm10k: add PF Tx Timestamp mode handler function fm10k: add no-op pointer for VF request_tx_timestamp_mode fm10k: Set PF queues to unlimited bandwidth fm10k: fix fm10k_mbx_write_copy header comment fm10k: Add

[dpdk-dev] [PATCH 01/28] fm10k: add PF Tx Timestamp mode handler function

2015-09-10 Thread Wang Xiao W
We need a handler function to be able to listen for Tx timestamp mode responses. Without this, core driver code for PTP can't determine if the Timestamp mode request was successful. This was overlooked in the previous commit. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH 02/28] fm10k: add no-op pointer for VF request_tx_timestamp_mode

2015-09-10 Thread Wang Xiao W
This patch resolves a bug in Linux where we called the request_tx_timestamp_mode function that is undefined for VF. Implement a no-op function that simply ensures that the mode is NONE, otherwise it would fail with ERR_PARAM. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_vf.c | 23

[dpdk-dev] [PATCH 03/28] fm10k: Set PF queues to unlimited bandwidth

2015-09-10 Thread Wang Xiao W
Set PF queues used for VMDq to unlimited bandwidth when virtualization resources are assigned. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base

[dpdk-dev] [PATCH 04/28] fm10k: fix fm10k_mbx_write_copy header comment

2015-09-10 Thread Wang Xiao W
The header comment included a miscopy of a C-code line, and also mis-used Rx FIFO when it clearly meant Tx FIFO. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers

[dpdk-dev] [PATCH 05/28] fm10k: Add support for ITR scaling based on PCIe link speed

2015-09-10 Thread Wang Xiao W
es how the MAC address is passed in the TDBAL/TDBAH registers. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 16 +++- drivers/net/fm10k/base/fm10k_type.h | 6 ++ drivers/net/fm10k/base/fm10k_vf.c | 5 - 3 files changed, 25 insertions(+), 2 deletion

[dpdk-dev] [PATCH 06/28] fm10k: reset head instead of calling update_max_size

2015-09-10 Thread Wang Xiao W
during mailbox negotiation, which is confusing to viewers of Linux ethtool statistics output. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net

[dpdk-dev] [PATCH 07/28] fm10k: mbx_update_max_size does not drop all

2015-09-10 Thread Wang Xiao W
the update_max_size function header comment to clearly indicate that it does not drop all oversized messages, but only those at the head of the FIFO. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 08/28] fm10k: ensure VF restores itr_scale on stop_hw

2015-09-10 Thread Wang Xiao W
the ITR scale instead of the correct value. If the VF driver blindly trusted this value it could cause a divide by zero failure. Fix this by having stop_hw_vf reset the ITR scale as the device goes down, similar to the way we handle the MAC address. Signed-off-by: Wang Xiao W --- drivers/net

[dpdk-dev] [PATCH 09/28] fm10k: ensure itr_scale is set even if we don't know speed

2015-09-10 Thread Wang Xiao W
To prevent divide-by-zero issues, ensure that we always have an ITR scale. Default to Gen3 scaling if we don't know the speed. Also ensure the VF checks the register value and ensures we use Gen3 if we are provided a zero value. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k

[dpdk-dev] [PATCH 10/28] fm10k: correct VF multicast update

2015-09-10 Thread Wang Xiao W
VFs were being improperly added to the switch's multicast group. The error stems from the fact that incorrect arguments were passed to the "update_mc_addr" function. It would seem to be a copy paste error since the parameters are similar to the "update_uc_addr" function.

[dpdk-dev] [PATCH 11/28] fm10k: Re-map all possible VF queues after a VFLR

2015-09-10 Thread Wang Xiao W
registers post-VFLR to prevent innocent VF drivers from triggering malicious events. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index 1004018..eb1adc9

[dpdk-dev] [PATCH 12/28] fm10k: pack TLV overlay structures correctly

2015-09-10 Thread Wang Xiao W
24. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.h b/drivers/net/fm10k/base/fm10k_pf.h index 5a40d5b..b7a1758 100644 --- a/drivers/net/fm10k/base/fm10k_pf.h +++ b/drivers/net/fm10k/base

[dpdk-dev] [PATCH 13/28] fm10k: 1558 DIR_NEGATIVE bit is actually DIR_POSITIVE

2015-09-10 Thread Wang Xiao W
The SYSTIME_CFG.Adjust field has a Direction bit to indicate whether the adjustment is positive or negative. However, we incorrectly read the documentation and the direction bit should be set 1 when positive, not when negative. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH 14/28] fm10k: remove err_no reference

2015-09-10 Thread Wang Xiao W
ever used. This occurred because a previous commit refactored and removed all used references to err_no. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_m

[dpdk-dev] [PATCH 15/28] fm10k: fix iov_msg_lport_state_pf re-enable bug

2015-09-10 Thread Wang Xiao W
sults in disabling the logical port. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index 86283fa..aa04937 100644 --- a/drivers/net/fm10k/base/fm10k

[dpdk-dev] [PATCH 16/28] fm10k: add macro definitions about valid ether addr

2015-09-10 Thread Wang Xiao W
To keep consistency with ND team, I add macro definitions about FM10K_IS_VALID_ETHER_ADD in fm10k_type.h, though they have already been defined in fm10k_osdep.h. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_type.h | 17 +++-- 1 file changed, 15 insertions(+), 2

[dpdk-dev] [PATCH 17/28] fm10k: store actual count of DWORDS pulled/pushed from mbmem

2015-09-10 Thread Wang Xiao W
DWORDs pushed or pulled from the mbmem. Base drivers can use this in debug builds to help detect this problem in the future. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 4 drivers/net/fm10k/base/fm10k_mbx.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a

[dpdk-dev] [PATCH 18/28] fm10k: fix iov_msg_mac_vlan_pf VID checks

2015-09-10 Thread Wang Xiao W
for selecting a default vid. This helps us remove duplicate code and streamlines location of this logic so that we don't make similar bugs in the future. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 83 --- 1 file changed, 51 inser

[dpdk-dev] [PATCH 19/28] fm10k: Fix Solaris build issue

2015-09-10 Thread Wang Xiao W
Solaris (and other OS's) are not C99 compliant, so they are not able to use the C99 style #pragma pack() code. Wrap with C99 tag for easy stripping. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/

[dpdk-dev] [PATCH 20/28] fm10k: fix Tx FIFO clearing for phantom messages

2015-09-10 Thread Wang Xiao W
es issue, as well as correctly keeping messages which have yet to be transmitted at all in the Tx FIFO. Thus, we will begin re-transmission once we have re-connected. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 23 --- 1 file changed, 20 insertions(+),

[dpdk-dev] [PATCH 21/28] fm10k: create "correct" header for the remote end on connect

2015-09-10 Thread Wang Xiao W
he Tx FIFO head and tail pointers. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_mbx.c index 251a81d..3c9ab3a 10064

[dpdk-dev] [PATCH 22/28] fm10k: do not assume VF always has 1 queue

2015-09-10 Thread Wang Xiao W
It is possible that the PF has not yet assigned resources to the VF. Although rare, this could result in the VF attempting to read queues it does not own and result in FUM or THI faults in the PF. To prevent this, check queue 0 before we continue in init_hw_vf. Signed-off-by: Wang Xiao W

[dpdk-dev] [PATCH 23/28] fm10k: Add support for Boulder Rapids and Atwood Channel

2015-09-10 Thread Wang Xiao W
Add the device ID for Boulder Rapids and Atwood Channel to enable drivers to support those devices. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_api.c | 6 ++ drivers/net/fm10k/base/fm10k_type.h | 6 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/fm10k

[dpdk-dev] [PATCH 24/28] fm10k: remove report_timestamp PF<->VF message

2015-09-10 Thread Wang Xiao W
<->VF message for this behavior. Note, the VF already didn't have ability to request Tx timestamp mode, so it essentially wasn't allowed to timestamp before anyways under the old API. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 14 -- driver

[dpdk-dev] [PATCH 25/28] fm10k: remove request_tx_timestamp_mode call

2015-09-10 Thread Wang Xiao W
future patch. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 50 ++--- drivers/net/fm10k/base/fm10k_pf.h | 13 -- drivers/net/fm10k/base/fm10k_type.h | 1 - drivers/net/fm10k/base/fm10k_vf.c | 21 4 files changed, 2

[dpdk-dev] [PATCH 26/28] fm10k: add 1588 clock owner message support

2015-09-10 Thread Wang Xiao W
ase driver may use it to disable any functions which modify the clock including Tx timestamps, frequency adjustments, and offset adjustments. This ensures only one PEP will be handling these at a time. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_osdep.h | 1 + drivers/net/fm10k/b

[dpdk-dev] [PATCH 27/28] fm10k: TRIVIAL fix typo in DEBUGFUNC

2015-09-10 Thread Wang Xiao W
The function is specifically for the PF, but the DEBUGFUNC labeled it with *_vf. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index

[dpdk-dev] [PATCH 28/28] fm10k: add support for MASTER_CLK_OFFSET message

2015-09-10 Thread Wang Xiao W
implementations so no message handler is provided in shared code. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_api.c | 14 ++ drivers/net/fm10k/base/fm10k_api.h | 1 + drivers/net/fm10k/base/fm10k_pf.c | 56 + drivers/net/fm10k/base/fm10k_pf.h

[dpdk-dev] [PATCH] net/fm10k: fix Rx descriptor read timing

2016-07-04 Thread Wang Xiao W
lue. This patch fixes this issue by reading and parsing Rx descriptor after DD bit is set. Fixes: 4b61d3bfa941 ("fm10k: add receive and tranmit") Fixes: c82dd0a7bfa5 ("fm10k: add scatter receive") Signed-off-by: Wang Xiao W --- drivers/net/fm10k/fm10k_rxtx.c | 8 1 fi

[dpdk-dev] [PATCH] net/fm10k: fix RSS hash config

2016-07-21 Thread Wang, Xiao W
Hi Mark, > -Original Message- > From: Chen, Jing D > Sent: Thursday, July 21, 2016 4:48 PM > To: Wang, Xiao W ; dev at dpdk.org > Cc: Lin, Xueqin > Subject: RE: [PATCH] net/fm10k: fix RSS hash config > > Hi, > > > diff --git a/drivers/net/fm10k/fm10k

[dpdk-dev] [PATCH 09/12] virtio: add Rx checksum offload support

2016-07-27 Thread Wang, Xiao W
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, July 21, 2016 4:08 PM > To: dev at dpdk.org; yuanhan.liu at linux.intel.com; Ananyev, Konstantin > > Cc: Chandran, Sugesh ; Richardson, Bruce > ; Tan, Jianfeng ; > Zhang, > Heli

[dpdk-dev] [PATCH] e1000: configure VLAN TPID

2016-06-02 Thread Wang, Xiao W
Hi Beilei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, April 21, 2016 4:56 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Xing, Beilei > Subject: [dpdk-dev] [PATCH] e1000: configure VLAN TPID > > This patch enables configurin

[dpdk-dev] [PATCH v2] e1000: configure VLAN TPID

2016-06-03 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Beilei Xing > Sent: Friday, June 3, 2016 10:59 AM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Xing, Beilei > Subject: [dpdk-dev] [PATCH v2] e1000: configure VLAN TPID > > This patch enables configuring the e

[dpdk-dev] [PATCH] fm10k: fix VF cannot receive broadcast traffic

2016-06-06 Thread Wang Xiao W
. Thus, app may fail on promisc/allmulti setting in VF. In fact, we don't need a valid glort value in VF, so this patch just skips the glort check for VF. Fixes: df02ba864695 ("fm10k: support promiscuous mode") Signed-off-by: Wang Xiao W --- drivers/net/fm10k/fm10k_ethdev.c |

[dpdk-dev] [PATCH] fm10k: fix wrong Rx func is used

2015-11-27 Thread Wang, Xiao W
Hi, > -Original Message- > From: Chen, Jing D > Sent: Friday, November 27, 2015 9:56 AM > To: dev at dpdk.org > Cc: Wang, Xiao W ; Chen, Jing D > > Subject: [PATCH] fm10k: fix wrong Rx func is used > > From: "Chen Jing D(Mark)" > > Steps to r

[dpdk-dev] [PATCH 01/16] fm10k: add PF Tx Timestamp mode handler function

2015-07-27 Thread Wang Xiao W
We need a handler function to be able to listen for Tx timestamp mode responses. Without this, core driver code for PTP can't determine if the Timestamp mode request was successful. This was overlooked in the previous commit. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH 02/16] fm10k: add no-op pointer for VF request_tx_timestamp_mode

2015-07-27 Thread Wang Xiao W
This patch resolves a bug in Linux where we called the request_tx_timestamp_mode function that is undefined for VF. Implement a no-op function that simply ensures that the mode is NONE, otherwise it would fail with ERR_PARAM. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_vf.c | 23

[dpdk-dev] [PATCH 03/16] fm10k: Set PF queues to unlimited bandwidth

2015-07-27 Thread Wang Xiao W
Set PF queues used for VMDq to unlimited bandwidth when virtualization resources are assigned. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base

[dpdk-dev] [PATCH 04/16] fm10k: fix fm10k_mbx_write_copy header comment

2015-07-27 Thread Wang Xiao W
The header comment included a miscopy of a C-code line, and also mis-used Rx FIFO when it clearly meant Tx FIFO. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers

[dpdk-dev] [PATCH 06/16] fm10k: reset head instead of calling update_max_size

2015-07-27 Thread Wang Xiao W
during mailbox negotiation, which is confusing to viewers of Linux ethtool statistics output. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net

[dpdk-dev] [PATCH 05/16] fm10k: Add support for ITR scaling based on PCIe link speed

2015-07-27 Thread Wang Xiao W
es how the MAC address is passed in the TDBAL/TDBAH registers. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 16 +++- drivers/net/fm10k/base/fm10k_type.h | 6 ++ drivers/net/fm10k/base/fm10k_vf.c | 5 - 3 files changed, 25 insertions(+), 2 deletion

[dpdk-dev] [PATCH 07/16] fm10k: mbx_update_max_size does not drop all

2015-07-27 Thread Wang Xiao W
the update_max_size function header comment to clearly indicate that it does not drop all oversized messages, but only those at the head of the FIFO. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 08/16] fm10k: ensure VF restores itr_scale on stop_hw

2015-07-27 Thread Wang Xiao W
the ITR scale instead of the correct value. If the VF driver blindly trusted this value it could cause a divide by zero failure. Fix this by having stop_hw_vf reset the ITR scale as the device goes down, similar to the way we handle the MAC address. Signed-off-by: Wang Xiao W --- drivers/net

[dpdk-dev] [PATCH 09/16] fm10k: ensure itr_scale is set even if we don't know speed

2015-07-27 Thread Wang Xiao W
To prevent divide-by-zero issues, ensure that we always have an ITR scale. Default to Gen3 scaling if we don't know the speed. Also ensure the VF checks the register value and ensures we use Gen3 if we are provided a zero value. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k

[dpdk-dev] [PATCH 10/16] fm10k: correct VF multicast update

2015-07-27 Thread Wang Xiao W
VFs were being improperly added to the switch's multicast group. The error stems from the fact that incorrect arguments were passed to the "update_mc_addr" function. It would seem to be a copy paste error since the parameters are similar to the "update_uc_addr" function.

[dpdk-dev] [PATCH 11/16] fm10k: Re-map all possible VF queues after a VFLR

2015-07-27 Thread Wang Xiao W
registers post-VFLR to prevent innocent VF drivers from triggering malicious events. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index 1004018..eb1adc9

[dpdk-dev] [PATCH 12/16] fm10k: pack TLV overlay structures correctly

2015-07-27 Thread Wang Xiao W
24. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.h b/drivers/net/fm10k/base/fm10k_pf.h index 5a40d5b..b7a1758 100644 --- a/drivers/net/fm10k/base/fm10k_pf.h +++ b/drivers/net/fm10k/base

[dpdk-dev] [PATCH 13/16] fm10k: 1558 DIR_NEGATIVE bit is actually DIR_POSITIVE

2015-07-27 Thread Wang Xiao W
The SYSTIME_CFG.Adjust field has a Direction bit to indicate whether the adjustment is positive or negative. However, we incorrectly read the documentation and the direction bit should be set 1 when positive, not when negative. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c

[dpdk-dev] [PATCH 14/16] fm10k: remove err_no reference

2015-07-27 Thread Wang Xiao W
ever used. This occurred because a previous commit refactored and removed all used references to err_no. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_mbx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/fm10k/base/fm10k_mbx.c b/drivers/net/fm10k/base/fm10k_m

[dpdk-dev] [PATCH 15/16] fm10k: fix iov_msg_lport_state_pf re-enable bug

2015-07-27 Thread Wang Xiao W
sults in disabling the logical port. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_pf.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/fm10k/base/fm10k_pf.c b/drivers/net/fm10k/base/fm10k_pf.c index 86283fa..aa04937 100644 --- a/drivers/net/fm10k/base/fm10k

[dpdk-dev] [PATCH 16/16] fm10k: add macro definitions about valid ether addr

2015-07-27 Thread Wang Xiao W
To keep consistency with another repo, I add macro definitions about FM10K_IS_VALID_ETHER_ADD in fm10k_type.h, though they have already been defined in fm10k_osdep.h. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_type.h | 17 +++-- 1 file changed, 15 insertions(+), 2

[dpdk-dev] [PATCH] fm10k: fix 2 bugs in rxtx_queue_disable and fm10k_dev_start

2015-07-31 Thread Wang Xiao W
: Wang Xiao W --- drivers/net/fm10k/fm10k_ethdev.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 902ccae..35f34bb 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c

[dpdk-dev] [PATCH v5 0/2] fm10k: enable FTAG based forwarding

2016-03-10 Thread Wang, Xiao W
Hi, We reached a consensus on configuring FTAG by devargs method, any other suggestion or concern for this patch? Best Regards, Xiao > -Original Message- > From: Liu, Yong > Sent: Tuesday, March 8, 2016 3:58 PM > To: Wang, Xiao W ; Chen, Jing D > > Cc: dev at dpdk

[dpdk-dev] [PATCH] ixgbe: fix reta query and update on x550

2016-03-18 Thread Wang Xiao W
ue. Fixes: 4bee94a6c22f ("ixgbe: support 512 RSS entries on x550") Signed-off-by: Wang Xiao W --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index afe

[dpdk-dev] [PATCH] ixgbe: return err for too many interrupt queues

2016-03-28 Thread Wang Xiao W
The lower 16 bits of EICR register are used for queue interrupts, dpdk framework take over the first bit for other interrupts like LSC, so there're only 15 bits left for queue interrupts mapping. This patch adds a check for the num of interrupt queues at dev_start. Signed-off-by: Wang X

[dpdk-dev] [PATCH] fm10k: enable TSO support

2015-09-25 Thread Wang Xiao W
This patch enables fm10k TSO feature for both non-tunneling packet and tunneling packet. Signed-off-by: Wang Xiao W --- drivers/net/fm10k/base/fm10k_osdep.h | 5 + drivers/net/fm10k/fm10k_ethdev.c | 3 ++- drivers/net/fm10k/fm10k_rxtx.c | 21 ++--- 3 files

[dpdk-dev] [PATCH] e1000: enable igb TSO support

2015-09-30 Thread Wang Xiao W
This patch enables igb TSO feature, the feature works on both PF and VF. The TCP segmentation offload needs to write the offload related information into the advanced context descriptors, which is similar to checksum offload. Signed-off-by: Wang Xiao W --- drivers/net/e1000/igb_ethdev.c | 6

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency

2019-04-01 Thread Wang, Xiao W
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 2, 2019 3:10 AM > To: Nithin Kumar Dabilpuram ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Cc: dev@dpdk.org; Wang, Xiao W > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 1/2] app/

Re: [dpdk-dev] [PATCH v2 6/7] net/fm10k: remove 'typedef int bool'

2020-01-02 Thread Wang, Xiao W
Hi, > -Original Message- > From: Dharmik Thakkar > Sent: Friday, January 3, 2020 1:49 AM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; Dharmik Thakkar > Subject: [PATCH v2 6/7] net/fm10k: remove 'typedef int bool' > > Replace 't

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-01-20 Thread Wang, Xiao W
r 11, 2019 5:52 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; > jakub.for...@intel.co; Keller, Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v2 0/7] support switch management > > To avoid configuration for both kernel driver > and userspace SDK outsi

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-01-22 Thread Wang, Xiao W
Xiao > -Original Message- > From: Harman Kalra > Sent: Wednesday, January 22, 2020 9:30 PM > To: Wang, Xiao W > Cc: Hunt, David ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable > > On Mon, Jan 20, 2020 at 10:06:57PM -050

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-16 Thread Wang, Xiao W
For the series, Reviewed-by: Xiao Wang Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Thursday, April 9, 2020 2:26 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PAT

Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect

2020-05-14 Thread Wang, Xiao W
Hi Marvin, Comments inline. Thanks for the fix. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, May 15, 2020 9:41 AM > To: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Liu, Yong > Subject: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect

2020-05-14 Thread Wang, Xiao W
Hi, Best Regards, Xiao > -Original Message- > From: Liu, Yong > Sent: Friday, May 15, 2020 10:35 AM > To: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Wang, Xiao W > > Cc: dev@dpdk.org; Liu, Yong ; sta...@dpdk.org > Subject: [PATCH v2] net/virt

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Wang, Xiao W
Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@mellanox.com;

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-17 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 6:09 PM > To: Wang, Xiao W ; Maxime Coquelin > ; Ye, Xiaolong ; > shah...@mellanox.com; ma...@mellanox.com; amore...@redhat.com; > viachesl...@mellanox.com;

Re: [dpdk-dev] [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stats

2020-06-04 Thread Wang, Xiao W
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 3, 2020 4:58 PM > To: Matan Azrad ; Viacheslav Ovsiienko > > Cc: dev@dpdk.org; Shahaf Shuler ; Wang, Xiao W > > Subject: Re: [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stat

Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

2020-04-02 Thread Wang, Xiao W
PDATE_NODES (1 << 27) Check more at http://patches.dpdk.org/patch/66973/. Please take care for next version. I'm wondering if we could have a tool for automatically check this kind of alignment issue. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu >

Re: [dpdk-dev] [PATCH v3 4/5] net/fm10k: add flow interface and switch management

2020-04-02 Thread Wang, Xiao W
upstreaming may mean burden of maintenance, so let's make the big patch in better shape. 😊 Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jaco

Re: [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support

2020-04-02 Thread Wang, Xiao W
| - DEV_RX_OFFLOAD_RSS_HASH); + DEV_RX_OFFLOAD_HEADER_SPLIT); Also some comments on the feature description are inlined below. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To:

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-03 Thread Wang, Xiao W
Hi Jerin, Found small typos on this patch. Please check comments inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Thomas Monjalon ; Richardson, Bruce > ; Mcnamara, John ; > Kovacevic, Marko ; Jerin

Re: [dpdk-dev] [PATCH v3 02/29] graph: implement node registration

2020-04-03 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@e

Re: [dpdk-dev] [PATCH v3 03/29] graph: implement node operations

2020-04-03 Thread Wang, Xiao W
Hi Jerin, Comment inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb

Re: [dpdk-dev] [PATCH v3 04/29] graph: implement node debug routines

2020-04-04 Thread Wang, Xiao W
Hi, Comment inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@er

Re: [dpdk-dev] [PATCH v3 05/29] graph: implement internal graph operation helpers

2020-04-06 Thread Wang, Xiao W
Hi, Comment inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@er

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-02-11 Thread Wang, Xiao W
t; for debugging, please use dpdk logging API instead. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Tuesday, January 21, 2020 2:15 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; Zhang, Qi Z ; Kwan, Ngai-mint > ; jakub.for...@intel.co; Keller, Jacob

Re: [dpdk-dev] [PATCH v2 0/7] support switch management

2020-02-19 Thread Wang, Xiao W
ch or in http://patches.dpdk.org/project/dpdk/list/?state=*&archive=both. Also, please document what change you made from previous version. You can refer to others' patches in the mailing list. Best Regards, Xiao From: Xiaojun Liu Sent: Wednesday, February 19, 2020 1:58 PM To: Wang,

Re: [dpdk-dev] [PATCH] net/fm10k: fix non-x86 build

2020-02-19 Thread Wang, Xiao W
Acked-by: Xiao Wang Thanks, Xiao > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, February 19, 2020 10:17 PM > To: Zhang, Qi Z ; Wang, Xiao W > ; Chen Jing D(Mark) > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: [PATCH] net/fm1

Re: [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support

2020-02-25 Thread Wang, Xiao W
ew versions, you need to document what has changed from last version in your cover letter, in below format: V2: * Fix what * Fix what Best Regards, Xiao > -Original Message----- > From: Xiaojun Liu > Sent: Thursday, February 20, 2020 10:00 PM > To: Wang, Xiao W ; Zhang, Qi Z >

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-23 Thread Wang, Xiao W
aolong > ; Shahaf Shuler ; > amore...@redhat.com; Wang, Xiao W ; Slava > Ovsiienko ; dev@dpdk.org > Cc: jasow...@redhat.com; l...@redhat.com > Subject: Re: [PATCH 9/9] vhost: only use vDPA config workaround if needed > > > > On 6/18/20 8:39 AM, Matan Azrad wrote: > >

Re: [dpdk-dev] [PATCH v1 1/5] net/fm10k: add basic functions for switch management

2020-03-15 Thread Wang, Xiao W
Hi Xiaojun, Comments inline. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 1

Re: [dpdk-dev] [PATCH v1 2/5] net/fm10k: add epl serdes and port control functions

2020-03-15 Thread Wang, Xiao W
Hi Xiaojun, Comments inline. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1

Re: [dpdk-dev] [PATCH v1 3/5] net/fm10k: add ffu and statistics and config file functions

2020-03-16 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 3/5

Re: [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support

2020-03-16 Thread Wang, Xiao W
Hi Xiaojun, Best Regards, Xiao > -Original Message- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Keller, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 5/5] net/fm10k: add s

Re: [dpdk-dev] [PATCH] net/fm10k: fix descriptor vlan field filling in Tx

2019-12-05 Thread Wang, Xiao W
Hi, > -Original Message- > From: Lu Qiuwen > Sent: Thursday, December 5, 2019 9:30 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; Shaw, Jeffrey B ; > sta...@dpdk.org > Subject: [PATCH] net/fm10k: fix descriptor vlan field filling in Tx > > The V

Re: [dpdk-dev] [PATCH] net/softnic: fix pipeline time calculation

2019-07-09 Thread Wang, Xiao W
> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, July 9, 2019 6:32 PM > To: Wang, Xiao W ; Singh, Jasvinder > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/softnic: fix pipeline time calculation > > > > > -

Re: [dpdk-dev] [v2] net/fm10k: fix segment fault at calling fm10k_stats_get()

2019-08-06 Thread Wang, Xiao W
Hi > -Original Message- > From: luqiu...@iie.ac.cn [mailto:luqiu...@iie.ac.cn] > Sent: Tuesday, August 6, 2019 2:34 PM > To: sta...@dpdk.org; dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Xiao W > ; ys...@mellanox.com > Subject: [v2] net/fm10k: fix segment fault at ca

Re: [dpdk-dev] [PATCH v4] net/fm10k: fix fm10k stats crash in multi-process

2019-08-07 Thread Wang, Xiao W
Hi Qiuwen, > -Original Message- > From: Lu Qiuwen [mailto:luqiu...@iie.ac.cn] > Sent: Wednesday, August 7, 2019 3:21 PM > To: dev@dpdk.org > Cc: Shaw, Jeffrey B ; Wang, Xiao W > > Subject: [PATCH v4] net/fm10k: fix fm10k stats crash in multi-process >

Re: [dpdk-dev] [PATCH v3 1/3] net/ice: enable switch filter

2019-06-20 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Thursday, June 20, 2019 1:35 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v3 1/3] net/ice: enable switch filter > > From: wei zhao > > The patch enables the backen

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Thursday, June 20, 2019 1:35 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > This patch adds ice_flow_create, ice_flow_destr

<    1   2   3   4   >