Hi,
This is a feature-add patch, so you need to add release note in
doc/guides/rel_notes/release_20_05.rst, that can be included as part of this
5/5 patch.
Another issue, why delete DEV_RX_OFFLOAD_RSS_HASH unconditionally? I think it
would impact the existing usage.
@@ -1808,8 +2044,7 @@ static uint64_t fm10k_get_rx_port_offloads_capa(struct
rte_eth_dev *dev)
DEV_RX_OFFLOAD_UDP_CKSUM |
DEV_RX_OFFLOAD_TCP_CKSUM |
DEV_RX_OFFLOAD_JUMBO_FRAME |
- DEV_RX_OFFLOAD_HEADER_SPLIT |
- DEV_RX_OFFLOAD_RSS_HASH);
+ DEV_RX_OFFLOAD_HEADER_SPLIT);
Also some comments on the feature description are inlined below.
Best Regards,
Xiao
> -----Original Message-----
> From: Xiaojun Liu <xiaojun....@silicom.co.il>
> Sent: Friday, March 20, 2020 2:59 PM
> To: Wang, Xiao W <xiao.w.w...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>; Kwan, Ngai-mint <ngai-mint.k...@intel.com>; Keller,
> Jacob E <jacob.e.kel...@intel.com>
> Cc: dev@dpdk.org; Xiaojun Liu <xiaojun....@silicom.co.il>
> Subject: [PATCH v3 5/5] net/fm10k: add switch management support
>
> Split dev init to 2 parts.
> First only register the port in switch
> management; second init hook will be
> called after all the pf are registered
> and switch initialization. It will finish
> dev init. Also add switch interrupt support.
> Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset
> to support mirror operation. Add fm10k_dev_filter_ctrl
> to support flow operation.
> Add dpdk port and pf mapping, so
> the dpdk port can map to a specific pf
> and 1 dpdk port can map to 2 pf to get
> total 100G throughput. Update fm10k.rst.
>
> Signed-off-by: Xiaojun Liu <xiaojun....@silicom.co.il>
> ---
> doc/guides/nics/fm10k.rst | 5 +
> drivers/net/fm10k/fm10k_ethdev.c | 559
> ++++++++++++++++++++++++++++++++++++---
> 2 files changed, 525 insertions(+), 39 deletions(-)
>
> diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst
> index 4e178c2..75f9929 100644
> --- a/doc/guides/nics/fm10k.rst
> +++ b/doc/guides/nics/fm10k.rst
> @@ -124,6 +124,11 @@ FM10000 PMD driver. The switch driver can be
> acquired from Intel support.
> Only Testpoint is validated with DPDK, the latest version that has been
> validated with DPDK is 4.1.6.
>
> +To avoid loading other switch driver from outside of DPDK, there is another
> +way to load switch driver in DPDK. If you want to use the inline switch
> driver,
"There is a way to load..." Since what you do is the only way to load switch
driver inside DPDK.
> +you need to set ''CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=y'' in the
> configure file.
Configuration file.
> +The inline switch driver supports mirror and some flow forward rules.
Please be clear on what forwarding rules are supported. Any doc reader will be
confused by "some".
> +
> Support for Switch Restart
> ~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]
