On 10/25/22 8:01 AM, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 25, 2022 1:26 AM
To: Vargas, Hernan ; dev@dpdk.org;
gak...@marvell.com; t...@redhat.com
Cc: Chautru, Nicolas ; Zhang, Qi Z
; David Marchand ;
Thomas Monjalon
Subje
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Updating the enum for rte_bbdev_op_type
to allow to keep ABI compatible for enum insertion
while adding padded maximum value for array need.
Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing
RTE_BBDEV_OP_TYPE_PADDED_MAX.
Signed-off-by: Nicolas Chau
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Added device status information, so that the PMD can
expose information related to the underlying accelerator device status.
Minor order change in structure to fit into padding hole.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Adding more options in the API to expose the number
of queues exposed and related priority.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/rte_bbdev.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Add support in existing bbdev PMDs for the explicit number of queue
and priority for each operation type configured on the device.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 29 +-
dr
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Extension of bbdev operation to support FFT based operations.
Signed-off-by: Nicolas Chautru
Acked-by: Hemant Agrawal
---
doc/guides/prog_guide/bbdev.rst | 130 +++
lib/bbdev/rte_bbdev.c | 11 ++-
lib/bb
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
This allows to expose more information with regards to any
queue related failure and warning which cannot be supported
in existing API.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 2 ++
lib/bbdev/rte_bbdev.c|
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Locking is not explicitly required but can be valuable
in case the application cannot guarantee to be thread-safe,
or specifically is at risk of using the same queue from multiple threads.
This is an option for PMD to use this.
Signed-off-by: Nicolas C
On 7/6/22 1:21 PM, Chautru, Nicolas wrote:
Hi Stephen, Tom.,
-Original Message-
From: Stephen Hemminger
On Wed, 6 Jul 2022 12:01:19 -0700
Tom Rix wrote:
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Locking is not explicitly required but can be valuable in case the
application
Nic,
Not all my comments were addressed.
The one I am most interested in is the default type / size and how it
interacts with fp16.
Please see the others below
On 7/6/22 2:04 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix >
On 7/5/22 5:23 PM, Nico
On 7/6/22 2:10 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Wednesday, July 6, 2022 9:15 AM
To: Chautru, Nicolas ; dev@dpdk.org;
tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson
On 7/6/22 2:12 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Adding more options in the API to expose the number of queues exposed
and related
On 7/6/22 2:16 PM, Chautru, Nicolas wrote:
-Original Message-
From: Tom Rix
Subject: Re: [PATCH v4 2/7] bbdev: add device status info
On 7/5/22 5:23 PM, Nicolas Chautru wrote:
Added device status information, so that the PMD can expose
information related to the underlying
This is a good start reusing code, but I think it needs to do more reuse.
These cards should be very close and likely represent a family of cards.
On 4/27/22 11:16 AM, Nicolas Chautru wrote:
Support for ACC101 as a derivative of ACC100.
Reusing existing code when possible.
Signed-off-by: Nicol
On 4/27/22 11:17 AM, Nicolas Chautru wrote:
The validation requirement is different for the two
devices.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 40 ++--
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/driver
On 4/27/22 11:17 AM, Nicolas Chautru wrote:
Adding companion function specific to ACC100 and it
can be called from bbdev-test when running from PF.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 57 ++
drivers/baseband/acc100/rte_acc100_cfg.h | 17 ++
On 4/27/22 11:17 AM, Nicolas Chautru wrote:
Ensure the performance monitor is restarted in case this
is reset after VF FLR.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 4
drivers/baseband/acc100/rte_acc100_pmd.h | 6 ++
2 files changed, 10 insert
On 4/27/22 11:17 AM, Nicolas Chautru wrote:
Catch exception in PMD in case of invalid input parameter.
It is not clear if this is 1 fix or 2.
But it does look like an acc100 fix so it should be split from the
acc101 patchset.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100
On 5/9/22 2:23 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Sunday, May 8, 2022 6:03 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; Kinsella, Ray ; Richardson,
Bruce ; hemant.agra...@nxp.com; Zhang,
Mingshan
On 5/9/22 2:36 PM, Chautru, Nicolas wrote:
-Original Message-
From: Tom Rix
Sent: Sunday, May 8, 2022 6:38 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; Kinsella, Ray ; Richardson,
Bruce ; hemant.agra...@nxp.com; Zhang,
Mingshan ; david.march
On 5/9/22 2:45 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Sunday, May 8, 2022 6:56 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; Kinsella, Ray ; Richardson,
Bruce ; hemant.agra...@nxp.com; Zhang,
Mingshan
On 5/16/22 1:48 PM, Nicolas Chautru wrote:
v3: Feedback from Tom Rix: missing copyright, refactor bbdev-test section
calling
the configure companion function for ACC100/101, taking the Pmon commit out
which is not directly required.
These address some of my comments.
The others, mostly
On 9/1/21 8:00 AM, Chautru, Nicolas wrote:
-Original Message-
From: Tom Rix
Sent: Wednesday, September 1, 2021 6:37 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan
; Joshi, Arun
Subject: Re: [PATCH v2 1/6
On 9/7/21 6:04 PM, Chautru, Nicolas wrote:
-Original Message-
From: Tom Rix
Sent: Wednesday, September 1, 2021 7:20 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan
; Joshi, Arun
Subject: Re: [PATCH v2 4/6
t;> 3, next_triplet,
+ ACC100_DMA_BLKID_OUT_HARD);
if (unlikely(next_triplet < 0)) {
rte_bbdev_log(ERR,
"Mismatch between data to process and mbuf data
length in bbdev_op: %p",
Thanks for this change, looks good.
Reviewed-by: Tom Rix
PC_INTERNAL_HARQ_MEMORY_LOOPBACK = (1ULL << 18),
/** Set if a device includes LLR filler bits in the circular buffer
* for HARQ memory. If not set, it is assumed the filler bits are not
* in HARQ memory and handled directly by the LDPC decoder.
*/
- RTE
rc_req, &crc_resp);
+ if (!crc_resp.check_passed)
+ op->status |= 1 << RTE_BBDEV_CRC_ERROR;
}
Thanks for the else-if() change.
Looks good.
Reviewed-by: Tom Rix
#ifdef RTE_BBDEV_OFFLOAD_COST
drop CRC24B bits not to be appended while decoding.
+*/
+ RTE_BBDEV_TURBO_DEC_CRC_24B_DROP = (1ULL << 17)
};
This is ok, thanks.
Reviewed-by: Tom Rix
mp; check_bit(op->turbo_dec.op_flags,
+ RTE_BBDEV_TURBO_DEC_CRC_24B_DROP))
crc24_overlap = 24;
ok if this isn't combined.
the bug moved to its own patch.
Looks good.
Reviewed-by: Tom Rix
/* Calculates circular buffer size.
@@ -1744,7 +1749,8 @@
next_triplet = acc100_dma_fill
provided back in the related harq_combined_output.length when it has processed
and dequeued (previous HARQ iteration).
+
+
The output mbuf data structures are expected to be allocated by the
application with enough room for the output data.
Fine.
Reviewed-by: Tom Rix
On 9/7/21 6:15 PM, Nicolas Chautru wrote:
Queue setup may genuinely fail when adding incremental queues
for a given priority level. In that case application would
attempt to configure a queue at a different priority level.
Not an actual error.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/rt
On 9/13/21 10:03 AM, Chautru, Nicolas wrote:
-Original Message-
From: Tom Rix
Sent: Sunday, September 12, 2021 5:55 AM
To: Chautru, Nicolas ; dev@dpdk.org;
gak...@marvell.com
Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Zhang, Mingshan
; Joshi, Arun
Subject: Re: [PATCH v3 6/6
seg_total_left = rte_pktmbuf_data_len(m_in) - in_offset;
>
> - if (enc->code_block_mode == 0) {
> + if (enc->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) {
> e = (r < enc->tb_params.cab) ?
> enc->tb_params.ea : enc->tb_params.eb;
> } else {
> @@ -1570,7 +1570,7 @@ struct turbo_sw_queue {
> return;
> }
>
> - if (dec->code_block_mode == 0) { /* For Transport Block mode */
> + if (dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) {
> c = dec->tb_params.c;
> } else { /* For Code Block mode */
> k = dec->cb_params.k;
> @@ -1582,7 +1582,7 @@ struct turbo_sw_queue {
> crc24_overlap = 24;
>
> while (mbuf_total_left > 0) {
> - if (dec->code_block_mode == 0)
> + if (dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
> k = (r < dec->tb_params.c_neg) ?
> dec->tb_params.k_neg : dec->tb_params.k_pos;
>
> @@ -1658,7 +1658,7 @@ struct turbo_sw_queue {
> return;
> }
>
> - if (dec->code_block_mode == 0) { /* For Transport Block mode */
> + if (dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) {
> c = dec->tb_params.c;
> e = dec->tb_params.ea;
> } else { /* For Code Block mode */
> @@ -1673,7 +1673,7 @@ struct turbo_sw_queue {
> out_length = ((out_length - crc24_overlap - dec->n_filler) >> 3);
>
> while (mbuf_total_left > 0) {
> - if (dec->code_block_mode == 0)
> + if (dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK)
> e = (r < dec->tb_params.cab) ?
> dec->tb_params.ea : dec->tb_params.eb;
> /* Special case handling when overusing mbuf */
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index f726d73..f946842 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -112,7 +112,7 @@ enum rte_bbdev_op_td_flag_bitmasks {
> /** Set if a device supports scatter-gather functionality */
> RTE_BBDEV_TURBO_DEC_SCATTER_GATHER = (1ULL << 15),
> /** Set to keep CRC24B bits appended while decoding. Only usable when
> - * decoding Transport Blocks (code_block_mode = 0).
> + * decoding Transport Block mode.
>*/
> RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP = (1ULL << 16)
> };
> @@ -209,6 +209,14 @@ enum rte_bbdev_op_ldpcenc_flag_bitmasks {
> RTE_BBDEV_LDPC_ENC_CONCATENATION = (1ULL << 7)
> };
>
> +/** Flags for the Code Block/Transport block mode */
> +enum rte_bbdev_op_cb_mode {
> + /** One operation is one or fraction of one transport block */
> + RTE_BBDEV_TRANSPORT_BLOCK = 0,
> + /** One operation is one code block mode */
> + RTE_BBDEV_CODE_BLOCK = 1,
> +};
Look good.
Thanks for the change,
Reviewed-by: Tom Rix
> +
> /** Data input and output buffer for BBDEV operations */
> struct rte_bbdev_op_data {
> /** The mbuf data structure representing the data for BBDEV operation.
On 9/1/22 1:34 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Thursday, September 1, 2022 6:49 AM
To: Chautru, Nicolas ; Maxime Coquelin
; dev@dpdk.org; tho...@monjalon.net;
gak...@marvell.com; hemant.agra...@nxp.com; Vargas, Hernan
Cc: m...@ashroe.eu
On 10/6/21 1:58 PM, Nicolas Chautru wrote:
Adding device information to capture explicitly the assumption
of the input/output data byte endianness being processed.
Signed-off-by: Nicolas Chautru
---
doc/guides/rel_notes/release_21_11.rst | 1 +
drivers/baseband/acc100/rte_acc10
On 8/19/21 2:10 PM, Nicolas Chautru wrote:
Adding a missing operation when CRC16
is being used for TB CRC check.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_vector.c | 2 ++
doc/guides/prog_guide/bbdev.rst| 3 +++
doc/guides/rel_notes/release_21_11.rst | 1
On 8/19/21 2:10 PM, Nicolas Chautru wrote:
This is to support the case for operation
where CRC16 is to be appended or checked.
Signed-off-by: Nicolas Chautru
---
doc/guides/rel_notes/release_21_11.rst | 3 +++
drivers/baseband/turbo_sw/bbdev_turbo_software.c | 17 +++
On 8/19/21 2:10 PM, Nicolas Chautru wrote:
This implements in PMD the option to drop the CB CRC
after 4G decoding to help transport block concatenation.
Signed-off-by: Nicolas Chautru
---
doc/guides/bbdevs/acc100.rst | 1 +
doc/guides/rel_notes/release_21_11.rst | 4
On 8/19/21 2:10 PM, Nicolas Chautru wrote:
Queue setup may genuinely fail when adding incremental queues
for a given priority level. In that case application would
attempt to configure a queue at a different priority level.
Not an actual error.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/r
On 7/14/22 11:49 AM, Vargas, Hernan wrote:
Hi Tom, Maxime,
Could you please review the v5 series that Nic submitted last week?
https://patches.dpdk.org/project/dpdk/list/?series=23912
Thanks,
Hernan
Hernan,
For this patch series for the acc200, will you be able to refactor it so
acc has a
On 7/7/22 10:13 AM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Thursday, July 7, 2022 6:34 AM
To: Chautru, Nicolas ; dev@dpdk.org;
tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson
On 7/7/22 10:15 AM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Thursday, July 7, 2022 6:37 AM
To: Chautru, Nicolas ; dev@dpdk.org;
tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson
On 7/7/22 10:19 AM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Thursday, July 7, 2022 6:21 AM
To: Chautru, Nicolas ; dev@dpdk.org;
tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson
On 7/7/22 9:57 AM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Nic,
Not all my comments were addressed.
The one I am most interested in is the default type / size and how it interacts
with fp16.
My bad, I had replied to all that (and fixed some of them in
k.org/project/dpdk/list/?series=23912
Thanks,
Hernan
-Original Message-
From: Tom Rix
Sent: Sunday, July 17, 2022 8:08 AM
To: Vargas, Hernan ; Maxime Coquelin
; Chautru, Nicolas ;
dev@dpdk.org; tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com
Cc: m...@ashroe.eu; Richa
On 8/15/22 10:52 PM, Hernan Vargas wrote:
Upstreaming ACC100 changes for 22.11.
This patch series is dependant on series:
https://patches.dpdk.org/project/dpdk/patch/1657150110-69957
Can you go into some more detail about these changes ?
Ex/ which are the fixes and which are the features ?
On 8/30/22 12:45 PM, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, August 30, 2022 12:45 AM
To: Chautru, Nicolas ; dev@dpdk.org;
tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com;
t...@redhat.com; Vargas, Hernan
Cc: m...@ash
On 8/31/22 3:37 PM, Chautru, Nicolas wrote:
Hi Thomas, Tom,
-Original Message-
From: Tom Rix
Sent: Wednesday, August 31, 2022 12:26 PM
To: Chautru, Nicolas ; Maxime Coquelin
; dev@dpdk.org; tho...@monjalon.net;
gak...@marvell.com; hemant.agra...@nxp.com; Vargas, Hernan
Cc: m
On 8/31/22 6:26 PM, Chautru, Nicolas wrote:
Hi Tom,
-Original Message-
From: Tom Rix
Sent: Wednesday, August 31, 2022 5:28 PM
To: Chautru, Nicolas ; Maxime Coquelin
; dev@dpdk.org; tho...@monjalon.net;
gak...@marvell.com; hemant.agra...@nxp.com; Vargas, Hernan
Cc: m...@ashroe.eu
On 10/23/20 4:42 PM, Nicolas Chautru wrote:
> Adding explicit different ut when testing for validation
> or latency (early termination enabled or not).
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Aidan Goddard
> Acked-by: Dave Burley
> ---
> app/test-bbdev/test_bbdev_perf.c | 92
> +++
On 10/23/20 4:42 PM, Nicolas Chautru wrote:
> Adding explicit check in ut that the stats counters
> have the expect values. Was missing for coverage.
missing from coverage
?
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Aidan Goddard
> Acked-by: Dave Burley
> ---
> app/test-bbdev/test_bbd
On 10/23/20 4:42 PM, Nicolas Chautru wrote:
> Run preloading explicitly for unit tests. Load each code block
> by reusing existing input op then restore for the actual test.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> app/test-bbdev/main.h| 1 +
> app/test-
On 10/23/20 4:42 PM, Nicolas Chautru wrote:
> Replacing magic number for default wait time for hw
> offload.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> app/test-bbdev/test_bbdev_perf.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/ap
ags,
> + RTE_BBDEV_LDPC_LLR_COMPRESSION))
> bler_function = bler_pmd_lcore_ldpc_dec;
> else
> return TEST_SKIPPED;
Looks ok.
Reviewed-by: Tom Rix
@@
> #define GET_SOCKET(socket_id) (((socket_id) == SOCKET_ID_ANY) ? 0 :
> (socket_id))
>
> #define MAX_QUEUES RTE_MAX_LCORE
> -#define TEST_REPETITIONS 1000
> +#define TEST_REPETITIONS 100
> #define WAIT_OFFLOAD_US 1000
>
> #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC
Looks ok
Reviewed-by: Tom Rix
On 10/23/20 4:43 PM, Nicolas Chautru wrote:
> update offload dequeue to retrieve the full ring to be
> agnostic of implementation.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Aidan Goddard
> Acked-by: Dave Burley
> ---
> app/test-bbdev/test_bbdev_perf.c | 16
> 1 file chan
On 10/26/20 9:04 AM, Chautru, Nicolas wrote:
>> From: Tom Rix
>> Sent: Monday, October 26, 2020 6:33 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: david.march...@redhat.com
>> Subject: Re: [PATCH v5 4/7] app/bbdev: define wait for
On 10/26/20 9:27 AM, Chautru, Nicolas wrote:
>> -Original Message-
>> From: Tom Rix
>> Sent: Monday, October 26, 2020 6:56 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: david.march...@redhat.com
>> Subject: Re: [PATCH
On 10/26/20 9:29 AM, Chautru, Nicolas wrote:
>> -Original Message-
>> From: Tom Rix
>> Sent: Monday, October 26, 2020 6:06 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: david.march...@redhat.com
>> Subject: Re: [PATCH
On 10/26/20 9:50 AM, Chautru, Nicolas wrote:
>> -Original Message-
>> From: Tom Rix
>> Sent: Monday, October 26, 2020 6:32 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: david.march...@redhat.com
>> Subject: Re: [PATC
On 10/26/20 10:30 AM, Chautru, Nicolas wrote:
>> -Original Message-
>> From: Tom Rix
>> Sent: Monday, October 26, 2020 5:56 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: david.march...@redhat.com
>> Subject: Re: [PA
On 11/2/20 12:53 PM, Nicolas Chautru wrote:
> Adding reference to pf_bb_config in github to do
> device configuration of the fpga_5gnr, fpga_lte and
> acc100 devices and pmds.
>
> Signed-off-by: Nicolas Chautru
> ---
> doc/guides/bbdevs/acc100.rst| 19 +++
> doc/guides/b
On 11/3/20 7:58 AM, Chautru, Nicolas wrote:
>
>> -Original Message-
>> From: Tom Rix
>> Sent: Tuesday, November 3, 2020 7:07 AM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com; tho...@monjalon.net
>> Cc: Mcnamara, John ;
>>
o companion configuration tool
>
> doc/guides/bbdevs/acc100.rst| 19 +++
> doc/guides/bbdevs/fpga_5gnr_fec.rst | 19 +++
> doc/guides/bbdevs/fpga_lte_fec.rst | 19 +++
> 3 files changed, 57 insertions(+)
>
Looks good, thanks.
Reviewed-by: Tom Rix
sue: ... ' from the log.
Reviewed-by: Tom Rix
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 9 -
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c
> b/drivers/baseband/acc100/rte_acc100_pmd.c
> index 47ddba
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Add stubs for the ACC100 PMD
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> doc/guides/bbdevs/acc100.rst | 233
> +
> doc/guides/bbdevs/features/acc100.ini | 14 ++
> doc/
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Add in the list of registers for the device and related
> HW specs definitions.
>
> Signed-off-by: Nicolas Chautru
> Reviewed-by: Rosen Xu
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/acc100_pf_enum.h | 1068
> +
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Add in the "info_get" function to the driver, to allow us to query the
> device.
> No processing capability are available yet.
> Linking bbdev-test to support the PMD with null capability.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
>
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Adding function to create and configure queues for
> the device. Still no capability.
>
> Signed-off-by: Nicolas Chautru
> Reviewed-by: Rosen Xu
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 420
>
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Adding LDPC decode and encode processing operations
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> Acked-by: Dave Burley
> ---
> doc/guides/bbdevs/features/acc100.ini|8 +-
> drivers/baseband/acc100/rte_acc100_pmd.c | 1625
>
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Additional support for HARQ memory loopback
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 158
> +++
> 1 file changed, 158 insertions(+)
>
> diff --git a/d
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Adding capability for 4G encode and decoder processing
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> doc/guides/bbdevs/features/acc100.ini|4 +-
> drivers/baseband/acc100/rte_acc100_pmd.c | 1010
> +
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Adding capability and functions to support MSI
> interrupts, call backs and inforing.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 288
> ++-
> drivers/ba
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Debug functions to validate the input API from user
> Only enabled in DEBUG mode at build time
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 424
> +++
> 1
On 9/28/20 5:29 PM, Nicolas Chautru wrote:
> Add configure function to configure the PF from within
> the bbdev-test itself without external application
> configuration the device.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
> ---
> app/test-bbdev/test_bbdev_perf.c
On 9/29/20 4:17 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> -Original Message-----
>> From: Tom Rix
>> Sent: Tuesday, September 29, 2020 12:54 PM
>> To: Chautru, Nicolas ; dev@dpdk.org;
>> akhil.go...@nxp.com
>> Cc: Richardson, Bruce ;
On 9/29/20 4:30 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Add in the list of registers for the device and related
>>> HW specs definitions.
>>>
>>> Signed-off-by: Nicolas
On 9/29/20 5:25 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Add in the "info_get" function to the driver, to allow us to query the
>>> device.
>>> No processing capability a
On 9/29/20 6:03 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Adding function to create and configure queues for the device. Still
>>> no capability.
>>>
>>> Signed-off-by: Ni
On 9/30/20 11:52 AM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Adding LDPC decode and encode processing operations
>>>
>>> Signed-off-by: Nicolas Chautru
>>> Acked-by: Liu Tianji
On 9/30/20 11:55 AM, Chautru, Nicolas wrote:
> Hi Tom,
>
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Additional support for HARQ memory loopback
>>>
>>> Signed-off-by: Nicolas Chautru
>>> Acked-by: Liu Tianji
On 9/30/20 12:10 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Adding capability for 4G encode and decoder processing
>>>
>>> Signed-off-by: Nicolas Chautru
>>> Acked-by: Liu Ti
On 9/30/20 12:45 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Adding capability and functions to support MSI interrupts, call backs
>>> and inforing.
>>>
>>> Sign
On 9/30/20 12:53 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Debug functions to validate the input API from user Only enabled in
>>> DEBUG mode at build time
>>>
>>> Sign
On 9/30/20 3:54 PM, Chautru, Nicolas wrote:
> Hi Tom,
>
>> From: Tom Rix
>> On 9/28/20 5:29 PM, Nicolas Chautru wrote:
>>> Add configure function to configure the PF from within the
>>> bbdev-test itself without external application configuration the de
On 10/1/20 2:54 PM, Thomas Monjalon wrote:
> 01/10/2020 23:22, Chautru, Nicolas:
>> From: t...@redhat.com
>>> From: Tom Rix
>>>
>>> Copied from the Linux kernel MAINTAINERS file.
>>> A Reviewer is designated person who wishes to review changes in
On 10/2/20 8:41 AM, Thomas Monjalon wrote:
> 02/10/2020 16:59, Tom Rix:
>> On 10/1/20 2:54 PM, Thomas Monjalon wrote:
>>> 01/10/2020 23:22, Chautru, Nicolas:
>>>> From: t...@redhat.com
>>>>> From: Tom Rix
>>>>>
>>>>> Co
gnr_fec/rte_pmd_fpga_5gnr_fec.h
> @@ -30,7 +30,7 @@ extern "C" {
> /**
> * Structure to pass FPGA 4G FEC configuration.
4G ?
There are a number of 4G references in this file's comments.
Consider a future patch to clean this up.
> */
> -struct fpga_5gnr_fec_conf {
> +struct rte_fpga_5gnr_fec_conf {
> /** 1 if PF is used for dataplane, 0 for VFs */
> bool pf_mode_en;
> /** Number of UL queues per VF */
> @@ -64,8 +64,8 @@ struct fpga_5gnr_fec_conf {
> */
> __rte_experimental
> int
> -fpga_5gnr_fec_configure(const char *dev_name,
> - const struct fpga_5gnr_fec_conf *conf);
> +rte_fpga_5gnr_fec_configure(const char *dev_name,
> + const struct rte_fpga_5gnr_fec_conf *conf);
>
> #ifdef __cplusplus
> }
Changes look complete.
Reviewed-by: Tom Rix
gt; */
> __rte_experimental
> int
> -fpga_lte_fec_configure(const char *dev_name,
> - const struct fpga_lte_fec_conf *conf);
> +rte_fpga_lte_fec_configure(const char *dev_name,
> + const struct rte_fpga_lte_fec_conf *conf);
>
> #ifdef __cplusplus
> }
> diff --git
> a/drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map
> b/drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map
> index a2ab086cd8..b95b7838e8 100644
> --- a/drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map
> +++ b/drivers/baseband/fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map
> @@ -5,6 +5,6 @@ DPDK_21 {
> EXPERIMENTAL {
> global:
>
> - fpga_lte_fec_configure;
> + rte_fpga_lte_fec_configure;
>
> };
Looks fine.
Reviewed-by: Tom Rix
0.ini
> create mode 100644 drivers/baseband/acc100/meson.build
> create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c
> create mode 100644 drivers/baseband/acc100/rte_acc100_pmd.h
> create mode 100644 drivers/baseband/acc100/rte_pmd_bbdev_acc100_version.map
Looks fine.
Reviewed-by: Tom Rix
s/baseband/acc100/acc100_vf_enum.h
Thanks for the changes.
Reviewed-by: Tom Rix
On 10/1/20 6:01 PM, Nicolas Chautru wrote:
> Add in the "info_get" function to the driver, to allow us to query the
> device.
> No processing capability are available yet.
> Linking bbdev-test to support the PMD with null capability.
>
> Signed-off-by: Nicolas Chautru
> Acked-by: Liu Tianjiao
>
On 10/1/20 6:01 PM, Nicolas Chautru wrote:
> Adding function to create and configure queues for
> the device. Still no capability.
>
> Signed-off-by: Nicolas Chautru
> Reviewed-by: Rosen Xu
> Acked-by: Liu Tianjiao
> ---
> drivers/baseband/acc100/rte_acc100_pmd.c | 445
>
original
change ?
If not, well that's ok.
Tom
> Thanks
> Nic
>
>> -Original Message-
>> From: t...@redhat.com
>> Sent: Monday, October 5, 2020 8:00 AM
>> To: tho...@monjalon.net; Chautru, Nicolas
>> Cc: dev@dpdk.org; Tom Rix
>> Sub
This change looks fine.
Reviewed-by: Tom Rix
In looking at the surrounding code i see the is-pf bool being found by checking
the driver name.
That is a fairly expensive check.
Is there a better way to do that ?
Tom
On 10/6/20 3:04 AM, Maxime Coquelin wrote:
> This series fixes segfau
95 matches
Mail list logo
