On 10/23/20 4:43 PM, Nicolas Chautru wrote:
> update offload dequeue to retrieve the full ring to be
> agnostic of implementation.
>
> Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com>
> Acked-by: Aidan Goddard <aidan.godd...@accelercomm.com>
> Acked-by: Dave Burley <dave.bur...@accelercomm.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c
> b/app/test-bbdev/test_bbdev_perf.c
> index b5dc536..a6884c5 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -4463,8 +4463,8 @@ typedef int (test_case_function)(struct active_device
> *ad,
> /* Dequeue one operation */
This comment and similar need to change, not doing just 1 anymore
> do {
> deq += rte_bbdev_dequeue_dec_ops(dev_id, queue_id,
> - &ops_deq[deq], 1);
> - } while (unlikely(deq != 1));
> + &ops_deq[deq], enq);
> + } while (unlikely(deq == 0));
This check looks wrong, should likely be (deq != enq)
Similar below
Tom
>
> deq_last_time = rte_rdtsc_precise() - deq_start_time;
> time_st->deq_max_time = RTE_MAX(time_st->deq_max_time,
> @@ -4554,8 +4554,8 @@ typedef int (test_case_function)(struct active_device
> *ad,
> /* Dequeue one operation */
> do {
> deq += rte_bbdev_dequeue_ldpc_dec_ops(dev_id, queue_id,
> - &ops_deq[deq], 1);
> - } while (unlikely(deq != 1));
> + &ops_deq[deq], enq);
> + } while (unlikely(deq == 0));
>
> deq_last_time = rte_rdtsc_precise() - deq_start_time;
> time_st->deq_max_time = RTE_MAX(time_st->deq_max_time,
> @@ -4642,8 +4642,8 @@ typedef int (test_case_function)(struct active_device
> *ad,
> /* Dequeue one operation */
> do {
> deq += rte_bbdev_dequeue_enc_ops(dev_id, queue_id,
> - &ops_deq[deq], 1);
> - } while (unlikely(deq != 1));
> + &ops_deq[deq], enq);
> + } while (unlikely(deq == 0));
>
> deq_last_time = rte_rdtsc_precise() - deq_start_time;
> time_st->deq_max_time = RTE_MAX(time_st->deq_max_time,
> @@ -4725,8 +4725,8 @@ typedef int (test_case_function)(struct active_device
> *ad,
> /* Dequeue one operation */
> do {
> deq += rte_bbdev_dequeue_ldpc_enc_ops(dev_id, queue_id,
> - &ops_deq[deq], 1);
> - } while (unlikely(deq != 1));
> + &ops_deq[deq], enq);
> + } while (unlikely(deq == 0));
>
> deq_last_time = rte_rdtsc_precise() - deq_start_time;
> time_st->deq_max_time = RTE_MAX(time_st->deq_max_time,
