Re: [dpdk-dev] [PATCH] eal/vfio: share the default container in multi process

2018-10-05 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, October 5, 2018 10:58 AM > > > + if (internal_config.process_type == RTE_PROC_PRIMARY) { > > + /* if we were secondary process we would try requesting > > +* container fd from the primary, but we're

Re: [dpdk-dev] [PATCH] eal: fixup hotplugging an already present device

2018-10-26 Thread Stojaczyk, Dariusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, October 25, 2018 1:49 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] eal: fixup hotplugging an already present device > > 25/10/201

Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on device hotplug

2018-10-29 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, October 26, 2018 4:22 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak > on device hotplug > &g

Re: [dpdk-dev] [PATCH 2/3] devargs: delay freeing previous devargs when overriding them

2018-11-05 Thread Stojaczyk, Dariusz
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, November 5, 2018 8:31 AM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/3] devargs: delay freeing previous devargs when > overriding them >

Re: [dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each rescan

2018-11-05 Thread Stojaczyk, Dariusz
Hi Gaetan, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Subject: Re: [dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each > rescan > > Hi Darek, > > On Mon, Nov 05, 2018 at 08:04:45AM +0100, Darek Stojaczyk wrote: > > Bus rescan is done e.g. during

Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs

2018-11-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, November 8, 2018 12:21 AM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com; Zhang, Qi Z ; Guo, Jia > ; Stojaczyk, Dariusz > Subject: [PATCH] devargs: do not replace alr

Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs

2018-11-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, November 8, 2018 1:26 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Zhang, Qi Z > ; Guo, Jia > Subject: Re: [PATCH] devargs: do not replace alr

Re: [dpdk-dev] [PATCH v2] dev: don't remove devargs that are still referenced

2018-11-22 Thread Stojaczyk, Dariusz
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, November 22, 2018 10:54 AM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v2] dev: don't remove devargs that are still referenced &g

Re: [dpdk-dev] [PATCH] dev: fix attach rollback of a device that was already attached

2018-11-23 Thread Stojaczyk, Dariusz
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, November 23, 2018 8:11 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: tho...@monjalon.net > Subject: RE: [PATCH] dev: fix attach rollback of a device that was already > attached > > > > >

Re: [dpdk-dev] [PATCH v3] dev: don't remove devargs that are still referenced

2018-11-23 Thread Stojaczyk, Dariusz
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, November 23, 2018 6:05 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org > Cc: gaetan.ri...@6wind.com; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v3] dev: don't

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

2018-09-17 Thread Stojaczyk, Dariusz
Hi, A little bit of self-advertising: I recently pushed patches that will make DPDK default to RTE_IOVA_VA when physical addresses were not explicitly requested and are not available, e.g. when running as a non-privileged user. It shouldn't cause any conflicts with the changes you're proposing

Re: [dpdk-dev] [PATCH v2] eal/bus: use RTE_IOVA_PA only if phys addresses are available

2018-09-17 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, September 17, 2018 12:34 PM > To: Stojaczyk, Dariusz ; dev@dpdk.org; > Santosh Shukla ; Hemant Agrawal > ; Jerin Jacob > > Cc: Maxime Coquelin ; Chas Williams > > Subject: Re: [PATCH v2] eal/bus

Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option

2018-09-21 Thread Stojaczyk, Dariusz
I'd like to point out that the comments inside eal_memory.c are outdated (e.g. the one from line #249). It makes it difficult to review this patch. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Friday, September 21, 2018 1:57 PM > To:

Re: [dpdk-dev] [PATCH v2] vhost: add external message handling callbacks to the public API

2019-01-16 Thread Stojaczyk, Dariusz
> -Original Message- > From: Bie, Tiwei > Sent: Tuesday, January 15, 2019 12:22 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; Wang, Zhihong ; Liang, > Cunming ; Maxime Coquelin > ; Harris, James R > ; Liu, Changpeng > Subject: Re: [PATCH v2] vhost: ad

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, January 18, 2019 11:25 AM > Subject: [PATCH v2] vfio: allow secondary process to query IOMMU type > > It is only possible to know IOMMU type of a given VFIO container > by attempting to initialize it. Since secondary process n

Re: [dpdk-dev] [PATCH] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Stojaczyk, Dariusz
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, February 25, 2019 8:49 AM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Stojaczyk, Dariusz ; > maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH] vhost: add virtio configuration space access socket messages

2019-02-25 Thread Stojaczyk, Dariusz
> -Original Message- > From: Liu, Changpeng > Sent: Monday, February 25, 2019 8:52 AM > To: dev@dpdk.org > Cc: Liu, Changpeng ; Stojaczyk, Dariusz > ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong > Subject: [PATCH] vhost: add virtio configuration space

Re: [dpdk-dev] [RFC v2 1/2] vhost: add API to set protocol features flags

2019-03-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, February 28, 2019 4:32 PM > To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei > ; i.maxim...@samsung.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [RFC v2 1/2] vhost: add API to se

Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

2019-03-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, February 28, 2019 4:32 PM > To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei > ; i.maxim...@samsung.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [RFC v2 2/2] vhost: support request

Re: [dpdk-dev] [PATCH v3 0/2] vhost: Support external backend only vhost-user requests

2019-03-20 Thread Stojaczyk, Dariusz
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 20, 2019 8:35 AM > To: dev@dpdk.org; i.maxim...@samsung.com; Liu, Changpeng > ; Bie, Tiwei ; Stojaczyk, > Dariusz > Subject: Re: [PATCH v3 0/2] vhost: Support

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-03-27 Thread Stojaczyk, Dariusz
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 27, 2019 7:12 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: initialize al

Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas

2019-03-28 Thread Stojaczyk, Dariusz
This patch caused a regression. Any secondary process fails to initialize. Please see the quick fix here: http://patchwork.dpdk.org/patch/51882/ D. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, March 28, 2019 9:45 PM > To: Bu

Re: [dpdk-dev] [PATCH] eal: initialize alarms early

2019-04-01 Thread Stojaczyk, Dariusz
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Wednesday, March 27, 2019 9:34 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] eal: initialize alarms early > > &

Re: [dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers

2020-05-07 Thread Stojaczyk, Dariusz
> -Original Message- > From: Bruce Richardson > Sent: Monday, March 30, 2020 3:53 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org > Subject: Re: [PATCH] build: don't parse build configs of explicitly disabled > drivers > > [SNIP] > > Looking at

Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

2020-05-13 Thread Stojaczyk, Dariusz
> -Original Message- > From: Gaëtan Rivet > Sent: Wednesday, May 13, 2020 11:04 AM > To: Stephen Hemminger > Cc: Stojaczyk, Dariusz ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers > > [SNIP] > > The original code

Re: [dpdk-dev] [PATCH v1 1/2] pci: fix allowing underflow when parsing PCI id

2020-05-14 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev On Behalf Of Gaetan Rivet > Sent: Wednesday, May 13, 2020 12:48 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/2] pci: fix allowing underflow when parsing > PCI > id > > The function strtoul will not return ERANGE if the inp

Re: [dpdk-dev] [PATCH v1 2/2] pci: explain how empty strings are rejected in DBDF

2020-05-14 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev On Behalf Of Gaetan Rivet > Sent: Wednesday, May 13, 2020 12:48 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 2/2] pci: explain how empty strings are rejected > in DBDF > > Empty strings are forbidden as input to rte_pci_addr_parse(). > It is expli

Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition

2020-04-01 Thread Stojaczyk, Dariusz
> From: dev On Behalf Of Michael Haeuptle > Sent: Tuesday, March 31, 2020 6:57 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition > > This fix treats a 0 return value from vfio_open_group_fd > in vfio_get_group_fd as the intended error condition instead > of

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Stojaczyk, Dariusz
This introduces a regression where uio-bound devies are attached to a DPDK app at runtime. When there are no devices attached at initialization, the only safe default should be RTE_IOVA_PA. With RTE_IOVA_VA we just won't be able to do any DMA to uio-bound PCI devices. Can we revert this patch?

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Stojaczyk, Dariusz
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, July 23, 2019 6:19 AM > > > -Original Message- > > From: Stojaczyk, Dariusz > > Sent: Tuesday, July 23, 2019 9:06 AM > > To: Thomas Monjalon ; D

Re: [dpdk-dev] [PATCH v3] eal: pick IOVA as PA if IOMMU is not available

2019-07-25 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 25, 2019 1:06 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Kovacevic, Marko > ; Stojaczyk, Dariusz > ; tho...@monjalon.net; > david.march...@redhat.com; jer...@marvell.com > Subject: [PATCH

Re: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memlea

Re: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; Zhang, > Qi Z ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak > > When sending sync

Re: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:44 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio

Re: [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak > > When sendi

Re: [dpdk-dev] [PATCH v2] ipc: unlock on failure

2019-05-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Monday, May 6, 2019 3:48 PM > To: dev@dpdk.org > Cc: Lipiec, Herakliusz ; sta...@dpdk.org; > Burakov, Anatoly ; David Marchand > > Subject: [dpdk-dev] [PATCH v2] ipc: unlock on failure > > Rep