application
Slawomir Mrozowicz (2):
cryptodev: add functions to retrieve device info
app/crypto-perf: introduce new performance test application
Marcin Kerlin (2)
cryptodev: add functions to retrieve device info
app/crypto-perf: introduce new performance test application
Piotr Azarewicz (1)
app
performed by crypto device.
Signed-off-by: Declan Doherty
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Marcin Kerlin
---
To be applied on top of:
[dpdk-dev,v4] crypto/aesni_gcm: migration from MB library to ISA-L
v2 changes:
- code style fix
- add information in version.map about changes
Slawomir Mrozowicz (3):
cryptodev: add functions to retrieve device info
app/crypto-perf: introduce new performance test application
doc: describe new performance test application
Marcin Kerlin (3)
cryptodev: add functions to retrieve device info
app/crypto-perf: introduce new performance test
performed by crypto device.
Signed-off-by: Declan Doherty
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Marcin Kerlin
---
To be applied on top of:
[dpdk-dev,v4] crypto/aesni_gcm: migration from MB library to ISA-L
v2 changes:
- code style fix
- add information in version.map about changes
Add test vectors example files to the performance test application.
Signed-off-by: Marcin Kerlin
---
v4 changes:
- split the test vectors files to separate patch
---
app/test-crypto-perf/data/aes_cbc_128_sha.data | 503
app/test-crypto-perf/data/aes_cbc_192_sha.data | 50
Add documentation to describe using the new performance test application.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Piotr Azarewicz
---
v4 changes:
- split the documentation to separate patch
---
doc/guides/rel_notes/release_17_02.rst | 5 +
doc/guides/tools/cryptoperf.rst
This patch fix problem in function rte_cryptodev_devices_get().
Program received signal SIGSEGV, Segmentation fault.
It also rework the function to use correct types and clean up visibility.
Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
Signed-off-by: Slawomir Mrozowicz
This patch fix problem in function rte_cryptodev_devices_get().
Program received signal SIGSEGV, Segmentation fault.
It rework the function to use correct types and clean up visibility.
It also fix Coverity ID 141073
Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info")
Signed-off-by
Dereferencing a pointer that might be null key_token when calling strstr.
Check if the pointer is null before.
Coverity issue: 141071
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Signed-off-by: Slawomir Mrozowicz
---
app/test-c
erformance test application")
Signed-off-by: Slawomir Mrozowicz
---
app/test-crypto-perf/cperf_test_vectors.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/app/test-crypto-perf/cperf_test_vectors.c
b/app/test-crypto-perf/cperf_test_vectors.c
index e
al to cipher key data.
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Signed-off-by: Slawomir Mrozowicz
---
v2 changes:
- kasumi, snow3g or zug have differ auth and cipher key data
---
app/test-crypto-perf/cperf_test_vectors.c | 44 +++
- change gmac aad max size
- update documentation and commits comments
Changes in V2:
- add gcm/gmac algorithm correction
- unit test rework
Slawomir Mrozowicz (1):
libcrypto_pmd: initial implementation of SW crypto device
Piotr Azarewicz (3)
app/test: cryptodev AES tests rework
app/test
to librte_cryptodev
library.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Michal Kobylinski
Signed-off-by: Tomasz Kulasek
Signed-off-by: Daniel Mrzyglod
---
v2:
- add gcm crypto cipher and authentication algorithm
- rework gmac crypto authentication algorithm
v3:
- fix pmd according to
This patch rework AES tests .
In general - rename AES-named functions to blockcipher functions pattern.
Signed-off-by: Piotr Azarewicz
Signed-off-by: Fiona Trahe
---
app/test/Makefile |2 +-
app/test/test_cryptodev.c | 74 +-
app/test/test_cryptod
This patch containes unit tests for libcrypto PMD. User can
use app/test application to check how to use this pmd and to
verify crypto processing.
Test name is cryptodev_libcrypto_autotest.
For performance test cryptodev_libcrypto_perftest can be used.
Signed-off-by: Piotr Azarewicz
Signed-off-b
Libcrypto PMD has support for:
Supported cipher algorithms:
RTE_CRYPTO_CIPHER_3DES_CBC
RTE_CRYPTO_CIPHER_AES_CBC
RTE_CRYPTO_CIPHER_AES_CTR
RTE_CRYPTO_CIPHER_3DES_CTR
RTE_CRYPTO_CIPHER_AES_GCM
Supported authentication algorithms:
RTE_CRYPTO_AUTH_AES_GMAC
RTE_CRYPTO_AUTH_MD5
RTE_CRYPTO_AUTH_SHA1
RT
This patch add big data AES-GMAC test for libcrypto PMD.
Signed-off-by: Piotr Azarewicz
---
app/test/test_cryptodev.c | 18 +-
app/test/test_cryptodev_gcm_test_vectors.h | 8245 +++-
2 files changed, 8242 insertions(+), 21 deletions(-)
diff --git a/app
--buffer-sz 64
Declan Doherty (3)
eal: add quiet mode to suppress log output to stdout
lib/librte_cryptodev: functions for new performance test application
app/crypto-perf: introduce new performance test application
Slawomir Mrozowicz (2):
lib/librte_cryptodev: functions for new performance
Add EAL option to suppresses all log output to stdout.
Signed-off-by: Declan Doherty
---
lib/librte_eal/common/eal_common_log.c | 13 +
lib/librte_eal/common/eal_common_options.c | 10 +-
lib/librte_eal/common/eal_options.h | 2 ++
lib/librte_eal/co
This patch adds helper functions for new performance application.
Application can be used to measute throughput and latency of
cryptography operation performed by crypto device.
Signed-off-by: Declan Doherty
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Marcin Kerlin
---
lib
Dereferencing a pointer that might be null key_token when calling strstr.
Check if the pointer is null before.
Coverity issue: 141071
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Signed-off-by: Slawomir Mrozowicz
---
v2 changes:
- print messa
freeing
memory space for not enqueued packets.
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Signed-off-by: Slawomir Mrozowicz
---
app/test-crypto-perf/cperf_test_latency.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
di
ns are using Openssl library crypto API.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Signed-off-by: Slawomir Mrozowicz
---
MAINTAINERS|6 +-
app/test/test_cryptodev.c | 56 +-
app/test/tes
/dev/patchwork/patch/15323/
http://dpdk.org/dev/patchwork/patch/15317/
http://dpdk.org/dev/patchwork/patch/15318/
http://dpdk.org/dev/patchwork/patch/15327/
Slawomir Mrozowicz (1):
libcrypto_pmd: initial implementation of SW crypto device
Piotr Azarewicz (1)
app/test: added tests for
to librte_cryptodev
library.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Michal Kobylinski
Signed-off-by: Tomasz Kulasek
Signed-off-by: Daniel Mrzyglod
---
v2:
- add gcm crypto cipher and authentication algorithm
- rework gmac crypto authentication algorithm
v3:
- fix pmd according to
Libcrypto PMD has support for:
Supported cipher algorithms:
RTE_CRYPTO_CIPHER_3DES_CBC
RTE_CRYPTO_CIPHER_AES_CBC
RTE_CRYPTO_CIPHER_AES_CTR
RTE_CRYPTO_CIPHER_3DES_CTR
RTE_CRYPTO_CIPHER_AES_GCM
Supported authentication algorithms:
RTE_CRYPTO_AUTH_AES_GMAC
RTE_CRYPTO_AUTH_MD5
RTE_CRYPTO_AUTH_SHA1
RT
This patch containes unit tests for libcrypto PMD. User can
use app/test application to check how to use this pmd and to
verify crypto processing.
Test name is cryptodev_libcrypto_autotest.
For performance test cryptodev_libcrypto_perftest can be used.
Signed-off-by: Piotr Azarewicz
Signed-off-b
CRYPTODEV_NAME_SNOW3G_PMD
CRYPTODEV_NAME_KASUMI_PMD
CRYPTODEV_NAME_ZUC_PMD
CRYPTODEV_NAME_ARMV8_PMD
CRYPTODEV_NAME_SCHEDULER_PMD
CRYPTODEV_NAME_DPAA2_SEC_PMD
Signed-off-by: Slawomir Mrozowicz
---
doc/guides/rel_notes/deprecation.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/rel_notes
RTE_PMD_REGISTER_CRYPTO_DRIVER which returns a unique
uint8_t identifier for that driver. New APIs are also introduced
to allow retrieval of the driver id using the driver name.
Library code is included in the RFC
(implementation in progress, API complete).
Signed-off-by: Slawomir Mrozowicz
---
drivers/crypto
to rte_cryptodev_device_count_by_driver().
Signed-off-by: Slawomir Mrozowicz
---
Refer to RFC patch: http://dpdk.org/dev/patchwork/patch/24119/
---
doc/guides/rel_notes/deprecation.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_no
RTE_PMD_REGISTER_CRYPTO_DRIVER which returns a unique
uint8_t identifier for that driver. New APIs are also introduced
to allow retrieval of the driver id using the driver name.
Signed-off-by: Slawomir Mrozowicz
---
doc/guides/prog_guide/cryptodev_lib.rst| 5 +-
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
RTE_PMD_REGISTER_CRYPTO_DRIVER which returns a unique
uint8_t identifier for that driver. New APIs are also introduced
to allow retrieval of the driver id using the driver name.
Signed-off-by: Slawomir Mrozowicz
---
v2 changes:
- add release notes information
- reduce some call of rte_cryptodev_driver_id_get
- remove
name string provided in command line.
Signed-off-by: Slawomir Mrozowicz
---
doc/guides/rel_notes/release_17_08.rst | 2 ++
drivers/crypto/aesni_gcm/aesni_gcm_pmd_private.h | 3 +++
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 3 +++
drivers/crypto/armv8
Cc: ian.be...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Slawomir Mrozowicz
---
examples/performance-thread/common/lthread.h | 2 +-
examples/performance-thread/common/lthread_sched.c | 11 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/examples/performance-thr
ned-off-by: Slawomir Mrozowicz
---
examples/performance-thread/common/lthread_sched.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/examples/performance-thread/common/lthread_sched.c
b/examples/performance-thread/common/lthread_sched.c
index 98291478e..138a87d32 10
.@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Slawomir Mrozowicz
---
examples/performance-thread/common/lthread_tls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/performance-thread/common/lthread_tls.c
b/examples/performance-thread/common/lthread_tls.c
index 4
.@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Slawomir Mrozowicz
---
examples/performance-thread/common/lthread_tls.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/examples/performance-thread/common/lthread_tls.c
b/examples/performance-thread/common/lthread_tl
Overrunning array mcfg->memseg of 256 44-byte elements
at element index 257 using index j.
Fixed by add condition with message information.
Fixes: af75078fece3 ("first public release")
Coverity ID 13282
Signed-off-by: Slawomir Mrozowicz
---
lib/librte_eal/linuxapp/eal/eal_
Calling rte_eth_dev_rss_hash_update without checking return value.
Fixed by handle return value and print out error status.
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Coverity ID 119251
Signed-off-by: Slawomir Mrozowicz
---
app/test-pmd/cmdline.c | 10 +++
Overrunning array mcfg->memseg of 256 44-byte elements
at element index 257 using index j.
Fixed by add condition with message information.
Fixes: af75078fece3 ("first public release")
Coverity ID 13282
Signed-off-by: Slawomir Mrozowicz
---
lib/librte_eal/linuxapp/eal/eal
Overrunning array mcfg->memseg of 256 44-byte elements
at element index 257 using index j.
Fixed by add condition with message information.
Fixes: af75078fece3 ("first public release")
Coverity ID 13282
Signed-off-by: Slawomir Mrozowicz
---
v5:
- update message
v4:
- remove check c
Overrunning array crypto_statistics of 32 64-byte elements
at element index 63 using index cdevid.
Fixed by extend crypto_statistics array.
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
Coverity ID 120145
Signed-off-by: Slawomir Mrozowicz
---
examples/l2
Overrunning array crypto_statistics of 32 64-byte elements
at element index 63 using index cdevid.
Fixed by extend crypto_statistics array.
Coverity ID 120145
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
Signed-off-by: Slawomir Mrozowicz
---
v2:
- corr
lrand48 should not be used for security related applications,
as linear congruential algorithms are too easy to break.
Used a compliant random number generator /dev/urandom.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Coverity ID 124558
Signed-off-by
: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Signed-off-by: Slawomir Mrozowicz
---
examples/ipsec-secgw/sa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index b6260ed..503e345 10
It fix coverity issue:
CID 124557 (#1 of 1): Unchecked return value (CHECKED_RETURN)
3. check_return: Calling rte_eth_tx_buffer_set_err_callback without checking
return value (as is done elsewhere 6 out of 7 times).
Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
Signed-off-by
It fix coverity issue:
CID 30699 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)
copy_paste_error: rx_port in pconf->rx_port looks like a copy-paste error.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Slawomir Mrozowicz
---
examples/qos_sched/args.c | 2 +-
1 fi
Signed-off-by: Slawomir Mrozowicz
---
examples/qos_sched/args.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 3e7fd08..d819269 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -175
r: git-send-email 1.9.1
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Slawomir Mrozowicz
---
examples/qos_sched/args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 3e7fd08..7a98e5c 10064
It fix coverity issue:
CID 30690 (#1 of 1): Bad bit shift operation (BAD_SHIFT)
10. large_shift: In expression 1ULL << i, left shifting by more than 63 bits
has undefined behavior. The shift amount, i, is as much as 127.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-
It fix coverity issue:
CID 30693 (#1 of 1): Unchecked return value (CHECKED_RETURN)
2. check_return: Calling rte_meter_srtcm_config without checking return value
(as is done elsewhere 16 out of 17 times).
Fixes: e6541fdec8b2 ("meter: initial import")
Signed-off-by: Slawomir
Fix issue reported by Coverity.
Coverity ID 13282: Out-of-bounds write
overrun-local: Overrunning array mcfg->memseg of 256 44-byte elements
at element index 257 using index j.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Slawomir Mrozowicz
---
lib/librte_eal
Fix issue reported by Coverity.
Coverity ID 13282: Out-of-bounds write
overrun-local: Overrunning array mcfg->memseg of 256 44-byte elements
at element index 257 using index j.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Slawomir Mrozowicz
---
lib/librte_eal
Fix issue reported by Coverity.
Coverity ID 13205: Unchecked return value
Unchecked return value
check_return: Calling rte_lpm6_add without checking return value
Fixes: 5c510e13a9cb ("lpm: add IPv6 support")
Signed-off-by: Slawomir Mrozowicz
---
lib/librte_lpm/rte_lpm6.c | 10 +++
Fix issue reported by Coverity.
Coverity ID 30693: Unchecked return value
check_return: Calling rte_meter_srtcm_config without checking return value.
Fixes: e6541fdec8b2 ("meter: initial import")
Signed-off-by: Slawomir Mrozowicz
---
examples/qos_meter/main.c | 15 ++-
Fix issue reported by Coverity.
Coverity ID 30690: Bad bit shift operation
large_shift: In expression 1ULL << i, left shifting by more than 63 bits
has undefined behavior. The shift amount, i, is as much as 127.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Sl
Fix issue reported by Coverity.
Coverity ID 30690: Bad bit shift operation
large_shift: In expression 1ULL << i, left shifting by more than 63 bits
has undefined behavior. The shift amount, i, is as much as 127.
Fixes: de3cfa2c9823 ("sched: initial import")
Signed-off-by: Sl
Fix issue reported by Coverity.
Coverity ID 13243: Division or modulo by zero
In function call rte_mempool_xmem_size, division by expression total_size
which may be zero has undefined behavior.
Fixes: 148f963fb532 ("xen: core library changes")
Signed-off-by: Slawomir Mrozowicz
Fix issue reported by Coverity.
Coverity ID 30693: Unchecked return value
check_return: Calling rte_meter_srtcm_config without checking return value.
Fixes: e6541fdec8b2 ("meter: initial import")
Signed-off-by: Slawomir Mrozowicz
---
examples/qos_meter/main.c | 16
Fix issue reported by Coverity.
Coverity ID 13243: Division or modulo by zero
In function call rte_mempool_xmem_size, division by expression total_size
which may be zero has undefined behavior.
Fixes: 148f963fb532 ("xen: core library changes")
Signed-off-by: Slawomir Mrozowicz
_index << 20 is greater than 0x7FFF,
the upper bits of the result will all be 1.
To fix the issue set explicit cast uint32_t of pf->fdir.match_counter_index.
Fixes: 05999aab4ca6 ("i40e: add or delete flow director")
Coverity ID 13315
Signed-off-by: Slawomir Mrozowicz
---
drive
Calling i40e_switch_tx_queue without checking return value.
Fixed by add warning log information if return failed.
Fixes: 71d35259ff67 ("i40e: tear down flow director")
Coverity ID 13208
Signed-off-by: Slawomir Mrozowicz
---
drivers/net/i40e/i40e_fdir.c | 5 -
1 file changed, 4
Negative array index write using variable pos as an index to array
enic->fdir.nodes.
Fixed by add array index check.
Fixes: fefed3d1e62c ("enic: new driver")
Coverity ID 13270
Signed-off-by: Slawomir Mrozowicz
---
drivers/net/enic/enic_clsf.c | 6 ++
1 file changed, 6 insert
- fix pmd according to negative verification tests
- change gmac aad max size
- update documentation and commits comments
Changes in V2:
- add gcm/gmac algorithm correction
- unit test rework
Slawomir Mrozowicz (1):
libcrypto_pmd: initial implementation of SW crypto device
Piotr Azarewicz (2
to librte_cryptodev
library.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Michal Kobylinski
Signed-off-by: Tomasz Kulasek
Signed-off-by: Daniel Mrzyglod
---
v2:
- add gcm crypto cipher and authentication algorithm
- rework gmac crypto authentication algorithm
v3:
- fix pmd according to
This patch rework AES tests .
In general - rename AES-named functions to blockcipher functions pattern.
Signed-off-by: Piotr Azarewicz
Signed-off-by: Fiona Trahe
---
app/test/Makefile |2 +-
app/test/test_cryptodev.c | 74 +-
app/test/test_cryptod
This patch containes unit tests for libcrypto PMD. User can
use app/test application to check how to use this pmd and to
verify crypto processing.
Test name is cryptodev_libcrypto_autotest.
For performance test cryptodev_libcrypto_perftest can be used.
Signed-off-by: Piotr Azarewicz
Signed-off-b
Libcrypto PMD has support for:
Supported cipher algorithms:
RTE_CRYPTO_CIPHER_3DES_CBC
RTE_CRYPTO_CIPHER_AES_CBC
RTE_CRYPTO_CIPHER_AES_CTR
RTE_CRYPTO_CIPHER_3DES_CTR
RTE_CRYPTO_CIPHER_AES_GCM
Supported authentication algorithms:
RTE_CRYPTO_AUTH_AES_GMAC
RTE_CRYPTO_AUTH_MD5
RTE_CRYPTO_AUTH_SHA1
RT
verification tests
- add big data test
- fix pmd according to negative verification tests
- change gmac aad max size
- update documentation and commits comments
Changes in V2:
- add gcm/gmac algorithm correction
- unit test rework
Slawomir Mrozowicz (1):
libcrypto_pmd: initial implementation of
to librte_cryptodev
library.
Signed-off-by: Slawomir Mrozowicz
Signed-off-by: Michal Kobylinski
Signed-off-by: Tomasz Kulasek
Signed-off-by: Daniel Mrzyglod
---
v2:
- add gcm crypto cipher and authentication algorithm
- rework gmac crypto authentication algorithm
v3:
- fix pmd according to
This patch rework AES tests .
In general - rename AES-named functions to blockcipher functions pattern.
Signed-off-by: Piotr Azarewicz
Signed-off-by: Fiona Trahe
---
v6:
- fix checkpatch warnings
---
app/test/Makefile |2 +-
app/test/test_cryptodev.c
This patch contains unit tests for libcrypto PMD. User can
use app/test application to check how to use this pmd and to
verify crypto processing.
Test name is cryptodev_libcrypto_autotest.
For performance test cryptodev_libcrypto_perftest can be used.
Signed-off-by: Piotr Azarewicz
Signed-off-by
Libcrypto PMD has support for:
Supported cipher algorithms:
RTE_CRYPTO_CIPHER_3DES_CBC
RTE_CRYPTO_CIPHER_AES_CBC
RTE_CRYPTO_CIPHER_AES_CTR
RTE_CRYPTO_CIPHER_3DES_CTR
RTE_CRYPTO_CIPHER_AES_GCM
Supported authentication algorithms:
RTE_CRYPTO_AUTH_AES_GMAC
RTE_CRYPTO_AUTH_MD5
RTE_CRYPTO_AUTH_SHA1
RT
73 matches
Mail list logo
