[dpdk-dev] [PATCH] enic: negative array index write

[Slawomir Mrozowicz]

Negative array index write using variable pos as an index to array 
enic->fdir.nodes.
Fixed by add array index check.

Fixes: fefed3d1e62c ("enic: new driver")
Coverity ID 13270

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz at intel.com>
---
 drivers/net/enic/enic_clsf.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index edb56e1..6b1489d 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -213,6 +213,12 @@ int enic_fdir_add_fltr(struct enic *enic, struct 
rte_eth_fdir_filter *params)
        }

        pos = rte_hash_add_key(enic->fdir.hash, params);
+       if (pos < 0 || pos >= ENICPMD_FDIR_MAX) {
+               dev_err(enic, "Add hash key failed\n");
+               enic->fdir.stats.f_add++;
+               return -EINVAL;
+       }
+
        enic->fdir.nodes[pos] = key;
        return 0;
 }
-- 
1.9.1