On Wed, 2023-01-18 at 10:57 +, Ferruh Yigit wrote:
> I assume this is highlighted by a tool but in practice
>
> 'rte_vdev_device_name()' should not return NULL, and there are many
>
> other location this check is missing.
That's correct. Warning was found by codeql static analysis tool. When
On Wed, 2023-01-18 at 09:42 +0100, Thomas Monjalon wrote:
> 22/11/2022 16:30,
> ok...@kernel.org
> :
>
> > rte_class_eth: eth_mac_cmp: The status of this call to
> > rte_eth_dev_info_get
> > is not checked, potentially leaving dev_info uninitialized.
>
> [...]
>
> >/* Return 0 if devarg
On Thu, 2023-01-19 at 23:41 -0500, ok...@kernel.org wrote:
> From: Sinan Kaya
>
> Following up the codeql reported problems first submitted
> by Stephen Hemminger here:
>
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
>
> Posting a series of fi
On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote:
> 20/01/2023 17:47, Stephen Hemminger:
> > On Thu, 19 Jan 2023 23:41:40 -0500
> > ok...@kernel.org wrote:
> >
> > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h
> > > index 364f140f91..6d94a65d97 100644
> > > --- a/lib/e
On Thu, 2023-07-06 at 15:43 -0700, Stephen Hemminger wrote:
> > lib/eal/common/eal_common_memalloc.c | 5 -
> > lib/eal/common/eal_common_memzone.c | 10 +-
> > lib/eal/common/malloc_elem.c | 14 +++---
> > lib/eal/common/malloc_heap.c | 9 -
> >
On Mon, 2023-08-14 at 19:12 -0700, Stephen Hemminger wrote:
> On Mon, 14 Aug 2023 21:38:19 -0400
>
> ok...@kernel.org wrote:
>
>
>
> > From: Sinan Kaya
> > We want to be able to call rte_eal_init() and rte_eal_cleanup()
> > APIs back to back for maintan
On Tue, 2023-08-15 at 10:49 -0700, Stephen Hemminger wrote:
> >
> > + __atomic_store_n(&run_once, 0, __ATOMIC_RELAXED);
> >return 0;
>
>
> Interesting, other flags don't use atomic. Why here?
>
>
>
> And is already set elsewhere?
Looking at the history, this variable used to be
On Tue, 2023-08-15 at 10:46 -0700, Stephen Hemminger wrote:
> > static uint32_t run_once;
> > +static bool worker_initialized;
> >
>
>
> I see a pattern here. Many places are using static to
>
> only initialize once. Could you name these variables the
>
> same; suggest using run_once every
On Tue, 2023-08-15 at 10:45 -0700, Stephen Hemminger wrote:
> > Why?
> > It is not always ideal to reinitialize a DPDK process. Memory needs
> > to be reinitialized, hugetables need to warm up etc.
>
>
>
>
> I am familiar with the backstory of why this is desirable in your
> case.
>
> But othe
On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote:
> 21/11/2022 21:40, ok...@kernel.org:
> > --- a/drivers/net/tap/rte_eth_tap.c+++
> > b/drivers/net/tap/rte_eth_tap.c@@ -2340,6 +2340,10 @@
> > rte_pmd_tun_probe(struct rte_vdev_device *dev) struct
> > rte_eth_dev *eth_dev; name =
On Tue, 2022-11-22 at 16:24 +0100, David Marchand wrote:
> Thanks for the fixes, but it looks like the v2 series is truncated.
>
> Can you resend it so it passes through the CI?
Sure
On Tue, 2022-11-22 at 10:30 -0500, ok...@kernel.org wrote:
> From: Sinan Kaya
> Following up the codeql reported problems first submittedby Stephen
> Hemminger here:
> https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/
>
> Posting a series of fixes about pote
On Tue, 2022-12-13 at 19:59 +0300, Dmitry Kozlyuk wrote:
> 2022-12-13 11:43 (UTC-0500), Sinan Kaya:
> > Checking to see if I need to cover any feedback.
>
> There was some feedback to pre-resend v2 that is not visible on
> patchwork:
>
> h
On Tue, 2022-12-13 at 12:02 -0500, Sinan Kaya wrote:
> On Tue, 2022-12-13 at 19:59 +0300, Dmitry Kozlyuk wrote:
> > 2022-12-13 11:43 (UTC-0500), Sinan Kaya:
> > > Checking to see if I need to cover any feedback.
> >
> > There was some feedback to pre-resend v2 that i
numbers to device naming so that we can uniquely identify
devices.
Signed-off-by: Sinan Kaya
---
lib/librte_ether/rte_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0a6e3f1..929240f 100644
--- a/lib
On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
> On Fri, 22 Jul 2016 11:34:10 -0400
> Sinan Kaya wrote:
>
>> The current code is enumerating devices based on bus, device and function
>> pairs. This does not work well for architectures with multiple PCI
>> segments/do
On 10/4/2016 4:15 AM, Thomas Monjalon wrote:
> 2016-07-22 18:56, Sinan Kaya:
>> On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
>>> On Fri, 22 Jul 2016 11:34:10 -0400
>>> Sinan Kaya wrote:
>>>
>>>> The current code is enumerating devices based on bu
17 matches
Mail list logo
