On 10/4/2016 4:15 AM, Thomas Monjalon wrote: > 2016-07-22 18:56, Sinan Kaya: >> On 7/22/2016 5:12 PM, Stephen Hemminger wrote: >>> On Fri, 22 Jul 2016 11:34:10 -0400 >>> Sinan Kaya <okaya at codeaurora.org> wrote: >>> >>>> The current code is enumerating devices based on bus, device and function >>>> pairs. This does not work well for architectures with multiple PCI >>>> segments/domains. Multiple PCI devices will have the same BDF value but >>>> different segment numbers (01:01:01.0 and 02:01:01.0) for instance. >>>> >>>> Adding segment numbers to device naming so that we can uniquely identify >>>> devices. >>>> >>>> Signed-off-by: Sinan Kaya <okaya at codeaurora.org> >>> >>> I ran into this yes. There is a small risk of breaking some application that >>> assumed something about names though. >>> >>> Acked-by: Stephen Hemminger <stephen at networkplumber.org> >>> >> >> Thanks, hopefully the change is minor and can be contained until next >> release. > > It is part of the EAL rework. > The function has been moved in EAL and includes the PCI domain: > http://dpdk.org/commit/affe1cdc >
Thanks for taking care of it. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
