Re: [dpdk-dev] [PATCH v2 7/7] pci: Clarify interfaces for dynamic attach/detach of drivers

2016-12-02 Thread Shreyansh Jain
On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: There are now two functions - rte_eal_pci_attach_driver and rte_eal_pci_detach_driver - that dynamically attempt to attach and detach drivers from PCI devices. These only control whether a registered PCI driver is loaded or not - they are i

Re: [dpdk-dev] [PATCH v5 00/12] Introducing EAL Bus-Device-Driver Model

2017-01-05 Thread Shreyansh Jain
On Wednesday 04 January 2017 03:52 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: Link to v1: [10] Link to v2: [11] Link to v3: [13] Link to v4: [14] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-06 Thread Shreyansh Jain
On Wednesday 04 January 2017 03:22 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: +DPDK_17.02 { + global: + + rte_bus_list; + rte_eal_bus_add_device; + rte_eal_bus_add_driver; + rte_eal_bus_get; + rte_eal_bus_dump; + rte_eal_bus_register

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-06 Thread Shreyansh Jain
On Wednesday 04 January 2017 03:16 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -844,6 +845,9 @@ rte_eal_init(int argc, char **argv) if (rte_eal_intr_init() < 0) rte_pa

Re: [dpdk-dev] [PATCH v5 05/12] eal: add probe and remove support for rte_driver

2017-01-06 Thread Shreyansh Jain
On Wednesday 04 January 2017 03:35 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -152,6 +162,8 @@ struct rte_driver { struct rte_bus *bus; /**< Bus serviced by t

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-06 Thread Shreyansh Jain
On Friday 06 January 2017 04:08 PM, Shreyansh Jain wrote: On Wednesday 04 January 2017 03:16 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -844,6 +845,9 @@ rte_eal_init(int argc, char **argv

Re: [dpdk-dev] [PATCH v5 08/12] eal/pci: generalize args of PCI scan/match towards RTE device/driver

2017-01-06 Thread Shreyansh Jain
On Wednesday 04 January 2017 03:43 AM, Thomas Monjalon wrote: 2016-12-26 18:54, Shreyansh Jain: PCI scan and match now work on rte_device/rte_driver rather than PCI specific objects. These functions can now be plugged to the generic bus callbacks for scanning and matching devices/drivers

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 08:25 PM, Thomas Monjalon wrote: 2017-01-06 16:01, Shreyansh Jain: On Wednesday 04 January 2017 03:22 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: +/** + * A structure describing a generic bus. + */ +struct rte_bus { + TAILQ_ENTRY(rte_bus) next

Re: [dpdk-dev] [PATCH v5 05/12] eal: add probe and remove support for rte_driver

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 08:56 PM, Thomas Monjalon wrote: 2017-01-06 17:14, Shreyansh Jain: On Wednesday 04 January 2017 03:35 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -152,6

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-08 Thread Shreyansh Jain
Hello, On Sunday 08 January 2017 05:51 PM, Rosen, Rami wrote: Hi, diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 2206277..2c223de 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c +/* Scan all the buses for

Re: [dpdk-dev] [PATCH v5 04/12] eal: integrate bus scan and probe with EAL

2017-01-08 Thread Shreyansh Jain
On Friday 06 January 2017 07:16 PM, Thomas Monjalon wrote: 2017-01-06 17:30, Shreyansh Jain: On Friday 06 January 2017 04:08 PM, Shreyansh Jain wrote: On Wednesday 04 January 2017 03:16 AM, Thomas Monjalon wrote: 2016-12-26 18:53, Shreyansh Jain: --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-09 Thread Shreyansh Jain
Hello Ferruh, On Monday 09 January 2017 08:52 PM, Ferruh Yigit wrote: On 12/26/2016 1:23 PM, Shreyansh Jain wrote: <...> + +DPDK_17.02 { + global: + + rte_bus_list; + rte_eal_bus_add_device; + rte_eal_bus_add_driver; + rte_eal_bus_get; + rte_eal_bu

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 09:48 PM, Ferruh Yigit wrote: On 1/9/2017 3:19 PM, Ferruh Yigit wrote: On 12/26/2016 1:24 PM, Shreyansh Jain wrote: These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callba

Re: [dpdk-dev] [PATCH v3 00/33] NXP DPAA2 PMD

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 11:12 PM, Ferruh Yigit wrote: On 12/29/2016 5:16 AM, Shreyansh Jain wrote: ** Sending v3 on behalf of Hemant Agrawal ** <...> Hi, Getting compile error for shared library [1] build. Not investigated, copying here. Thanks, ferruh [1] == Build drivers/net

Re: [dpdk-dev] [PATCH 1/2] add rte_bus->probe

2017-01-10 Thread Shreyansh Jain
On Tuesday 10 January 2017 11:32 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_bus.c | 7 --- lib/librte_eal/common/include/rte_bus.h | 3 +++ lib/librte_eal/linuxapp/eal/eal_pci.c | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --

Re: [dpdk-dev] [PATCH 1/2] add rte_bus->probe

2017-01-11 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, January 11, 2017 8:34 PM > To: Shreyansh Jain ; dev@dpdk.org > Cc: Stephen Hemminger ; Jan Blunck > > Subject: Re: [PATCH 1/2] add rte_bus->probe > > On 1/11/2017

[dpdk-dev] [PATCH v6 1/8] eal/bus: introduce bus abstraction

2017-01-16 Thread Shreyansh Jain
| 'bus | | | ++| | | |rte_device || | | | bus ' | | ...|| | ++| | ... | +---+ Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/Makefile

[dpdk-dev] [PATCH v6 0/8] Introducing EAL Bus-Device-Driver Model

2017-01-16 Thread Shreyansh Jain
ve been separated from EAL changes (but this does make PCI PMDs non-working for a particular patch) Shreyansh Jain (8): eal/bus: introduce bus abstraction test: add basic bus infrastructure tests pci: split match and probe function eal/bus: support for scanning of bus eal: introduce bus scan

[dpdk-dev] [PATCH v6 2/8] test: add basic bus infrastructure tests

2017-01-16 Thread Shreyansh Jain
Verification of bus registration, deregistration methods. Signed-off-by: Shreyansh Jain --- app/test/Makefile | 2 +- app/test/test.h | 2 + app/test/test_bus.c | 359 lib/librte_eal/common

[dpdk-dev] [PATCH v6 4/8] eal/bus: support for scanning of bus

2017-01-16 Thread Shreyansh Jain
Scan for bus discovers the devices available on the bus and adds them to a bus specific device list. Each bus mandatorily implements this method. Test cases for Bus are also updated by this patch. Signed-off-by: Shreyansh Jain --- app/test/test_bus.c | 175

[dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus

2017-01-16 Thread Shreyansh Jain
Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 7 - lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 -- lib/librte_eal/common/eal_common_pci.c | 36

[dpdk-dev] [PATCH v6 6/8] test: update bus and pci unit test cases

2017-01-16 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- app/test/test_bus.c | 152 app/test/test_pci.c | 164 2 files changed, 266 insertions(+), 50 deletions(-) diff --git a/app/test/test_bus.c b/app/test

[dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp

[dpdk-dev] [PATCH v6 5/8] eal: introduce bus scan and probe in EAL

2017-01-16 Thread Shreyansh Jain
: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 8 +++ lib/librte_eal/bsdapp/eal/eal_pci.c | 11 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_bus.c | 41 +++ lib/librte_eal/common/eal_common_pci.c

[dpdk-dev] [PATCH v6 8/8] eal: enable hotplugging of devices on bus

2017-01-16 Thread Shreyansh Jain
Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/common/eal_common_dev.c | 56 +- lib

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Shreyansh Jain
Hello Ferruh, On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev

Re: [dpdk-dev] [PATCH v6 5/8] eal: introduce bus scan and probe in EAL

2017-01-16 Thread Shreyansh Jain
On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Each bus implementation defines their own callbacks for scanning bus and probing devices available on the bus. Enable EAL to call bus specific scan and probe functions during DPDK initialization

Re: [dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus

2017-01-16 Thread Shreyansh Jain
On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain --- <...> -/* Init the PCI EAL subsystem */ -int -rte_eal_pci_ini

Re: [dpdk-dev] [PATCH v6 0/8] Introducing EAL Bus-Device-Driver Model

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 11:57 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:19 +0530 Shreyansh Jain wrote: Link to v5: [15] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined

Re: [dpdk-dev] [PATCH v6 0/8] Introducing EAL Bus-Device-Driver Model

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 11:57 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:19 +0530 Shreyansh Jain wrote: Link to v5: [15] :: Introduction :: DPDK has been inherently a PCI inclined framework. Because of this, the design of device tree (or list) within DPDK is also PCI inclined

Re: [dpdk-dev] [PATCH v6 8/8] eal: enable hotplugging of devices on bus

2017-01-16 Thread Shreyansh Jain
On Monday 16 January 2017 09:08 PM, Shreyansh Jain wrote: Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal

[dpdk-dev] [PATCH v7 0/9] Introducing EAL Bus-Device-Driver Model

2017-01-17 Thread Shreyansh Jain
rearrangement of patches: -- changes to drivers have been separated from EAL changes (but this does make PCI PMDs non-working for a particular patch) Shreyansh Jain (9): eal/bus: introduce bus abstraction test: add basic bus infrastructure tests pci: split match and probe function

[dpdk-dev] [PATCH v7 1/9] eal/bus: introduce bus abstraction

2017-01-17 Thread Shreyansh Jain
| 'bus | | | ++| | | |rte_device || | | | bus ' | | ...|| | ++| | ... | +---+ Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/Makefile

[dpdk-dev] [PATCH v7 3/9] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp

[dpdk-dev] [PATCH v7 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Shreyansh Jain
Scan for bus discovers the devices available on the bus and adds them to a bus specific device list. Each bus mandatorily implements this method. Test cases for Bus are also updated by this patch. Signed-off-by: Shreyansh Jain --- app/test/test_bus.c | 175

[dpdk-dev] [PATCH v7 6/9] eal: integrate bus scan and probe with EAL

2017-01-17 Thread Shreyansh Jain
: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 8 +++ lib/librte_eal/bsdapp/eal/eal_pci.c | 11 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_bus.c | 40 +++ lib/librte_eal/common

[dpdk-dev] [PATCH v7 2/9] test: add basic bus infrastructure tests

2017-01-17 Thread Shreyansh Jain
Verification of bus registration, deregistration methods. Signed-off-by: Shreyansh Jain --- app/test/Makefile | 2 +- app/test/test.h | 2 + app/test/test_bus.c | 359 lib/librte_eal/common

[dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on bus

2017-01-17 Thread Shreyansh Jain
Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/common/eal_common_dev.c | 56 - lib

[dpdk-dev] [PATCH v7 5/9] eal/bus: introduce support for bus probing

2017-01-17 Thread Shreyansh Jain
Bus implementations can implement a probe handler to match the devices scanned against the drivers registered. This patch introduces the callback which would be implemented for PCI in subsequent patch. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_bus.c | 1 + lib

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
On Monday 16 January 2017 11:54 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:22 +0530 Shreyansh Jain wrote: -rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *dev) +int +rte_pci_match(struct rte_pci_driver *pci_drv, + struct

[dpdk-dev] [PATCH v7 8/9] eal: enable PCI bus

2017-01-17 Thread Shreyansh Jain
Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal.c | 7 - lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 -- lib/librte_eal

[dpdk-dev] [PATCH v7 7/9] test: update bus and pci unit test cases

2017-01-17 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- app/test/test_bus.c | 152 app/test/test_pci.c | 164 2 files changed, 266 insertions(+), 50 deletions(-) diff --git a/app/test/test_bus.c b/app/test

Re: [dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus

2017-01-17 Thread Shreyansh Jain
On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain --- <...> -/* Init the PCI EAL subsystem */ -int -rte_eal_pci_ini

Re: [dpdk-dev] [PATCH v6 5/8] eal: introduce bus scan and probe in EAL

2017-01-17 Thread Shreyansh Jain
Just an update on things fixed/updated in v7 against these comments: On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Each bus implementation defines their own callbacks for scanning bus and probing devices available on the bus. Enable EAL to

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
On Tuesday 17 January 2017 03:28 PM, Ferruh Yigit wrote: On 1/17/2017 4:54 AM, Shreyansh Jain wrote: Hello Ferruh, On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Matching of PCI device address and driver ID table is being done at two

Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on bus

2017-01-17 Thread Shreyansh Jain
Hi Ferruh, > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, January 17, 2017 4:18 PM > To: Shreyansh Jain ; david.march...@6wind.com > Cc: dev@dpdk.org; thomas.monja...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: ena

[dpdk-dev] [PATCH v8 0/9] Introducing EAL Bus-Device-Driver Model

2017-01-17 Thread Shreyansh Jain
- changes to drivers have been separated from EAL changes (but this does make PCI PMDs non-working for a particular patch) Shreyansh Jain (9): eal/bus: introduce bus abstraction test: add basic bus infrastructure tests pci: split match and probe function eal/bus: support for scanning

[dpdk-dev] [PATCH v8 3/9] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v8 1/9] eal/bus: introduce bus abstraction

2017-01-17 Thread Shreyansh Jain
| 'bus | | | ++| | | |rte_device || | | | bus ' | | ...|| | ++| | ... | +---+ Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/l

[dpdk-dev] [PATCH v8 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Shreyansh Jain
Scan for bus discovers the devices available on the bus and adds them to a bus specific device list. Each bus mandatorily implements this method. Test cases for Bus are also updated by this patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c

[dpdk-dev] [PATCH v8 5/9] eal/bus: introduce support for bus probing

2017-01-17 Thread Shreyansh Jain
Bus implementations can implement a probe handler to match the devices scanned against the drivers registered. This patch introduces the callback which would be implemented for PCI in subsequent patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/common

[dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests

2017-01-17 Thread Shreyansh Jain
Verification of bus registration, deregistration methods. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/Makefile | 2 +- app/test/test.h | 2 + app/test/test_bus.c | 359

[dpdk-dev] [PATCH v8 7/9] test: update bus and pci unit test cases

2017-01-17 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c | 152 app/test/test_pci.c | 164 2 files changed, 266 insertions(+), 50 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v8 8/9] eal: enable PCI bus

2017-01-17 Thread Shreyansh Jain
Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 7 - lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +++ lib/librte_eal/bsdapp/eal/rte_eal_version.map

[dpdk-dev] [PATCH v8 9/9] eal: enable hotplugging of devices on bus

2017-01-17 Thread Shreyansh Jain
Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/common/eal_common_dev.c | 56 - lib

[dpdk-dev] [PATCH v8 6/9] eal: integrate bus scan and probe with EAL

2017-01-17 Thread Shreyansh Jain
: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 8 +++ lib/librte_eal/bsdapp/eal/eal_pci.c | 11 lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + lib/librte_eal/common/eal_common_bus.c | 40 +++ lib

Re: [dpdk-dev] [PATCH v7 9/9] eal: enable hotplugging of devices on bus

2017-01-17 Thread Shreyansh Jain
Hello Ferruh, On Tuesday 17 January 2017 04:34 PM, Shreyansh Jain wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Tuesday, January 17, 2017 4:18 PM To: Shreyansh Jain ; david.march...@6wind.com Cc: dev@dpdk.org; thomas.monja...@6wind.com

Re: [dpdk-dev] [PATCH v8 1/9] eal/bus: introduce bus abstraction

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 4:50 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 1/9] eal/bus: introduce bus abstraction > > 2017-01-17 19:07, S

Re: [dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 4:54 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 2/9] test: add basic bus infrastructure tests > > 2017-01-

Re: [dpdk-dev] [PATCH v8 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 5:07 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 4/9] eal/bus: support for scanning of bus > > 2017-01-17 19:07, Shreyansh J

Re: [dpdk-dev] [PATCH v8 3/9] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 5:02 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 3/9] pci: split match and probe function > > 2017-01-17 19:07, Shreyan

Re: [dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Shreyansh Jain > Sent: Wednesday, January 18, 2017 10:42 AM > To: 'Thomas Monjalon' > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 2/9] test: add basic bus infrastructure tests > > > -Original Message- > >

Re: [dpdk-dev] [PATCH v8 2/9] test: add basic bus infrastructure tests

2017-01-18 Thread Shreyansh Jain
On Wednesday 18 January 2017 12:58 PM, Thomas Monjalon wrote: 2017-01-18 06:56, Shreyansh Jain: +/* Bus list exposed */ +extern struct rte_bus_list rte_bus_list; I think it should be possible to write a test without the real list of registered bus. Yes, it is possible. I just modeled it on

[dpdk-dev] [PATCH v9 00/12] Introducing EAL Bus-Device-Driver Model

2017-01-18 Thread Shreyansh Jain
ted from EAL changes (but this does make PCI PMDs non-working for a particular patch) Shreyansh Jain (12): eal/bus: introduce bus abstraction test: add basic bus infrastructure tests pci: split match and probe function eal: remove loop over drivers in device detach eal/bus: support for

[dpdk-dev] [PATCH v9 02/12] test: add basic bus infrastructure tests

2017-01-18 Thread Shreyansh Jain
Verification of bus registration, deregistration methods. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/Makefile | 2 +- app/test/autotest_data.py | 6 + app/test/test.h | 2 + app/test/test_bus.c

[dpdk-dev] [PATCH v9 01/12] eal/bus: introduce bus abstraction

2017-01-18 Thread Shreyansh Jain
| 'bus | | | ++| | | |rte_device || | | | bus ' | | ...|| | ++| | ... | +---+ Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/l

[dpdk-dev] [PATCH v9 03/12] pci: split match and probe function

2017-01-18 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v9 05/12] eal/bus: support for scanning of bus

2017-01-18 Thread Shreyansh Jain
Scan for bus discovers the devices available on the bus and adds them to a bus specific device list. Each bus mandatorily implements this method. Test cases for Bus are also updated by this patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c

[dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
rte_eal_pci_detach_dev to work without looping over driver list. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 41 +- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common

[dpdk-dev] [PATCH v9 06/12] eal/bus: introduce support for bus probing

2017-01-18 Thread Shreyansh Jain
Bus implementations can implement a probe handler to match the devices scanned against the drivers registered. This patch introduces the callback which would be implemented for PCI in subsequent patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/common

[dpdk-dev] [PATCH v9 07/12] eal: integrate bus scan and probe with EAL

2017-01-18 Thread Shreyansh Jain
Add functions for scanning all the buses and performing probe on all the buses on EAL initialization. Presently, no bus exists - in subseqent patches, PCI bus would be introduced. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 7

[dpdk-dev] [PATCH v9 08/12] eal/pci: add support for PCI bus

2017-01-18 Thread Shreyansh Jain
Based on EAL Bus APIs, PCI bus callbacks and support functions are introduced in this patch. EAL continues to have direct PCI init/scan calls as well. These would be removed in subsequent patches to enable bus only PCI devices. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib

[dpdk-dev] [PATCH v9 10/12] test: add Bus based scan and probe test cases for PCI

2017-01-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_pci.c | 164 1 file changed, 114 insertions(+), 50 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cda186d..09261cc 100644 --- a/app/test

[dpdk-dev] [PATCH v9 09/12] test: add test cases for scan and probe on BUS

2017-01-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c | 152 1 file changed, 152 insertions(+) diff --git a/app/test/test_bus.c b/app/test/test_bus.c index 0b6d011..ef7fa89 100644 --- a/app/test/test_bus.c +++ b/app

[dpdk-dev] [PATCH v9 11/12] eal: enable PCI bus

2017-01-18 Thread Shreyansh Jain
Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 7 - lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +++ lib/librte_eal/bsdapp/eal/rte_eal_version.map

Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
Thomas, On Wednesday 18 January 2017 04:07 PM, Shreyansh Jain wrote: diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 4f155c6..7548ab0 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -259,15

[dpdk-dev] [PATCH v9 12/12] eal: enable hotplugging of devices on bus

2017-01-18 Thread Shreyansh Jain
Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/common/eal_common_dev.c | 56

Re: [dpdk-dev] [PATCH v9 01/12] eal/bus: introduce bus abstraction

2017-01-18 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 4:16 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction > > 2017-01-18 16:07, S

Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 4:43 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v9 04/12] eal: remove loop over drivers in device detach > > 2017-01-

[dpdk-dev] [PATCH v10 00/13] Introducing EAL Bus-Device-Driver Model

2017-01-18 Thread Shreyansh Jain
ers have been separated from EAL changes (but this does make PCI PMDs non-working for a particular patch) Shreyansh Jain (13): eal/bus: introduce bus abstraction test: add basic bus infrastructure tests pci: split match and probe function eal: remove loop over drivers in device detach eal/b

[dpdk-dev] [PATCH v10 01/13] eal/bus: introduce bus abstraction

2017-01-18 Thread Shreyansh Jain
| 'bus | | | ++| | | |rte_device || | | | bus ' | | ...|| | ++| | ... | +---+ Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/l

[dpdk-dev] [PATCH v10 02/13] test: add basic bus infrastructure tests

2017-01-18 Thread Shreyansh Jain
Verification of bus registration, deregistration methods. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/Makefile | 2 +- app/test/autotest_data.py | 6 + app/test/test.h | 2 + app

[dpdk-dev] [PATCH v10 03/13] pci: split match and probe function

2017-01-18 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit

[dpdk-dev] [PATCH v10 05/13] eal/bus: support for scanning of bus

2017-01-18 Thread Shreyansh Jain
Scan for bus discovers the devices available on the bus and adds them to a bus specific device list. Each bus mandatorily implements this method. Test cases for Bus are also updated by this patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c

[dpdk-dev] [PATCH v10 06/13] eal/bus: introduce support for bus probing

2017-01-18 Thread Shreyansh Jain
Bus implementations can implement a probe handler to match the devices scanned against the drivers registered. This patch introduces the callback which would be implemented for PCI in subsequent patch. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/common

[dpdk-dev] [PATCH v10 04/13] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
rte_eal_pci_detach_dev to work without looping over driver list. Signed-off-by: Shreyansh Jain --- lib/librte_eal/common/eal_common_pci.c | 47 +++--- 1 file changed, 9 insertions(+), 38 deletions(-) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common

[dpdk-dev] [PATCH v10 07/13] eal: integrate bus scan and probe with EAL

2017-01-18 Thread Shreyansh Jain
Add functions for scanning all the buses and performing probe on all the buses on EAL initialization. Presently, no bus exists - in subseqent patches, PCI bus would be introduced. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 7

[dpdk-dev] [PATCH v10 08/13] eal/pci: add support for PCI bus

2017-01-18 Thread Shreyansh Jain
Based on EAL Bus APIs, PCI bus callbacks and support functions are introduced in this patch. EAL continues to have direct PCI init/scan calls as well. These would be removed in subsequent patches to enable bus only PCI devices. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib

[dpdk-dev] [PATCH v10 09/13] test: add test cases for scan and probe on BUS

2017-01-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_bus.c | 152 1 file changed, 152 insertions(+) diff --git a/app/test/test_bus.c b/app/test/test_bus.c index 0b6d011..ef7fa89 100644 --- a/app/test/test_bus.c +++ b/app

[dpdk-dev] [PATCH v10 10/13] test: add Bus based scan and probe test cases for PCI

2017-01-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- app/test/test_pci.c | 164 1 file changed, 114 insertions(+), 50 deletions(-) diff --git a/app/test/test_pci.c b/app/test/test_pci.c index cda186d..09261cc 100644 --- a/app/test

[dpdk-dev] [PATCH v10 11/13] eal: enable PCI bus

2017-01-18 Thread Shreyansh Jain
Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal.c | 7 - lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +++ lib/librte_eal/bsdapp/eal/rte_eal_version.map

[dpdk-dev] [PATCH v10 12/13] eal: enable hotplugging of devices on bus

2017-01-18 Thread Shreyansh Jain
Given a bus, attach and detach callbacks allow the implementation to handles calls from EAL for attaching or detaching a named device. Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 + lib/librte_eal/common/eal_common_dev.c | 56

[dpdk-dev] [PATCH v10 13/13] doc: remove deprecation notice for rte_bus

2017-01-18 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 291e03d..60d2bad 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides

Re: [dpdk-dev] [PATCHv5 04/33] bus/fslmc: introducing fsl-mc bus driver

2017-01-19 Thread Shreyansh Jain
On Friday 20 January 2017 12:38 AM, Ferruh Yigit wrote: On 1/19/2017 1:23 PM, Hemant Agrawal wrote: The fslmc bus driver is a rte_bus driver which scans the fsl-mc bus for NXP DPAA2 SoCs. Signed-off-by: Hemant Agrawal --- <...> +# +# library name +# +LIB = librte_pmd_fslmcbus.a Since now

Re: [dpdk-dev] [PATCHv5 13/33] net/dpaa2: introducing NXP dpaa2 pmd driver

2017-01-20 Thread Shreyansh Jain
Hello Ferruh, On Friday 20 January 2017 12:45 AM, Ferruh Yigit wrote: On 1/19/2017 1:23 PM, Hemant Agrawal wrote: add support for fsl-mc bus based dpaa2 pmd driver. Signed-off-by: Hemant Agrawal <...> diff --git a/drivers/common/Makefile b/drivers/common/Makefile index e5bfecb..76ec2d1 10

Re: [dpdk-dev] [PATCHv6 02/33] drivers/common/dpaa2: adding qbman driver

2017-01-23 Thread Shreyansh Jain
Hello Ferruh, On Monday 23 January 2017 11:00 PM, Ferruh Yigit wrote: On 1/23/2017 11:59 AM, Hemant Agrawal wrote: QBMAN, is a hardware block which interfaces with the other accelerating hardware blocks (For e.g., WRIOP) on NXP's DPAA2 SoC for queue, buffer and packet scheduling. This patch in

Re: [dpdk-dev] [PATCHv6 12/33] net/dpaa2: introducing NXP dpaa2 pmd driver

2017-01-24 Thread Shreyansh Jain
On Monday 23 January 2017 11:02 PM, Ferruh Yigit wrote: On 1/23/2017 11:59 AM, Hemant Agrawal wrote: add support for fsl-mc bus based dpaa2 pmd driver. Signed-off-by: Hemant Agrawal --- <...> diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile new file mode 100644 index 000

Re: [dpdk-dev] [PATCHv6 16/33] drivers/pool/dpaa2: adding hw offloaded mempool

2017-01-24 Thread Shreyansh Jain
On Monday 23 January 2017 11:04 PM, Ferruh Yigit wrote: On 1/23/2017 11:59 AM, Hemant Agrawal wrote: Adding NXP DPAA2 architecture specific mempool support Each mempool instance is represented by a DPBP object from the FSL-MC bus. This patch also registers a dpaa2 type MEMPOOL OPS Signed-off-b

[dpdk-dev] NXP DPAA2: Symbol renaming issue: Request for Suggestions

2017-01-24 Thread Shreyansh Jain
Hello, We are facing a peculiar problem with respect to symbol namespace in DPDK. I think Ferruh and Thomas would have fair idea about it as they have already reviewed and commented on it. I was hoping to get some input to take it forward from here. Brief Intro to DPAA2 Architecture: This is bri

Re: [dpdk-dev] [PATCH] cryptodev: decouple from PCI device

2017-01-24 Thread Shreyansh Jain
eth_driver and rte_cryptodev_driver and make it generic. Reviewed-by: Shreyansh Jain

  1   2   3   4   5   6   7   8   9   10   >