[dpdk-dev] [PATCH v9 2/3] net/tap: move fds of Rx/Tx queues to be in process private

2018-10-18 Thread Raslan Darawsheh
fd's cannot be shared between processes, and each process need to have it's own fd's pointer. Signed-off-by: Raslan Darawsheh --- This patch has dependancy on the following patch http://patches.dpdk.org/patch/46185/ --- --- drivers/net/tap/rte

[dpdk-dev] [PATCH v9 3/3] net/tap: allow secondary process to access primary device queues

2018-10-18 Thread Raslan Darawsheh
process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: - translate file descriptors via IPC API - add documentation v3: - rabse the commit - use private static array for fd's to be local for each process v4: - removed

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 17, 2018 7:33 PM > To: Iremonger, Bernard ; Raslan Darawsheh > ; Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Xueming(Steven) Li > ; Ori Kam ; > jerin.ja...@cavi

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level

2018-10-18 Thread Raslan Darawsheh
You are right about that my mistake. Kindest regards, Raslan Darawsheh > -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 18, 2018 11:34 AM > To: Raslan Darawsheh ; Iremonger, Bernard > ; Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf

[dpdk-dev] [PATCH v10 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

2018-10-18 Thread Raslan Darawsheh
Port and queue ids are added to easily map the file descriptors stored in each process private. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 3 +++ drivers/net/tap/rte_eth_tap.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b

[dpdk-dev] [PATCH v10 2/3] net/tap: move fds of Rx/Tx queues to be in process private

2018-10-18 Thread Raslan Darawsheh
fd's cannot be shared between processes, and each process need to have it's own fd's pointer. Signed-off-by: Raslan Darawsheh --- This patch has dependancy on the following patch http://patches.dpdk.org/patch/46185/ --- --- drivers/net/tap/rte

[dpdk-dev] [PATCH v10 3/3] net/tap: allow secondary process to access primary device queues

2018-10-18 Thread Raslan Darawsheh
process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: - translate file descriptors via IPC API - add documentation v3: - rabse the commit - use private static array for fd's to be local for each process v4: - removed

Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-12 Thread Raslan Darawsheh
Hi Keith, Yes you are right about that, This is exactly the case and I'll need to provide a V2 for this with the kernel mapping. Kindest regards, Raslan Darawsheh -Original Message- From: Wiles, Keith [mailto:keith.wi...@intel.com] Sent: Tuesday, June 12, 2018 3:46 PM To: R

[dpdk-dev] [PATCH] net/mlx5: fix Rss level validation

2018-06-19 Thread Raslan Darawsheh
When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: sta...@dpdk.org Signed-off-by: R

[dpdk-dev] [PATCH] net/mlx5: fix Rss level validation

2018-06-19 Thread Raslan Darawsheh
When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. this change the check to be for the requested action insted. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: sta...@dpdk.org Signed-off-by: R

[dpdk-dev] [PATCH v2] net/mlx5: fix RSS level validation

2018-06-21 Thread Raslan Darawsheh
When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. This change the check to be for the requested action instead. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: sta...@dpdk.org Signed-off-by: Raslan Dara

[dpdk-dev] [PATCH] app/testpmd: fix set L4 len for UDP packets

2018-11-11 Thread Raslan Darawsheh
testpmd only sets the L4 len in case of TCP packets. some PMD's like tap rely on mbuf meta data to calculate csum this will set the L4 len for UDP packets same as TCP Fixes: 160c3dc9 ("app/testpmd: introduce IP parsing functions in csum fwd engine") Signed-off-by: Raslan Daraws

[dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2018-08-05 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_18_08.rst | 150 + 1 file changed, 150 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index 9849fec..0338de5 100644 --- a/doc/guides

[dpdk-dev] [PATCH v2] doc: add tested platforms with Mellanox NICs

2018-08-08 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- changes in v2: add Bluefield as one of the tested platforms for Mellanox. --- Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_18_08.rst | 165 + 1 file changed, 165 insertions(+) diff --git a/doc/guides

Re: [dpdk-dev] 17.11.4 patches review and test (RC2)

2018-08-30 Thread Raslan Darawsheh
Hi, We've tested this version on our machines and seems to be OK we don't have any new issues there. Kindest regards, Raslan Darawsheh -Original Message- From: dev On Behalf Of Yongseok Koh Sent: Saturday, August 25, 2018 4:18 AM To: dpdk stable Cc: dev@dpdk.org Subject:

Re: [dpdk-dev] [PATCH v2 0/4] Hyper-V Netvsc PMD

2018-04-17 Thread Raslan Darawsheh
ced one additional new dependency which is uuid-dev and I think you might be missing the documentation of that. Kindest regards, Raslan Darawsheh > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, April 17, 2018 2:25 AM > To: dev@dpdk.org

Re: [dpdk-dev] [PATCH v2 0/4] Hyper-V Netvsc PMD

2018-04-18 Thread Raslan Darawsheh
I'm facing this on gcc version 5.4.0 on 64bit. Kindest regards, Raslan Darawsheh -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, April 17, 2018 7:22 PM To: Raslan Darawsheh Cc: dev@dpdk.org; Stephen Hemminger ; Thomas Monjalon Subjec

[dpdk-dev] [PATCH] net/failsafe: fix starting failsafe with invalid MAC

2018-05-07 Thread Raslan Darawsheh
When starting failsafe with mac option, and giving it an invalid MAC. It will cause a segmentation fault due to the hotplug_alarm installed on an invalid subdev. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe.c |

[dpdk-dev] [PATCH 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
When attr_ctx is NULL it will attempt to free the list of devices twice. So, changing it to be freed in error handling only. Fixes: 771fa900 ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH 2/2] net/mlx5: add free for eth dev port in case of error

2018-05-07 Thread Raslan Darawsheh
in case of errors need to free the eth_dev port that was allocated during the port setup. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d34076b..63c94ad 100644 --- a

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
When attr_ctx is NULL it will attempt to free the list of devices twice. Avoid double freeing the list by directly going to error handling. Fixes: 771fa900 ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh ---

[dpdk-dev] [PATCH v2 2/2] net/mlx5: free eth dev port in case of error

2018-05-07 Thread Raslan Darawsheh
If something went wrong in mlx5 pci prop need to free the eth_dev that was previously allocated during the port setup. Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. --- --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5

[dpdk-dev] [PATCH v2] net/failsafe: fix starting failsafe with invalid MAC

2018-05-07 Thread Raslan Darawsheh
hotplug alarm is called it will try to access this pointer, which will lead to a segmentation fault. This commit fixes this issue by removing the installed hotplug alarm in case of invalid MAC address. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh ---

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
Hi Yongseok, Thx for your review. But I already sent a V2 for this patch which handles the redundant goto that I had. But still missing the fix for title. I'll submit a v3 tomorrow with a fixed title. Kindest regards Raslan Darawsheh From: Yongseok Koh

[dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling

2018-05-08 Thread Raslan Darawsheh
When attr_ctx is NULL it will attempt to free the list of devices twice. Avoid double freeing the list by directly going to error handling. Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh ---

[dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error

2018-05-08 Thread Raslan Darawsheh
If something went wrong in mlx5 pci prop the allocated eth dev will cause a memory leak. This commit release the eth dev that was previously allocated. Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan

[dpdk-dev] [PATCH v3] net/failsafe: fix probe cleanup

2018-05-08 Thread Raslan Darawsheh
to a segmentation fault. Uninstall the hot-plug alarm in case of error in probe function. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. v3 changes: Reword the commit log. --- --- drive

[dpdk-dev] [PATCH 1/2] app/testpmd: add a generic way for dumping packets

2018-09-12 Thread Raslan Darawsheh
verbosity for the received/sent packets is needed in all of the forwarding engines so moving it to be in a separate function. Signed-off-by: Raslan Darawsheh --- app/test-pmd/Makefile | 1 + app/test-pmd/testpmd.h | 2 + app/test-pmd/util.c| 143

[dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

2018-09-12 Thread Raslan Darawsheh
: set verbose 3 Signed-off-by: Raslan Darawsheh --- app/test-pmd/iofwd.c | 2 + app/test-pmd/macfwd.c | 4 ++ app/test-pmd/macswap.c | 4 ++ app/test-pmd/rxonly.c | 136 ++--- 4 files changed, 15 insertions(+), 131 deletions(-) diff --git a/app

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

2018-09-17 Thread Raslan Darawsheh
Hi David, Thx for this feedback I'll be sending a new version with your suggestion. Kindest regards, Raslan Darawsheh -Original Message- From: Jerin Jacob Sent: Friday, September 14, 2018 9:35 AM To: David Marchand Cc: Raslan Darawsheh ; Wu, Jingjing ; Thomas Monjalon

[dpdk-dev] [PATCH v2 2/3] app/testpmd: add packet dump callback functions

2018-09-24 Thread Raslan Darawsheh
add new rx/tx callback functions to be used for dumping the packets. Signed-off-by: Raslan Darawsheh --- app/test-pmd/config.c | 67 ++ app/test-pmd/testpmd.h | 15 +++ app/test-pmd/util.c| 17 + 3 files changed, 99

[dpdk-dev] [PATCH v2 1/3] app/testpmd: move dumping packets to a separate function

2018-09-24 Thread Raslan Darawsheh
verbosity for the received/sent packets is needed in all of the forwarding engines so moving it to be in a separate function Signed-off-by: Raslan Darawsheh --- app/test-pmd/Makefile | 1 + app/test-pmd/rxonly.c | 134 ++ app/test-pmd/util.c | 144

[dpdk-dev] [PATCH v2 3/3] app/testpmd: set packet dump based on verbosity level

2018-09-24 Thread Raslan Darawsheh
ackets: testpmd> set verbose (any number > 2) 4- disable dump testpmd> set verbose 0 Signed-off-by: Raslan Darawsheh --- app/test-pmd/config.c | 25 + app/test-pmd/testpmd.c | 4 ++-- app/test-pmd/testpmd.h | 1 + 3 files changed, 28 insertions(+), 2 del

[dpdk-dev] [PATCH v3 2/2] net/tap: add queues when attaching from secondary process

2018-09-27 Thread Raslan Darawsheh
process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: - translate file descriptors via IPC API - add documentation v3: - rabse the commit - use private static array for fd's to be local for each process --- --- doc/guides/nics/tap.rst

[dpdk-dev] [PATCH v3 1/2] net/tap: change queue fd to be pointers to process private

2018-09-27 Thread Raslan Darawsheh
change the fds for the queues to be pointers and add new process private structure and make the queue fds point to it. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 63 --- drivers/net/tap/rte_eth_tap.h | 9 +-- drivers/net/tap

[dpdk-dev] [PATCH] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- .../multi_process/client_server_mp/mp_server/main.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/examples/multi_process/client_server_mp

[dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- v2: - fix includes order --- --- examples/multi_process/client_server_mp/mp_server/main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/examples/multi_process

[dpdk-dev] [PATCH v3] examples/client_server_mp: add sigint handler to server

2018-09-27 Thread Raslan Darawsheh
add sigint handler in the server application to stop and close ports Signed-off-by: Raslan Darawsheh --- v2: - fix includes order v3: - fix spacing --- --- examples/multi_process/client_server_mp/mp_server/main.c | 15 +++ 1 file changed, 15 insertions(+) diff

Re: [dpdk-dev] [PATCH v5 0/4] Hyper-V netvsc PMD (and VMBus)

2018-05-09 Thread Raslan Darawsheh
for target 'hn_ethdev.o' failed make[6]: *** [hn_ethdev.o] Error 1 make[6]: *** Waiting for unfinished jobs CC hn_rndis.o Kindest regards, Raslan Darawsheh -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, April 27,

[dpdk-dev] [PATCH v3] net/failsafe: fix probe cleanup

2018-05-09 Thread Raslan Darawsheh
to a segmentation fault. Uninstall the hot-plug alarm in case of error in probe function. Fixes: ebea83f8 ("net/failsafe: add plug-in support") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. v3 changes: Reword the commit log. v4 changes:

[dpdk-dev] [PATCH v4] net/failsafe: fix probe cleanup

2018-05-09 Thread Raslan Darawsheh
to a segmentation fault. Uninstall the hot-plug alarm in case of error in probe function. Fixes: ebea83f8 ("net/failsafe: add plug-in support") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. v3 changes: Reword the commit log. v4 changes:

[dpdk-dev] [PATCH v5] net/failsafe: fix probe cleanup

2018-05-09 Thread Raslan Darawsheh
to a segmentation fault. Uninstall the hot-plug alarm in case of error in probe function. Fixes: ebea83f8 ("net/failsafe: add plug-in support") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Matan Azrad Acked-by: Gaetan Rivet --- v2 changes: Reword the commit log. v3 c

[dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2018-05-23 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_18_05.rst | 151 + 1 file changed, 151 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index cc4b77f..2f5bab4 100644 --- a/doc/guides

[dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-07 Thread Raslan Darawsheh
In the case where the device is created by the primary process. Currently, secondary process only contains the eth dev without being able to do any Rx/Tx. When attaching the device from secondary process this patch adds queues info got from IPC massaging. Signed-off-by: Raslan Darawsheh

Re: [dpdk-dev] 17.11.3 (LTS) patches review and test

2018-06-07 Thread Raslan Darawsheh
Hi, We've tested this version and we don't see new issues with it. Kindest regards, Raslan Darawsheh -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yuanhan Liu Sent: Sunday, May 27, 2018 8:35 AM To: dpdk stable Cc: dev@dpdk.org; Thomas Monjalon Subj

Re: [dpdk-dev] 18.02.2 patches review and test

2018-06-07 Thread Raslan Darawsheh
Hi, We've tested this version and we don't see any new issues. Kindest regards, Raslan Darawsheh -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Luca Boccassi Sent: Monday, June 4, 2018 9:36 PM To: dpdk stable Cc: dev@dpdk.org Subject: Re: [dpdk-de

Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-07 Thread Raslan Darawsheh
o exchange the fds between the processes throw the IPC massages And to set the Rx/Tx functions for the secondary. I hope I explained it properly, please let me know if you still didn't get it. Kindest regards, Raslan Darawsheh -Original Message- From: Wiles, Keith [mailto:keith.

[dpdk-dev] [PATCH] doc: add tested platforms with Mellanox NICs

2019-01-24 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_19_02.rst | 189 + 1 file changed, 189 insertions(+) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst index facf0c5..4291f9f 100644 --- a/doc/guides

Re: [dpdk-dev] [dpdk-announce] release candidate 19.02-rc4

2019-01-31 Thread Raslan Darawsheh
Hi Thomas, We are ok with this release and we don't have any blocking issues. Kindest regards, Raslan Darawsheh > -Original Message- > From: announce On Behalf Of Thomas > Monjalon > Sent: Monday, January 28, 2019 4:10 AM > To: annou...@dpdk.org > Subject:

[dpdk-dev] [PATCH] net/tap: fix multi process request

2019-02-26 Thread Raslan Darawsheh
The structure was not initialized. Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/d

[dpdk-dev] [PATCH 0/4] support secondary process for failsafe

2019-02-28 Thread Raslan Darawsheh
this set of patches are intended to support secondary process for failsafe. Raslan Darawsheh (4): net/failsafe: replace local device with shared data net/failsafe: change back-reference from sub-device net/failsafe: replace local sub-device with shared data net/failsafe: support secondary

[dpdk-dev] [PATCH 2/4] net/failsafe: change back-reference from sub-device

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the sub-device structure is shared between processes. The reference to the failsafe device was a per process pointer. It's changed to port id which is the same for all processes. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- drivers/net/fai

[dpdk-dev] [PATCH 1/4] net/failsafe: replace local device with shared data

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Mon

[dpdk-dev] [PATCH 3/4] net/failsafe: replace local sub-device with shared data

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the pointer to sub-device is shared between processes. Previously, it was a pointer to per process eth_dev so it's needed to replace this dependency. Signed-off-by: Thomas Monjalon Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c

[dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- drivers/net/failsafe/failsafe.c | 43 - 1 file changed, 42 insertions

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-03-05 Thread Raslan Darawsheh
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 28, 2019 7:25 PM > To: Raslan Darawsheh > Cc: gaetan.ri...@6wind.com; dev@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary proces

[dpdk-dev] [PATCH v2 4/4] net/failsafe: support secondary process

2019-03-05 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed devargs_alread_listed return value to be bool. --- drivers/net/failsafe/failsafe.c | 45

[dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the sub-device structure is shared between processes. The reference to the failsafe device was a per process pointer. It's changed to port id which is the same for all processes. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed macro

[dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the pointer to sub-device is shared between processes. Previously, it was a pointer to per process eth_dev so it's needed to replace this dependency. Signed-off-by: Thomas Monjalon Signed-off-by: Raslan Darawsheh --- v2: - moved comment in fs_sdev about subs to

[dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Mon

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 6, 2019 8:02 PM > To: Gaëtan Rivet ; Raslan Darawsheh > > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device > wit

Re: [dpdk-dev] [PATCH v2 2/4] net/failsafe: change back-reference from sub-device

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gaëtan Rivet > Sent: Tuesday, March 5, 2019 6:49 PM > To: Raslan Darawsheh > Cc: dev@dpdk.org; Thomas Monjalon ; > step...@networkplumber.org > Subject: Re: [PATCH v2 2/4] net/failsafe: change back-reference from sub- > devic

Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data

2019-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gaëtan Rivet > Sent: Thursday, March 7, 2019 11:48 AM > To: Raslan Darawsheh > Cc: Thomas Monjalon ; dev@dpdk.org; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device > with

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-11 Thread Raslan Darawsheh
Hi, I've been trying to compile it as well without installing the VS stuff. But, it's always failing to compile: Even the sanitycheck.c file is failing with such error: lld-link.exe: error: could not open libcmt.lib: no such file or directory Kindest regards, Raslan Darawsheh >

[dpdk-dev] [PATCH 1/3] ethdev: expose Rx hardware timestamp

2017-08-22 Thread Raslan Darawsheh
Added new capability to the list of rx offloads for hw timestamp The PMDs how expose this capability will always have it enabled. But, if the following API got accepted applications can choose between disable/enable this API. http://dpdk.org/dev/patchwork/patch/27470/ Signed-off-by: Raslan

[dpdk-dev] [PATCH 2/3] app/testpmd: add Rx timestamp in testpmd

2017-08-22 Thread Raslan Darawsheh
Added new print in case a PMD exposes Rx timestamp. Also, added a print for timestamp value in rxonly mode in case the packet was timestamped. Signed-off-by: Raslan Darawsheh --- app/test-pmd/config.c | 3 +++ app/test-pmd/rxonly.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH 3/3] net/mlx5: add hardware timestamp

2017-08-22 Thread Raslan Darawsheh
. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c | 23 +++ drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 3 +++ drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers

[dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Raslan Darawsheh
Added hotplug in testpmd, to be able to test hotplug function in the PMD's. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c | 44 app/test-pmd/testpmd.c | 18 ++ app/test-pmd/testpmd.h | 1 + 3 files changed, 63 inser

[dpdk-dev] [PATCH v2 3/3] net/mlx5: add hardware timestamp

2017-08-24 Thread Raslan Darawsheh
. Signed-off-by: Raslan Darawsheh --- doc/guides/nics/mlx5.rst | 5 + drivers/net/mlx5/mlx5.c | 23 +++ drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 3 +++ drivers

[dpdk-dev] [PATCH v2 1/3] ethdev: expose Rx hardware timestamp

2017-08-24 Thread Raslan Darawsheh
Added new capability to the list of rx offloads for hw timestamp The PMDs how expose this capability will always have it enabled. But, if the following API got accepted applications can choose between disable/enable this API. http://dpdk.org/dev/patchwork/patch/27470/ Signed-off-by: Raslan

[dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx timestamp in testpmd

2017-08-24 Thread Raslan Darawsheh
Added new print in case a PMD exposes Rx timestamp. Also, added a print for timestamp value in rxonly mode in case the packet was timestamped. Signed-off-by: Raslan Darawsheh --- app/test-pmd/config.c | 3 +++ app/test-pmd/rxonly.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/app/test

[dpdk-dev] [PATCH] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Will now return the first sub device fail value in case it fails. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/fail

[dpdk-dev] [PATCH v2] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 20 ++-- 1 file changed, 10 inserti

[dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 19 +-- 1 file changed, 9 inserti

[dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability

2017-09-28 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- lib/librte_ether/rte_ethdev.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b

[dpdk-dev] [PATCH v3 2/3] app/testpmd: add Rx HW timestamp

2017-09-28 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2

[dpdk-dev] [PATCH v3 3/3] net/mlx5: add Rx HW timestamp

2017-09-28 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3

Re: [dpdk-dev] [Suspected-Phishing]Re: [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-02 Thread Raslan Darawsheh
Hi Guys, This is gentle remainder of this patch, Do we have any updates about it? Kindest regards Raslan Darawsheh -Original Message- From: gowrishankar muthukrishnan [mailto:gowrishanka...@linux.vnet.ibm.com] Sent: Wednesday, September 6, 2017 11:59 AM To: Thomas Monjalon Cc: dev

[dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst

[dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2

[dpdk-dev] [PATCH 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3

[dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst

[dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2

[dpdk-dev] [PATCH 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v5 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3 ++- drivers/net/mlx5

[dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst | 11 +++ lib

Re: [dpdk-dev] [Suspected-Phishing]Re: [Suspected-Phishing]Re: [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-03 Thread Raslan Darawsheh
Hi, I've just tested it and looks like the issue is fixed with this patch. Kindest regards Raslan Darawsheh -Original Message- From: gowrishankar muthukrishnan [mailto:gowrishanka...@linux.vnet.ibm.com] Sent: Monday, October 2, 2017 11:44 AM To: Raslan Darawsheh ; Thomas Monjalon

[dpdk-dev] [PATCH v6 2/3] app/testpmd: add Rx HW timestamp

2017-10-03 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v6 1/3] ethdev: add Rx HW timestamp capability

2017-10-03 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ Changes in v6: - Rebased properly on top of the mentioned

[dpdk-dev] [PATCH v6 3/3] net/mlx5: add Rx HW timestamp

2017-10-03 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- Changes in v6: - Rebasing the work on top of 217b1421 ("net/mlx5: separate DPDK from Verbs Rx queue objects") --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +

[dpdk-dev] [PATCH v7 1/3] ethdev: add Rx HW timestamp capability

2017-10-08 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh --- Changes in v7: - Updated features.rst to use both rx_offload_capa,rx_queue_offload_capa - Updated default.ini to have Timestamp offload --- doc/guides/nics

[dpdk-dev] [PATCH v7 2/3] app/testpmd: add Rx HW timestamp

2017-10-08 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v7 3/3] net/mlx5: add Rx HW timestamp

2017-10-08 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- Changes in v7: - Rebasing the work on top ot c814b93b ("net/mlx5: add vectorized Rx/Tx burst for ARM") - Adding the timestamp code for ARM NEON Changes in v6: - Rebasing the work on top of 217b1421 ("net

[dpdk-dev] [PATCH v8 2/3] app/testpmd: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2

[dpdk-dev] [PATCH v8 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Reviewed-by: Shahaf Shuler --- Changes in v7: - Updated features.rst to use both rx_offload_capa,rx_queue_offload_capa - Updated default.ini to have Timestamp

[dpdk-dev] [PATCH v8 3/3] net/mlx5: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- Changes in V8: - Rebasing the work on top of next-net Changes in v7: - Rebasing the work on top ot c814b93b ("net/mlx5: add vectorized Rx/Tx burst for ARM") - Adding the timestamp code for ARM NEON Cha

[dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability

2017-10-10 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Reviewed-by: Shahaf Shuler Acked-by: Yongseok Koh --- Changes in v7: - Updated features.rst to use both rx_offload_capa,rx_queue_offload_capa - Updated

[dpdk-dev] [PATCH v9 2/3] app/testpmd: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2

[dpdk-dev] [PATCH v9 3/3] net/mlx5: add Rx HW timestamp

2017-10-10 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- Changes in v9: - Fix indentation issue in mlx5_rxtx_vec_neon.h Changes in v8: - Rebasing the work on top of next-net Changes in v7: - Rebasing the work on top ot c814b93b ("net/mlx5: add vectorized Rx/Tx burst fo

<    4   5   6   7   8   9   10   11   12   13   >