Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

[Raslan Darawsheh]

Hi David, 

Thx for this feedback I'll be sending a new version with your suggestion. 

Kindest regards,
Raslan Darawsheh

-----Original Message-----
From: Jerin Jacob <jerin.ja...@caviumnetworks.com> 
Sent: Friday, September 14, 2018 9:35 AM
To: David Marchand <david.march...@6wind.com>
Cc: Raslan Darawsheh <rasl...@mellanox.com>; Wu, Jingjing 
<jingjing...@intel.com>; Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org; 
Shahaf Shuler <shah...@mellanox.com>; Xueming(Steven) Li <xuemi...@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to 
dump packets

-----Original Message-----
> Date: Thu, 13 Sep 2018 18:43:02 +0200
> From: David Marchand <david.march...@6wind.com>
> To: Raslan Darawsheh <rasl...@mellanox.com>
> Cc: "Wu, Jingjing" <jingjing...@intel.com>, Thomas Monjalon  
> <tho...@monjalon.net>, dev@dpdk.org, Shahaf Shuler 
> <shah...@mellanox.com>,  xuemi...@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic 
> function  to dump packets
> 
> 
> On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh <rasl...@mellanox.com> 
> wrote:
> > use the generic function to dump packets for several forwarding 
> > engines.
> 
> Rather than patching some engines, how about putting this in rx/tx callbacks ?

+1 to have zero performance impact on forward engines.

> A bit like something I sent earlier ?
> 
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> hes.dpdk.org%2Fpatch%2F44465%2F&amp;data=02%7C01%7Crasland%40mellanox.
> com%7C9bbd72a1f31b4555b0be08d61a0c4402%7Ca652971c7d2e4d9ba6a4d149256f4
> 61b%7C0%7C0%7C636725037336863883&amp;sdata=bWeN5Rsi0vrX5oPZYI5%2FChCZ4
> VogpRAiY6doOkT0Q8s%3D&amp;reserved=0
> 
> 
> --
> David Marchand