[dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-19 Thread Rahul Lakkireddy
3.2 Windows Software Development Kit (SDK) v10.0.17763 3.3 Windows Driver Kit (WDK) v10.0.17763 [1] https://software.intel.com/en-us/parallel-studio-xe Thanks, Rahul --- v2: - Add more info in commit message regarding Windows build. Rahul Lakkireddy (4): net/cxgbe: use relative paths for

[dpdk-dev] [PATCH v2 1/4] net/cxgbe: use relative paths for including header files

2018-12-19 Thread Rahul Lakkireddy
ntel Parallel Studio XE 2019 [1] 3. Development Tools: 3.1 Microsoft Visual Studio 2017 Professional 3.2 Windows Software Development Kit (SDK) v10.0.17763 3.3 Windows Driver Kit (WDK) v10.0.17763 [1] https://software.intel.com/en-us/parallel-studio-xe Signed-off-by: Rahul Lakkireddy ---

[dpdk-dev] [PATCH v2 2/4] net/cxgbe: fix macros related to logs for Windows

2018-12-19 Thread Rahul Lakkireddy
019 [1] 3. Development Tools: 3.1 Microsoft Visual Studio 2017 Professional 3.2 Windows Software Development Kit (SDK) v10.0.17763 3.3 Windows Driver Kit (WDK) v10.0.17763 [1] https://software.intel.com/en-us/parallel-studio-xe Signed-off-by: Rahul Lakkireddy --- v2: - Add more

[dpdk-dev] [PATCH v2 3/4] net/cxgbe: only define symbols when not available

2018-12-19 Thread Rahul Lakkireddy
ftware Development Kit (SDK) v10.0.17763 3.3 Windows Driver Kit (WDK) v10.0.17763 [1] https://software.intel.com/en-us/parallel-studio-xe Signed-off-by: Rahul Lakkireddy --- v2: - Add more info in commit message regarding Windows build. drivers/net/cxgbe/base/t4_hw.c | 4 ++-- driv

[dpdk-dev] [PATCH v2 4/4] net/cxgbe: fix other misc build issues for Windows

2018-12-19 Thread Rahul Lakkireddy
io XE 2019 [1] 3. Development Tools: 3.1 Microsoft Visual Studio 2017 Professional 3.2 Windows Software Development Kit (SDK) v10.0.17763 3.3 Windows Driver Kit (WDK) v10.0.17763 [1] https://software.intel.com/en-us/parallel-studio-xe Signed-off-by: Rahul Lakkireddy --- v2: - Add more info

Re: [dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-19 Thread Rahul Lakkireddy
On Thursday, December 12/20/18, 2018 at 03:09:44 +0530, Ferruh Yigit wrote: > On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote: > > This series of patches fix compilation warning and errors seen while > > building CXGBE PMD in preparation for Microsoft Windows OS support. > &

[dpdk-dev] [PATCH v2 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-10-06 Thread Rahul Lakkireddy
. - Ensure correct ULP type is set when offloading NAT actions. - Returning appropriate RTE_FLOW_ERROR_TYPE_ACTION error if a corresponding valid flow pattern item is not found. - Updated release notes. Rahul Lakkireddy (3): ethdev: add flow api actions to modify IP addresses ethdev: add flow

[dpdk-dev] [PATCH v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-10-06 Thread Rahul Lakkireddy
Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyu

[dpdk-dev] [PATCH v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-06 Thread Rahul Lakkireddy
Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyu Min Acked-by: Ori Kam --- v2: - Rebased to tip. - Removed adding actions to app/test-pmd

[dpdk-dev] [PATCH v2 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-10-06 Thread Rahul Lakkireddy
-off-by: Rahul Lakkireddy --- v2: - No changes. v1 changes since RFC v2: - Re-based to tip. - Updated all instances of fw_filter_wr to new fw_filter2_wr and removed fw_filter_wr. - Ensure correct ULP type is set when offloading NAT actions. - Returning appropriate RTE_FLOW_ERROR_TYPE_ACTION error

[dpdk-dev] [PATCH v2] ethdev: add action to swap source and destination MAC to flow API

2018-10-06 Thread Rahul Lakkireddy
-by: Rahul Lakkireddy Acked-by: Andrew Rybchenko --- RFC v1: http://mails.dpdk.org/archives/dev/2018-August/110232.html RFC v2: http://mails.dpdk.org/archives/dev/2018-August/110355.html v2: - Rebased to tip. - Removed adding action to app/test-pmd/config.c, to sync with rte_flow_conv() changes

[dpdk-dev] [PATCH v3 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-10-09 Thread Rahul Lakkireddy
appropriate RTE_FLOW_ERROR_TYPE_ACTION error if a corresponding valid flow pattern item is not found. - Updated release notes. Rahul Lakkireddy (3): ethdev: add flow api actions to modify IP addresses ethdev: add flow api actions to modify TCP/UDP port numbers net/cxgbe: add flow actions to modify

[dpdk-dev] [PATCH v3 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-09 Thread Rahul Lakkireddy
Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyu Min Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- v3: - Replaced uint16_t with

[dpdk-dev] [PATCH v3 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-10-09 Thread Rahul Lakkireddy
-off-by: Rahul Lakkireddy --- v3: - No changes. v2: - No changes. v1 changes since RFC v2: - Re-based to tip. - Updated all instances of fw_filter_wr to new fw_filter2_wr and removed fw_filter_wr. - Ensure correct ULP type is set when offloading NAT actions. - Returning appropriate

[dpdk-dev] [PATCH v3 1/3] ethdev: add flow api actions to modify IP addresses

2018-10-09 Thread Rahul Lakkireddy
Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy Acked-by: Xiaoyu

Re: [dpdk-dev] [PATCH v3 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-10-09 Thread Rahul Lakkireddy
On Tuesday, October 10/09/18, 2018 at 17:55:09 +0530, Ferruh Yigit wrote: > On 10/9/2018 9:44 AM, Rahul Lakkireddy wrote: > > Query firmware for the new filter work request to offload flows with > > actions to modify IP and TCP/UDP port addresses. When available, > > translat

Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API

2018-10-09 Thread Rahul Lakkireddy
On Tuesday, October 10/09/18, 2018 at 20:19:54 +0530, Ferruh Yigit wrote: > On 9/24/2018 9:29 AM, Rahul Lakkireddy wrote: > > This action is useful for offloading loopback mode, where the hardware > > will swap source and destination MAC addresses in the outermost Ethernet &g

[dpdk-dev] [PATCH] net/cxgbe: add action to swap MAC addresses

2018-10-15 Thread Rahul Lakkireddy
Implement RTE_FLOW_ACTION_TYPE_MAC_SWAP to offload flows with action to swap the source and destination MAC addresses in the outermost Ethernet header. Signed-off-by: Rahul Lakkireddy --- doc/guides/rel_notes/release_18_11.rst | 3 ++- drivers/net/cxgbe/base/t4_msg.h | 3 +++ drivers

[dpdk-dev] [PATCH] net/cxgbe: fix copyright year in license

2018-06-14 Thread Rahul Lakkireddy
Fixes: 22d9597f6b59 ("net/cxgbe: query firmware for filter resources") Fixes: 10eee6a8fae7 ("net/cxgbe: parse and validate flows") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 2 +- drivers/net/cxgbe/cxgbe_filter.h | 2 +- drivers/net/cxgb

[dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-06-22 Thread Rahul Lakkireddy
This series of patches add support for actions: - OF_SET_NW_IPV4_SRC - set a new IPv4 source address. - OF_SET_NW_IPV4_DST - set a new IPv4 destination address. - OF_SET_NW_IPV6_SRC - set a new IPv6 source address. - OF_SET_NW_IPV6_DST - set a new IPv6 destination address. - OF_SET_TP_SRC - set a n

[dpdk-dev] [RFC 1/3] ethdev: add flow api actions to modify IP addresses

2018-06-22 Thread Rahul Lakkireddy
OFPAT_SET_NW_DST in OpenFlow Specification. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- app/test-pmd/cmdline_flow.c | 100 app/test-pmd/config.c | 8 +++ doc/guides/prog_guide/rte_flow.rst | 68

[dpdk-dev] [RFC 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-06-22 Thread Rahul Lakkireddy
From: Shagun Agrawal Add actions: - OF_SET_TP_SRC - set a new TCP/UDP source port number. - OF_SET_TP_DST - set a new TCP/UDP destination port number. Based on OFPAT_SET_TP_SRC and OFPAT_SET_TP_DST actions from OpenFlow Specification. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul

[dpdk-dev] [RFC 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-06-22 Thread Rahul Lakkireddy
: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4fw_interface.h | 50 + drivers/net/cxgbe/cxgbe_filter.c| 23 +- drivers/net/cxgbe/cxgbe_filter.h| 26 ++- drivers/net/cxgbe/cxgbe_flow.c

[dpdk-dev] [PATCH 1/9] net/cxgbe: query firmware for HASH filter resources

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Fetch available HASH filter resources and allocate table for managing them. Currently only supported on Chelsio T6 family of NICs. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 7 ++ drivers/net/cxgbe/base

[dpdk-dev] [PATCH 0/9] net/cxgbe: add support for offloading flows to HASH region

2018-06-29 Thread Rahul Lakkireddy
This series of patches add support to offload flows to HASH region available on Chelsio T6 NICs. HASH region can only offload exact match (maskless) flows and hence the masks must be all set for all match items. Patch 1 queries firmware for HASH filter support. Patch 2 updates cxgbe_flow to decid

[dpdk-dev] [PATCH 3/9] net/cxgbe: add Compressed Local IP region

2018-06-29 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/Makefile | 1 + drivers/net/cxgbe/base/adapter.h| 32 ++ drivers/net/cxgbe/base/t4fw_interface.h | 19 drivers/net/cxgbe/clip_tbl.c| 195 drivers/net/cxgbe/clip_tbl.h

[dpdk-dev] [PATCH 2/9] net/cxgbe: validate flows offloaded to HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Fetch supported match items in HASH region. Ensure the mask is all set for all the supported match items to be offloaded to HASH region. Otherwise, offload them to LE-TCAM region. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base

[dpdk-dev] [PATCH 6/9] net/cxgbe: add support to query hit counters for flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to enable hit counters for flows offloaded in HASH region. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_tcb.h | 11 +++ drivers/net/cxgbe/cxgbe_filter.c | 71

[dpdk-dev] [PATCH 4/9] net/cxgbe: add support to offload flows to HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to offload flows to HASH region. Translate internal filter specification to requests to offload flows to HASH region. Save the returned hash index of the offloaded flow for deletion later. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy

[dpdk-dev] [PATCH 7/9] net/cxgbe: add support to flush flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c index 48df62aff..4f00ac4c6 100644 --- a

[dpdk-dev] [PATCH 5/9] net/cxgbe: add support to delete flows in HASH region

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add interface to delete offloaded flows in HASH region. Use the hash index saved during insertion to delete the corresponding flow. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_msg.h | 72 drivers/net

[dpdk-dev] [PATCH 9/9] net/cxgbe: add support to redirect packets to egress physical port

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add action to redirect matched packets to specified egress physical port without sending them to host. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_msg.h | 6 ++ drivers/net/cxgbe/cxgbe_filter.c | 19

[dpdk-dev] [PATCH 8/9] net/cxgbe: add support to match on ingress physical port

2018-06-29 Thread Rahul Lakkireddy
From: Shagun Agrawal Add support to match packets based on ingress physical port. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 16 +++- drivers/net/cxgbe/cxgbe_flow.c | 30 ++ 2 files changed

[dpdk-dev] [PATCH 1/5] net/cxgbe: add link up and down ops

2018-06-29 Thread Rahul Lakkireddy
Add ops to set link up and down for both PF and VF. If wait_to_complete is set, poll for link update for up to 10 seconds max. Original work by Surendra Mobiya Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe.h | 5 +++ drivers/net/cxgbe/cxgbe_ethdev.c | 72

[dpdk-dev] [PATCH 2/5] net/cxgbe: enable more RSS hash functions

2018-06-29 Thread Rahul Lakkireddy
Enable RSS on IPv4 fragmented packets and IPv6 packets with extension headers based on 2-tuple hash. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe.h| 15 ++- drivers/net/cxgbe/cxgbe_ethdev.c | 8 drivers/net/cxgbe/cxgbe_main.c | 14 -- 3

[dpdk-dev] [PATCH 0/5] net/cxgbe: feature updates and bug fixes

2018-06-29 Thread Rahul Lakkireddy
to manage internal mapping correctly. Patch 5 fixes forgotten Tx byte counters for VF. Thanks, Rahul Rahul Lakkireddy (5): net/cxgbe: add link up and down ops net/cxgbe: enable more RSS hash functions net/cxgbe: query firmware for max queues available net/cxgbe: fix Rx channel map and

[dpdk-dev] [PATCH 3/5] net/cxgbe: query firmware for max queues available

2018-06-29 Thread Rahul Lakkireddy
Query firmware for max Tx and Rx queues that can be allocated. Move the code to determine max queues to common place for both PF and VF. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 10 +++ drivers/net/cxgbe/base/t4_hw.c | 40

[dpdk-dev] [PATCH 5/5] net/cxgbevf: add missing Tx byte counters

2018-06-29 Thread Rahul Lakkireddy
Fixes: a0a344a8f728 ("net/cxgbe: add VF port statistics") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_regs.h | 3 +++ drivers/net/cxgbe/base/t4vf_hw.c | 6 ++ drivers/net/cxgbe/cxgbevf_ethdev.c | 1 + 3 files changed, 10 insertions(+) di

[dpdk-dev] [PATCH 4/5] net/cxgbe: fix Rx channel map and queue type

2018-06-29 Thread Rahul Lakkireddy
Set the Rx channel map and ingress queue type properly to allow firmware to manage the internal mapping correctly. Fixes: 6c2809628cd5 ("net/cxgbe: improve latency for slow traffic") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4fw_interf

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-02 Thread Rahul Lakkireddy
ahul > In our scenarios, we need to specific that NAT action is on inner or outer > IP header. > > Thanks, > -Jack > > > -----Original Message- > > From: dev On Behalf Of Rahul Lakkireddy > > Sent: June 22, 2018 17:56 > > To: dev@dpdk.org &g

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-03 Thread Rahul Lakkireddy
v4 { > uint32_t ipv4_addr; > uint8_t level; /* 0 - outer (default), 1 - inner, 2 -255 > deeper if available */ > }; > > What do you think ? > Looks good. I'll update the API and use the above approach in v2. Thanks, Rahul > >

[dpdk-dev] [PATCH] net/cxgbe: update release notes for flow API support

2018-07-06 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 2 +- doc/guides/rel_notes/release_18_08.rst | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/cxgbe.rst b/doc/guides/nics/cxgbe.rst index 124022cfc..58d88eef5 100644 --- a/doc

[dpdk-dev] [PATCH] net/cxgbe: fix init failure due to new flash parts

2018-07-09 Thread Rahul Lakkireddy
Add decode logic for new flash parts shipped with new Chelsio NICs to fix initialization failure on these NICs. Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 97 -- 1 file changed, 84 insertions(+), 13 deletions

[dpdk-dev] [PATCH 0/6] net/cxgbe: bug fixes

2018-11-08 Thread Rahul Lakkireddy
timeouts under heavy load. Patch 5 fixes wrong ingress port value being written in filter spec passed to hardware while offloading flows. Patch 6 fixes freeing illegal memory location while destroying MPS table. Thanks, Rahul Rahul Lakkireddy (6): net/cxgbevf: add missing PCI uninitialization

[dpdk-dev] [PATCH 2/6] net/cxgbe: check Rx offload flags before doing VLAN strip offload

2018-11-08 Thread Rahul Lakkireddy
Fixes: 436125e64174 ("net/cxgbe: update to Rx/Tx offloada API") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cx

[dpdk-dev] [PATCH 1/6] net/cxgbevf: add missing PCI uninitialization function for VF

2018-11-08 Thread Rahul Lakkireddy
Fixes: 2195df6d11bd ("net/cxgbe: rework ethdev device allocation") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbevf_ethdev.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbevf_ethdev.c b/drivers

[dpdk-dev] [PATCH 4/6] net/cxgbe: increase completion wait time for flow operations

2018-11-08 Thread Rahul Lakkireddy
.@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 4 ++-- drivers/net/cxgbe/cxgbe_flow.h | 5 +++-- drivers/net/cxgbe/cxgbe_main.c | 8 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_fl

[dpdk-dev] [PATCH 6/6] net/cxgbevf: fix illegal memory access when freeing MPS TCAM

2018-11-08 Thread Rahul Lakkireddy
e MPS table") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbevf_main.c | 6 ++ drivers/net/cxgbe/mps_tcam.c | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgbe/cxgbevf_main.c b/drivers/net/cxgbe/cxgbevf_main.c index 6223e1250..61bd85

[dpdk-dev] [PATCH 5/6] net/cxgbe: fix wrong ingress port value set in filter spec

2018-11-08 Thread Rahul Lakkireddy
Set the "value" in the filter spec and not the "mask". Also, remove duplicate comparison for hardware supported match items already done earlier. Fixes: af44a577988b ("net/cxgbe: support to offload flows to HASH region") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakk

[dpdk-dev] [PATCH 3/6] net/cxgbe: fix check for redefined match items

2018-11-08 Thread Rahul Lakkireddy
t;net/cxgbe: parse and validate flows") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c index 54ec7e595..a8f076

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-10 Thread Rahul Lakkireddy
On Friday, July 07/06/18, 2018 at 01:46:40 +0530, Adrien Mazarguil wrote: > On Tue, Jul 03, 2018 at 07:09:22PM +0530, Rahul Lakkireddy wrote: > > On Tuesday, July 07/03/18, 2018 at 07:57:55 +0530, Jack Min wrote: > > > Hey Rahul, > > > > > > Thank you, th

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: fix init failure due to new flash parts

2018-07-18 Thread Rahul Lakkireddy
On Wednesday, July 07/18/18, 2018 at 14:56:12 +0530, Ferruh Yigit wrote: > On 7/9/2018 4:43 PM, Rahul Lakkireddy wrote: > > Add decode logic for new flash parts shipped with new Chelsio NICs > > to fix initialization failure on these NICs. > > > > Cc: sta...@dpdk.org &

[dpdk-dev] [PATCH] net/cxgbevf: don't allocate control queues for VFs

2018-07-26 Thread Rahul Lakkireddy
;) Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index f1ca89cec..4dcad7a23 100644 --- a/drivers

[dpdk-dev] [PATCH] net/cxgbe: fix NULL deref in CLIP failure path

2018-07-26 Thread Rahul Lakkireddy
From: Shagun Agrawal Fixes: 3f2c1e20 ("net/cxgbe: add Compressed Local IP region") Coverity issue: 302872 Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/clip_tbl.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/d

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-08-02 Thread Rahul Lakkireddy
On Thursday, August 08/02/18, 2018 at 05:05:34 +0530, Jack Min wrote: > > -Original Message- > > From: Rahul Lakkireddy > > Sent: July 10, 2018 21:14 > > To: Adrien Mazarguil > > Cc: Jack Min ; dev@dpdk.org; Shagun Agarwal > > ; Indranil Choudhury

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-13 Thread Rahul Lakkireddy
On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > There is a need to offload rewrite MAC address for both destination and source > from the matched flow > > The proposed actions could make above easily achieved > +1. We're also looking to offload these actions. In addition,

[dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-08-13 Thread Rahul Lakkireddy
From: Shagun Agrawal Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- v2: - Remove OpenFlow prefix from TCP/UDP port rewrite actions. - Re-based to tip

[dpdk-dev] [RFC v2 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-08-13 Thread Rahul Lakkireddy
: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- v2: - Re-based to tip. drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4fw_interface.h | 50 drivers/net/cxgbe/cxgbe_filter.c| 21 ++- drivers/net/cxgbe/cxgbe_filter.h| 23

[dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-08-13 Thread Rahul Lakkireddy
From: Shagun Agrawal Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul

[dpdk-dev] [RFC v2 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-08-13 Thread Rahul Lakkireddy
This series of patches add support for actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. - SET_TP_SRC - set a new TCP/UDP source port numb

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-21 Thread Rahul Lakkireddy
On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote: > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote: > > On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > > > There is a need to offload rewrite MAC address for bo

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-23 Thread Rahul Lakkireddy
On Thursday, August 08/23/18, 2018 at 07:45:27 +0530, Jack MIN wrote: > On Tue, Aug 21, 2018 at 01:44:32PM +0530, Rahul Lakkireddy wrote: > > On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote: > > > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy

[dpdk-dev] [PATCH 0/4] net/cxgbe: add destination MAC match and VLAN rewrite support for flow API

2018-08-27 Thread Rahul Lakkireddy
This series of patches add support to offload flows with destination MAC match item and VLAN push/pop/rewrite actions. Patch 1 adds API to program and manage hardware Layer 2 Table (L2T). L2T holds destination node information to be used for VLAN rewrite. Patch 2 implements offloading VLAN push/p

[dpdk-dev] [PATCH 4/4] net/cxgbe: add flow operations to match based on destination MAC address

2018-08-27 Thread Rahul Lakkireddy
regions. Also update existing mac_addr_set() to use the new MPS table API. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- doc/guides/rel_notes/release_18_11.rst | 1 + drivers/net/cxgbe/base/common.h| 1 + drivers/net/cxgbe/base/t4_hw.c | 2 ++ drivers/net

[dpdk-dev] [PATCH 1/4] net/cxgbe: add API to program hardware layer 2 table

2018-08-27 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to program and manage hardware Layer 2 Table. L2T holds information necessary to rewrite specific fields in packet, such as destination MAC address and vlan id. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/Makefile

[dpdk-dev] [PATCH 2/4] net/cxgbe: add flow operations to offload vlan actions

2018-08-27 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy --- doc/guides/rel_notes/release_18_11.rst | 6 drivers/net/cxgbe/base/t4_msg.h| 6 drivers/net/cxgbe/base/t4_tcb.h| 5 +++ drivers/net/cxgbe/cxgbe_filter.c | 62 -- drivers/net/cxgbe

[dpdk-dev] [PATCH 3/4] net/cxgbe: add API to program hardware MPS table

2018-08-27 Thread Rahul Lakkireddy
promiscuous mode. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/Makefile | 1 + drivers/net/cxgbe/base/adapter.h| 1 + drivers/net/cxgbe/base/common.h | 6 + drivers/net/cxgbe/base/t4_hw.c | 106

[dpdk-dev] [PATCH] net/cxgbe: fix illegal memory access when parsing flow match items

2018-08-27 Thread Rahul Lakkireddy
From: Shagun Agrawal Coverity issue: 293096 Fixes: ee61f511 ("net/cxgbe: parse and validate flows") Cc: sta...@dpdk.org Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

[dpdk-dev] [RFC] ethdev: add action to swap source and destination MAC to flow API

2018-08-27 Thread Rahul Lakkireddy
are swapped before either the source or destination MAC address is rewritten and NAT is performed. Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- app/test-pmd/cmdline_flow.c | 9 + app/test-pmd/config.c | 1 + doc/guides

Re: [dpdk-dev] [RFC] ethdev: add action to swap source and destination MAC to flow API

2018-08-29 Thread Rahul Lakkireddy
On Tuesday, August 08/28/18, 2018 at 16:27:43 +0530, Andrew Rybchenko wrote: >On 08/27/2018 03:54 PM, Rahul Lakkireddy wrote: > > From: Shagun Agrawal [1] > > This action is useful for offloading loopback mode, where the hardware > will swap source and destination

[dpdk-dev] [RFC v2] ethdev: add action to swap source and destination MAC to flow API

2018-08-29 Thread Rahul Lakkireddy
: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- v2: - Updated all comments and doc to indicate outermost Ethernet header's source and destination MAC addresses are swapped and that a valid RTE_FLOW_ITEM_TYPE_ETH must be specified. Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error should be ret

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify IP addresses

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 13:26:06 +0530, Xiaoyu Min wrote: > > > > static int > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > index f8ba71cdb..48c3c606e 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -15

Re: [dpdk-dev] [RFC v2 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 14:59:10 +0530, Xiaoyu Min wrote: > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index 638331c17..f60be0862 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/gui

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER not available in i40e an cxgbe

2018-09-19 Thread Rahul Lakkireddy
On Tuesday, September 09/18/18, 2018 at 14:54:07 +0530, Martin Weiser wrote: > Hi, > > is there a specific reason that the rx offload capability > DEV_RX_OFFLOAD_SCATTER is not available in the i40e and cxgbe drivers in > DPDK 18.08? > We previously used this feature with DPDK 17.11 to handle jumb

[dpdk-dev] [PATCH 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-09-24 Thread Rahul Lakkireddy
if a corresponding valid flow pattern item is not found. - Updated release notes. Rahul Lakkireddy (3): ethdev: add flow api actions to modify IP addresses ethdev: add flow api actions to modify TCP/UDP port numbers net/cxgbe: add flow actions to modify IP and TCP/UDP port address app

[dpdk-dev] [PATCH 1/3] ethdev: add flow api actions to modify IP addresses

2018-09-24 Thread Rahul Lakkireddy
Add actions: - SET_IPV4_SRC - set a new IPv4 source address. - SET_IPV4_DST - set a new IPv4 destination address. - SET_IPV6_SRC - set a new IPv6 source address. - SET_IPV6_DST - set a new IPv6 destination address. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- Changes

[dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-09-24 Thread Rahul Lakkireddy
Add actions: - SET_TP_SRC - set a new TCP/UDP source port number. - SET_TP_DST - set a new TCP/UDP destination port number. Original work by Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- Changes since RFC v2: - Updated comments, help messages, and doc to indicate that IP/TCP/UDP of the

[dpdk-dev] [PATCH 3/3] net/cxgbe: add flow actions to modify IP and TCP/UDP port address

2018-09-24 Thread Rahul Lakkireddy
-off-by: Rahul Lakkireddy --- Changes since RFC v2: - Re-based to tip. - Updated all instances of fw_filter_wr to new fw_filter2_wr and removed fw_filter_wr. - Ensure correct ULP type is set when offloading NAT actions. - Returning appropriate RTE_FLOW_ERROR_TYPE_ACTION error if a corresponding

[dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API

2018-09-24 Thread Rahul Lakkireddy
-by: Rahul Lakkireddy --- RFC v1: http://mails.dpdk.org/archives/dev/2018-August/110232.html RFC v2: http://mails.dpdk.org/archives/dev/2018-August/110355.html Changes since RFC v2: - Updated release notes. app/test-pmd/cmdline_flow.c | 10 ++ app/test-pmd/config.c

[dpdk-dev] [PATCH] net/cxgbe: add missing DEV_RX_OFFLOAD_SCATTER flag

2018-09-24 Thread Rahul Lakkireddy
;) Cc: sta...@dpdk.org Reported-by: Martin Weiser Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe.h| 15 +++ drivers/net/cxgbe/cxgbe_ethdev.c | 19 +++ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers

[dpdk-dev] [PATCH] net/cxgbe: free resources in dev_uninit function

2018-05-12 Thread Rahul Lakkireddy
ation") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe_ethdev.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c index 14011bb..3ee7

[dpdk-dev] [PATCH] net/cxgbevf: fix inter-vm traffic when physical link down

2018-05-18 Thread Rahul Lakkireddy
-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst| 6 ++ drivers/net/cxgbe/cxgbe.h| 4 drivers/net/cxgbe/cxgbe_ethdev.c | 14 ++ drivers/net/cxgbe/cxgbe_main.c | 17 - 4 files changed, 32 insertions(+), 9 deletion

[dpdk-dev] [PATCH v2] net/cxgbevf: fix inter-vm traffic when physical link down

2018-05-21 Thread Rahul Lakkireddy
: add skeleton VF driver") Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- v2: - Move CXGBE_DEVARG_KEEP_OVLAN macro to header file to keep all devargs in one place. - Add RTE_PMD_REGISTER_PARAM_STRING to export all supported devargs. doc/g

[dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation

2018-05-23 Thread Rahul Lakkireddy
Report current configured link auto-negotiation. Also initialize rte_eth_link. Coverity issue: 280648 Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++- 1 file changed, 2

[dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources

2018-06-08 Thread Rahul Lakkireddy
: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h| 4 ++ drivers/net/cxgbe/base/t4fw_interface.h | 6 ++ drivers/net/cxgbe/cxgbe_filter.h| 97 + drivers/net/cxgbe/cxgbe_main.c | 106

[dpdk-dev] [PATCH 0/7] cxgbe: add support to offload flows via rte_flow

2018-06-08 Thread Rahul Lakkireddy
This series add basic support to offload flows to Chelsio T5/T6 NICs via rte_flow API. Chelsio NICs can support wildcard (maskfull) filters and exact (maskless) filters. Filters can be created in two regions available on Chelsio NICs. The smaller LE-TCAM region can support both maskfull and maskles

[dpdk-dev] [PATCH 2/7] net/cxgbe: parse and validate flows

2018-06-08 Thread Rahul Lakkireddy
available free index. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 1 + doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/rel_notes/release_18_08.rst | 5 + drivers/net/cxgbe/Makefile

[dpdk-dev] [PATCH 5/7] net/cxgbe: implement flow destroy operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to construct delete filter work request to remove filter at specified index in LE-TCAM (maskfull) region. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 114

[dpdk-dev] [PATCH 3/7] net/cxgbe: add control queue to communicate filter requests

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add control queue to communicate filter creation/deletion requests with firmware. This API will be used by subsequent patches. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h| 15

[dpdk-dev] [PATCH 6/7] net/cxgbe: implement flow query operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to query filter hit and byte counts from hardware. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h | 1 + drivers/net/cxgbe/base/common.h | 15 +++ drivers/net/cxgbe/base/t4_hw.c

[dpdk-dev] [PATCH 7/7] net/cxgbe: implement flow flush operation

2018-06-08 Thread Rahul Lakkireddy
From: Shagun Agrawal Add API to flush all the filters under specified port. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.h | 1 + drivers/net/cxgbe/cxgbe_flow.c | 40

[dpdk-dev] [PATCH 4/7] net/cxgbe: implement flow create operation

2018-06-08 Thread Rahul Lakkireddy
) region at specified index. Signed-off-by: Shagun Agrawal Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h| 21 ++ drivers/net/cxgbe/base/t4_msg.h | 22 ++ drivers/net/cxgbe/base/t4fw_interface.h | 145 + drivers

[dpdk-dev] [PATCH v4 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

2015-07-01 Thread Rahul Lakkireddy
On Tue, Jun 30, 2015 at 23:01:39 +0200, Thomas Monjalon wrote: > 2015-06-30 04:58, Rahul Lakkireddy: > > This series of patches add the CXGBE Poll Mode Driver support for Chelsio > > Terminator 5 series of 10G/40G adapters. The CXGBE PMD is split into > > multiple > >

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Rahul Lakkireddy
Hi Alejandro, On Mon, Jul 06, 2015 at 16:45:01 +0100, Alejandro Lucero wrote: > Hi all, > > From the kernel VFIO maintainer: > > "I suppose in the short term, mmap should not be advertised as available > on 32bit hosts. Thanks," > > So, as VFIO support for 32bit systems is broken, DPDK should

[dpdk-dev] [PATCH v2] vfio: Fix overflow while assigning vfio BAR region offset and size

2015-07-07 Thread Rahul Lakkireddy
Hi Anatoly, On Tue, Jul 07, 2015 at 09:08:08 +, Burakov, Anatoly wrote: > Hi all, > > > So, as VFIO support for 32bit systems is broken, DPDK should not configure > > VFIO in that case. > > ...Or no one should try and run VFIO on a 32-bit system, which should be > noted in documentation. I

[dpdk-dev] [PATCH 0/3] cxgbe: RX perf fixes, doc update, and add support for more devices

2015-07-07 Thread Rahul Lakkireddy
T5 devices. Rahul Lakkireddy (3): cxgbe: Fix RX performance for cxgbe PMD. cxgbe: Add more supported Chelsio T5 devices. doc: Update cxgbe documentation doc/guides/nics/cxgbe.rst | 84 ++- drivers/net/cxgbe/base/adapter.h| 2 + drivers/net/cxgbe/base

[dpdk-dev] [PATCH 1/3] cxgbe: Fix RX performance for cxgbe PMD.

2015-07-07 Thread Rahul Lakkireddy
CXGBE PMD rx allocates a new mbuf everytime, which could lead to performance hit. Instead, do bulk allocation of mbufs and re-use them. Also, simplify the overall rx-handler, and update its logic to fix rx perf. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net

[dpdk-dev] [PATCH 2/3] cxgbe: Add more supported Chelsio T5 devices.

2015-07-07 Thread Rahul Lakkireddy
Update pci id table to include more supported Chelsio T5 devices. Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/base/t4_pci_id_tbl.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cxgbe/base/t4_pci_id_tbl.h b/drivers/net/cxgbe/base

[dpdk-dev] [PATCH 3/3] doc: Update cxgbe documentation

2015-07-07 Thread Rahul Lakkireddy
Update cxgbe documentation with the following: 1. Add instructions on how to flash firmware and config file on Chelsio T5 devices. 2. Add a list of supported devices. 3. Add instructions on how to enable and disable flow control via testpmd. Signed-off-by: Rahul Lakkireddy Signed-off-by

[dpdk-dev] [PATCH 1/3] doc: add CXGBEVF PMD documentation

2018-04-03 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add documentation on running DPDK on SR-IOV virtual functions for Chelsio NICs. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst| 127 ++- doc/guides/nics/features/cxgbevf.ini | 1 + 2

<    1   2   3   4   5   >