Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor

2022-06-21 Thread Omer Yamac
On 21.06.2022 13:26, Ferruh Yigit wrote: On 6/21/2022 9:44 AM, Hunt, David wrote: Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: This patch fixes the syntax error when using the single-core for both rx and distributor functions. Fixes: 4

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-27 Thread Omer Yamac
Hi David, Thank you for your review. I have two questions. The first one is about new release. As I remember new DPDK realize will be published in a short time and my previous fix in that release. Therefore, Should I wait for that release to submit patch? The other question is below, On 27.

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
Hi David, I have one more question. When I was working on new patch, I just want to make sure what we are doing. On 27.06.2022 18:51, Hunt, David wrote: Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: --clipped-- @@ -39,6 +39,7 @@ volatile uint8_t quit_signal_

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
distributor, 3 fixed function cores (stat, TX, at least 1 worker) min_cores = 5; num_workers = rte_lcore_count() - 4; } On 28.06.2022 14:25, Hunt, David wrote: On 28/06/2022 12:06, Omer Yamac wrote: Hi David, I have one more question. When I was working on new patch, I just

Re: [PATCH v2] examples/distributor: update dynamic configuration

2022-09-01 Thread Omer Yamac
Hi David, I applied the changes as new version (v3), Thank you On 01.09.2022 13:58, Hunt, David wrote: Hi Ömer, On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer Yamaç) wrote: In this patch, * It is possible to switch the running mode of the distributor using the comman

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Omer Yamac
On 03.10.2022 12:19, Bruce Richardson wrote: On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: In this patch, we remove all version.map files which include only the below part: `DPDK_23 { local: *; };` Then we modify the meson.build to be able to compile without v

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Omer Yamac
On 03.10.2022 17:01, Bruce Richardson wrote: On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: On 03.10.2022 12:19, Bruce Richardson wrote: > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > > In this patch, we remove all version.map files whic

Re: [PATCH 1/2] drivers: suggestion on meson without version file

2022-10-10 Thread Omer Yamac
On 07.10.2022 13:30, Bruce Richardson wrote: The title of this patch needs an update - I would suggest something like: "build: make version file optional for drivers" Thank you, it will make more sense More comments inline below. On Thu, Oct 06, 2022 at 10:19:22AM +0300, Abdullah Ömer Yam

Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map

2022-10-11 Thread Omer Yamac
On 11.10.2022 16:10, David Marchand wrote: On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç wrote: With the previous patch, some version.map files are not necessary. In this patch, we removed them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit I'd like some check add