On 11.10.2022 16:10, David Marchand wrote:
On Tue, Oct 11, 2022 at 1:09 PM Abdullah Ömer Yamaç
<omer.ya...@ceng.metu.edu.tr> wrote:
With the previous patch, some version.map files are not necessary.
In this patch, we removed them.
Signed-off-by: Abdullah Ömer Yamaç <omer.ya...@ceng.metu.edu.tr>
Suggested-by: Ferruh Yigit <ferruh.yi...@amd.com>
I'd like some check added as part of this series.
Thank you for this patch.
Something like:
$ git diff
diff --git a/devtools/check-symbol-maps.sh
b/devtools/check-symbol-maps.sh
index 32e1fa5c8f..9d2f85ed73 100755
--- a/devtools/check-symbol-maps.sh
+++ b/devtools/check-symbol-maps.sh
@@ -60,4 +60,18 @@ if [ -n "$local_miss_maps" ] ; then
ret=1
fi
+find_unneeded_maps ()
+{
+ for map in $@ ; do
+ [ $(buildtools/map-list-symbol.sh $map | wc -l) != 0 ] || echo
$map
+ done
+}
+
+unneeded_maps=$(find_unneeded_maps $@)
+if [ -n "$unneeded_maps" ] ; then
+ echo "Found unneeded map files:"
+ echo "$unneeded_maps"
+ ret=1
+fi
+
exit $ret
It helped me catch:
$ ./devtools/check-symbol-maps.sh
Found unneeded map files:
drivers/net/mana/version.map
That’s my fault, I forgot to rebase my local repo. Thanks
