[dpdk-dev] [PATCH] net/mlx5: fix 32bits compilation issue

2017-01-18 Thread Nelio Laranjeiro
Fixes: 02bb06aca20f ("net/mlx5: use vector types to speed up processing") Reported-by: Thomas Monjalon Signed-off-by: Nelio Laranjeiro --- Please squash it in the original patch if possible. --- drivers/net/mlx5/mlx5_rxtx.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[dpdk-dev] [PATCH 2/2] net/mlx5: fix Rx packet validation and type

2017-01-20 Thread Nelio Laranjeiro
sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_prm.h | 47 + drivers/net/mlx5/mlx5_rxtx.c | 50 +++- 2 files changed, 50 insertions(+), 47 deletions(-) diff --git a/drivers/net/mlx5/mlx5_prm.h

[dpdk-dev] [PATCH 1/2] net/mlx5: fix flow API mark combined with drop

2017-01-20 Thread Nelio Laranjeiro
Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index d7ed686..7b97a61 10

[dpdk-dev] [PATCH 1/2] net/mlx5: fix VLAN validation

2017-01-27 Thread Nelio Laranjeiro
TCI field is read from the wrong place due to an invalid cast. Moreover there is no need to limit matching to VID since PCP and DEI bits can be matched as well. Fixes: 12475fb203ad ("net/mlx5: support VLAN flow item") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_f

[dpdk-dev] [PATCH 2/2] net/mlx5: fix validation

2017-01-27 Thread Nelio Laranjeiro
Size of the mask is wrongly computed and make the validation process only verify the first 4 bytes of the layer. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH 1/3] net/mlx5: use flow API default masks

2017-01-31 Thread Nelio Laranjeiro
Default masks were introduced in the API after its implementation in this PMD. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers

[dpdk-dev] [PATCH 3/3] net/mlx5: fix flow rule creation if ports are stopped

2017-01-31 Thread Nelio Laranjeiro
Adding a flow when the port is stopped ends in an inconsistent situation where the queue can receive traffic when it should not. Record new rules and apply them as soon as the port is started. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Signed-off-by: Nelio

[dpdk-dev] [PATCH 2/3] net/mlx5: fix verification of mark action

2017-01-31 Thread Nelio Laranjeiro
A configuration structure for the MARK action must always be specified. Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletio

[dpdk-dev] [PATCH 1/3] net/mlx5: fix Ethernet header re-writing

2017-02-02 Thread Nelio Laranjeiro
First two bytes of the Ethernet header was written twice at the same place. Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization") Signed-off-by: Yongseok Koh Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 36 1 file c

[dpdk-dev] [PATCH 2/3] net/mlx5: fix Tx WQE corruption caused by starvation

2017-02-02 Thread Nelio Laranjeiro
putting the work queue in error. Fixes: 2a66cf378954 ("net/mlx5: support inline send") Cc: sta...@dpdk.org Reported-by: Elad Persiko Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 91 +--- driver

[dpdk-dev] [PATCH 3/3] net/mlx5: fix inline WQE consumption

2017-02-02 Thread Nelio Laranjeiro
.@dpdk.org Reported-by: Elad Persiko Signed-off-by: Yongseok Koh Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c ind

[dpdk-dev] [PATCH] doc: add flow API to features list

2017-02-09 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/mlx5.ini| 1 + doc/guides/nics/mlx5.rst | 1 + 3 files changed, 3 insertions(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini

[dpdk-dev] [PATCH 0/3] doc: update release notes

2017-02-09 Thread Nelio Laranjeiro
Biggest change is in the first patch to provide a better visibility for users on which NIC has been tested on which platform. Others two are just updates for Mellanox PMDs. Nelio Laranjeiro (3): doc: merge release notes sections doc: update release notes for mlx4 doc: update release notes

[dpdk-dev] [PATCH 1/3] doc: merge release notes sections

2017-02-09 Thread Nelio Laranjeiro
These sections do not provide the exact tests that were done nor whether specific NICs are supported by all platforms. Signed-off-by: Nelio Laranjeiro --- doc/guides/rel_notes/release_17_02.rst | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff

[dpdk-dev] [PATCH 2/3] doc: update release notes for mlx4

2017-02-09 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/mlx4.rst | 9 +++-- doc/guides/rel_notes/release_17_02.rst | 35 ++ 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index

[dpdk-dev] [PATCH 3/3] doc: update release notes for mlx5

2017-02-09 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/mlx5.rst | 37 -- doc/guides/rel_notes/release_17_02.rst | 202 + 2 files changed, 230 insertions(+), 9 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index

[dpdk-dev] [PATCH v2] doc: add flow API to features list

2017-02-09 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- Changes in v2: - add ixgbe and i40e. --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/i40e.ini| 1 + doc/guides/nics/features/ixgbe.ini | 1 + doc/guides/nics/features/mlx5.ini| 1 + doc/guides/nics/mlx5.rst

[dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell

2016-12-09 Thread Nelio Laranjeiro
Too much data is uselessly written to the Tx doorbell. Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- This patch should be applied on top of [1] or [2]. [1] http://dpdk.org/ml/archives/dev/2016-November/0507

[dpdk-dev] [PATCH v2 1/4] net/mlx5: add preliminary support for rte_flow

2016-12-21 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.h | 16 ++ drivers/net/mlx5/mlx5_fdir.c | 15 ++ drivers/net/mlx5/mlx5_flow.c | 122 +++ 4 files changed, 154 insertions(+) create mode 100644

[dpdk-dev] [PATCH v2 2/4] net/mlx5: add software support for rte_flow

2016-12-21 Thread Nelio Laranjeiro
Introduce initial software validation for rte_flow rules. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.c| 202 ++-- drivers/net/mlx5/mlx5_trigger.c | 2 + 3 files changed, 177 insertions(+), 29

[dpdk-dev] [PATCH v2 3/4] net/mlx5: add rte_flow rule creation

2016-12-21 Thread Nelio Laranjeiro
Convert Ethernet, IPv4, IPv6, TCP, UDP layers into ibv_flow and create those rules when after validation (i.e. NIC supports the rule). VLAN is still not supported in this commit. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 3 +- drivers/net/mlx5/mlx5_flow.c| 737

[dpdk-dev] [PATCH v2 0/4] net/mlx5: support flow_rte

2016-12-21 Thread Nelio Laranjeiro
This series requires rte_flow [1]. It brings rte_flow support to the same level as flow director (FDIR) in mlx5. [1] http://dpdk.org/ml/archives/dev/2016-December/052802.html Changes in v2: - Fix several issues. - Support VLAN filtering. Nelio Laranjeiro (4): net/mlx5: add preliminary

[dpdk-dev] [PATCH v2 4/4] net/mlx5: add VLAN filter support in rte_flow

2016-12-21 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 59 ++-- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 44e2fb8..fec1950 100644 --- a/drivers/net/mlx5

[dpdk-dev] [PATCH v3 0/4] net/mlx5: support flow_rte

2016-12-21 Thread Nelio Laranjeiro
. Nelio Laranjeiro (4): net/mlx5: add preliminary support for rte_flow net/mlx5: add software support for rte_flow net/mlx5: add rte_flow rule creation net/mlx5: add VLAN filter support in rte_flow drivers/net/mlx5/Makefile |1 + drivers/net/mlx5/mlx5.h | 19 + drivers

[dpdk-dev] [PATCH v3 1/4] net/mlx5: add preliminary support for rte_flow

2016-12-21 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.h | 16 ++ drivers/net/mlx5/mlx5_fdir.c | 15 ++ drivers/net/mlx5/mlx5_flow.c | 122 +++ 4 files changed, 154 insertions(+) create mode 100644

[dpdk-dev] [PATCH v3 3/4] net/mlx5: add rte_flow rule creation

2016-12-21 Thread Nelio Laranjeiro
Convert Ethernet, IPv4, IPv6, TCP, UDP layers into ibv_flow and create those rules when after validation (i.e. NIC supports the rule). VLAN is still not supported in this commit. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 3 +- drivers/net/mlx5/mlx5_flow.c| 733

[dpdk-dev] [PATCH v3 2/4] net/mlx5: add software support for rte_flow

2016-12-21 Thread Nelio Laranjeiro
Introduce initial software validation for rte_flow rules. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.c| 202 ++-- drivers/net/mlx5/mlx5_trigger.c | 2 + 3 files changed, 177 insertions(+), 29

[dpdk-dev] [PATCH v3 4/4] net/mlx5: add VLAN filter support in rte_flow

2016-12-21 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 59 ++-- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index a33c568..2478fb6 100644 --- a/drivers/net/mlx5

[dpdk-dev] [PATCH] net/mlx5: fix RSS hash result for flows

2016-12-28 Thread Nelio Laranjeiro
Flows redirected to a specific queue do not have a valid RSS hash result and the related mbuf flag must not be set. Fixes: ecf60761fc2a ("net/mlx5: return RSS hash result in mbuf") CC: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/m

[dpdk-dev] [PATCH v4 3/6] net/mlx5: support VLAN flow item

2016-12-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index ebae2b5..549da6c 100644

[dpdk-dev] [PATCH v4 2/6] net/mlx5: support basic flow items and actions

2016-12-28 Thread Nelio Laranjeiro
Introduce initial software for rte_flow rules. VLAN, VXLAN are still not supported. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 3 + drivers/net/mlx5/mlx5_flow.c| 928 ++-- drivers/net/mlx5

[dpdk-dev] [PATCH v4 1/6] net/mlx5: add preliminary flow API support

2016-12-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.h | 16 ++ drivers/net/mlx5/mlx5_fdir.c | 15 ++ drivers/net/mlx5/mlx5_flow.c | 124 +++ 4 files changed, 156

[dpdk-dev] [PATCH v4 0/6] net/mlx5: support flow API

2016-12-28 Thread Nelio Laranjeiro
Changes in v4: - Simplify flow parsing by using a graph. - Add VXLAN flow item. - Add mark flow action. - Extend IPv4 filter item (Type of service, Next Protocol ID). Changes in v3: - Fix Ethernet ether type issue. Changes in v2: - Fix several issues. - Support VLAN filtering. Nelio

[dpdk-dev] [PATCH v4 4/6] net/mlx5: support VXLAN flow item

2016-12-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 72 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 549da6c..1ec0ef5 100644

[dpdk-dev] [PATCH v4 6/6] net/mlx5: extend IPv4 flow item

2016-12-28 Thread Nelio Laranjeiro
This commits adds: - Type of service - Next protocol ID Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5

[dpdk-dev] [PATCH v4 5/6] net/mlx5: support mark flow action

2016-12-28 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 78 drivers/net/mlx5/mlx5_prm.h | 70 ++- drivers/net/mlx5/mlx5_rxtx.c | 12 ++- drivers/net/mlx5/mlx5_rxtx.h | 3

[dpdk-dev] [PATCH v5 0/6] net/mlx5: support flow API

2016-12-29 Thread Nelio Laranjeiro
). Changes in v3: - Fix Ethernet ether type issue. Changes in v2: - Fix several issues. - Support VLAN filtering. Nelio Laranjeiro (6): net/mlx5: add preliminary flow API support net/mlx5: support basic flow items and actions net/mlx5: support VLAN flow item net/mlx5: support VXLAN flow item

[dpdk-dev] [PATCH v5 1/6] net/mlx5: add preliminary flow API support

2016-12-29 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.h | 16 ++ drivers/net/mlx5/mlx5_fdir.c | 15 ++ drivers/net/mlx5/mlx5_flow.c | 124 +++ 4 files changed, 156

[dpdk-dev] [PATCH v5 2/6] net/mlx5: support basic flow items and actions

2016-12-29 Thread Nelio Laranjeiro
Introduce initial software for rte_flow rules. VLAN, VXLAN are still not supported. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.h | 3 + drivers/net/mlx5/mlx5_flow.c| 954 ++-- drivers/net/mlx5

[dpdk-dev] [PATCH v5 3/6] net/mlx5: support VLAN flow item

2016-12-29 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 62 +++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 4f6696e..8f2f4d5 100644

[dpdk-dev] [PATCH v5 5/6] net/mlx5: support mark flow action

2016-12-29 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 78 drivers/net/mlx5/mlx5_prm.h | 70 ++- drivers/net/mlx5/mlx5_rxtx.c | 12 ++- drivers/net/mlx5/mlx5_rxtx.h | 3

[dpdk-dev] [PATCH v5 6/6] net/mlx5: extend IPv4 flow item

2016-12-29 Thread Nelio Laranjeiro
This commits adds: - Type of service - Next protocol ID Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b

[dpdk-dev] [PATCH v5 4/6] net/mlx5: support VXLAN flow item

2016-12-29 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 78 1 file changed, 72 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 8f2f4d5..093c140 100644

[dpdk-dev] [PATCH] net/mlx5: fix MTU update

2017-08-01 Thread Nelio Laranjeiro
Changing the MTU is not related to changing the number of segments, activating or not the multi-segment support should be handled by the application. Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yo

[dpdk-dev] [PATCH 1/5] net/mlx5: warn which Tx/Rx burst function is selected

2017-08-01 Thread Nelio Laranjeiro
Warning the user helps to understand way the performances does not match the expected values. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c

[dpdk-dev] [PATCH 3/5] net/mlx5: avoid reusing old queue's mbuf on reconfigure

2017-08-01 Thread Nelio Laranjeiro
This patch prepare the merge of fake mbuf allocation needed by the vector code with rxq_alloc_elts() where all mbuf of the queues should be allocated. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 21 - 1 file changed, 4 insertions

[dpdk-dev] [PATCH 0/5] net/mlx5: enable/disable vPMD and some cleanups

2017-08-01 Thread Nelio Laranjeiro
details). Nelio Laranjeiro (5): net/mlx5: warn which Tx/Rx burst function is selected net/mlx5: add parameters to enable/disable vector code net/mlx5: avoid reusing old queue's mbuf on reconfigure net/mlx5: prepare vector Rx ring at setup time net/mlx5: cleanup Rx ring in free functions

[dpdk-dev] [PATCH 2/5] net/mlx5: add parameters to enable/disable vector code

2017-08-01 Thread Nelio Laranjeiro
Helps to deactivate the vector function without re-compiling the code. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 14 ++ drivers/net/mlx5/mlx5.c | 23 +++ drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH 4/5] net/mlx5: prepare vector Rx ring at setup time

2017-08-01 Thread Nelio Laranjeiro
-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 1 - drivers/net/mlx5/mlx5_rxq.c | 43 drivers/net/mlx5/mlx5_rxtx.c | 6 - drivers/net/mlx5/mlx5_rxtx.h | 1 - drivers/net/mlx5

[dpdk-dev] [PATCH 5/5] net/mlx5: cleanup Rx ring in free functions

2017-08-01 Thread Nelio Laranjeiro
freed them. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 71 +--- drivers/net/mlx5/mlx5_rxtx.h | 3 +- 2 files changed, 21 insertions(+), 53 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net

[dpdk-dev] [PATCH 1/5] net/mlx5: remove flow drop useless if branches

2017-08-01 Thread Nelio Laranjeiro
Those two if statements are useless as there is a verification on the drop field of the flow to jump to the end of the function just above. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 0/5] net/mlx5: cleanups

2017-08-01 Thread Nelio Laranjeiro
This Series make some cleanup in mlx5 PMD by removing useless code or non working code. This series apply on top of: [PATCH 0/5] net/mlx5: enable/disable vPMD and some cleanups Specifically on patch: net/mlx5: cleanup Rx ring in free functions http://dpdk.org/dev/patchwork/patch/27303/ Nelio

[dpdk-dev] [PATCH 3/5] net/mlx5: fix non working secondary process by removing it

2017-08-01 Thread Nelio Laranjeiro
ation in secondary processes") Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c| 33 +--- drivers/net/mlx5/mlx5.h| 9 --- drivers/net/mlx5/mlx5_ethdev.c | 166 + drivers/net/mlx5/mlx5_rxq.

[dpdk-dev] [PATCH 4/5] net/mlx5: remove multiple drop RSS queues

2017-08-01 Thread Nelio Laranjeiro
Since MLNX_OFED 4.1 this code is no more useful. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/Makefile| 5 drivers/net/mlx5/mlx5_flow.c | 55 ++-- 2 files changed, 17 insertions(+), 43 deletions(-) diff --git a

[dpdk-dev] [PATCH 2/5] net/mlx5: remove pdentic pragma

2017-08-01 Thread Nelio Laranjeiro
Those are useless since DPDK headers have been cleaned up. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 7 --- drivers/net/mlx5/mlx5.h | 7 --- drivers/net/mlx5/mlx5_ethdev.c | 7 --- drivers/net/mlx5

[dpdk-dev] [PATCH 5/5] net/mlx5: remove old MLNX_OFED 3.3 verification

2017-08-01 Thread Nelio Laranjeiro
This version of MLNX_OFED is no more supported. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 2392be5..e89aba8 100644 --- a/drivers/net/mlx5

[dpdk-dev] [PATCH v1 00/21] net/mlx5: cleanup for isolated mode

2017-08-02 Thread Nelio Laranjeiro
object. Nelio Laranjeiro (21): net/mlx5: merge action and flow parser structure net/mlx5: remove flow director support net/mlx5: prefix Rx queue control structures net/mlx5: prefix Tx control queue structures net/mlx5: remove redundant started flag net/mlx5: verify all flows are been

[dpdk-dev] [PATCH v1] net/mlx5: support RSS hash configuration in generic flow action

2017-08-02 Thread Nelio Laranjeiro
This also bring back the RSS support on all flows created by default from the control plane. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 437 ++- 1 file changed, 346 insertions(+), 91 deletions(-) diff --git a/drivers/net/mlx5

[dpdk-dev] [PATCH v1 01/21] net/mlx5: merge action and flow parser structure

2017-08-02 Thread Nelio Laranjeiro
mlx5_flow_create() and mlx5_flow_validate() are making common checks. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 151 +-- 1 file changed, 72 insertions(+), 79 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net

[dpdk-dev] [PATCH v1 02/21] net/mlx5: remove flow director support

2017-08-02 Thread Nelio Laranjeiro
Generic flow API should be use for flow steering as is provides a better and easier way to configure flows. Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini |1 - doc/guides/nics/mlx5.rst |2 - drivers/net/mlx5/Makefile |1 - drivers/net/mlx5

[dpdk-dev] [PATCH v1 05/21] net/mlx5: remove redundant started flag

2017-08-02 Thread Nelio Laranjeiro
This flag is already present in the Ethernet device. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow.c| 6 +++--- drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_trigger.c | 12 drivers/net/mlx5/mlx5_txq.c

[dpdk-dev] [PATCH v1 03/21] net/mlx5: prefix Rx queue control structures

2017-08-02 Thread Nelio Laranjeiro
Prefix struct rxq_ctrl with mlx5. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 8 ++--- drivers/net/mlx5/mlx5.h | 4 +-- drivers/net/mlx5/mlx5_flow.c | 12 +++ drivers/net/mlx5/mlx5_rxq.c | 61

[dpdk-dev] [PATCH v1 04/21] net/mlx5: prefix Tx control queue structures

2017-08-02 Thread Nelio Laranjeiro
Prefix struct txq_ctrl with mlx5. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 8 drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_mr.c | 20 +- drivers/net/mlx5/mlx5_rxtx.c | 25

[dpdk-dev] [PATCH v1 06/21] net/mlx5: verify all flows are been removed on close

2017-08-02 Thread Nelio Laranjeiro
Debug tools to verify all flows are be un-register from the NIC. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 3 +++ drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.c | 22 ++ 3 files changed, 26 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v1 07/21] net/mlx5: add reference counter on memory region

2017-08-02 Thread Nelio Laranjeiro
Memory regions becomes shared by the same time, the control plane as it own reference in addition of the Tx/Rx queues. This should also avoid to un-register a memory region when the Tx queue evicts it from its local cache. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 8

[dpdk-dev] [PATCH v1 09/21] net/mlx5: separate DPDK from Verbs Tx queue objects

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 3 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_rxtx.h | 18 +- drivers/net/mlx5/mlx5_txq.c | 437 ++- 4 files changed, 284 insertions(+), 175 deletions(-) diff --git

[dpdk-dev] [PATCH v1 08/21] net/mlx5: separate DPDK from Verbs Rx queue objects

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 3 + drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 97 +++- drivers/net/mlx5/mlx5_rxq.c | 564 ++- drivers/net/mlx5/mlx5_rxtx.h | 26 +- drivers/net/mlx5

[dpdk-dev] [PATCH v1 10/21] net/mlx5: add reference counter on DPDK Tx queues

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 16 +- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_mr.c | 37 ++-- drivers/net/mlx5/mlx5_rxtx.h| 13 +- drivers/net/mlx5/mlx5_trigger.c | 56 ++ drivers/net/mlx5/mlx5_txq.c | 383

[dpdk-dev] [PATCH v1 12/21] net/mlx5: remove queue drop support

2017-08-02 Thread Nelio Laranjeiro
In prevision of the huge rework on Rx hash queues and the fact this feature will be totally different, the drop flow is removed from now and will be re-introduced later. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow.c | 228

[dpdk-dev] [PATCH v1 13/21] net/mlx5: make indirection tables sharable

2017-08-02 Thread Nelio Laranjeiro
Avoid to have for each Hash Rx queue it dedicated indirection table. On verbs side, the indirection table only points to the Work Queue, two hash Rx queues using the same set of WQ can use the same indirection table. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 3

[dpdk-dev] [PATCH v1 11/21] net/mlx5: add reference counter on DPDK Rx queues

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 16 +- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_rxq.c | 492 +--- drivers/net/mlx5/mlx5_rxtx.h| 10 + drivers/net/mlx5/mlx5_trigger.c | 45 5 files

[dpdk-dev] [PATCH v1 14/21] net/mlx5: add Hash Rx queue object

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 3 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.c | 137 +++- drivers/net/mlx5/mlx5_rxq.c | 161 +++ drivers/net/mlx5/mlx5_rxtx.h

[dpdk-dev] [PATCH v1 15/21] net/mlx5: disable priority protection in flows

2017-08-02 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index f258567..90deb30 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -426,13

[dpdk-dev] [PATCH v1 16/21] net/mlx5: use flow to enable promiscuous mode

2017-08-02 Thread Nelio Laranjeiro
RSS hash configuration is currently ignored by the PMD, this commits removes the RSS feature on promiscuous mode. This functionality will be added in a later commit. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 15

[dpdk-dev] [PATCH v1 17/21] net/mlx5: use flow to enable all multi mode

2017-08-02 Thread Nelio Laranjeiro
RSS hash configuration is currently ignored by the PMD, this commits removes the RSS feature on promiscuous mode. This functionality will be added in a later commit. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_rxmode.c | 52

[dpdk-dev] [PATCH v1 19/21] net/mlx5: handle a single RSS hash key for all protocols

2017-08-02 Thread Nelio Laranjeiro
Since RSS configuration can also be used by flow API, there is no more necessity to keep a list of RSS configurable for all protocols. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c| 24 +--- drivers/net/mlx5/mlx5.h| 6 +- drivers/net/mlx5/mlx5_ethdev.c | 16

[dpdk-dev] [PATCH v1 18/21] net/mlx5: use flow to enable unicast traffic

2017-08-02 Thread Nelio Laranjeiro
RSS hash configuration is currently ignored by the PMD, this commits removes the RSS feature. This functionality will be added in a later commit. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 9 +- drivers/net/mlx5/mlx5.h | 22 +-- drivers/net/mlx5

[dpdk-dev] [PATCH v1 20/21] net/mlx5: remove hash Rx queues support

2017-08-02 Thread Nelio Laranjeiro
>From this commit the RSS support becomes un-available until it is replaced by the generic flow implementation. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c | 2 - drivers/net/mlx5/mlx5.h | 6 - drivers/net/mlx5/mlx5_rxq.c |

[dpdk-dev] [PATCH v1 21/21] net/mlx5: support RSS hash configuration in generic flow action

2017-08-02 Thread Nelio Laranjeiro
This also bring back the RSS support on all flows created by default from the control plane. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 437 ++- 1 file changed, 346 insertions(+), 91 deletions(-) diff --git a/drivers/net/mlx5

[dpdk-dev] [PATCH v2] net/mlx5: enable/disable vPMD and some cleanups

2017-08-02 Thread Nelio Laranjeiro
. Other patches will be differed for the next release has they are less important. Nelio Laranjeiro (1): net/mlx5: add parameters to enable/disable vector code doc/guides/nics/mlx5.rst | 14 ++ drivers/net/mlx5/mlx5.c | 23 +++ drivers/net

[dpdk-dev] [PATCH v2] net/mlx5: add parameters to enable/disable vector code

2017-08-02 Thread Nelio Laranjeiro
back to regular burst functions. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 14 ++ drivers/net/mlx5/mlx5.c | 23 +++ drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5

[dpdk-dev] [PATCH v2] net/mlx5: fix MTU update

2017-08-03 Thread Nelio Laranjeiro
Changing the MTU is not related to changing the number of segments, activating or not the multi-segment support should be handled by the application. Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yo

[dpdk-dev] [PATCH] net/mlx5: fix Tx when first segment size is too short

2017-03-29 Thread Nelio Laranjeiro
ned-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 823aac8..e2e8a22 100644 --- a/drivers/net/mlx5/m

[dpdk-dev] [PATCH] net/mlx5: fix Tx when first segment size is too short

2017-03-29 Thread Nelio Laranjeiro
;) Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- v2: fix the commit log. --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 823aac8..e2e8

[dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS flow rule with non existing queues

2017-03-29 Thread Nelio Laranjeiro
RSS flow rule validation accepts any queue even non existing ones which causes a segmentation fault at creation time. Fixes: fb4db56ea074 ("net/mlx5: support RSS action flow rule") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- driver

[dpdk-dev] [PATCH 1/2] net/mlx5: remove duplicated process

2017-03-29 Thread Nelio Laranjeiro
Flow validation already processes the final actions to verify if a rule can be applied or not and the same is done during creation. As the creation function relies on validation to generate and apply a rule, this job can be fully handled by the validation function. Signed-off-by: Nelio Laranjeiro

[dpdk-dev] [PATCH] net/mlx5: fix mark id retrieval

2017-03-30 Thread Nelio Laranjeiro
Mark ID in the completion queue entry is 24 bits, the remaining 8 bits are reserved and may be nonzero. Do not take them into account when looking for marked packets. CC: sta...@dpdk.org Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") Signed-off-by: Nelio Laranjeiro Acked-

[dpdk-dev] [PATCH] net/mlx5: remove duplicated process

2017-04-03 Thread Nelio Laranjeiro
Flow validation already processes the final actions to verify if a rule can be applied or not and the same is done during creation. As the creation function relies on validation to generate and apply a rule, this job can be fully handled by the validation function. Signed-off-by: Nelio Laranjeiro

[dpdk-dev] [PATCH] net/mlx5: fix RSS flow rule with non existing queues

2017-04-03 Thread Nelio Laranjeiro
RSS flow rule validation accepts any queue even non existing ones which causes a segmentation fault at creation time. Fixes: fb4db56ea074 ("net/mlx5: support RSS action flow rule") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- To be integr

[dpdk-dev] [PATCH] net/mlx5: fix startup when flow cannot be applied

2017-02-22 Thread Nelio Laranjeiro
When flows cannot be re-applied due to configuration modifications, the start function should rollback the configuration done. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trig

[dpdk-dev] [PATCH] net/mlx5: fix supported packets types

2017-02-24 Thread Nelio Laranjeiro
Fixes: 0603df73a077 ("net/mlx5: fix Rx packet validation and type") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler

2017-02-28 Thread Nelio Laranjeiro
The returned error code was wrongly handled causing the PMD to refuse to start. Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied") CC: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] net/mlx5: fix flow mark action handling

2017-02-28 Thread Nelio Laranjeiro
Mark value is always reported even when not requested or invalid. Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action") CC: sta...@dpdk.org Reported-by: Mark Bloch Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file

[dpdk-dev] [PATCH v2 0/9] net/mlx5: enhance flow API

2017-03-01 Thread Nelio Laranjeiro
combination of mark id. - support flag action. - support RSS action. Nelio Laranjeiro (9): net/mlx5: fix drop queue creation error net/mlx5: fix resources free in the right function net/mlx5: support ether type support in flow item net/mlx5: add RSS hash result with mark id net/mlx5

[dpdk-dev] [PATCH v2 2/9] net/mlx5: fix resources free in the right function

2017-03-01 Thread Nelio Laranjeiro
ibv_attr should be freed in the function which allocates the memory. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") CC: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v2 3/9] net/mlx5: support ether type support in flow item

2017-03-01 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 0712926..d3c0661 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -163,6

[dpdk-dev] [PATCH v2 1/9] net/mlx5: fix drop queue creation error

2017-03-01 Thread Nelio Laranjeiro
Creating a drop queue in mlx5 ends by creating a non polled queue, but if the associated work queue could not be created the error was not handled ending in a undefined situation. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") CC: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH v2 4/9] net/mlx5: add RSS hash result with mark id

2017-03-01 Thread Nelio Laranjeiro
RSS hash and mark ID can now coexists. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 8f16f2f..122847d 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers

[dpdk-dev] [PATCH v2 5/9] net/mlx5: extend IPv6 flow item

2017-03-01 Thread Nelio Laranjeiro
This commit adds: - Vtc flow, - Protocol, - Hop limits Needs MLNX_OFED-4.0-0.0.7.0 or higher. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 7/9] net/mlx5: prepare support for RSS action rule

2017-03-01 Thread Nelio Laranjeiro
with a single queue. No RSS hash key will be provided to the Verbs flow. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 249 +-- 1 file changed, 190 insertions(+), 59 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net

  1   2   3   4   5   6   7   8   9   >