Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
---
 drivers/net/mlx5/mlx5.c      |   3 +
 drivers/net/mlx5/mlx5.h      |   1 +
 drivers/net/mlx5/mlx5_rxtx.h |  18 +-
 drivers/net/mlx5/mlx5_txq.c  | 437 ++++++++++++++++++++++++++-----------------
 4 files changed, 284 insertions(+), 175 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index c158d8e..23068ae 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -203,6 +203,9 @@ mlx5_dev_close(struct rte_eth_dev *dev)
        i = mlx5_priv_rxq_ibv_verify(priv);
        if (i)
                WARN("%p: some Verbs Rx queue still remain", (void*)priv);
+       i = mlx5_priv_txq_ibv_verify(priv);
+       if (i)
+               WARN("%p: some Verbs Tx queue still remain", (void*)priv);
        i = priv_flow_verify(priv);
        if (i)
                WARN("%p: some flows still remain", (void*)priv);
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 228fd34..25711ef 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -147,6 +147,7 @@ struct priv {
        TAILQ_HEAD(mlx5_flows, rte_flow) flows; /* RTE Flow rules. */
        LIST_HEAD(mr, mlx5_mr) mr; /* Memory region. */
        LIST_HEAD(rxqibv, mlx5_rxq_ibv) rxqsibv; /* Verbs Rx queues. */
+       LIST_HEAD(txqibv, mlx5_txq_ibv) txqsibv; /* Verbs Tx queues. */
        uint32_t link_speed_capa; /* Link speed capabilities. */
        struct mlx5_xstats_ctrl xstats_ctrl; /* Extended stats control. */
        rte_spinlock_t lock; /* Lock for control functions. */
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index abdbf6a..f78aa38 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -283,12 +283,21 @@ struct mlx5_txq_data {
        struct mlx5_txq_stats stats; /* TX queue counters. */
 } __rte_cache_aligned;
 
+/* Verbs Rx queue elements. */
+struct mlx5_txq_ibv {
+       LIST_ENTRY(mlx5_txq_ibv) next; /* Pointer to the next element. */
+       rte_atomic32_t refcnt; /* Reference counter. */
+       struct ibv_cq *cq; /* Completion Queue. */
+       struct ibv_qp *qp; /* Queue Pair. */
+};
+
 /* TX queue control descriptor. */
 struct mlx5_txq_ctrl {
        struct priv *priv; /* Back pointer to private data. */
-       struct ibv_cq *cq; /* Completion Queue. */
-       struct ibv_qp *qp; /* Queue Pair. */
        unsigned int socket; /* CPU socket ID for allocations. */
+       unsigned int max_inline_data; /* Max inline data. */
+       unsigned int max_tso_header; /* Max TSO header size. */
+       struct mlx5_txq_ibv *ibv; /* Verbs queue object. */
        struct mlx5_txq_data txq; /* Data path structure. */
 };
 
@@ -333,6 +342,11 @@ int mlx5_txq_ctrl_setup(struct rte_eth_dev *, struct 
mlx5_txq_ctrl *, uint16_t,
 int mlx5_tx_queue_setup(struct rte_eth_dev *, uint16_t, uint16_t, unsigned int,
                        const struct rte_eth_txconf *);
 void mlx5_tx_queue_release(void *);
+struct mlx5_txq_ibv* mlx5_priv_txq_ibv_new(struct priv *priv, uint16_t idx);
+struct mlx5_txq_ibv* mlx5_priv_txq_ibv_get(struct priv *priv, uint16_t idx);
+int mlx5_priv_txq_ibv_release(struct priv *priv, struct mlx5_txq_ibv *txq);
+int mlx5_priv_txq_ibv_releasable(struct priv *priv, struct mlx5_txq_ibv *txq);
+int mlx5_priv_txq_ibv_verify(struct priv *priv);
 
 /* mlx5_rxtx.c */
 
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index ce826dd..570eb67 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -73,13 +73,6 @@ txq_alloc_elts(struct mlx5_txq_ctrl *txq_ctrl, unsigned int 
elts_n)
 
        for (i = 0; (i != elts_n); ++i)
                (*txq_ctrl->txq.elts)[i] = NULL;
-       for (i = 0; (i != (1u << txq_ctrl->txq.wqe_n)); ++i) {
-               volatile struct mlx5_wqe64 *wqe =
-                       (volatile struct mlx5_wqe64 *)
-                       txq_ctrl->txq.wqes + i;
-
-               memset((void *)(uintptr_t)wqe, 0x0, sizeof(*wqe));
-       }
        DEBUG("%p: allocated and configured %u WRs", (void *)txq_ctrl, elts_n);
        txq_ctrl->txq.elts_head = 0;
        txq_ctrl->txq.elts_tail = 0;
@@ -136,60 +129,15 @@ mlx5_txq_cleanup(struct mlx5_txq_ctrl *txq_ctrl)
 
        DEBUG("cleaning up %p", (void *)txq_ctrl);
        txq_free_elts(txq_ctrl);
-       if (txq_ctrl->qp != NULL)
-               claim_zero(ibv_destroy_qp(txq_ctrl->qp));
-       if (txq_ctrl->cq != NULL)
-               claim_zero(ibv_destroy_cq(txq_ctrl->cq));
        for (i = 0; (i != RTE_DIM(txq_ctrl->txq.mp2mr)); ++i)
                if (txq_ctrl->txq.mp2mr[i])
                        priv_mr_release(txq_ctrl->priv, txq_ctrl->txq.mp2mr[i]);
+       if (txq_ctrl->ibv)
+               mlx5_priv_txq_ibv_release(txq_ctrl->priv, txq_ctrl->ibv);
        memset(txq_ctrl, 0, sizeof(*txq_ctrl));
 }
 
 /**
- * Initialize TX queue.
- *
- * @param tmpl
- *   Pointer to TX queue control template.
- * @param txq_ctrl
- *   Pointer to TX queue control.
- *
- * @return
- *   0 on success, errno value on failure.
- */
-static inline int
-txq_setup(struct mlx5_txq_ctrl *tmpl, struct mlx5_txq_ctrl *txq_ctrl)
-{
-       struct mlx5_qp *qp = to_mqp(tmpl->qp);
-       struct ibv_cq *ibcq = tmpl->cq;
-       struct ibv_mlx5_cq_info cq_info;
-
-       if (ibv_mlx5_exp_get_cq_info(ibcq, &cq_info)) {
-               ERROR("Unable to query CQ info. check your OFED.");
-               return ENOTSUP;
-       }
-       if (cq_info.cqe_size != RTE_CACHE_LINE_SIZE) {
-               ERROR("Wrong MLX5_CQE_SIZE environment variable value: "
-                     "it should be set to %u", RTE_CACHE_LINE_SIZE);
-               return EINVAL;
-       }
-       tmpl->txq.cqe_n = log2above(cq_info.cqe_cnt);
-       tmpl->txq.qp_num_8s = qp->ctrl_seg.qp_num << 8;
-       tmpl->txq.wqes = qp->gen_data.sqstart;
-       tmpl->txq.wqe_n = log2above(qp->sq.wqe_cnt);
-       tmpl->txq.qp_db = &qp->gen_data.db[MLX5_SND_DBR];
-       tmpl->txq.bf_reg = qp->gen_data.bf->reg;
-       tmpl->txq.cq_db = cq_info.dbrec;
-       tmpl->txq.cqes =
-               (volatile struct mlx5_cqe (*)[])
-               (uintptr_t)cq_info.buf;
-       tmpl->txq.elts =
-               (struct rte_mbuf *(*)[1 << tmpl->txq.elts_n])
-               ((uintptr_t)txq_ctrl + sizeof(*txq_ctrl));
-       return 0;
-}
-
-/**
  * Configure a TX queue.
  *
  * @param dev
@@ -216,22 +164,13 @@ mlx5_txq_ctrl_setup(struct rte_eth_dev *dev, struct 
mlx5_txq_ctrl *txq_ctrl,
                .priv = priv,
                .socket = socket,
        };
-       union {
-               struct ibv_exp_qp_init_attr init;
-               struct ibv_exp_cq_init_attr cq;
-               struct ibv_exp_qp_attr mod;
-               struct ibv_exp_cq_attr cq_attr;
-       } attr;
-       unsigned int cqe_n;
        const unsigned int max_tso_inline = ((MLX5_MAX_TSO_HEADER +
                                             (RTE_CACHE_LINE_SIZE - 1)) /
                                              RTE_CACHE_LINE_SIZE);
-       int ret = 0;
 
        if (mlx5_getenv_int("MLX5_ENABLE_CQE_COMPRESSION")) {
-               ret = ENOTSUP;
                ERROR("MLX5_ENABLE_CQE_COMPRESSION must never be set");
-               goto error;
+               return ENOTSUP;
        }
        tmpl.txq.flags = conf->txq_flags;
        assert(desc > MLX5_TX_COMP_THRESH);
@@ -239,52 +178,10 @@ mlx5_txq_ctrl_setup(struct rte_eth_dev *dev, struct 
mlx5_txq_ctrl *txq_ctrl,
        if (priv->mps == MLX5_MPW_ENHANCED)
                tmpl.txq.mpw_hdr_dseg = priv->mpw_hdr_dseg;
        /* MRs will be registered in mp2mr[] later. */
-       attr.cq = (struct ibv_exp_cq_init_attr){
-               .comp_mask = 0,
-       };
-       cqe_n = ((desc / MLX5_TX_COMP_THRESH) - 1) ?
-               ((desc / MLX5_TX_COMP_THRESH) - 1) : 1;
-       if (priv->mps == MLX5_MPW_ENHANCED)
-               cqe_n += MLX5_TX_COMP_THRESH_INLINE_DIV;
-       tmpl.cq = ibv_exp_create_cq(priv->ctx,
-                                   cqe_n,
-                                   NULL, NULL, 0, &attr.cq);
-       if (tmpl.cq == NULL) {
-               ret = ENOMEM;
-               ERROR("%p: CQ creation failure: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
        DEBUG("priv->device_attr.max_qp_wr is %d",
              priv->device_attr.max_qp_wr);
        DEBUG("priv->device_attr.max_sge is %d",
              priv->device_attr.max_sge);
-       attr.init = (struct ibv_exp_qp_init_attr){
-               /* CQ to be associated with the send queue. */
-               .send_cq = tmpl.cq,
-               /* CQ to be associated with the receive queue. */
-               .recv_cq = tmpl.cq,
-               .cap = {
-                       /* Max number of outstanding WRs. */
-                       .max_send_wr = ((priv->device_attr.max_qp_wr < desc) ?
-                                       priv->device_attr.max_qp_wr :
-                                       desc),
-                       /*
-                        * Max number of scatter/gather elements in a WR,
-                        * must be 1 to prevent libmlx5 from trying to affect
-                        * too much memory. TX gather is not impacted by the
-                        * priv->device_attr.max_sge limit and will still work
-                        * properly.
-                        */
-                       .max_send_sge = 1,
-               },
-               .qp_type = IBV_QPT_RAW_PACKET,
-               /* Do *NOT* enable this, completions events are managed per
-                * TX burst. */
-               .sq_sig_all = 0,
-               .pd = priv->pd,
-               .comp_mask = IBV_EXP_QP_INIT_ATTR_PD,
-       };
        if (priv->txq_inline && (priv->txqs_n >= priv->txqs_inline)) {
                tmpl.txq.max_inline =
                        ((priv->txq_inline + (RTE_CACHE_LINE_SIZE - 1)) /
@@ -298,7 +195,7 @@ mlx5_txq_ctrl_setup(struct rte_eth_dev *dev, struct 
mlx5_txq_ctrl *txq_ctrl,
                        /* To minimize the size of data set, avoid requesting
                         * too large WQ.
                         */
-                       attr.init.cap.max_inline_data =
+                       tmpl.max_inline_data =
                                ((RTE_MIN(priv->txq_inline,
                                          priv->inline_max_packet_sz) +
                                  (RTE_CACHE_LINE_SIZE - 1)) /
@@ -310,73 +207,27 @@ mlx5_txq_ctrl_setup(struct rte_eth_dev *dev, struct 
mlx5_txq_ctrl *txq_ctrl,
                         * Adjust inline value as Verbs aggregates
                         * tso_inline and txq_inline fields.
                         */
-                       attr.init.cap.max_inline_data = inline_diff > 0 ?
-                                                       inline_diff *
-                                                       RTE_CACHE_LINE_SIZE :
-                                                       0;
+                       tmpl.max_inline_data = inline_diff > 0 ?
+                                              inline_diff *
+                                              RTE_CACHE_LINE_SIZE :
+                                              0;
                } else {
-                       attr.init.cap.max_inline_data =
+                       tmpl.max_inline_data =
                                tmpl.txq.max_inline * RTE_CACHE_LINE_SIZE;
                }
        }
        if (priv->tso) {
-               attr.init.max_tso_header =
-                       max_tso_inline * RTE_CACHE_LINE_SIZE;
-               attr.init.comp_mask |= IBV_EXP_QP_INIT_ATTR_MAX_TSO_HEADER;
+               tmpl.max_tso_header = max_tso_inline * RTE_CACHE_LINE_SIZE;
                tmpl.txq.max_inline = RTE_MAX(tmpl.txq.max_inline,
                                              max_tso_inline);
                tmpl.txq.tso_en = 1;
        }
        if (priv->tunnel_en)
                tmpl.txq.tunnel_en = 1;
-       tmpl.qp = ibv_exp_create_qp(priv->ctx, &attr.init);
-       if (tmpl.qp == NULL) {
-               ret = (errno ? errno : EINVAL);
-               ERROR("%p: QP creation failure: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
-       DEBUG("TX queue capabilities: max_send_wr=%u, max_send_sge=%u,"
-             " max_inline_data=%u",
-             attr.init.cap.max_send_wr,
-             attr.init.cap.max_send_sge,
-             attr.init.cap.max_inline_data);
-       attr.mod = (struct ibv_exp_qp_attr){
-               /* Move the QP to this state. */
-               .qp_state = IBV_QPS_INIT,
-               /* Primary port number. */
-               .port_num = priv->port
-       };
-       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod,
-                               (IBV_EXP_QP_STATE | IBV_EXP_QP_PORT));
-       if (ret) {
-               ERROR("%p: QP state to IBV_QPS_INIT failed: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
-       ret = txq_setup(&tmpl, txq_ctrl);
-       if (ret) {
-               ERROR("%p: cannot initialize TX queue structure: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
+       tmpl.txq.elts =
+               (struct rte_mbuf *(*)[1 << tmpl.txq.elts_n])
+               ((uintptr_t)txq_ctrl + sizeof(*txq_ctrl));
        txq_alloc_elts(&tmpl, desc);
-       attr.mod = (struct ibv_exp_qp_attr){
-               .qp_state = IBV_QPS_RTR
-       };
-       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);
-       if (ret) {
-               ERROR("%p: QP state to IBV_QPS_RTR failed: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
-       attr.mod.qp_state = IBV_QPS_RTS;
-       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);
-       if (ret) {
-               ERROR("%p: QP state to IBV_QPS_RTS failed: %s",
-                     (void *)dev, strerror(ret));
-               goto error;
-       }
        /* Clean up txq in case we're reinitializing it. */
        DEBUG("%p: cleaning-up old txq just in case", (void *)txq_ctrl);
        mlx5_txq_cleanup(txq_ctrl);
@@ -384,12 +235,7 @@ mlx5_txq_ctrl_setup(struct rte_eth_dev *dev, struct 
mlx5_txq_ctrl *txq_ctrl,
        DEBUG("%p: txq updated with %p", (void *)txq_ctrl, (void *)&tmpl);
        /* Pre-register known mempools. */
        rte_mempool_walk(mlx5_txq_mp2mr_iter, txq_ctrl);
-       assert(ret == 0);
        return 0;
-error:
-       mlx5_txq_cleanup(&tmpl);
-       assert(ret > 0);
-       return ret;
 }
 
 /**
@@ -480,14 +326,22 @@ mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
idx, uint16_t desc,
                }
        }
        ret = mlx5_txq_ctrl_setup(dev, txq_ctrl, desc, socket, conf);
-       if (ret)
+       if (ret) {
                rte_free(txq_ctrl);
-       else {
-               txq_ctrl->txq.stats.idx = idx;
-               DEBUG("%p: adding TX queue %p to list",
-                     (void *)dev, (void *)txq_ctrl);
-               (*priv->txqs)[idx] = &txq_ctrl->txq;
+               goto out;
+       }
+       txq_ctrl->txq.stats.idx = idx;
+       DEBUG("%p: adding TX queue %p to list",
+             (void *)dev, (void *)txq_ctrl);
+       (*priv->txqs)[idx] = &txq_ctrl->txq;
+       txq_ctrl->ibv = mlx5_priv_txq_ibv_new(priv, idx);
+       if (!txq_ctrl->ibv) {
+               ret = EAGAIN;
+               goto out;
        }
+       /* Update send callback. */
+       priv_select_tx_function(priv);
+out:
        priv_unlock(priv);
        return -ret;
 }
@@ -525,3 +379,240 @@ mlx5_tx_queue_release(void *dpdk_txq)
        rte_free(txq_ctrl);
        priv_unlock(priv);
 }
+
+/**
+ * Create the Tx queue Verbs object.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param idx
+ *   Queue index in DPDK Rx queue array
+ *
+ * @return
+ *   The Verbs object initialised if it can be created.
+ */
+struct mlx5_txq_ibv*
+mlx5_priv_txq_ibv_new(struct priv *priv, uint16_t idx)
+{
+       struct mlx5_txq_data *txq = (*priv->txqs)[idx];
+       struct mlx5_txq_ctrl *ctrl =
+               container_of(txq, struct mlx5_txq_ctrl, txq);
+       struct mlx5_txq_ibv tmpl;
+       struct mlx5_txq_ibv *ibv;
+       union {
+               struct ibv_exp_qp_init_attr init;
+               struct ibv_exp_cq_init_attr cq;
+               struct ibv_exp_qp_attr mod;
+               struct ibv_exp_cq_attr cq_attr;
+       } attr;
+       unsigned int cqe_n;
+       struct mlx5_qp *qp;
+       struct ibv_mlx5_cq_info cq_info;
+       const int desc = 1 << txq->elts_n;
+       int ret = 0;
+
+       if (mlx5_getenv_int("MLX5_ENABLE_CQE_COMPRESSION")) {
+               ERROR("MLX5_ENABLE_CQE_COMPRESSION must never be set");
+               goto error;
+       }
+       memset(&tmpl, 0, sizeof(struct mlx5_txq_ibv));
+       /* MRs will be registered in mp2mr[] later. */
+       attr.cq = (struct ibv_exp_cq_init_attr){
+               .comp_mask = 0,
+       };
+       cqe_n = ((desc / MLX5_TX_COMP_THRESH) - 1) ?
+               ((desc / MLX5_TX_COMP_THRESH) - 1) : 1;
+       if (priv->mps == MLX5_MPW_ENHANCED)
+               cqe_n += MLX5_TX_COMP_THRESH_INLINE_DIV;
+       tmpl.cq = ibv_exp_create_cq(priv->ctx,
+                                   cqe_n,
+                                   NULL, NULL, 0, &attr.cq);
+       if (tmpl.cq == NULL) {
+               ERROR("%p: CQ creation failure", (void *)ctrl);
+               goto error;
+       }
+       attr.init = (struct ibv_exp_qp_init_attr){
+               /* CQ to be associated with the send queue. */
+               .send_cq = tmpl.cq,
+               /* CQ to be associated with the receive queue. */
+               .recv_cq = tmpl.cq,
+               .cap = {
+                       /* Max number of outstanding WRs. */
+                       .max_send_wr = ((priv->device_attr.max_qp_wr < desc) ?
+                                       priv->device_attr.max_qp_wr : desc),
+                       /*
+                        * Max number of scatter/gather elements in a WR,
+                        * must be 1 to prevent libmlx5 from trying to affect
+                        * too much memory. TX gather is not impacted by the
+                        * priv->device_attr.max_sge limit and will still work
+                        * properly.
+                        */
+                       .max_send_sge = 1,
+               },
+               .qp_type = IBV_QPT_RAW_PACKET,
+               /* Do *NOT* enable this, completions events are managed per
+                * TX burst. */
+               .sq_sig_all = 0,
+               .pd = priv->pd,
+               .comp_mask = IBV_EXP_QP_INIT_ATTR_PD,
+       };
+       if (txq->inline_en)
+               attr.init.cap.max_inline_data = ctrl->max_inline_data;
+       if (txq->tso_en) {
+               attr.init.max_tso_header = ctrl->max_tso_header;
+               attr.init.comp_mask |= IBV_EXP_QP_INIT_ATTR_MAX_TSO_HEADER;
+       }
+       tmpl.qp = ibv_exp_create_qp(priv->ctx, &attr.init);
+       if (tmpl.qp == NULL) {
+               ERROR("%p: QP creation failure", (void *)ctrl);
+               goto error;
+       }
+       attr.mod = (struct ibv_exp_qp_attr){
+               /* Move the QP to this state. */
+               .qp_state = IBV_QPS_INIT,
+               /* Primary port number. */
+               .port_num = priv->port
+       };
+       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod,
+                               (IBV_EXP_QP_STATE | IBV_EXP_QP_PORT));
+       if (ret) {
+               ERROR("%p: QP state to IBV_QPS_INIT failed", (void *)ctrl);
+               goto error;
+       }
+       attr.mod = (struct ibv_exp_qp_attr){
+               .qp_state = IBV_QPS_RTR
+       };
+       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);
+       if (ret) {
+               ERROR("%p: QP state to IBV_QPS_RTR failed", (void *)ctrl);
+               goto error;
+       }
+       attr.mod.qp_state = IBV_QPS_RTS;
+       ret = ibv_exp_modify_qp(tmpl.qp, &attr.mod, IBV_EXP_QP_STATE);
+       if (ret) {
+               ERROR("%p: QP state to IBV_QPS_RTS failed", (void *)ctrl);
+               goto error;
+       }
+       ibv = rte_calloc_socket(__func__, 1, sizeof(struct mlx5_txq_ibv), 0,
+                               ctrl->socket);
+       if (!ibv) {
+               ERROR("%p: cannot allocate memory", (void *)ctrl);
+               goto error;
+       }
+       *ibv = tmpl;
+       qp = to_mqp(ibv->qp);
+       if (ibv_mlx5_exp_get_cq_info(ibv->cq, &cq_info)) {
+               ERROR("Unable to query CQ info. check your OFED.");
+               goto error;
+       }
+       if (cq_info.cqe_size != RTE_CACHE_LINE_SIZE) {
+               ERROR("Wrong MLX5_CQE_SIZE environment variable value: "
+                     "it should be set to %u", RTE_CACHE_LINE_SIZE);
+               goto error;
+       }
+       txq->cqe_n = log2above(cq_info.cqe_cnt);
+       txq->qp_num_8s = qp->ctrl_seg.qp_num << 8;
+       txq->wqes = qp->gen_data.sqstart;
+       txq->wqe_n = log2above(qp->sq.wqe_cnt);
+       txq->qp_db = &qp->gen_data.db[MLX5_SND_DBR];
+       txq->bf_reg = qp->gen_data.bf->reg;
+       txq->cq_db = cq_info.dbrec;
+       txq->cqes =
+               (volatile struct mlx5_cqe (*)[])
+               (uintptr_t)cq_info.buf;
+       rte_atomic32_inc(&ibv->refcnt);
+       LIST_INSERT_HEAD(&priv->txqsibv, ibv, next);
+       return ibv;
+error:
+       if (tmpl.cq)
+               claim_zero(ibv_destroy_cq(tmpl.cq));
+       if (tmpl.qp)
+               claim_zero(ibv_destroy_qp(tmpl.qp));
+       return NULL;
+
+}
+
+/**
+ * Get an Tx queue Verbs object.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param idx
+ *   Queue index in DPDK Rx queue array
+ *
+ * @return
+ *   The Verbs object if it exists.
+ */
+struct mlx5_txq_ibv*
+mlx5_priv_txq_ibv_get(struct priv *priv, uint16_t idx)
+{
+       struct mlx5_txq_data *txq = (*priv->txqs)[idx];
+       struct mlx5_txq_ctrl *ctrl =
+               container_of(txq, struct mlx5_txq_ctrl, txq);
+
+       if (ctrl->ibv)
+               rte_atomic32_inc(&ctrl->ibv->refcnt);
+       return ctrl->ibv;
+}
+
+/**
+ * Release an Tx verbs queue object.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param rxq
+ *   Verbs Rx queue object.
+ *
+ * @return
+ *   0 on success, errno on failure.
+ */
+int
+mlx5_priv_txq_ibv_release(struct priv *priv, struct mlx5_txq_ibv *txq)
+{
+       (void)priv;
+       if (rte_atomic32_dec_and_test(&txq->refcnt)) {
+               claim_zero(ibv_destroy_qp(txq->qp));
+               claim_zero(ibv_destroy_cq(txq->cq));
+               LIST_REMOVE(txq, next);
+               rte_free(txq);
+               return 0;
+       }
+       return EBUSY;
+}
+
+/**
+ * Return true if a single reference exists on the object.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param txq
+ *   Verbs Tx queue object.
+ */
+int
+mlx5_priv_txq_ibv_releasable(struct priv *priv, struct mlx5_txq_ibv *txq)
+{
+       (void)priv;
+       return (rte_atomic32_read(&txq->refcnt) == 1);
+}
+
+/**
+ * Verify the Verbs Tx queue list is empty
+ *
+ * @param priv
+ *  Pointer to private structure.
+ *
+ * @return the number of object not released.
+ */
+int
+mlx5_priv_txq_ibv_verify(struct priv *priv)
+{
+       int ret = 0;
+       struct mlx5_txq_ibv *txq;
+
+       LIST_FOREACH(txq, &priv->txqsibv, next) {
+               DEBUG("%p: Verbs Tx queue %p still referenced", (void*)priv,
+                     (void*)txq);
+               ++ret;
+       }
+       return ret;
+}
-- 
2.1.4

Reply via email to