Re: [dpdk-dev] [dpdk-stable] [PATCH] EAL: Called remove() of drivers for vdev and pci buses

2020-10-25 Thread Muhammad Bilal
On Tue, Oct 20, 2020 at 6:43 PM David Marchand wrote: > > Hello, Hi > > On Sat, Sep 12, 2020 at 9:53 PM Gaƫtan Rivet wrote: > > > > On 08/07/20 17:03 +0500, Muhammad Bilal wrote: > > > while using memif with app, the resources are not cleaned on exit, > &g

[dpdk-dev] [PATCH] EAL: Called remove() of drivers for vdev and pci buses

2020-07-08 Thread Muhammad Bilal
divers e.g pci, so to solve this problem I have added the functionality of calling remove() function of all the driver attached to devices on vdev and pci buses. Bugzilla ID: 353 Signed-off-by: Muhammad Bilal --- drivers/bus/pci/pci_common.c | 23 +++ drivers/bus

Re: [dpdk-dev] [PATCH] EAL: Called remove() of drivers for vdev and pci buses

2020-07-08 Thread Muhammad Bilal
On Wed, Jul 8, 2020 at 5:04 PM Muhammad Bilal wrote: > > while using memif with app, the resources are not cleaned on exit, > So an error occurred on running it second time. The cause of this problem > is that remove() of memif driver is not called by rte_eal_cleanup() which > is

[dpdk-dev] [PATCH] examples/l2fwd/main.c: free resources in case of error

2020-05-11 Thread Muhammad Bilal
Bugzilla ID: 437 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Cc: vipin.vargh...@intel.com Cc: jgraj...@cisco.com Signed-off-by: Muhammad Bilal --- examples/l2fwd/main.c | 72 ++- 1 file changed, 57 insertions(+), 15 deletions

[dpdk-dev] [PATCH v2] examples/l2fwd: free resources in case of error

2020-05-12 Thread Muhammad Bilal
Bugzilla ID: 437 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Cc: vipin.vargh...@intel.com Cc: jgraj...@cisco.com Signed-off-by: Muhammad Bilal --- examples/l2fwd/main.c | 76 ++- 1 file changed, 60 insertions(+), 16 deletions

[dpdk-dev] [PATCH] doc/guides/eventdevs: removing typing error in documentation of eventdevs

2020-05-14 Thread Muhammad Bilal
Bugzilla ID: 477 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: jer...@marvell.com Signed-off-by: Muhammad Bilal --- doc/guides/eventdevs/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.rst index 570905b81

[dpdk-dev] [PATCH v2] removing typing error of word 'through' in multiple places

2020-05-15 Thread Muhammad Bilal
-by: Muhammad Bilal --- doc/guides/eventdevs/index.rst | 2 +- drivers/net/mlx5/mlx5.c| 2 +- lib/librte_vhost/rte_vhost.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/eventdevs/index.rst b/doc/guides/eventdevs/index.rst index 570905b81..bb66a5eac

[dpdk-dev] [PATCH 2/5] examples/l2fwd-jobstats: free resources in case of error

2020-05-19 Thread Muhammad Bilal
Freeing the resources and call rte_eal_cleanup in case of error exit. Signed-off-by: Muhammad Bilal --- examples/l2fwd-jobstats/main.c | 75 +++--- 1 file changed, 60 insertions(+), 15 deletions(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats

[dpdk-dev] [PATCH 3/5] examples/l2fwd-keepalive: free resources in case of error

2020-05-19 Thread Muhammad Bilal
Freeing the resources and call rte_eal_cleanup in case of error exit. Signed-off-by: Muhammad Bilal --- examples/l2fwd-keepalive/main.c | 97 + 1 file changed, 74 insertions(+), 23 deletions(-) diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd

[dpdk-dev] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-05-19 Thread Muhammad Bilal
Freeing the resources and call rte_eal_cleanup in case of error exit. Signed-off-by: Muhammad Bilal --- examples/l2fwd-event/main.c | 43 ++--- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c

[dpdk-dev] [PATCH 5/5] examples/l2fwd-crypto: free resources in case of error

2020-05-19 Thread Muhammad Bilal
Freeing the resources and call rte_eal_cleanup in case of error exit. Signed-off-by: Muhammad Bilal --- examples/l2fwd-crypto/main.c | 54 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto

[dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: free resources in case of error

2020-05-19 Thread Muhammad Bilal
Freeing the resources and call rte_eal_cleanup in case of error exit. Signed-off-by: Muhammad Bilal --- examples/l2fwd-cat/l2fwd-cat.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd-cat/l2fwd-cat.c b/examples/l2fwd-cat/l2fwd

[dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted

2020-05-27 Thread Muhammad Bilal
Recently I have submitted patches and some tests were failing on patchwork. My question is, which tests are compulsory to pass for a patch to be accepted. As in the below mentioned patch, it is accepted while 1 test was still failing. http://patches.dpdk.org/patch/70348/ kind regards. Muhammad

[dpdk-dev] [PATCH] doc: removed typing mistake

2020-05-29 Thread Muhammad Bilal
There was a duplicate command instruction in the documentation of memif so I have removed the 1 command from it. Fixes: cd3365d2 ("net/memif: enable loopback") Cc: jmilan@gmail.com Signed-off-by: Muhammad Bilal --- doc/guides/nics/memif.rst | 1 - 1 file changed, 1 deletio

Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted

2020-06-02 Thread Muhammad Bilal
Thank you for your response. How will we know if a patch is failing because of some failure in the CI infrastructure or due to earlier merge? On Thu, May 28, 2020 at 1:59 AM Stephen Hemminger wrote: > > On Thu, 28 May 2020 01:13:27 +0500 > Muhammad Bilal wrote: > > > Recentl

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-02 Thread Muhammad Bilal
On Tue, May 19, 2020 at 2:35 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Tuesday, May 19, 2020 2:25 PM > >To: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > >Bhagavatula ; Sunil Kumar Kori

Re: [dpdk-dev] [PATCH v2] examples/l2fwd: free resources in case of error

2020-06-05 Thread Muhammad Bilal
Is there anything else to be done for acceptance? So that this problem can be removed from other examples. On Tue, May 12, 2020 at 6:57 PM Muhammad Bilal wrote: > > Bugzilla ID: 437 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: bruce.richard...@intel.com > Cc: vipin.vargh

[dpdk-dev] [PATCH] Nonnumeric input check for Setting hugepages

2020-04-06 Thread Muhammad Bilal
Bugzilla ID: 432 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: john.mcnam...@intel.com Signed-off-by: Muhammad Bilal --- usertools/dpdk-setup.sh | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index

[dpdk-dev] [PATCH] putting null checks on ops_name

2020-04-06 Thread Muhammad Bilal
Bugzilla ID: 353 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: hemant.agra...@nxp.com Signed-off-by: Muhammad Bilal --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf

[dpdk-dev] [PATCH v2] putting null checks on ops_name

2020-04-07 Thread Muhammad Bilal
Bugzilla ID: 353 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: hemant.agra...@nxp.com Signed-off-by: Muhammad Bilal --- lib/librte_mbuf/rte_mbuf_pool_ops.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf

[dpdk-dev] First the test fail and than get passed

2020-04-08 Thread Muhammad Bilal
st the test fail and than get passed? Patch address : http://patches.dpdk.org/patch/67893/ Bugzilla ID: 353 Thanks, Muhammad Bilal

[dpdk-dev] Compilation failed for Patches intended for previous releases

2020-04-13 Thread Muhammad Bilal
should we submit a patch for the 18.11 branch. Patch address = http://patches.dpdk.org/patch/66978/ Bugzilla ID: 364 Regards, Muhammad Bilal

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-15 Thread Muhammad Bilal
On Wed, Jun 10, 2020 at 3:01 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Tuesday, June 2, 2020 5:57 PM > >To: Sunil Kumar Kori > >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > &

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-16 Thread Muhammad Bilal
On Tue, Jun 16, 2020 at 10:53 AM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Monday, June 15, 2020 5:30 PM > >To: Sunil Kumar Kori > >Cc: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > &

[dpdk-dev] When .remove function (of struct rte_vdev_driver) is called

2020-06-21 Thread Muhammad Bilal
While working on applications(l2fwd, testpmd) with PMD(memif, Tun|Tap and some other) I have noticed that the .probe function of rte_vdev_driver structure is called in rte_eal_init() and .remove function of rte_vdev_driver structure is NEVER called, even after exiting the application. My Question

Re: [dpdk-dev] When .remove function (of struct rte_vdev_driver) is called

2020-06-21 Thread Muhammad Bilal
Yes, I have used the rte_eal_cleanup() function when application exits. And still it does not call the .remove function of rte_vdev_driver structure, used in PMD. On Sun, Jun 21, 2020 at 11:11 PM Stephen Hemminger wrote: > > On Sun, 21 Jun 2020 18:17:09 +0500 > Muhammad Bilal wrote: &g

[dpdk-dev] [PATCH] drivers/bus/vdev: corrected a typing error in header file

2020-06-23 Thread Muhammad Bilal
om Signed-off-by: Muhammad Bilal --- drivers/bus/vdev/rte_bus_vdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/vdev/rte_bus_vdev.h b/drivers/bus/vdev/rte_bus_vdev.h index 2bc46530c..78a032cea 100644 --- a/drivers/bus/vdev/rte_bus_vdev.h +++ b/driver

[dpdk-dev] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Muhammad Bilal
: 364 Cc: Thomas Monjalon Cc: John McNamara Cc: M: Luca Boccassi Cc: dev@dpdk.org Cc: sta...@dpdk.org Signed-off-by: Muhammad Bilal --- v2: * Added Details of branches for which patch is used. * This patch is intended for v18.11 and v17.11 branches mk/rte.sdkdoc.mk | 8 ++-- 1 file changed

Re: [dpdk-dev] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-20 Thread Muhammad Bilal
On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi wrote: > > On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote: > > in doc-clean removing the folder which contain > > the text files and no .rst files, > > they cause problem When switching branches and compiling > &g

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

2020-03-24 Thread Muhammad Bilal
On Fri, Mar 20, 2020 at 3:02 PM Kevin Traynor wrote: > > On 20/03/2020 09:53, Muhammad Bilal wrote: > > On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi wrote: > >> > >> On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote: > >>> in doc-clean removi

[dpdk-dev] [PATCH] doc/guides/contributing/patches.rst: corrected typing mistake in line 185

2020-03-25 Thread Muhammad Bilal
Bugzilla ID: 422 Cc: marko.kovace...@intel.com Cc: john.mcnam...@intel.com Cc: dev@dpdk.org Cc: sta...@dpdk.org Signed-off-by: Muhammad Bilal --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc

[dpdk-dev] [PATCH] drivers/net/i40e: fixed misplaced arguments

2020-07-14 Thread Muhammad Bilal
Here I have corrected a misplaced argument of i40e_aq_get_phy_register() This was also evident after seeing the datatype of its arguments. Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") Cc: zijie@6wind.com Bugzilla ID: 506 Signed-off-by: Muhammad Bilal --

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments

2020-07-15 Thread Muhammad Bilal
Yes, This is the patch for the same bug, Which is already fixed. So this duplicate patch can be ignored. On Tue, Jul 14, 2020 at 9:54 PM Ferruh Yigit wrote: > > On 7/14/2020 4:58 PM, Muhammad Bilal wrote: > > Here I have corrected a misplaced argument of i40e_aq_get_phy_register()

[dpdk-dev] [PATCH] doc: removed typing mistake

2020-09-09 Thread Muhammad Bilal
Here I have removed 'that' from the sentence to make it grammatically correct, as it seems to be a typing mistake Fixes: d0dff9ba445e ("doc: sample application user guide") Cc: bernard.iremon...@intel.com Signed-off-by: Muhammad Bilal --- doc/guides/prog_guide/multi_